188574 2018-08-14 13:17:56 -0700 MotionMark fails to display the "run benchmark" button in some situations 2022-09-03 20:03:04 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 fabrice sabouhallawa ahmad.saleem792 ap bfulgham cdumez dewei_zhu ews-watchlist jonlee lforschler mmaxfield rniwa sabouhallawa simon.fraser oldest_to_newest 1450076 0 fabrice 2018-08-14 13:17:56 -0700 If window.orientation exists, addOrientationListenerIfNecessary() in animometer.js calls _orientationChanged(). Here it ends up looking for an element: document.querySelector(".start-benchmark p") which is not in the DOM so the classList.XXX fails and benchmarkController.updateStartButtonState() is never called. 1450388 1 sabouhallawa 2018-08-15 12:11:11 -0700 The release runner page (index.html and motionmark.js) has the following elements and css: .portrait-orientation-check { display: none; } @media screen and (max-device-width: 1025px) and (orientation: portrait) { .portrait-orientation-check { display: block; } } @media screen and (max-device-width: 1025px) and (orientation: portrait) { .landscape-orientation-check { /* This keeps the button color animation in sync with page, while display: none does not. */ visibility: hidden; } } <p class="portrait-orientation-check"><b>Please rotate your device.</b></p> <button class="landscape-orientation-check" onclick="benchmarkController.startBenchmark()">Run Benchmark</button> -- The <p> element will be hidden by default but will be shown if screen width <= 1025px and the device in portrait mode. -- The <button> element will be shown by default but will be hidden if screen width <= 1025px and the device in portrait mode. The release runner page (developer.html and motionmark.js) has the following elements and code: <div class="start-benchmark"> <p class="hidden">Please rotate the device to orientation before starting.</p> <button id="run-benchmark" onclick="benchmarkController.startBenchmark()">Run benchmark</button> </div> <script> _orientationChanged: function(match) { benchmarkController.isInLandscapeOrientation = match.matches; if (match.matches) document.querySelector(".start-benchmark p").classList.add("hidden"); else document.querySelector(".start-benchmark p").classList.remove("hidden"); benchmarkController.updateStartButtonState(); }, updateStartButtonState: function() { document.getElementById("run-benchmark").disabled = !this.isInLandscapeOrientation; }, </script> So the <p> element ".start-benchmark p" and the <button> "#"run-benchmark" are made hidden or visible based on the result of window.matchMedia("(orientation: landscape). The problem is resources/runner/motionmark.js is shared between the debug and the release runners and both of them make calls to benchmarkController.addOrientationListenerIfNecessary() in their benchmarkController.initialize() function. I think the fix is to make both the debug and the release runners rely on the media query to show or hide the <p> and the <button> element. 1450395 2 347194 sabouhallawa 2018-08-15 12:37:43 -0700 Created attachment 347194 Patch 1450425 3 347194 jonlee 2018-08-15 13:24:14 -0700 Comment on attachment 347194 Patch It seems ok, but can we do a spot check on Windows, Android, and other browsers? 1896009 4 ahmad.saleem792 2022-09-03 04:14:24 -0700 This r+ patch landed or needed anymore? 347194 2018-08-15 12:37:43 -0700 2018-08-15 13:24:14 -0700 Patch bug-188574-20180815123742.patch text/plain 4879 sabouhallawa SW5kZXg6IFBlcmZvcm1hbmNlVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFBlcmZvcm1h bmNlVGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzQ4OTQpCisrKyBQZXJmb3JtYW5jZVRlc3Rz L0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA4LTE1ICBT YWlkIEFib3UtSGFsbGF3YSAgPHNhYm91aGFsbGF3YUBhcHBsZS5jb20+CisKKyAgICAgICAgTW90 aW9uTWFyayBmYWlscyB0byBkaXNwbGF5IHRoZSAicnVuIGJlbmNobWFyayIgYnV0dG9uIGluIHNv bWUgc2l0dWF0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTg4NTc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgVXNlIHRoZSBtZWRpYSBxdWVyaWVzIHRvIGNvbnRyb2wgdGhlIHZpc2liaWxpdHkgb2Yg dGhlICJydW4gYmVuY2htYXJrIgorICAgICAgICBidXR0b24gaW4gTW90aW9uTWFyayBkZXZlbG9w ZXIgcGFnZS4KKworICAgICAgICAqIE1vdGlvbk1hcmsvZGV2ZWxvcGVyLmh0bWw6CisgICAgICAg ICogTW90aW9uTWFyay9yZXNvdXJjZXMvZGVidWctcnVubmVyL21vdGlvbm1hcmsuanM6CisgICAg ICAgICogTW90aW9uTWFyay9yZXNvdXJjZXMvcnVubmVyL21vdGlvbm1hcmsuanM6CisgICAgICAg ICh3aW5kb3cuYmVuY2htYXJrQ29udHJvbGxlci5pbml0aWFsaXplKToKKyAgICAgICAgKHdpbmRv dy5iZW5jaG1hcmtDb250cm9sbGVyLmFkZE9yaWVudGF0aW9uTGlzdGVuZXJJZk5lY2Vzc2FyeSk6 IERlbGV0ZWQuCisgICAgICAgICh3aW5kb3cuYmVuY2htYXJrQ29udHJvbGxlci5fb3JpZW50YXRp b25DaGFuZ2VkKTogRGVsZXRlZC4KKyAgICAgICAgKHdpbmRvdy5iZW5jaG1hcmtDb250cm9sbGVy LnVwZGF0ZVN0YXJ0QnV0dG9uU3RhdGUpOiBEZWxldGVkLgorCiAyMDE4LTA4LTEzICBKb24gTGVl ICA8am9ubGVlQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgTW90aW9uTWFyayB2ZXJzaW9u IG51bWJlcgpJbmRleDogUGVyZm9ybWFuY2VUZXN0cy9Nb3Rpb25NYXJrL2RldmVsb3Blci5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFBlcmZvcm1hbmNlVGVzdHMvTW90aW9uTWFyay9kZXZlbG9wZXIuaHRt bAkocmV2aXNpb24gMjM0ODkzKQorKysgUGVyZm9ybWFuY2VUZXN0cy9Nb3Rpb25NYXJrL2RldmVs b3Blci5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0xMTMsOCArMTEzLDggQEAKICAgICAgICAgICAg ICAgICA8L2Rpdj4KICAgICAgICAgICAgICAgICA8cD5Gb3IgYWNjdXJhdGUgcmVzdWx0cywgcGxl YXNlIHRha2UgdGhlIGJyb3dzZXIgd2luZG93IGZ1bGwgc2NyZWVuLCBvciByb3RhdGUgdGhlIGRl dmljZSB0byBsYW5kc2NhcGUgb3JpZW50YXRpb24uPC9wPgogICAgICAgICAgICAgICAgIDxkaXYg Y2xhc3M9InN0YXJ0LWJlbmNobWFyayI+Ci0gICAgICAgICAgICAgICAgICAgIDxwIGNsYXNzPSJo aWRkZW4iPlBsZWFzZSByb3RhdGUgdGhlIGRldmljZSB0byBvcmllbnRhdGlvbiBiZWZvcmUgc3Rh cnRpbmcuPC9wPgotICAgICAgICAgICAgICAgICAgICA8YnV0dG9uIGlkPSJydW4tYmVuY2htYXJr IiBvbmNsaWNrPSJiZW5jaG1hcmtDb250cm9sbGVyLnN0YXJ0QmVuY2htYXJrKCkiPlJ1biBiZW5j aG1hcms8L2J1dHRvbj4KKyAgICAgICAgICAgICAgICAgICAgPHAgY2xhc3M9InBvcnRyYWl0LW9y aWVudGF0aW9uLWNoZWNrIj48Yj5QbGVhc2Ugcm90YXRlIHlvdXIgZGV2aWNlLjwvYj48L3A+Cisg ICAgICAgICAgICAgICAgICAgIDxidXR0b24gY2xhc3M9ImxhbmRzY2FwZS1vcmllbnRhdGlvbi1j aGVjayIgb25jbGljaz0iYmVuY2htYXJrQ29udHJvbGxlci5zdGFydEJlbmNobWFyaygpIj5SdW4g QmVuY2htYXJrPC9idXR0b24+CiAgICAgICAgICAgICAgICAgPC9kaXY+CiAgICAgICAgICAgICA8 L2Rpdj4KICAgICAgICAgPC9zZWN0aW9uPgpJbmRleDogUGVyZm9ybWFuY2VUZXN0cy9Nb3Rpb25N YXJrL3Jlc291cmNlcy9kZWJ1Zy1ydW5uZXIvbW90aW9ubWFyay5qcwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBQ ZXJmb3JtYW5jZVRlc3RzL01vdGlvbk1hcmsvcmVzb3VyY2VzL2RlYnVnLXJ1bm5lci9tb3Rpb25t YXJrLmpzCShyZXZpc2lvbiAyMzQ4OTMpCisrKyBQZXJmb3JtYW5jZVRlc3RzL01vdGlvbk1hcmsv cmVzb3VyY2VzL2RlYnVnLXJ1bm5lci9tb3Rpb25tYXJrLmpzCSh3b3JraW5nIGNvcHkpCkBAIC01 NDgsNyArNTQ4LDYgQEAgVXRpbGl0aWVzLmV4dGVuZE9iamVjdCh3aW5kb3cuYmVuY2htYXJrQwog ICAgICAgICBpZiAoYmVuY2htYXJrQ29udHJvbGxlci5zdGFydEJlbmNobWFya0ltbWVkaWF0ZWx5 SWZFbmNvZGVkKCkpCiAgICAgICAgICAgICByZXR1cm47CiAKLSAgICAgICAgYmVuY2htYXJrQ29u dHJvbGxlci5hZGRPcmllbnRhdGlvbkxpc3RlbmVySWZOZWNlc3NhcnkoKTsKICAgICAgICAgc3Vp dGVzTWFuYWdlci5jcmVhdGVFbGVtZW50cygpOwogICAgICAgICBzdWl0ZXNNYW5hZ2VyLnVwZGF0 ZVVJRnJvbUxvY2FsU3RvcmFnZSgpOwogICAgICAgICBzdWl0ZXNNYW5hZ2VyLnVwZGF0ZUVkaXRz RWxlbWVudHNTdGF0ZSgpOwpAQCAtNTg5LDExICs1ODgsNiBAQCBVdGlsaXRpZXMuZXh0ZW5kT2Jq ZWN0KHdpbmRvdy5iZW5jaG1hcmtDCiAKICAgICB1cGRhdGVTdGFydEJ1dHRvblN0YXRlOiBmdW5j dGlvbigpCiAgICAgewotICAgICAgICB2YXIgc3RhcnRCdXR0b24gPSBkb2N1bWVudC5nZXRFbGVt ZW50QnlJZCgicnVuLWJlbmNobWFyayIpOwotICAgICAgICBpZiAoImlzSW5MYW5kc2NhcGVPcmll bnRhdGlvbiIgaW4gdGhpcyAmJiAhdGhpcy5pc0luTGFuZHNjYXBlT3JpZW50YXRpb24pIHsKLSAg ICAgICAgICAgIHN0YXJ0QnV0dG9uLmRpc2FibGVkID0gdHJ1ZTsKLSAgICAgICAgICAgIHJldHVy bjsKLSAgICAgICAgfQogICAgICAgICBzdGFydEJ1dHRvbi5kaXNhYmxlZCA9ICFzdWl0ZXNNYW5h Z2VyLmlzQXRMZWFzdE9uZVRlc3RTZWxlY3RlZCgpOwogICAgIH0sCiAKSW5kZXg6IFBlcmZvcm1h bmNlVGVzdHMvTW90aW9uTWFyay9yZXNvdXJjZXMvcnVubmVyL21vdGlvbm1hcmsuanMKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gUGVyZm9ybWFuY2VUZXN0cy9Nb3Rpb25NYXJrL3Jlc291cmNlcy9ydW5uZXIvbW90 aW9ubWFyay5qcwkocmV2aXNpb24gMjM0ODkzKQorKysgUGVyZm9ybWFuY2VUZXN0cy9Nb3Rpb25N YXJrL3Jlc291cmNlcy9ydW5uZXIvbW90aW9ubWFyay5qcwkod29ya2luZyBjb3B5KQpAQCAtNDYz LDcgKzQ2Myw2IEBAIHdpbmRvdy5iZW5jaG1hcmtDb250cm9sbGVyID0gewogICAgICAgICBkb2N1 bWVudC5xdWVyeVNlbGVjdG9yQWxsKCIudmVyc2lvbiIpLmZvckVhY2goZnVuY3Rpb24oZSkgewog ICAgICAgICAgICAgZS50ZXh0Q29udGVudCA9IFN0cmluZ3MudmVyc2lvbjsKICAgICAgICAgfSk7 Ci0gICAgICAgIGJlbmNobWFya0NvbnRyb2xsZXIuYWRkT3JpZW50YXRpb25MaXN0ZW5lcklmTmVj ZXNzYXJ5KCk7CiAgICAgfSwKIAogICAgIGRldGVybWluZUNhbnZhc1NpemU6IGZ1bmN0aW9uKCkg ewpAQCAtNDg4LDMwICs0ODcsNiBAQCB3aW5kb3cuYmVuY2htYXJrQ29udHJvbGxlciA9IHsKICAg ICAgICAgZG9jdW1lbnQuYm9keS5jbGFzc0xpc3QuYWRkKCJsYXJnZSIpOwogICAgIH0sCiAKLSAg ICBhZGRPcmllbnRhdGlvbkxpc3RlbmVySWZOZWNlc3Nhcnk6IGZ1bmN0aW9uKCkgewotICAgICAg ICBpZiAoISgib3JpZW50YXRpb24iIGluIHdpbmRvdykpCi0gICAgICAgICAgICByZXR1cm47Ci0K LSAgICAgICAgdGhpcy5vcmllbnRhdGlvblF1ZXJ5ID0gd2luZG93Lm1hdGNoTWVkaWEoIihvcmll bnRhdGlvbjogbGFuZHNjYXBlKSIpOwotICAgICAgICB0aGlzLl9vcmllbnRhdGlvbkNoYW5nZWQo dGhpcy5vcmllbnRhdGlvblF1ZXJ5KTsKLSAgICAgICAgdGhpcy5vcmllbnRhdGlvblF1ZXJ5LmFk ZExpc3RlbmVyKHRoaXMuX29yaWVudGF0aW9uQ2hhbmdlZCk7Ci0gICAgfSwKLQotICAgIF9vcmll bnRhdGlvbkNoYW5nZWQ6IGZ1bmN0aW9uKG1hdGNoKQotICAgIHsKLSAgICAgICAgYmVuY2htYXJr Q29udHJvbGxlci5pc0luTGFuZHNjYXBlT3JpZW50YXRpb24gPSBtYXRjaC5tYXRjaGVzOwotICAg ICAgICBpZiAobWF0Y2gubWF0Y2hlcykKLSAgICAgICAgICAgIGRvY3VtZW50LnF1ZXJ5U2VsZWN0 b3IoIi5zdGFydC1iZW5jaG1hcmsgcCIpLmNsYXNzTGlzdC5hZGQoImhpZGRlbiIpOwotICAgICAg ICBlbHNlCi0gICAgICAgICAgICBkb2N1bWVudC5xdWVyeVNlbGVjdG9yKCIuc3RhcnQtYmVuY2ht YXJrIHAiKS5jbGFzc0xpc3QucmVtb3ZlKCJoaWRkZW4iKTsKLSAgICAgICAgYmVuY2htYXJrQ29u dHJvbGxlci51cGRhdGVTdGFydEJ1dHRvblN0YXRlKCk7Ci0gICAgfSwKLQotICAgIHVwZGF0ZVN0 YXJ0QnV0dG9uU3RhdGU6IGZ1bmN0aW9uKCkKLSAgICB7Ci0gICAgICAgIGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJydW4tYmVuY2htYXJrIikuZGlzYWJsZWQgPSAhdGhpcy5pc0luTGFuZHNjYXBl T3JpZW50YXRpb247Ci0gICAgfSwKLQogICAgIF9zdGFydEJlbmNobWFyazogZnVuY3Rpb24oc3Vp dGVzLCBvcHRpb25zLCBmcmFtZUNvbnRhaW5lcklEKQogICAgIHsKICAgICAgICAgYmVuY2htYXJr Q29udHJvbGxlci5kZXRlcm1pbmVDYW52YXNTaXplKCk7Cg==