188557 2018-08-14 09:43:58 -0700 [DFG] DFGPredictionPropagation should set PrimaryPass when processing invariants 2018-08-14 10:24:16 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist fpizlo keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1449960 0 ysuzuki 2018-08-14 09:43:58 -0700 [DFG] DFGPredictionPropagation should set PrimaryPass when processing invariants 1449962 1 347082 ysuzuki 2018-08-14 09:45:31 -0700 Created attachment 347082 Patch 1449984 2 347082 mark.lam 2018-08-14 10:18:07 -0700 Comment on attachment 347082 Patch r=me. Should we also specify an initializer for m_pass { PrimaryPass } (just to be pedantic)? 1449985 3 ysuzuki 2018-08-14 10:19:53 -0700 (In reply to Mark Lam from comment #2) > Comment on attachment 347082 [details] > Patch > > r=me. Should we also specify an initializer for m_pass { PrimaryPass } > (just to be pedantic)? It sounds nice. I would like to keep both (initializer and `m_pass = PrimaryPass`). Since the latter offers good readability of PredictionPropagationPhase::run function. 1449986 4 ysuzuki 2018-08-14 10:23:57 -0700 Committed r234853: <https://trac.webkit.org/changeset/234853> 1449989 5 webkit-bug-importer 2018-08-14 10:24:16 -0700 <rdar://problem/43292220> 347082 2018-08-14 09:45:31 -0700 2018-08-14 10:18:07 -0700 Patch bug-188557-20180815014530.patch text/plain 1685 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0ODQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk ZmVhMjg1N2Q2YzMzMGIyMzJiZDVkNmNlZDk4MWUzNGU5NGQ2MzIyLi42N2ZiYTA5ZDdlYTNkMmQ0 OTU4ZGViYmY3ZDY1Y2U1ODM3Y2U5ZjZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNiBAQAorMjAxOC0wOC0xNCAgWXVzdWtlIFN1enVraSAgPHl1c3VrZXN1enVraUBzbG93 c3RhcnQub3JnPgorCisgICAgICAgIFtERkddIERGR1ByZWRpY3Rpb25Qcm9wYWdhdGlvbiBzaG91 bGQgc2V0IFByaW1hcnlQYXNzIHdoZW4gcHJvY2Vzc2luZyBpbnZhcmlhbnRzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg1NTcKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBERkdQcmVkaWN0aW9uUHJvcGFn YXRpb25QaGFzZSBzaG91bGQgc2V0IFByaW1hcnlQYXNzIGJlZm9yZSBwcm9jZXNzaW5nIGludmFy aWFudHMgc2luY2UKKyAgICAgICAgcHJvY2Vzc2luZyBmb3IgQXJpdGhSb3VuZCBldGMuJ3MgaW52 YXJpYW50cyByZXF1aXJlcyBgbV9wYXNzYCBsb2FkLiBUaGlzIGlzc3VlIGlzIGZvdW5kCisgICAg ICAgIGluIFVCU2FuJ3MgcmVzdWx0LgorCisgICAgICAgICogZGZnL0RGR1ByZWRpY3Rpb25Qcm9w YWdhdGlvblBoYXNlLmNwcDoKKwogMjAxOC0wOC0xMiAgS2FybyBHeW9rZXIgIDxrYXJvZ3lva2Vy Mit3ZWJraXRAZ21haWwuY29tPgogCiAgICAgICAgIERpc2FibGUgSklUIG9uIElBLTMyIHdpdGhv dXQgU1NFMgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdQcmVkaWN0 aW9uUHJvcGFnYXRpb25QaGFzZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1By ZWRpY3Rpb25Qcm9wYWdhdGlvblBoYXNlLmNwcAppbmRleCAyZGIzZTY0M2I2NjdkMWFlMGM3YTFi ZTAzYjg5N2RlOTA3MGZjYWVhLi43ZTgzNThkYzcxZDVlZDA5YmFhZGM5NjI4ZTdjNzA4MGZiOTg0 ZjU5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1ByZWRpY3Rpb25Q cm9wYWdhdGlvblBoYXNlLmNwcAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1By ZWRpY3Rpb25Qcm9wYWdhdGlvblBoYXNlLmNwcApAQCAtNTAsMTEgKzUwLDEyIEBAIGNsYXNzIFBy ZWRpY3Rpb25Qcm9wYWdhdGlvblBoYXNlIDogcHVibGljIFBoYXNlIHsKICAgICAgICAgQVNTRVJU KG1fZ3JhcGgubV9mb3JtID09IFRocmVhZGVkQ1BTKTsKICAgICAgICAgQVNTRVJUKG1fZ3JhcGgu bV91bmlmaWNhdGlvblN0YXRlID09IEdsb2JhbGx5VW5pZmllZCk7CiAKKyAgICAgICAgbV9wYXNz ID0gUHJpbWFyeVBhc3M7CisKICAgICAgICAgcHJvcGFnYXRlVGhyb3VnaEFyZ3VtZW50UG9zaXRp b25zKCk7CiAKICAgICAgICAgcHJvY2Vzc0ludmFyaWFudHMoKTsKIAotICAgICAgICBtX3Bhc3Mg PSBQcmltYXJ5UGFzczsKICAgICAgICAgcHJvcGFnYXRlVG9GaXhwb2ludCgpOwogICAgICAgICAK ICAgICAgICAgbV9wYXNzID0gUmFyZUNhc2VQYXNzOwo=