188546 2018-08-14 01:52:46 -0700 [GTK] MiniBrowser: web view doesn't get the focus when new window is created 2018-08-16 01:16:08 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned bburg bugs-noreply mcatanzaro oldest_to_newest 1449899 0 cgarcia 2018-08-14 01:52:46 -0700 "User prompts that are spawned from beforeunload event handlers, are dismissed implicitly upon navigation or close window, regardless of the defined user prompt handler." I think this is causing timeouts in tests: imported/w3c/webdriver/tests/forward/forward.py::test_dismissed_beforeunload imported/w3c/webdriver/tests/close_window/close.py::test_close_browsing_context_with_dismissed_beforeunload_prompt imported/w3c/webdriver/tests/back/back.py::test_dismissed_beforeunload 1449917 1 cgarcia 2018-08-14 06:06:41 -0700 This turned out to be a bug in MiniBrowser, it has nothing to do with WebDriver, nor with beforeunload. The problem is that the affected tests use a popup window, with an entry that is filled with send keys command. The send keys command is failing because in the new window the focus is not in the web view, it's in the toolbar, so key events are sent to the toolbar instead. 1449921 2 347069 cgarcia 2018-08-14 06:12:13 -0700 Created attachment 347069 Patch 1450632 3 cgarcia 2018-08-16 01:16:08 -0700 Committed r234915: <https://trac.webkit.org/changeset/234915> 347069 2018-08-14 06:12:13 -0700 2018-08-14 08:54:58 -0700 Patch mb-view-focus.diff text/plain 5153 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBiYmQ3 ZTZlODJkYy4uNzdmMzMwODNhMWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMiBAQAorMjAxOC0wOC0xNCAgQ2FybG9zIEdhcmNp YSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gTWluaUJyb3dz ZXI6IHdlYiB2aWV3IGRvZXNuJ3QgZ2V0IHRoZSBmb2N1cyB3aGVuIG5ldyB3aW5kb3cgaXMgY3Jl YXRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4 NTQ2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2hl biBhIG5ldyB3aW5kb3cgaXMgY3JlYXRlZCwgdGhlIGZpcnN0IHdpZGdldCBvZiB0aGUgd2luZG8g aXMgZ2V0dGluZyB0aGUgZm9jdXMsIHRoZSB0b29sYmFyIGluIHRoaXMgY2FzZS4gV2UKKyAgICAg ICAgYWx3YXlzIHdhbnQgdGhlIFdlYlZpZXcgdG8gZ3JhYiB0aGUgZm9jdXMuIEluIGNhc2Ugb2Yg bmV3IGVtcHR5IHRhYiwgd2Ugd2FudCB0byB0aGUgVVJMIGJhciB0byBiZSBmb2N1c2VkCisgICAg ICAgIGluc3RlYWQuIFRoaXMgd2FzIGNhdXNpbmcgZmFpbHVyZXMgaW4gV2ViRHJpdmVyIHRlc3Rz IHRoYXQgY3JlYXRlIGEgcG9wdXAgd2luZG93IHdpdGggYW4gaW5wdXQgZWxlbWVudCB0aGF0IGlz CisgICAgICAgIGZpbGxlZCB3aXRoIHNlbmQga2V5cyBjb21tYW5kLiBUaGUgaW5wdXQgZWxlbWVu dCBpcyBtYXJrZWQgYXMgZm9jdXNlZCBpbiB0aGUgRE9NLCBidXQgdGhlIGFjdHVhbCBmb2N1c2Vk IHdpZGdldAorICAgICAgICBpcyB0aGUgdG9vbGJhciwgc28ga2V5IGV2ZW50cyBhcmUgc2VudCB0 byB0aGUgdG9vbGJhciBpbnN0ZWFkIG9mIHRoZSB3ZWIgdmlldy4KKworICAgICAgICAqIE1pbmlC cm93c2VyL2d0ay9Ccm93c2VyV2luZG93LmM6CisgICAgICAgICh3ZWJWaWV3Q3JlYXRlKToKKyAg ICAgICAgKG5ld1RhYkNhbGxiYWNrKToKKyAgICAgICAgKG9wZW5Qcml2YXRlV2luZG93KToKKyAg ICAgICAgKGJyb3dzZXJfd2luZG93X2dldF9vcl9jcmVhdGVfd2ViX3ZpZXdfZm9yX2F1dG9tYXRp b24pOgorCiAyMDE4LTA4LTE0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlh LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLiBGaXggV2ViRHJpdmVyIHRlc3RzIGFmdGVyIHIy MzQ4MzkuCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3NlcldpbmRvdy5j IGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYwppbmRleCAzNmIzMDY1N2M5 YS4uZDU1OTgzNTFkZTIgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2Vy V2luZG93LmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJXaW5kb3cuYwpAQCAt MzM4LDYgKzMzOCw3IEBAIHN0YXRpYyBHdGtXaWRnZXQgKndlYlZpZXdDcmVhdGUoV2ViS2l0V2Vi VmlldyAqd2ViVmlldywgV2ViS2l0TmF2aWdhdGlvbkFjdGlvbiAqCiAKICAgICBHdGtXaWRnZXQg Km5ld1dpbmRvdyA9IGJyb3dzZXJfd2luZG93X25ldyhHVEtfV0lORE9XKHdpbmRvdyksIHdpbmRv dy0+d2ViQ29udGV4dCk7CiAgICAgYnJvd3Nlcl93aW5kb3dfYXBwZW5kX3ZpZXcoQlJPV1NFUl9X SU5ET1cobmV3V2luZG93KSwgbmV3V2ViVmlldyk7CisgICAgZ3RrX3dpZGdldF9ncmFiX2ZvY3Vz KEdUS19XSURHRVQobmV3V2ViVmlldykpOwogICAgIGdfc2lnbmFsX2Nvbm5lY3QobmV3V2ViVmll dywgInJlYWR5LXRvLXNob3ciLCBHX0NBTExCQUNLKHdlYlZpZXdSZWFkeVRvU2hvdyksIG5ld1dp bmRvdyk7CiAgICAgZ19zaWduYWxfY29ubmVjdChuZXdXZWJWaWV3LCAicnVuLWFzLW1vZGFsIiwg R19DQUxMQkFDSyh3ZWJWaWV3UnVuQXNNb2RhbCksIG5ld1dpbmRvdyk7CiAgICAgZ19zaWduYWxf Y29ubmVjdChuZXdXZWJWaWV3LCAiY2xvc2UiLCBHX0NBTExCQUNLKHdlYlZpZXdDbG9zZSksIG5l d1dpbmRvdyk7CkBAIC01MjgsNiArNTI5LDcgQEAgc3RhdGljIHZvaWQgbmV3VGFiQ2FsbGJhY2so QnJvd3NlcldpbmRvdyAqd2luZG93KQogICAgICAgICAidXNlci1jb250ZW50LW1hbmFnZXIiLCB3 ZWJraXRfd2ViX3ZpZXdfZ2V0X3VzZXJfY29udGVudF9tYW5hZ2VyKHdlYlZpZXcpLAogICAgICAg ICAiaXMtY29udHJvbGxlZC1ieS1hdXRvbWF0aW9uIiwgd2Via2l0X3dlYl92aWV3X2lzX2NvbnRy b2xsZWRfYnlfYXV0b21hdGlvbih3ZWJWaWV3KSwKICAgICAgICAgTlVMTCkpKTsKKyAgICBndGtf d2lkZ2V0X2dyYWJfZm9jdXMod2luZG93LT51cmlFbnRyeSk7CiAgICAgZ3RrX25vdGVib29rX3Nl dF9jdXJyZW50X3BhZ2UoR1RLX05PVEVCT09LKHdpbmRvdy0+bm90ZWJvb2spLCAtMSk7CiB9CiAK QEAgLTU0OCw2ICs1NTAsNyBAQCBzdGF0aWMgdm9pZCBvcGVuUHJpdmF0ZVdpbmRvdyhCcm93c2Vy V2luZG93ICp3aW5kb3cpCiAgICAgICAgIE5VTEwpKTsKICAgICBHdGtXaWRnZXQgKm5ld1dpbmRv dyA9IGJyb3dzZXJfd2luZG93X25ldyhHVEtfV0lORE9XKHdpbmRvdyksIHdpbmRvdy0+d2ViQ29u dGV4dCk7CiAgICAgYnJvd3Nlcl93aW5kb3dfYXBwZW5kX3ZpZXcoQlJPV1NFUl9XSU5ET1cobmV3 V2luZG93KSwgbmV3V2ViVmlldyk7CisgICAgZ3RrX3dpZGdldF9ncmFiX2ZvY3VzKEdUS19XSURH RVQobmV3V2ViVmlldykpOwogICAgIGd0a193aWRnZXRfc2hvdyhHVEtfV0lER0VUKG5ld1dpbmRv dykpOwogfQogCkBAIC0xMjMzLDUgKzEyMzYsNiBAQCBXZWJLaXRXZWJWaWV3ICpicm93c2VyX3dp bmRvd19nZXRfb3JfY3JlYXRlX3dlYl92aWV3X2Zvcl9hdXRvbWF0aW9uKHZvaWQpCiAgICAgICAg ICJpcy1jb250cm9sbGVkLWJ5LWF1dG9tYXRpb24iLCBUUlVFLAogICAgICAgICBOVUxMKSk7CiAg ICAgYnJvd3Nlcl93aW5kb3dfYXBwZW5kX3ZpZXcod2luZG93LCBuZXdXZWJWaWV3KTsKKyAgICBn dGtfd2lkZ2V0X2dyYWJfZm9jdXMoR1RLX1dJREdFVChuZXdXZWJWaWV3KSk7CiAgICAgcmV0dXJu IG5ld1dlYlZpZXc7CiB9CmRpZmYgLS1naXQgYS9XZWJEcml2ZXJUZXN0cy9DaGFuZ2VMb2cgYi9X ZWJEcml2ZXJUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMGI0NjhkOGZhZGIuLjdmYTIyYzgzZmUzIDEw MDY0NAotLS0gYS9XZWJEcml2ZXJUZXN0cy9DaGFuZ2VMb2cKKysrIGIvV2ViRHJpdmVyVGVzdHMv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTgtMDgtMTQgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIE1pbmlCcm93c2VyOiB3 ZWIgdmlldyBkb2Vzbid0IGdldCB0aGUgZm9jdXMgd2hlbiBuZXcgd2luZG93IGlzIGNyZWF0ZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODU0Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZSBl eHBlY3RhdGlvbnMgb2YgdGhlIHRlc3RzIHRoYXQgcGFzcyBub3cuCisKKyAgICAgICAgKiBUZXN0 RXhwZWN0YXRpb25zLmpzb246CisKIDIwMTgtMDgtMTQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8 Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgZ2FyZGVuaW5nLiBVcGRh dGUgc2V2ZXJhbCB0ZXN0IGV4cGVjdGF0aW9ucyBhZnRlciByMjM0ODM5LgpkaWZmIC0tZ2l0IGEv V2ViRHJpdmVyVGVzdHMvVGVzdEV4cGVjdGF0aW9ucy5qc29uIGIvV2ViRHJpdmVyVGVzdHMvVGVz dEV4cGVjdGF0aW9ucy5qc29uCmluZGV4IDE0Y2QyMmE1N2Y4Li5iMzNhMjJhODc0MiAxMDA2NDQK LS0tIGEvV2ViRHJpdmVyVGVzdHMvVGVzdEV4cGVjdGF0aW9ucy5qc29uCisrKyBiL1dlYkRyaXZl clRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMuanNvbgpAQCAtNDc4LDIwICs0NzgsMTAgQEAKICAgICAg ICAgICAgIH0KICAgICAgICAgfQogICAgIH0sCi0gICAgImltcG9ydGVkL3czYy93ZWJkcml2ZXIv dGVzdHMvYmFjay9iYWNrLnB5IjogewotICAgICAgICAic3VidGVzdHMiOiB7Ci0gICAgICAgICAg ICAidGVzdF9kaXNtaXNzZWRfYmVmb3JldW5sb2FkIjogewotICAgICAgICAgICAgICAgICJleHBl Y3RlZCI6IHsiYWxsIjogeyJzdGF0dXMiOiBbIlRJTUVPVVQiXSwgImJ1ZyI6ICJ3ZWJraXQub3Jn L2IvMTg4NTQ2In19Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KLSAgICB9LAogICAgICJpbXBv cnRlZC93M2Mvd2ViZHJpdmVyL3Rlc3RzL2Nsb3NlX3dpbmRvdy9jbG9zZS5weSI6IHsKICAgICAg ICAgInN1YnRlc3RzIjogewogICAgICAgICAgICAgInRlc3RfY2xvc2VfbGFzdF9icm93c2luZ19j b250ZXh0IjogewogICAgICAgICAgICAgICAgICJleHBlY3RlZCI6IHsiZ3RrIjogeyJzdGF0dXMi OiBbIkZBSUwiLCAiUEFTUyJdLCAiYnVnIjogIndlYmtpdC5vcmcvYi8xODgxMTgifX0KLSAgICAg ICAgICAgIH0sCi0gICAgICAgICAgICAidGVzdF9jbG9zZV9icm93c2luZ19jb250ZXh0X3dpdGhf ZGlzbWlzc2VkX2JlZm9yZXVubG9hZF9wcm9tcHQiOiB7Ci0gICAgICAgICAgICAgICAgImV4cGVj dGVkIjogeyJhbGwiOiB7InN0YXR1cyI6IFsiVElNRU9VVCJdLCAiYnVnIjogIndlYmtpdC5vcmcv Yi8xODg1NDYifX0KICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgIH0sCkBAIC02MDcsMTMg KzU5Nyw2IEBACiAgICAgICAgICAgICB9CiAgICAgICAgIH0KICAgICB9LAotICAgICJpbXBvcnRl ZC93M2Mvd2ViZHJpdmVyL3Rlc3RzL2ZvcndhcmQvZm9yd2FyZC5weSI6IHsKLSAgICAgICAgInN1 YnRlc3RzIjogewotICAgICAgICAgICAgInRlc3RfZGlzbWlzc2VkX2JlZm9yZXVubG9hZCI6IHsK LSAgICAgICAgICAgICAgICAiZXhwZWN0ZWQiOiB7ImFsbCI6IHsic3RhdHVzIjogWyJUSU1FT1VU Il0sICJidWciOiAid2Via2l0Lm9yZy9iLzE4ODU0NiJ9fQotICAgICAgICAgICAgfQotICAgICAg ICB9Ci0gICAgfSwKICAgICAiaW1wb3J0ZWQvdzNjL3dlYmRyaXZlci90ZXN0cy9lbGVtZW50X3Nl bmRfa2V5cy9ldmVudHMucHkiOiB7CiAgICAgICAgICJzdWJ0ZXN0cyI6IHsKICAgICAgICAgICAg ICJ0ZXN0X2ZpbGVfdXBsb2FkIjogewo=