188478 2018-08-10 13:35:55 -0700 [Cocoa] WebKit::PlatformPopupMenuData should use member initialization 2018-08-10 19:55:31 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ddkilzer ddkilzer achristensen commit-queue joepeck mcatanzaro webkit-bug-importer oldest_to_newest 1449355 0 ddkilzer 2018-08-10 13:35:55 -0700 WebKit::PlatformPopupMenuData should use member initialization. A new checker for the clang static analyzer found that the default constructor doesn't initialize these member fields to default values. 1449356 1 webkit-bug-importer 2018-08-10 13:36:12 -0700 <rdar://problem/43154363> 1449357 2 346919 ddkilzer 2018-08-10 13:47:38 -0700 Created attachment 346919 Patch v1 1449358 3 346919 joepeck 2018-08-10 13:50:15 -0700 Comment on attachment 346919 Patch v1 r=me 1449359 4 346919 joepeck 2018-08-10 13:50:42 -0700 Comment on attachment 346919 Patch v1 Leaving `cq?` until bots finish running. 1449460 5 346919 commit-queue 2018-08-10 19:55:30 -0700 Comment on attachment 346919 Patch v1 Clearing flags on attachment: 346919 Committed r234781: <https://trac.webkit.org/changeset/234781> 1449461 6 commit-queue 2018-08-10 19:55:31 -0700 All reviewed patches have been landed. Closing bug. 346919 2018-08-10 13:47:38 -0700 2018-08-10 19:55:30 -0700 Patch v1 bug-188478-20180810134737.patch text/plain 2745 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NjkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE4NDYzZjU4MWU2ZGM0NmRi YWVlZjAzMGNlNjViZWE5N2NjMDY2ZDQuLjVkZTFmMzQ4ZGMyODhkZmZmNTU1ZWYzNzg2MmRkNWVh NGRlNTc1OTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjMgQEAKKzIwMTgtMDgtMTAgIERhdmlkIEtp bHplciAgPGRka2lsemVyQGFwcGxlLmNvbT4KKworICAgICAgICBbQ29jb2FdIFdlYktpdDo6UGxh dGZvcm1Qb3B1cE1lbnVEYXRhIHNob3VsZCB1c2UgbWVtYmVyIGluaXRpYWxpemF0aW9uCisgICAg ICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8xODg0Nzg+CisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS80MzE1NDM2Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNoYXJlZC9QbGF0Zm9ybVBvcHVwTWVudURhdGEuY3BwOgorICAgICAgICAoV2ViS2l0 OjpQbGF0Zm9ybVBvcHVwTWVudURhdGE6OlBsYXRmb3JtUG9wdXBNZW51RGF0YSk6IERlbGV0ZQor ICAgICAgICBpbXBsZW1lbnRhdGlvbi4gIFRoaXMgY29uc3RydWN0b3IgY2F1c2VkIHRoZSB3YXJu aW5nIGJ5IG5ldmVyCisgICAgICAgIGluaXRpYWxpemluZyBpdHMgbWVtYmVyIHZhcmlhYmxlcy4K KyAgICAgICAgKiBTaGFyZWQvUGxhdGZvcm1Qb3B1cE1lbnVEYXRhLmg6CisgICAgICAgIChXZWJL aXQ6OlBsYXRmb3JtUG9wdXBNZW51RGF0YTo6UGxhdGZvcm1Qb3B1cE1lbnVEYXRhKToKKyAgICAg ICAgLSBVc2UgZGVmYXVsdCBjb25zdHJ1Y3Rvci4KKyAgICAgICAgKFdlYktpdDo6UGxhdGZvcm1Q b3B1cE1lbnVEYXRhOjpzaG91bGRQb3BPdmVyKToKKyAgICAgICAgKFdlYktpdDo6UGxhdGZvcm1Q b3B1cE1lbnVEYXRhOjpoaWRlQXJyb3dzKToKKyAgICAgICAgKFdlYktpdDo6UGxhdGZvcm1Qb3B1 cE1lbnVEYXRhOjptZW51U2l6ZSk6CisgICAgICAgIC0gQWRkIHN0cnVjdCBtZW1iZXIgaW5pdGlh bGl6YXRpb24uCisKIDIwMTgtMDgtMDUgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgog CiAgICAgICAgIFtDb2NvYV0gTW9yZSB0d2Vha3MgYW5kIHJlZmFjdG9yaW5nIHRvIHByZXBhcmUg Zm9yIEFSQwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFyZWQvUGxhdGZvcm1Qb3B1cE1l bnVEYXRhLmNwcCBiL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1BsYXRmb3JtUG9wdXBNZW51RGF0YS5j cHAKaW5kZXggMmMwNjY5MTM2MDZlYjczMDg2YzRjZTE1OTM0NGI5MWFhODYxOWJkOS4uYjk0ODgx OWU2ZjBlNjQ5NWVlZTBlNzEwZDliNWI1N2U3NjdmYjI2YyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YktpdC9TaGFyZWQvUGxhdGZvcm1Qb3B1cE1lbnVEYXRhLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 L1NoYXJlZC9QbGF0Zm9ybVBvcHVwTWVudURhdGEuY3BwCkBAIC0zMCwxMCArMzAsNiBAQAogCiBu YW1lc3BhY2UgV2ViS2l0IHsKIAotUGxhdGZvcm1Qb3B1cE1lbnVEYXRhOjpQbGF0Zm9ybVBvcHVw TWVudURhdGEoKQotewotfQotCiB2b2lkIFBsYXRmb3JtUG9wdXBNZW51RGF0YTo6ZW5jb2RlKElQ Qzo6RW5jb2RlciYgZW5jb2RlcikgY29uc3QKIHsKICNpZiBQTEFURk9STShDT0NPQSkKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJLaXQvU2hhcmVkL1BsYXRmb3JtUG9wdXBNZW51RGF0YS5oIGIvU291 cmNlL1dlYktpdC9TaGFyZWQvUGxhdGZvcm1Qb3B1cE1lbnVEYXRhLmgKaW5kZXggYjI5NWE2N2M1 YWMxZDc3NmJjMDQyYjk5ODIwNjlmOGU1NmU3MDkzZi4uNTk5NDk4NzBlY2M0MjNjYzk5OGMxNmUz YThlNzU5MThlM2I4MGQwNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvUGxhdGZv cm1Qb3B1cE1lbnVEYXRhLmgKKysrIGIvU291cmNlL1dlYktpdC9TaGFyZWQvUGxhdGZvcm1Qb3B1 cE1lbnVEYXRhLmgKQEAgLTM4LDcgKzM4LDcgQEAgY2xhc3MgRW5jb2RlcjsKIG5hbWVzcGFjZSBX ZWJLaXQgewogCiBzdHJ1Y3QgUGxhdGZvcm1Qb3B1cE1lbnVEYXRhIHsKLSAgICBQbGF0Zm9ybVBv cHVwTWVudURhdGEoKTsKKyAgICBQbGF0Zm9ybVBvcHVwTWVudURhdGEoKSA9IGRlZmF1bHQ7CiAK ICAgICB2b2lkIGVuY29kZShJUEM6OkVuY29kZXImKSBjb25zdDsKICAgICBzdGF0aWMgYm9vbCBk ZWNvZGUoSVBDOjpEZWNvZGVyJiwgUGxhdGZvcm1Qb3B1cE1lbnVEYXRhJik7CkBAIC00Niw5ICs0 Niw5IEBAIHN0cnVjdCBQbGF0Zm9ybVBvcHVwTWVudURhdGEgewogCiAjaWYgUExBVEZPUk0oQ09D T0EpCiAgICAgRm9udEluZm8gZm9udEluZm87Ci0gICAgYm9vbCBzaG91bGRQb3BPdmVyOwotICAg IGJvb2wgaGlkZUFycm93czsKLSAgICBXZWJDb3JlOjpQb3B1cE1lbnVTdHlsZTo6UG9wdXBNZW51 U2l6ZSBtZW51U2l6ZTsKKyAgICBib29sIHNob3VsZFBvcE92ZXIgeyBmYWxzZSB9OworICAgIGJv b2wgaGlkZUFycm93cyB7IGZhbHNlIH07CisgICAgV2ViQ29yZTo6UG9wdXBNZW51U3R5bGU6OlBv cHVwTWVudVNpemUgbWVudVNpemUgeyBXZWJDb3JlOjpQb3B1cE1lbnVTdHlsZTo6UG9wdXBNZW51 U2l6ZTo6UG9wdXBNZW51U2l6ZU5vcm1hbCB9OwogI2VsaWYgUExBVEZPUk0oV0lOKQogICAgIGlu dCBtX2NsaWVudFBhZGRpbmdMZWZ0IHsgMCB9OwogICAgIGludCBtX2NsaWVudFBhZGRpbmdSaWdo dCB7IDAgfTsK