188465 2018-08-10 00:47:07 -0700 [GTK][WPE] WebDriver: do not use default browser arguments when browser binary has been provided 2018-08-10 01:18:18 -0700 1 1 1 Unclassified WebKit WebDriver WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, InRadar P2 Normal --- 1 cgarcia webkit-unassigned bburg bugs-noreply webkit-bug-importer zan oldest_to_newest 1449246 0 cgarcia 2018-08-10 00:47:07 -0700 We only want to use --automation when no options or no browser binary is provided, because we fallback to MiniBrowser and we know it needs --automation flag. 1449247 1 346899 cgarcia 2018-08-10 00:50:14 -0700 Created attachment 346899 Patch 1449248 2 cgarcia 2018-08-10 01:17:18 -0700 Committed r234753: <https://trac.webkit.org/changeset/234753> 1449249 3 webkit-bug-importer 2018-08-10 01:18:18 -0700 <rdar://problem/43131428> 346899 2018-08-10 00:50:14 -0700 2018-08-10 01:13:13 -0700 Patch wd-browser-arguments-default.diff text/plain 4105 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJEcml2ZXIvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkRyaXZl ci9DaGFuZ2VMb2cKaW5kZXggNDczMjUyZGNjZWEuLmNkYjMwZmJmYzE0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViRHJpdmVyL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA4LTEwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNn YXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIFdlYkRyaXZlcjogZG8gbm90 IHVzZSBkZWZhdWx0IGJyb3dzZXIgYXJndW1lbnRzIHdoZW4gYnJvd3NlciBiaW5hcnkgaGFzIGJl ZW4gcHJvdmlkZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE4ODQ2NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlIG9ubHkgd2FudCB0byB1c2UgLS1hdXRvbWF0aW9uIHdoZW4gbm8gb3B0aW9ucyBvciBu byBicm93c2VyIGJpbmFyeSBpcyBwcm92aWRlZCwgYmVjYXVzZSB3ZSBmYWxsYmFjayB0bworICAg ICAgICBNaW5pQnJvd3NlciBhbmQgd2Uga25vdyBpdCBuZWVkcyAtLWF1dG9tYXRpb24gZmxhZy4K KworICAgICAgICAqIGdsaWIvU2Vzc2lvbkhvc3RHbGliLmNwcDoKKyAgICAgICAgKFdlYkRyaXZl cjo6U2Vzc2lvbkhvc3Q6OmxhdW5jaEJyb3dzZXIpOiBIYW5kbGUgdGhlIGNhc2Ugb2YgYnJvd3Nl ciBhcmd1bWVudHMgYmVpbmcgc3RkOjpudWxsb3B0LgorICAgICAgICAqIGd0ay9XZWJEcml2ZXJT ZXJ2aWNlR3RrLmNwcDoKKyAgICAgICAgKFdlYkRyaXZlcjo6V2ViRHJpdmVyU2VydmljZTo6cGxh dGZvcm1QYXJzZUNhcGFiaWxpdGllcyBjb25zdCk6IEluaXRpYWxpemUgYnJvd3NlciBhcmd1bWVu dHMgdG8gc3RkOm51bGxvcHQgaWYKKyAgICAgICAgYnJvd3NlciBiaW5hcnkgd2FzIHByb3ZpZGVk LgorICAgICAgICAqIHdwZS9XZWJEcml2ZXJTZXJ2aWNlV1BFLmNwcDoKKyAgICAgICAgKFdlYkRy aXZlcjo6V2ViRHJpdmVyU2VydmljZTo6cGxhdGZvcm1QYXJzZUNhcGFiaWxpdGllcyBjb25zdCk6 IERpdHRvLgorCiAyMDE4LTA4LTAzICBNczJnZXIgIDxNczJnZXJAaWdhbGlhLmNvbT4KIAogICAg ICAgICBGaXggaW52YWxpZCBvcHRpb25hbCBhY2Nlc3MgaW4gV2ViRHJpdmVyIFNlc3Npb246OmNy ZWF0ZVRvcExldmVsQnJvd3NpbmdDb250ZXh0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkRyaXZl ci9nbGliL1Nlc3Npb25Ib3N0R2xpYi5jcHAgYi9Tb3VyY2UvV2ViRHJpdmVyL2dsaWIvU2Vzc2lv bkhvc3RHbGliLmNwcAppbmRleCA5NDEzODFmN2E3Yy4uYTVhYTc4MzU5M2IgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJEcml2ZXIvZ2xpYi9TZXNzaW9uSG9zdEdsaWIuY3BwCisrKyBiL1NvdXJjZS9X ZWJEcml2ZXIvZ2xpYi9TZXNzaW9uSG9zdEdsaWIuY3BwCkBAIC0xNDcsMTEgKzE0NywxMSBAQCB2 b2lkIFNlc3Npb25Ib3N0OjpsYXVuY2hCcm93c2VyKEZ1bmN0aW9uPHZvaWQgKHN0ZDo6b3B0aW9u YWw8U3RyaW5nPiBlcnJvcik+JiYgYwogICAgIGdfc3VicHJvY2Vzc19sYXVuY2hlcl9zZXRlbnYo bGF1bmNoZXIuZ2V0KCksICJHVEtfT1ZFUkxBWV9TQ1JPTExJTkciLCBtX2NhcGFiaWxpdGllcy51 c2VPdmVybGF5U2Nyb2xsYmFycy52YWx1ZSgpID8gIjEiIDogIjAiLCBUUlVFKTsKICNlbmRpZgog Ci0gICAgY29uc3QgYXV0byYgYnJvd3NlckFyZ3VtZW50cyA9IG1fY2FwYWJpbGl0aWVzLmJyb3dz ZXJBcmd1bWVudHMudmFsdWUoKTsKLSAgICBHVW5pcXVlUHRyPGNoYXIqPiBhcmdzKGdfbmV3MChj aGFyKiwgYnJvd3NlckFyZ3VtZW50cy5zaXplKCkgKyAyKSk7CisgICAgc2l6ZV90IGJyb3dzZXJB cmd1bWVudHNTaXplID0gbV9jYXBhYmlsaXRpZXMuYnJvd3NlckFyZ3VtZW50cyA/IG1fY2FwYWJp bGl0aWVzLmJyb3dzZXJBcmd1bWVudHMtPnNpemUoKSA6IDA7CisgICAgR1VuaXF1ZVB0cjxjaGFy Kj4gYXJncyhnX25ldzAoY2hhciosIGJyb3dzZXJBcmd1bWVudHNTaXplICsgMikpOwogICAgIGFy Z3MuZ2V0KClbMF0gPSBnX3N0cmR1cChtX2NhcGFiaWxpdGllcy5icm93c2VyQmluYXJ5LnZhbHVl KCkudXRmOCgpLmRhdGEoKSk7Ci0gICAgZm9yICh1bnNpZ25lZCBpID0gMDsgaSA8IGJyb3dzZXJB cmd1bWVudHMuc2l6ZSgpOyArK2kpCi0gICAgICAgIGFyZ3MuZ2V0KClbaSArIDFdID0gZ19zdHJk dXAoYnJvd3NlckFyZ3VtZW50c1tpXS51dGY4KCkuZGF0YSgpKTsKKyAgICBmb3IgKHVuc2lnbmVk IGkgPSAwOyBpIDwgYnJvd3NlckFyZ3VtZW50c1NpemU7ICsraSkKKyAgICAgICAgYXJncy5nZXQo KVtpICsgMV0gPSBnX3N0cmR1cChtX2NhcGFiaWxpdGllcy5icm93c2VyQXJndW1lbnRzLnZhbHVl KClbaV0udXRmOCgpLmRhdGEoKSk7CiAKICAgICBHVW5pcXVlT3V0UHRyPEdFcnJvcj4gZXJyb3I7 CiAgICAgbV9icm93c2VyID0gYWRvcHRHUmVmKGdfc3VicHJvY2Vzc19sYXVuY2hlcl9zcGF3bnYo bGF1bmNoZXIuZ2V0KCksIGFyZ3MuZ2V0KCksICZlcnJvci5vdXRQdHIoKSkpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkRyaXZlci9ndGsvV2ViRHJpdmVyU2VydmljZUd0ay5jcHAgYi9Tb3VyY2Uv V2ViRHJpdmVyL2d0ay9XZWJEcml2ZXJTZXJ2aWNlR3RrLmNwcAppbmRleCA4MWY4YTQ3NDM1My4u ODA4YjdlMjI5OGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJEcml2ZXIvZ3RrL1dlYkRyaXZlclNl cnZpY2VHdGsuY3BwCisrKyBiL1NvdXJjZS9XZWJEcml2ZXIvZ3RrL1dlYkRyaXZlclNlcnZpY2VH dGsuY3BwCkBAIC0xMjEsOCArMTIxLDEwIEBAIHZvaWQgV2ViRHJpdmVyU2VydmljZTo6cGxhdGZv cm1QYXJzZUNhcGFiaWxpdGllcyhjb25zdCBKU09OOjpPYmplY3QmIG1hdGNoZWRDYXBhCiAgICAg ICAgIHJldHVybjsKIAogICAgIFN0cmluZyBicm93c2VyQmluYXJ5OwotICAgIGlmIChicm93c2Vy T3B0aW9ucy0+Z2V0U3RyaW5nKCJiaW5hcnkiX3MsIGJyb3dzZXJCaW5hcnkpKQorICAgIGlmIChi cm93c2VyT3B0aW9ucy0+Z2V0U3RyaW5nKCJiaW5hcnkiX3MsIGJyb3dzZXJCaW5hcnkpKSB7CiAg ICAgICAgIGNhcGFiaWxpdGllcy5icm93c2VyQmluYXJ5ID0gYnJvd3NlckJpbmFyeTsKKyAgICAg ICAgY2FwYWJpbGl0aWVzLmJyb3dzZXJBcmd1bWVudHMgPSBzdGQ6Om51bGxvcHQ7CisgICAgfQog CiAgICAgUmVmUHRyPEpTT046OkFycmF5PiBicm93c2VyQXJndW1lbnRzOwogICAgIGlmIChicm93 c2VyT3B0aW9ucy0+Z2V0QXJyYXkoImFyZ3MiX3MsIGJyb3dzZXJBcmd1bWVudHMpICYmIGJyb3dz ZXJBcmd1bWVudHMtPmxlbmd0aCgpKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViRHJpdmVyL3dw ZS9XZWJEcml2ZXJTZXJ2aWNlV1BFLmNwcCBiL1NvdXJjZS9XZWJEcml2ZXIvd3BlL1dlYkRyaXZl clNlcnZpY2VXUEUuY3BwCmluZGV4IGQ4ZTY3N2Q1ZTQwLi5jNjJkZTEzMjMzOCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkRyaXZlci93cGUvV2ViRHJpdmVyU2VydmljZVdQRS5jcHAKKysrIGIvU291 cmNlL1dlYkRyaXZlci93cGUvV2ViRHJpdmVyU2VydmljZVdQRS5jcHAKQEAgLTg4LDggKzg4LDEw IEBAIHZvaWQgV2ViRHJpdmVyU2VydmljZTo6cGxhdGZvcm1QYXJzZUNhcGFiaWxpdGllcyhjb25z dCBKU09OOjpPYmplY3QmIG1hdGNoZWRDYXBhCiAgICAgICAgIHJldHVybjsKIAogICAgIFN0cmlu ZyBicm93c2VyQmluYXJ5OwotICAgIGlmIChicm93c2VyT3B0aW9ucy0+Z2V0U3RyaW5nKCJiaW5h cnkiX3MsIGJyb3dzZXJCaW5hcnkpKQorICAgIGlmIChicm93c2VyT3B0aW9ucy0+Z2V0U3RyaW5n KCJiaW5hcnkiX3MsIGJyb3dzZXJCaW5hcnkpKSB7CiAgICAgICAgIGNhcGFiaWxpdGllcy5icm93 c2VyQmluYXJ5ID0gYnJvd3NlckJpbmFyeTsKKyAgICAgICAgY2FwYWJpbGl0aWVzLmJyb3dzZXJB cmd1bWVudHMgPSBzdGQ6Om51bGxvcHQ7CisgICAgfQogCiAgICAgUmVmUHRyPEpTT046OkFycmF5 PiBicm93c2VyQXJndW1lbnRzOwogICAgIGlmIChicm93c2VyT3B0aW9ucy0+Z2V0QXJyYXkoImFy Z3MiX3MsIGJyb3dzZXJBcmd1bWVudHMpICYmIGJyb3dzZXJBcmd1bWVudHMtPmxlbmd0aCgpKSB7 Cg==