188450 2018-08-09 14:08:20 -0700 test262-runner -s --test-only should replace test results 2018-09-04 10:17:21 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue keith_miller leo lforschler mcatanzaro msaboff webkit-bug-importer oldest_to_newest 1449105 0 keith_miller 2018-08-09 14:08:20 -0700 Right now if you run the test262-runner and tell it to save results while only running a subset of the tests it will clear all the other results. It should probably regex replace the results for what actually changed. 1449388 1 346931 keith_miller 2018-08-10 14:58:32 -0700 Created attachment 346931 Patch 1452137 2 346931 msaboff 2018-08-21 10:00:45 -0700 Comment on attachment 346931 Patch r=me 1453843 3 346931 commit-queue 2018-08-27 04:49:16 -0700 Comment on attachment 346931 Patch Clearing flags on attachment: 346931 Committed r235359: <https://trac.webkit.org/changeset/235359> 1453844 4 commit-queue 2018-08-27 04:49:17 -0700 All reviewed patches have been landed. Closing bug. 1453846 5 webkit-bug-importer 2018-08-27 04:50:17 -0700 <rdar://problem/43750234> 1456315 6 mcatanzaro 2018-09-04 08:49:57 -0700 This introduced 10 webkitperl test failures for WPE/GTK: Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl .................................. Experimental keys on scalar is now forbidden at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262/Runner.pm line 929. Compilation failed in require at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262-runner line 45. BEGIN failed--compilation aborted at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262-runner line 45. Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl .................................. 1/13 # Failed test 'test262 test failed, ignore expectations (exit code: 1)' # at Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl line 136. # got: '255' # expected: '1' # Failed test 'test262 test failed, ignore expectations (new failures: 2)' # at Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl line 142. # got: '0' # expected: '2' Experimental keys on scalar is now forbidden at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262/Runner.pm line 929. Compilation failed in require at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262-runner line 45. BEGIN failed--compilation aborted at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262-runner line 45. # Failed test 'test262 test passed, ignore expectations (exit code: 0)' # at Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl line 136. # got: '255' # expected: '0' Experimental keys on scalar is now forbidden at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262/Runner.pm line 929. Compilation failed in require at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262-runner line 45. BEGIN failed--compilation aborted at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262-runner line 45. # Failed test 'test262 tests newly failed (exit code: 1)' # at Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl line 136. # got: '255' # expected: '1' # Failed test 'test262 tests newly failed (new failures: 2)' # at Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl line 142. # got: '0' # expected: '2' Experimental keys on scalar is now forbidden at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262/Runner.pm line 929. Compilation failed in require at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262-runner line 45. BEGIN failed--compilation aborted at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262-runner line 45. # Failed test 'test262 tests newly passed (exit code: 0)' # at Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl line 136. # got: '255' # expected: '0' Experimental keys on scalar is now forbidden at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262/Runner.pm line 929. Compilation failed in require at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262-runner line 45. BEGIN failed--compilation aborted at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262-runner line 45. # Failed test 'test262 tests fails, expected failure (exit code: 0)' # at Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl line 136. # got: '255' # expected: '0' Experimental keys on scalar is now forbidden at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262/Runner.pm line 929. Compilation failed in require at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262-runner line 45. BEGIN failed--compilation aborted at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262-runner line 45. # Failed test 'test262 tests fails, with unexpected error string (exit code: 1)' # at Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl line 136. # got: '255' # expected: '1' # Failed test 'test262 tests fails, with unexpected error string (new failures: 2)' # at Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl line 142. # got: '0' # expected: '2' Experimental keys on scalar is now forbidden at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262/Runner.pm line 929. Compilation failed in require at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262-runner line 45. BEGIN failed--compilation aborted at /home/slave/webkitgtk/gtk-linux-64-release-tests/build/Tools/Scripts/test262-runner line 45. # Failed test 'expectations yaml file format' # at Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl line 157. # Looks like you failed 10 tests of 13. Tools/Scripts/webkitperl/test262_unittest/test262-runner-tests.pl .................................. Dubious, test returned 10 (wstat 2560, 0xa00) Failed 10/13 subtests 1456354 7 keith_miller 2018-09-04 10:17:21 -0700 It seems that perl has deprecated calling keys on a reference. Maybe this will fix that?: https://bugs.webkit.org/show_bug.cgi?id=189261. idk how to perl... 346931 2018-08-10 14:58:32 -0700 2018-08-27 04:49:16 -0700 Patch bug-188450-20180810145831.patch text/plain 2784 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NzcwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2YyYTRhNTdlMjVjY2FjNDYzODZkODg3Zjk2OTZlMThj ZTkzMDc2NS4uODU1ZjM1Y2U1YWU0MjJhNDY0ZDE1ZWI5N2VmNGQzMWVhZWE5YWEzYSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDE4LTA4LTEwICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgor CisgICAgICAgIHRlc3QyNjItcnVubmVyIC1zIC0tdGVzdC1vbmx5IHNob3VsZCByZXBsYWNlIHRl c3QgcmVzdWx0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTg4NDUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBTY3JpcHRzL3Rlc3QyNjIvUnVubmVyLnBtOgorICAgICAgICAobWFpbik6CisgICAgICAg IChTZXRGYWlsdXJlRm9yVGVzdCk6CisgICAgICAgIChVcGRhdGVSZXN1bHRzKToKKwogMjAxOC0w OC0xMCAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgd2Via2l0 LXBhdGNoIHNldHVwLWdpdC1jbG9uZSBzaG91bGQgc2V0IEdpdCBjb3JlIGVkaXRvciB0byBjb21t aXQtbG9nLWVkaXRvcgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy90ZXN0MjYyL1J1bm5lci5w bSBiL1Rvb2xzL1NjcmlwdHMvdGVzdDI2Mi9SdW5uZXIucG0KaW5kZXggM2ZlMmY0ZjNjNDAwOTk0 NThlNTE1MTU0MDNiMmViNmFjMjM0NDFmYy4uZjRjZDVlZWNmMjhiOWNkMDkxOTQ2NTNhZTlkOTAz YTEwNzZjODk5ZiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy90ZXN0MjYyL1J1bm5lci5wbQor KysgYi9Ub29scy9TY3JpcHRzL3Rlc3QyNjIvUnVubmVyLnBtCkBAIC00NDMsMTQgKzQ0Myw3IEBA IHN1YiBtYWluIHsKICAgICAgICAgICAgICRmYWlsY291bnQrKzsKIAogICAgICAgICAgICAgIyBS ZWNvcmQgdGhpcyByb3VuZCBvZiBmYWlsdXJlcwotICAgICAgICAgICAgaWYgKCAkZmFpbGVkeyR0 ZXN0LT57cGF0aH19ICkgewotICAgICAgICAgICAgICAgICRmYWlsZWR7JHRlc3QtPntwYXRofX0t PnskdGVzdC0+e21vZGV9fSA9ICAkdGVzdC0+e2Vycm9yfTsKLSAgICAgICAgICAgIH0KLSAgICAg ICAgICAgIGVsc2UgewotICAgICAgICAgICAgICAgICRmYWlsZWR7JHRlc3QtPntwYXRofX0gPSB7 Ci0gICAgICAgICAgICAgICAgICAgICR0ZXN0LT57bW9kZX0gPT4gJHRlc3QtPntlcnJvcn0KLSAg ICAgICAgICAgICAgICB9OwotICAgICAgICAgICAgfQorICAgICAgICAgICAgU2V0RmFpbHVyZUZv clRlc3QoXCVmYWlsZWQsICR0ZXN0KTsKIAogICAgICAgICAgICAgIyBJZiBhbiB1bmV4cGVjdGVk IGZhaWx1cmUKICAgICAgICAgICAgIGlmICghJGV4cGVjdGVkRmFpbHVyZSB8fCAoJGV4cGVjdGVk RmFpbHVyZSBuZSAkdGVzdC0+e2Vycm9yfSkpIHsKQEAgLTUyMCw2ICs1MTMsOSBAQCBzdWIgbWFp biB7CiAgICAgfQogCiAgICAgaWYgKCRzYXZlRXhwZWN0YXRpb25zKSB7CisgICAgICAgIGlmICgh JHJ1bm5pbmdBbGxUZXN0cykgeworICAgICAgICAgICAgVXBkYXRlUmVzdWx0cygkZXhwZWN0LCBc QHJlc3VsdHMsIFwlZmFpbGVkKTsKKyAgICAgICAgfQogICAgICAgICBEdW1wRmlsZSgkZXhwZWN0 YXRpb25zRmlsZSwgXCVmYWlsZWQpOwogICAgICAgICBwcmludCAiU2F2ZWQgZXhwZWN0YXRpb24g ZmlsZSBpbjogJGV4cGVjdGF0aW9uc0ZpbGVcbiI7CiAgICAgfQpAQCAtOTA4LDYgKzkwNCw0MiBA QCBzdWIgZ2V0SGFybmVzcyB7CiAgICAgcmV0dXJuICRjb250ZW50IHx8ICcnOwogfQogCitzdWIg U2V0RmFpbHVyZUZvclRlc3QgeworICAgIG15ICgkZmFpbGVkLCAkdGVzdCkgPSBAXzsKKworICAg IGlmICgkZmFpbGVkLT57JHRlc3QtPntwYXRofX0pIHsKKyAgICAgICAgJGZhaWxlZC0+eyR0ZXN0 LT57cGF0aH19LT57JHRlc3QtPnttb2RlfX0gPSAkdGVzdC0+e2Vycm9yfTsKKyAgICB9CisgICAg ZWxzZSB7CisgICAgICAgICRmYWlsZWQtPnskdGVzdC0+e3BhdGh9fSA9IHsKKyAgICAgICAgICAg ICR0ZXN0LT57bW9kZX0gPT4gJHRlc3QtPntlcnJvcn0KKyAgICAgICAgfTsKKyAgICB9Cit9CisK K3N1YiBVcGRhdGVSZXN1bHRzIHsKKyAgICBwcmludCAiVXBkYXRpbmcgcmVzdWx0cy4uLiBcbiI7 CisKKyAgICBteSAoJGV4cGVjdCwgJHJlc3VsdHMsICRmYWlsZWQpID0gQF87CisKKyAgICBmb3Jl YWNoIG15ICR0ZXN0IChAeyRyZXN1bHRzfSkgeworICAgICAgICBkZWxldGUgJGV4cGVjdC0+eyR0 ZXN0LT57cGF0aH19OworICAgIH0KKworICAgIGZvcmVhY2ggbXkgJHBhdGggKGtleXMoJGV4cGVj dCkpIHsKKyAgICAgICAgZm9yZWFjaCBteSAkbW9kZSAoa2V5cygkZXhwZWN0LT57JHBhdGh9KSkg eworICAgICAgICAgICAgbXkgJHRlc3QgPSB7CisgICAgICAgICAgICAgICAgcGF0aCA9PiAkcGF0 aCwKKyAgICAgICAgICAgICAgICBtb2RlID0+ICRtb2RlLAorICAgICAgICAgICAgICAgIGVycm9y ID0+ICRleHBlY3QtPnskcGF0aH0tPnskbW9kZX0sCisgICAgICAgICAgICAgICAgcmVzdWx0ID0+ ICdGQUlMJworICAgICAgICAgICAgfTsKKworICAgICAgICAgICAgU2V0RmFpbHVyZUZvclRlc3Qo JGZhaWxlZCwgJHRlc3QpOworICAgICAgICB9CisgICAgfQorfQorCiBzdWIgc3VtbWFyaXplUmVz dWx0cyB7CiAgICAgcHJpbnQgIlN1bW1hcml6aW5nIHJlc3VsdHMuLi5cbiI7CiAK