188429 2018-08-08 19:21:38 -0700 Prevent collectScreenProperties from crashing Base System 2018-08-08 20:53:26 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 justin_fan justin_fan commit-queue simon.fraser webkit-bug-importer oldest_to_newest 1448906 0 justin_fan 2018-08-08 19:21:38 -0700 Prevent collectScreenProperties from crashing Base System 1448907 1 webkit-bug-importer 2018-08-08 19:25:48 -0700 <rdar://problem/43075662> 1448910 2 346812 justin_fan 2018-08-08 19:50:39 -0700 Created attachment 346812 Patch 1448912 3 346812 simon.fraser 2018-08-08 19:57:21 -0700 Comment on attachment 346812 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346812&action=review > Source/WebCore/ChangeLog:9 > + Reviewed by NOBODY (OOPS!). This should go above the description (use "webkit-patch upload" to prepare your patches). > Source/WebCore/platform/mac/PlatformScreenMac.mm:203 > + CGLRendererInfoObj rendererInfo = 0; nullptr, not 0 > Source/WebCore/platform/mac/PlatformScreenMac.mm:205 > ASSERT(error == kCGLNoError); We know this assert will fire on some systems, so remove it. 1448915 4 346814 justin_fan 2018-08-08 20:06:52 -0700 Created attachment 346814 Patch 1448916 5 justin_fan 2018-08-08 20:09:52 -0700 Thanks for the rapid review Simon! 1448935 6 346814 commit-queue 2018-08-08 20:53:25 -0700 Comment on attachment 346814 Patch Clearing flags on attachment: 346814 Committed r234717: <https://trac.webkit.org/changeset/234717> 1448936 7 commit-queue 2018-08-08 20:53:26 -0700 All reviewed patches have been landed. Closing bug. 346812 2018-08-08 19:50:39 -0700 2018-08-08 20:06:51 -0700 Patch bug-188429-20180808195038.patch text/plain 2574 justin_fan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWMzOGQ3NGQ1ZThmZmIw YjQ0MjhkNTVhZDBhMmU1NzJhZGY2MDA3NC4uMzJkYzU4MjAzZDI5ZTBhNGQxZWY3MWI5Njg3NWYx MGUzYTM4NTk1YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA4LTA4ICBKdXN0 aW4gRmFuICA8anVzdGluX2ZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUHJldmVudCBjb2xsZWN0 U2NyZWVuUHJvcGVydGllcyBmcm9tIGNyYXNoaW5nIEJhc2UgU3lzdGVtCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg0MjkKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzQzMDc1NjYyPgorCisgICAgICAgIEFkZGluZyBzb21lIGVycm9yLWNoZWNraW5n IGFuZCBlYXJseSByZXR1cm5zIHRvIGZ1cnRoZXIgcHJldmVudCBjYWxsaW5nIENHTERlc2NyaWJl UmVuZGVyZXIgd2l0aCBpbnZhbGlkIHBhcmFtZXRlcnMuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRXhpc3RpbmcgV2ViR0wgdGVzdHMgc2hvdWxkIGNv dmVyOyBubyBleHBlY3RlZCBjaGFuZ2UgaW4gYmVoYXZpb3IuIENyYXNoIGhhcHBlbmVkIHByaW1h cmlseSBvbiBCYXNlIFN5c3RlbS4gCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvUGxhdGZvcm1T Y3JlZW5NYWMubW06CisgICAgICAgIChXZWJDb3JlOjpncHVJREZvckRpc3BsYXlNYXNrKToKKwog MjAxOC0wOC0wNyAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLCBzdXBwcmVzcyB3YXJuaW5ncyB0byBmaXggdGhlIGJ1aWxkLgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1BsYXRmb3JtU2NyZWVuTWFjLm1tIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1BsYXRmb3JtU2NyZWVuTWFjLm1tCmluZGV4IGU3 ODQzNGYzMWU1YjU4M2ZkNWYwZmM5MTUyNzc3OTcwNGI4ZGE1ZmYuLjRmMGI3MjU3ZTdlNjNhNDYz YTllZDMxMzYwNmUwZDRmNzg5NjQ5ODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL21hYy9QbGF0Zm9ybVNjcmVlbk1hYy5tbQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9tYWMvUGxhdGZvcm1TY3JlZW5NYWMubW0KQEAgLTE5OSwyNCArMTk5LDMzIEBAIElPUmVnaXN0 cnlHUFVJRCBncHVJREZvckRpc3BsYXkoUGxhdGZvcm1EaXNwbGF5SUQgZGlzcGxheUlEKQogCiBJ T1JlZ2lzdHJ5R1BVSUQgZ3B1SURGb3JEaXNwbGF5TWFzayhHTHVpbnQgZGlzcGxheU1hc2spCiB7 Ci0gICAgR0xpbnQgbnVtUmVuZGVyZXJzOwotICAgIENHTFJlbmRlcmVySW5mb09iaiByZW5kZXJl ckluZm87CisgICAgR0xpbnQgbnVtUmVuZGVyZXJzID0gMDsKKyAgICBDR0xSZW5kZXJlckluZm9P YmogcmVuZGVyZXJJbmZvID0gMDsKICAgICBDR0xFcnJvciBlcnJvciA9IENHTFF1ZXJ5UmVuZGVy ZXJJbmZvKGRpc3BsYXlNYXNrLCAmcmVuZGVyZXJJbmZvLCAmbnVtUmVuZGVyZXJzKTsKICAgICBB U1NFUlQoZXJyb3IgPT0ga0NHTE5vRXJyb3IpOworICAgIGlmICghbnVtUmVuZGVyZXJzIHx8ICFy ZW5kZXJlckluZm8gfHwgZXJyb3IgIT0ga0NHTE5vRXJyb3IpCisgICAgICAgIHJldHVybiAwOwog CiAgICAgLy8gVGhlIDB0aCByZW5kZXJlciBzaG91bGQgbm90IGJlIHRoZSBzb2Z0d2FyZSByZW5k ZXJlci4KICAgICBHTGludCBpc0FjY2VsZXJhdGVkOwogICAgIGVycm9yID0gQ0dMRGVzY3JpYmVS ZW5kZXJlcihyZW5kZXJlckluZm8sIDAsIGtDR0xSUEFjY2VsZXJhdGVkLCAmaXNBY2NlbGVyYXRl ZCk7CiAgICAgQVNTRVJUKGVycm9yID09IGtDR0xOb0Vycm9yKTsKICAgICBBU1NFUlQoaXNBY2Nl bGVyYXRlZCk7CisgICAgaWYgKCFpc0FjY2VsZXJhdGVkIHx8IGVycm9yICE9IGtDR0xOb0Vycm9y KQorICAgICAgICByZXR1cm4gMDsKIAotICAgIEdMaW50IGdwdUlETG93OwotICAgIEdMaW50IGdw dUlESGlnaDsKKyAgICBHTGludCBncHVJRExvdyA9IDA7CisgICAgR0xpbnQgZ3B1SURIaWdoID0g MDsKIAogICAgIGVycm9yID0gQ0dMRGVzY3JpYmVSZW5kZXJlcihyZW5kZXJlckluZm8sIDAsIGtD R0xSUFJlZ2lzdHJ5SURMb3csICZncHVJRExvdyk7CiAgICAgQVNTRVJUKGVycm9yID09IGtDR0xO b0Vycm9yKTsKKyAgICBpZiAoZXJyb3IgIT0ga0NHTE5vRXJyb3IpCisgICAgICAgIHJldHVybiAw OworCiAgICAgZXJyb3IgPSBDR0xEZXNjcmliZVJlbmRlcmVyKHJlbmRlcmVySW5mbywgMCwga0NH TFJQUmVnaXN0cnlJREhpZ2gsICZncHVJREhpZ2gpOwogICAgIEFTU0VSVChlcnJvciA9PSBrQ0dM Tm9FcnJvcik7CisgICAgaWYgKGVycm9yICE9IGtDR0xOb0Vycm9yKQorICAgICAgICByZXR1cm4g MDsKIAogICAgIHJldHVybiAoSU9SZWdpc3RyeUdQVUlEKSBncHVJREhpZ2ggPDwgMzIgfCBncHVJ RExvdzsKIH0K 346814 2018-08-08 20:06:52 -0700 2018-08-08 20:53:25 -0700 Patch bug-188429-20180808200652.patch text/plain 2579 justin_fan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NjU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWMzOGQ3NGQ1ZThmZmIw YjQ0MjhkNTVhZDBhMmU1NzJhZGY2MDA3NC4uZmQ4MjRhZWNiNDA4YjM0ODA0MzMyNmVhMDNlZjY3 YmIxMjBkODA0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA4LTA4ICBKdXN0 aW4gRmFuICA8anVzdGluX2ZhbkBhcHBsZS5jb20+CisKKyAgICAgICAgUHJldmVudCBjb2xsZWN0 U2NyZWVuUHJvcGVydGllcyBmcm9tIGNyYXNoaW5nIEJhc2UgU3lzdGVtCisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg0MjkKKyAgICAgICAgPHJkYXI6 Ly9wcm9ibGVtLzQzMDc1NjYyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgIEFkZGluZyBzb21lIGVycm9yLWNoZWNraW5nIGFuZCBlYXJseSByZXR1cm5z IHRvIGZ1cnRoZXIgcHJldmVudCBjYWxsaW5nIENHTERlc2NyaWJlUmVuZGVyZXIgd2l0aCBpbnZh bGlkIHBhcmFtZXRlcnMuCisKKyAgICAgICAgRXhpc3RpbmcgV2ViR0wgdGVzdHMgc2hvdWxkIGNv dmVyOyBubyBleHBlY3RlZCBjaGFuZ2UgaW4gYmVoYXZpb3IuIENyYXNoIGhhcHBlbmVkIHByaW1h cmlseSBvbiBCYXNlIFN5c3RlbS4KKworICAgICAgICAqIHBsYXRmb3JtL21hYy9QbGF0Zm9ybVNj cmVlbk1hYy5tbToKKyAgICAgICAgKFdlYkNvcmU6OmdwdUlERm9yRGlzcGxheU1hc2spOgorCiAy MDE4LTA4LTA3ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAg IFVucmV2aWV3ZWQsIHN1cHByZXNzIHdhcm5pbmdzIHRvIGZpeCB0aGUgYnVpbGQuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUGxhdGZvcm1TY3JlZW5NYWMubW0gYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvUGxhdGZvcm1TY3JlZW5NYWMubW0KaW5kZXggZTc4 NDM0ZjMxZTViNTgzZmQ1ZjBmYzkxNTI3Nzc5NzA0YjhkYTVmZi4uZmU1MmM1MWY5NjM2MTQ5MDU0 NjYyYjU4YjA3ZTM5ZTU2M2EwY2I4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWFjL1BsYXRmb3JtU2NyZWVuTWFjLm1tCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21hYy9QbGF0Zm9ybVNjcmVlbk1hYy5tbQpAQCAtMTk5LDI0ICsxOTksMjggQEAgSU9SZWdpc3Ry eUdQVUlEIGdwdUlERm9yRGlzcGxheShQbGF0Zm9ybURpc3BsYXlJRCBkaXNwbGF5SUQpCiAKIElP UmVnaXN0cnlHUFVJRCBncHVJREZvckRpc3BsYXlNYXNrKEdMdWludCBkaXNwbGF5TWFzaykKIHsK LSAgICBHTGludCBudW1SZW5kZXJlcnM7Ci0gICAgQ0dMUmVuZGVyZXJJbmZvT2JqIHJlbmRlcmVy SW5mbzsKKyAgICBHTGludCBudW1SZW5kZXJlcnMgPSAwOworICAgIENHTFJlbmRlcmVySW5mb09i aiByZW5kZXJlckluZm8gPSBudWxscHRyOwogICAgIENHTEVycm9yIGVycm9yID0gQ0dMUXVlcnlS ZW5kZXJlckluZm8oZGlzcGxheU1hc2ssICZyZW5kZXJlckluZm8sICZudW1SZW5kZXJlcnMpOwot ICAgIEFTU0VSVChlcnJvciA9PSBrQ0dMTm9FcnJvcik7CisgICAgaWYgKCFudW1SZW5kZXJlcnMg fHwgIXJlbmRlcmVySW5mbyB8fCBlcnJvciAhPSBrQ0dMTm9FcnJvcikKKyAgICAgICAgcmV0dXJu IDA7CiAKICAgICAvLyBUaGUgMHRoIHJlbmRlcmVyIHNob3VsZCBub3QgYmUgdGhlIHNvZnR3YXJl IHJlbmRlcmVyLgogICAgIEdMaW50IGlzQWNjZWxlcmF0ZWQ7CiAgICAgZXJyb3IgPSBDR0xEZXNj cmliZVJlbmRlcmVyKHJlbmRlcmVySW5mbywgMCwga0NHTFJQQWNjZWxlcmF0ZWQsICZpc0FjY2Vs ZXJhdGVkKTsKLSAgICBBU1NFUlQoZXJyb3IgPT0ga0NHTE5vRXJyb3IpOwotICAgIEFTU0VSVChp c0FjY2VsZXJhdGVkKTsKKyAgICBpZiAoIWlzQWNjZWxlcmF0ZWQgfHwgZXJyb3IgIT0ga0NHTE5v RXJyb3IpCisgICAgICAgIHJldHVybiAwOwogCi0gICAgR0xpbnQgZ3B1SURMb3c7Ci0gICAgR0xp bnQgZ3B1SURIaWdoOworICAgIEdMaW50IGdwdUlETG93ID0gMDsKKyAgICBHTGludCBncHVJREhp Z2ggPSAwOwogCiAgICAgZXJyb3IgPSBDR0xEZXNjcmliZVJlbmRlcmVyKHJlbmRlcmVySW5mbywg MCwga0NHTFJQUmVnaXN0cnlJRExvdywgJmdwdUlETG93KTsKLSAgICBBU1NFUlQoZXJyb3IgPT0g a0NHTE5vRXJyb3IpOworICAgIGlmIChlcnJvciAhPSBrQ0dMTm9FcnJvcikKKyAgICAgICAgcmV0 dXJuIDA7CisKICAgICBlcnJvciA9IENHTERlc2NyaWJlUmVuZGVyZXIocmVuZGVyZXJJbmZvLCAw LCBrQ0dMUlBSZWdpc3RyeUlESGlnaCwgJmdwdUlESGlnaCk7Ci0gICAgQVNTRVJUKGVycm9yID09 IGtDR0xOb0Vycm9yKTsKKyAgICBpZiAoZXJyb3IgIT0ga0NHTE5vRXJyb3IpCisgICAgICAgIHJl dHVybiAwOwogCiAgICAgcmV0dXJuIChJT1JlZ2lzdHJ5R1BVSUQpIGdwdUlESGlnaCA8PCAzMiB8 IGdwdUlETG93OwogfQo=