188427 2018-08-08 18:40:57 -0700 Yet more crashes in MobileSafari under -[WKFormInputSession setSuggestions:] 2018-08-08 21:36:49 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1448896 0 thorton 2018-08-08 18:40:57 -0700 Yet more crashes in MobileSafari under -[WKFormInputSession setSuggestions:] 1448897 1 346809 thorton 2018-08-08 18:41:19 -0700 Created attachment 346809 Patch 1448898 2 thorton 2018-08-08 18:41:21 -0700 <rdar://problem/43064672> 1448901 3 346809 wenson_hsieh 2018-08-08 19:02:24 -0700 Comment on attachment 346809 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346809&action=review > Source/WebKit/ChangeLog:15 > + Belt-and-suspenders fix: use ObjCWeakPtr for WKFormInputSession's WKContentView reference. ObjCWeakPtr => WeakObjCPtr 1448946 4 thorton 2018-08-08 21:36:49 -0700 https://trac.webkit.org/changeset/234719/webkit 346809 2018-08-08 18:41:19 -0700 2018-08-08 19:02:24 -0700 Patch bug-188427-20180808184118.patch text/plain 4195 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NzEzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI4NTRjNjAxNTI2ZjQwNDI4 NzU0MzM5OTRlNTc4MWQ3M2U0YmIxN2EuLmIyOWIwNmQwMzVlZjVmOTFiODBmZjBjZmU1ZmMzYThh NmIzMWE4NjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTgtMDgtMDggIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgWWV0IG1vcmUgY3Jhc2hl cyBpbiBNb2JpbGVTYWZhcmkgdW5kZXIgLVtXS0Zvcm1JbnB1dFNlc3Npb24gc2V0U3VnZ2VzdGlv bnM6XQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4 NDI3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MzA2NDY3Mj4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBTcGVjdWxhdGl2ZWx5IGZpeCBtb3JlIGNy YXNoZXMgc2VlbiB1bmRlciBzZXRTdWdnZXN0aW9ucy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9p b3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0Zvcm1JbnB1dFNl c3Npb24gaXNWYWxpZF0pOgorICAgICAgICAoLVtXS0Zvcm1JbnB1dFNlc3Npb24gc2V0U3VnZ2Vz dGlvbnM6XSk6CisgICAgICAgICgtW1dLRm9ybUlucHV0U2Vzc2lvbiBpbnZhbGlkYXRlXSk6Cisg ICAgICAgIEJlbHQtYW5kLXN1c3BlbmRlcnMgZml4OiB1c2UgT2JqQ1dlYWtQdHIgZm9yIFdLRm9y bUlucHV0U2Vzc2lvbidzIFdLQ29udGVudFZpZXcgcmVmZXJlbmNlLgorCisgICAgICAgICgtW1dL Q29udGVudFZpZXcgX3N0YXJ0QXNzaXN0aW5nTm9kZTp1c2VySXNJbnRlcmFjdGluZzpibHVyUHJl dmlvdXNOb2RlOmNoYW5naW5nQWN0aXZpdHlTdGF0ZTp1c2VyT2JqZWN0Ol0pOgorICAgICAgICBJ bnZhbGlkYXRlIHRoZSBXS0Zvcm1JbnB1dFNlc3Npb24gYmVmb3JlIHJlcGxhY2luZyBpdDsgd2Ug dGhlb3JpemUgdGhhdAorICAgICAgICB0aGVyZSBpcyBhIHBhdGggaW4gd2hpY2ggd2UgZ2V0IGhl cmUgd2l0aG91dCBoYXZpbmcgcHJldmlvdXNseSBjYWxsZWQgc3RvcEFzc2lzdGluZ05vZGUuCisg ICAgICAgIE1vc3Qgb2YgdGhlIGNvZGUgaXMgT0sgd2l0aCB0aGlzLCBidXQgdGhpcyBsZWF2ZXMg V0tGb3JtSW5wdXRTZXNzaW9uCisgICAgICAgIHdpdGggYSByYXcgcmVmZXJlbmNlIHRvIFdLQ29u dGVudFZpZXcgd2hpY2ggY2FuIGxhdGVyIGJlY29tZSBzdGFsZS4KKwogMjAxOC0wOC0wOCAgQ29t bWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdl ZCwgcm9sbGluZyBvdXQgcjIzNDMxNCwgcjIzNDMyMCwgYW5kIHIyMzQzMjEuCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t IGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t bQppbmRleCA4Y2VlN2I3ZjY5OWMwZjQ1ZjQ3YTI3MDY0ZDk1NjllMjBmM2NjMmFkLi5jMDkxMmMy OGQzZDM1MDVmY2QxZDVkYzI5ZTMyNTQ4MTA4MjU1ODQ2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW0KQEAgLTI5 MSw3ICsyOTEsNyBAQCAtICh2b2lkKWludmFsaWRhdGU7CiBAZW5kCiAKIEBpbXBsZW1lbnRhdGlv biBXS0Zvcm1JbnB1dFNlc3Npb24gewotICAgIFdLQ29udGVudFZpZXcgKl9jb250ZW50VmlldzsK KyAgICBXZWFrT2JqQ1B0cjxXS0NvbnRlbnRWaWV3PiBfY29udGVudFZpZXc7CiAgICAgUmV0YWlu UHRyPFdLRm9jdXNlZEVsZW1lbnRJbmZvPiBfZm9jdXNlZEVsZW1lbnRJbmZvOwogICAgIFJldGFp blB0cjxVSVZpZXc+IF9jdXN0b21JbnB1dFZpZXc7CiAgICAgUmV0YWluUHRyPE5TQXJyYXk8VUlU ZXh0U3VnZ2VzdGlvbiAqPj4gX3N1Z2dlc3Rpb25zOwpAQCAtMzI0LDcgKzMyNCw3IEBAIC0gKE5T T2JqZWN0IDxOU1NlY3VyZUNvZGluZz4gKil1c2VyT2JqZWN0CiAKIC0gKEJPT0wpaXNWYWxpZAog ewotICAgIHJldHVybiBfY29udGVudFZpZXcgIT0gbmlsOworICAgIHJldHVybiAhIV9jb250ZW50 VmlldzsKIH0KIAogLSAoTlNTdHJpbmcgKilhY2Nlc3NvcnlWaWV3Q3VzdG9tQnV0dG9uVGl0bGUK QEAgLTM5MSw3ICszOTEsNyBAQCAtIChOU0FycmF5PFVJVGV4dFN1Z2dlc3Rpb24gKj4gKilzdWdn ZXN0aW9ucwogCiAtICh2b2lkKXNldFN1Z2dlc3Rpb25zOihOU0FycmF5PFVJVGV4dFN1Z2dlc3Rp b24gKj4gKilzdWdnZXN0aW9ucwogewotICAgIGlkIDxVSVRleHRJbnB1dFN1Z2dlc3Rpb25EZWxl Z2F0ZT4gc3VnZ2VzdGlvbkRlbGVnYXRlID0gKGlkIDxVSVRleHRJbnB1dFN1Z2dlc3Rpb25EZWxl Z2F0ZT4pX2NvbnRlbnRWaWV3LmlucHV0RGVsZWdhdGU7CisgICAgaWQgPFVJVGV4dElucHV0U3Vn Z2VzdGlvbkRlbGVnYXRlPiBzdWdnZXN0aW9uRGVsZWdhdGUgPSAoaWQgPFVJVGV4dElucHV0U3Vn Z2VzdGlvbkRlbGVnYXRlPilbX2NvbnRlbnRWaWV3IGlucHV0RGVsZWdhdGVdOwogICAgIF9zdWdn ZXN0aW9ucyA9IGFkb3B0TlMoW3N1Z2dlc3Rpb25zIGNvcHldKTsKICAgICBbc3VnZ2VzdGlvbkRl bGVnYXRlIHNldFN1Z2dlc3Rpb25zOnN1Z2dlc3Rpb25zXTsKIH0KQEAgLTQwMyw3ICs0MDMsNyBA QCAtIChCT09MKXJlcXVpcmVzU3Ryb25nUGFzc3dvcmRBc3Npc3RhbmNlCiAKIC0gKHZvaWQpaW52 YWxpZGF0ZQogewotICAgIGlkIDxVSVRleHRJbnB1dFN1Z2dlc3Rpb25EZWxlZ2F0ZT4gc3VnZ2Vz dGlvbkRlbGVnYXRlID0gKGlkIDxVSVRleHRJbnB1dFN1Z2dlc3Rpb25EZWxlZ2F0ZT4pX2NvbnRl bnRWaWV3LmlucHV0RGVsZWdhdGU7CisgICAgaWQgPFVJVGV4dElucHV0U3VnZ2VzdGlvbkRlbGVn YXRlPiBzdWdnZXN0aW9uRGVsZWdhdGUgPSAoaWQgPFVJVGV4dElucHV0U3VnZ2VzdGlvbkRlbGVn YXRlPilbX2NvbnRlbnRWaWV3IGlucHV0RGVsZWdhdGVdOwogICAgIFtzdWdnZXN0aW9uRGVsZWdh dGUgc2V0U3VnZ2VzdGlvbnM6bmlsXTsKICAgICBfY29udGVudFZpZXcgPSBuaWw7CiB9CkBAIC00 MTIxLDggKzQxMjEsMTAgQEAgLSAodm9pZClfc3RhcnRBc3Npc3RpbmdOb2RlOihjb25zdCBBc3Np c3RlZE5vZGVJbmZvcm1hdGlvbiYpaW5mb3JtYXRpb24gdXNlcklzSW4KICAgICBib29sIGRlbGVn YXRlSW1wbGVtZW50c1dpbGxTdGFydElucHV0U2Vzc2lvbiA9IFtpbnB1dERlbGVnYXRlIHJlc3Bv bmRzVG9TZWxlY3RvcjpAc2VsZWN0b3IoX3dlYlZpZXc6d2lsbFN0YXJ0SW5wdXRTZXNzaW9uOild OwogICAgIGJvb2wgZGVsZWdhdGVJbXBsZW1lbnRzRGlkU3RhcnRJbnB1dFNlc3Npb24gPSBbaW5w dXREZWxlZ2F0ZSByZXNwb25kc1RvU2VsZWN0b3I6QHNlbGVjdG9yKF93ZWJWaWV3OmRpZFN0YXJ0 SW5wdXRTZXNzaW9uOildOwogCi0gICAgaWYgKGRlbGVnYXRlSW1wbGVtZW50c1dpbGxTdGFydElu cHV0U2Vzc2lvbiB8fCBkZWxlZ2F0ZUltcGxlbWVudHNEaWRTdGFydElucHV0U2Vzc2lvbikKKyAg ICBpZiAoZGVsZWdhdGVJbXBsZW1lbnRzV2lsbFN0YXJ0SW5wdXRTZXNzaW9uIHx8IGRlbGVnYXRl SW1wbGVtZW50c0RpZFN0YXJ0SW5wdXRTZXNzaW9uKSB7CisgICAgICAgIFtfZm9ybUlucHV0U2Vz c2lvbiBpbnZhbGlkYXRlXTsKICAgICAgICAgX2Zvcm1JbnB1dFNlc3Npb24gPSBhZG9wdE5TKFtb V0tGb3JtSW5wdXRTZXNzaW9uIGFsbG9jXSBpbml0V2l0aENvbnRlbnRWaWV3OnNlbGYgZm9jdXNl ZEVsZW1lbnRJbmZvOmZvY3VzZWRFbGVtZW50SW5mby5nZXQoKSByZXF1aXJlc1N0cm9uZ1Bhc3N3 b3JkQXNzaXN0YW5jZTpfZm9jdXNSZXF1aXJlc1N0cm9uZ1Bhc3N3b3JkQXNzaXN0YW5jZV0pOwor ICAgIH0KIAogICAgIGlmIChkZWxlZ2F0ZUltcGxlbWVudHNXaWxsU3RhcnRJbnB1dFNlc3Npb24p CiAgICAgICAgIFtpbnB1dERlbGVnYXRlIF93ZWJWaWV3Ol93ZWJWaWV3IHdpbGxTdGFydElucHV0 U2Vzc2lvbjpfZm9ybUlucHV0U2Vzc2lvbi5nZXQoKV07Cg==