188422 2018-08-08 15:34:30 -0700 Disallow navigations when page cache updates the current document of the frame 2018-08-21 09:51:25 -0700 1 1 1 Unclassified WebKit Page Loading WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 dbates dbates aestes beidson cdumez ews-watchlist japhet koivisto rniwa webkit-bug-importer oldest_to_newest 1448870 0 dbates 2018-08-08 15:34:30 -0700 As part of restoring a page from the page cache we call Frame::setDocument() to re-associate the cached document into its frame. Frame::setDocument() triggers render tree construction and post style resolution callbacks that can do anything, including navigating child frames before we have restored them (and hence re-attached them to the frame tree). For example, pages embedded via an HTML object element are loaded from a post style resolution callback. We should not perform navigations during page restore. 1448884 1 346804 dbates 2018-08-08 17:14:48 -0700 Created attachment 346804 Patch and layout test 1450931 2 346804 rniwa 2018-08-16 16:07:15 -0700 Comment on attachment 346804 Patch and layout test View in context: https://bugs.webkit.org/attachment.cgi?id=346804&action=review > LayoutTests/fast/history/go-back-to-object-subframe.html:22 > +window.onpageshow = runTest; We should probably mention in the change log that we're not preventing navigation during pageshow event. 1450933 3 dbates 2018-08-16 16:09:13 -0700 (In reply to Ryosuke Niwa from comment #2) > Comment on attachment 346804 [details] > Patch and layout test > > View in context: > https://bugs.webkit.org/attachment.cgi?id=346804&action=review > > > LayoutTests/fast/history/go-back-to-object-subframe.html:22 > > +window.onpageshow = runTest; > > We should probably mention in the change log that we're not preventing > navigation during pageshow event. Will add the following remark to the change log entry in LayoutTests/ChangeLog: This change does not prevent navigations initiated from a pageshow event handler. 1452133 4 dbates 2018-08-21 09:50:30 -0700 Committed r235121: <https://trac.webkit.org/changeset/235121> 1452134 5 webkit-bug-importer 2018-08-21 09:51:25 -0700 <rdar://problem/43565212> 346804 2018-08-08 17:14:48 -0700 2018-08-16 16:07:15 -0700 Patch and layout test bug-188422-20180808171448.patch text/plain 5100 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzg1YWRiZTBmZTg1NDg1 MTU3NDIwZGIyMWM2MTQwYTJlM2RlYTVkZS4uYzc5ZWExNzg0MzM0YmRlNDJkNTU1Mjc4YzA0MjE2 ZjlhOTYwZGI1MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE4LTA4LTA4ICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBEaXNhbGxvdyBuYXZpZ2F0 aW9ucyB3aGVuIHBhZ2UgY2FjaGUgdXBkYXRlcyB0aGUgY3VycmVudCBkb2N1bWVudCBvZiB0aGUg ZnJhbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 ODQyMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE1h a2UgdXNlIG9mIE5hdmlnYXRpb25EaXNhYmxlciB0byBkaXNhbGxvdyBuYXZpZ2F0aW9ucyB3aGVu IGFzc29jaWF0aW5nIHRoZSBjYWNoZWQKKyAgICAgICAgZG9jdW1lbnQgYmFjayB3aXRoIGl0cyBm cmFtZSAoaS5lLiBjYWxsaW5nIEZyYW1lOjpzZXREb2N1bWVudCgpKS4KKworICAgICAgICBXaGVu IHdlIGFzc29jaWF0ZSBhIGNhY2hlZCBkb2N1bWVudCB3aXRoIGl0cyBmcmFtZSB3ZSB3aWxsIGNv bnN0cnVjdCBpdHMgcmVuZGVyIHRyZWUKKyAgICAgICAgYW5kIHJ1biBwb3N0IHN0eWxlIHJlc29s dXRpb24gY2FsbGJhY2tzIHRoYXQgY2FuIGRvIGFueXRoaW5nLCBpbmNsdWRpbmcgcGVyZm9ybWlu ZworICAgICAgICBhIGZyYW1lIGxvYWQuIFVudGlsIHBhZ2UgcmVzdG9yYXRpb24gaXMgY29tbnBs ZXRlIHRoZSBmcmFtZSB0cmVlIGlzIGluIGEgdHJhbnNpZW50CisgICAgICAgIHN0YXRlIHRoYXQg bWFrZXMgcmVhc29uaW5nIGFib3V0IGl0IGRpZmZpY3VsdCBhbmQgZXJyb3IgcHJvbmUuIFdlIHNo b3VsZCBub3QgYWxsb3cKKyAgICAgICAgbmF2aWdhdGlvbnMgaW4gdGhpcyBzdGF0ZS4KKworICAg ICAgICBUZXN0OiBmYXN0L2hpc3RvcnkvZ28tYmFjay10by1vYmplY3Qtc3ViZnJhbWUuaHRtbAor CisgICAgICAgICogbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkZy YW1lTG9hZGVyOjpvcGVuKToKKwogMjAxOC0wOC0wOCAgRXJpYyBDYXJsc29uICA8ZXJpYy5jYXJs c29uQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgTG9nQXJndW1lbnQgdGVtcGxhdGUgZm9yIFBs YXRmb3JtTWVkaWFTZXNzaW9uOjpSZW1vdGVDb250cm9sQ29tbWFuZFR5cGUKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9s b2FkZXIvRnJhbWVMb2FkZXIuY3BwCmluZGV4IGRlNzFiMGM5NzAwNmIxZTg1ZDMyOGY5YzUwMTg5 NDM4M2Q4YzI5NzMuLjE4NDU2MTNjNzljMGVlNDk3NDgxZGI5YTFlNmU3ZTI5YTEyMjc0NGIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApAQCAtMjI2Myw4ICsyMjYzLDE1IEBA IHZvaWQgRnJhbWVMb2FkZXI6Om9wZW4oQ2FjaGVkRnJhbWVCYXNlJiBjYWNoZWRGcmFtZSkKICAg ICAvLyBVc2UgdGhlIHByZXZpb3VzIFNjcm9sbFZpZXcncyBmcmFtZSByZWN0LgogICAgIGlmIChw cmV2aW91c1ZpZXdGcmFtZVJlY3QpCiAgICAgICAgIHZpZXctPnNldEZyYW1lUmVjdChwcmV2aW91 c1ZpZXdGcmFtZVJlY3QudmFsdWUoKSk7Ci0gICAgCi0gICAgbV9mcmFtZS5zZXREb2N1bWVudChk b2N1bWVudCk7CisKKyAgICB7CisgICAgICAgIC8vIFNldHRpbmcgdGhlIGRvY3VtZW50IGJ1aWxk cyB0aGUgcmVuZGVyIHRyZWUgYW5kIHJ1bnMgcG9zdCBzdHlsZSByZXNvbHV0aW9uIGNhbGxiYWNr cyB0aGF0IGNhbiBkbyBhbnl0aGluZywKKyAgICAgICAgLy8gaW5jbHVkaW5nIGxvYWRpbmcgYSBj aGlsZCBmcmFtZSBiZWZvcmUgaXRzIGJlZW4gcmUtYXR0YWNoZWQgdG8gdGhlIGZyYW1lIHRyZWUg YXMgcGFydCBvZiB0aGlzIHJlc3RvcmUuCisgICAgICAgIC8vIEZvciBleGFtcGxlLCB0aGUgSFRN TCBvYmplY3QgZWxlbWVudCBtYXkgbG9hZCBpdHMgY29udGVudCBpbnRvIGEgZnJhbWUgaW4gYSBw b3N0IHN0eWxlIHJlc29sdXRpb24gY2FsbGJhY2suCisgICAgICAgIE5hdmlnYXRpb25EaXNhYmxl ciBkaXNhYmxlTmF2aWdhdGlvbiB7ICZtX2ZyYW1lIH07CisgICAgICAgIG1fZnJhbWUuc2V0RG9j dW1lbnQoZG9jdW1lbnQpOworICAgIH0KKwogICAgIGRvY3VtZW50LT5kb21XaW5kb3coKS0+cmVz dW1lRnJvbURvY3VtZW50U3VzcGVuc2lvbigpOwogCiAgICAgdXBkYXRlRmlyc3RQYXJ0eUZvckNv b2tpZXMoKTsKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwppbmRleCBkYmRiYTQxMzkyYjM1ZmI3Nzg4N2ZmYjAyNzk2NzBmYjk1ZTM5ZWQ3 Li41ODk4Yzk1NDg5NzZjODBlYzY3NTNmZmEyYTNlZDFlYTExZWE3YzkzIDEwMDY0NAotLS0gYS9M YXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTggQEAKKzIwMTgtMDgtMDggIERhbmllbCBCYXRlcyAgPGRhYmF0ZXNAYXBwbGUuY29tPgor CisgICAgICAgIERpc2FsbG93IG5hdmlnYXRpb25zIHdoZW4gcGFnZSBjYWNoZSB1cGRhdGVzIHRo ZSBjdXJyZW50IGRvY3VtZW50IG9mIHRoZSBmcmFtZQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4NDIyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWRkIGEgdGVzdCBjYXNlIHRoYXQgZW5zdXJlcyB0aGF0 IHdlIGRvIG5vdCBoaXQgdGhlIGFzc2VydGlvbiBBU1NFUlQob3duZXJGcmFtZSB8fCBtX2ZyYW1l LmlzTWFpbkZyYW1lKCkpCisgICAgICAgIGluIEZyYW1lTG9hZGVyOjphZGRFeHRyYUZpZWxkc1Rv UmVxdWVzdCgpIHdoZW4gbmF2aWdhdGluZyBiYWNrIHRvIGEgcGFnZSB0aGF0IGxvYWRzIGEgbmVz dGVkCisgICAgICAgIHBhZ2UsIHdob3NlIFVSTCBjb250YWlucyBhIGZyYWdtZW50LCB2aWEgYW4g SFRNTCBvYmplY3QgZWxlbWVudC4gVGhpcyBhc3NlcnRpb24gZmFpbHMgaWYKKyAgICAgICAgbmF2 aWdhdGlvbnMgYXJlIGFsbG93ZWQgd2hlbiByZXN0b3JpbmcgYSBwYWdlIGZyb20gdGhlIHBhZ2Ug Y2FjaGUuCisKKyAgICAgICAgKiBmYXN0L2hpc3RvcnkvZ28tYmFjay10by1vYmplY3Qtc3ViZnJh bWUtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2hpc3RvcnkvZ28tYmFjay10 by1vYmplY3Qtc3ViZnJhbWUuaHRtbDogQWRkZWQuCisKIDIwMTgtMDgtMDggIEpvc2VwaCBQZWNv cmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBYSFIg Y29udGVudCBzb21ldGltZXMgc2hvd3MgYXMgZXJyb3IgZXZlbiB0aG91Z2ggbG9hZCBzdWNjZWVk ZWQKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvaGlzdG9yeS9nby1iYWNrLXRvLW9iamVj dC1zdWJmcmFtZS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0L2hpc3RvcnkvZ28tYmFj ay10by1vYmplY3Qtc3ViZnJhbWUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLmU2NmJkZDMwZDc2 NjkwZGU1Y2EwMjg0NTQxMmU2NTc1ZGE2NzQ3NDUKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2hpc3RvcnkvZ28tYmFjay10by1vYmplY3Qtc3ViZnJhbWUtZXhwZWN0ZWQudHh0 CkBAIC0wLDAgKzEsMiBAQAorUEFTUy4gWW91IGRpZG4ndCBjcmFzaC4KKwpkaWZmIC0tZ2l0IGEv TGF5b3V0VGVzdHMvZmFzdC9oaXN0b3J5L2dvLWJhY2stdG8tb2JqZWN0LXN1YmZyYW1lLmh0bWwg Yi9MYXlvdXRUZXN0cy9mYXN0L2hpc3RvcnkvZ28tYmFjay10by1vYmplY3Qtc3ViZnJhbWUuaHRt bApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwLi41ODBhNDJmODNlNTc2OWFjZmRmZjQ0YTg2MzgyMDY3Yzg0MjcwODFkCi0t LSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9oaXN0b3J5L2dvLWJhY2stdG8tb2Jq ZWN0LXN1YmZyYW1lLmh0bWwKQEAgLTAsMCArMSwyOSBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRt bD4KKzxoZWFkPgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikgeworICAgIHRlc3RS dW5uZXIuZHVtcEFzVGV4dCgpOworICAgIHRlc3RSdW5uZXIub3ZlcnJpZGVQcmVmZXJlbmNlKCJX ZWJLaXRVc2VzUGFnZUNhY2hlUHJlZmVyZW5jZUtleSIsIDEpOworICAgIHRlc3RSdW5uZXIud2Fp dFVudGlsRG9uZSgpOworfQorCitmdW5jdGlvbiBydW5UZXN0KGUpCit7CisgICAgaWYgKGUucGVy c2lzdGVkKSB7CisgICAgICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgICAgICAgIHRl c3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgIH0gZWxzZSB7CisgICAgICAgIC8vIE5hdmlnYXRl IHVzaW5nIGEgdGltZW91dCB0byBtYWtlIHN1cmUgd2UgZ2VuZXJhdGUgYSBoaXN0b3J5IGVudHJ5 IHRoYXQgd2UgY2FuIGdvIGJhY2sgdG8uCisgICAgICAgIHNldFRpbWVvdXQoKCkgPT4geyBsb2Nh dGlvbi5ocmVmID0gImRhdGE6dGV4dC9odG1sLDxzY3JpcHQ+aGlzdG9yeS5iYWNrKCk8LyIgKyAi c2NyaXB0PiI7IH0sIDApOworICAgIH0KK30KKword2luZG93Lm9ucGFnZXNob3cgPSBydW5UZXN0 OworPC9zY3JpcHQ+Cis8L2hlYWQ+Cis8Ym9keT4KKzxkaXY+UEFTUy4gWW91IGRpZG4ndCBjcmFz aC48L2Rpdj4KKzxvYmplY3QgZGF0YT0icmVzb3VyY2VzL3N1YmZyYW1lLmh0bWwjZHVtbXkiICB3 aWR0aD0iNDAwIiBoZWlnaHQ9IjIwMCIgc3R5bGU9ImJvcmRlcjogMXB4IHNvbGlkIGJsYWNrIj48 L29iamVjdD4KKzwvYm9keT4KKzwvaHRtbD4K