188418 2018-08-08 14:18:28 -0700 Fix possible null dereference in WebBackForwardList::restoreFromState 2018-08-08 15:58:29 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez commit-queue rniwa webkit-bug-importer oldest_to_newest 1448840 0 achristensen 2018-08-08 14:18:28 -0700 Fix possible null dereference in WebBackForwardList::restoreFromState 1448842 1 346795 achristensen 2018-08-08 14:18:51 -0700 Created attachment 346795 Patch 1448843 2 achristensen 2018-08-08 14:18:53 -0700 <rdar://problem/42531726> 1448851 3 346795 cdumez 2018-08-08 14:44:15 -0700 Comment on attachment 346795 Patch I think it is fine to make this change in WebKit. However, let's confirm that it does not crash later on (or that Safari is not visually broken) after this fix before closing <rdar://problem/42531726>, since we have reproduction steps. 1448853 4 346795 cdumez 2018-08-08 14:45:49 -0700 Comment on attachment 346795 Patch Actually, hold on. We should have an API test. 1448862 5 cdumez 2018-08-08 15:03:26 -0700 <rdar://problem/43065730> 1448863 6 346802 achristensen 2018-08-08 15:05:54 -0700 Created attachment 346802 Patch 1448869 7 346802 cdumez 2018-08-08 15:29:23 -0700 Comment on attachment 346802 Patch r=me 1448875 8 346802 commit-queue 2018-08-08 15:58:27 -0700 Comment on attachment 346802 Patch Clearing flags on attachment: 346802 Committed r234714: <https://trac.webkit.org/changeset/234714> 1448876 9 commit-queue 2018-08-08 15:58:29 -0700 All reviewed patches have been landed. Closing bug. 346795 2018-08-08 14:18:51 -0700 2018-08-08 15:05:52 -0700 Patch bug-188418-20180808141850.patch text/plain 1264 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzQ3MTApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA4LTA4ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHBvc3NpYmxl IG51bGwgZGVyZWZlcmVuY2UgaW4gV2ViQmFja0ZvcndhcmRMaXN0OjpyZXN0b3JlRnJvbVN0YXRl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg0MTgK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQyNTMxNzI2PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYkJhY2tGb3J3YXJkTGlz dC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkJhY2tGb3J3YXJkTGlzdDo6cmVzdG9yZUZyb21T dGF0ZSk6CisKIDIwMTgtMDgtMDggIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3ZWJraXQu b3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMzQzMTQsIHIyMzQzMjAs IGFuZCByMjM0MzIxLgpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQmFja0Zvcndh cmRMaXN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJCYWNr Rm9yd2FyZExpc3QuY3BwCShyZXZpc2lvbiAyMzQ2NjMpCisrKyBTb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9XZWJCYWNrRm9yd2FyZExpc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MzMsNiArNDMz LDkgQEAgQmFja0ZvcndhcmRMaXN0U3RhdGUgV2ViQmFja0ZvcndhcmRMaXN0OgogCiB2b2lkIFdl YkJhY2tGb3J3YXJkTGlzdDo6cmVzdG9yZUZyb21TdGF0ZShCYWNrRm9yd2FyZExpc3RTdGF0ZSBi YWNrRm9yd2FyZExpc3RTdGF0ZSkKIHsKKyAgICBpZiAoIW1fcGFnZSkKKyAgICAgICAgcmV0dXJu OworCiAgICAgVmVjdG9yPFJlZjxXZWJCYWNrRm9yd2FyZExpc3RJdGVtPj4gaXRlbXM7CiAgICAg aXRlbXMucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShiYWNrRm9yd2FyZExpc3RTdGF0ZS5pdGVtcy5z aXplKCkpOwogCg== 346802 2018-08-08 15:05:54 -0700 2018-08-08 15:58:27 -0700 Patch bug-188418-20180808150553.patch text/plain 2993 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzQ3MTApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA4LTA4ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHBvc3NpYmxl IG51bGwgZGVyZWZlcmVuY2UgaW4gV2ViQmFja0ZvcndhcmRMaXN0OjpyZXN0b3JlRnJvbVN0YXRl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODg0MTgK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQyNTMxNzI2PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYkJhY2tGb3J3YXJkTGlz dC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYkJhY2tGb3J3YXJkTGlzdDo6cmVzdG9yZUZyb21T dGF0ZSk6CisgICAgICAgIE51bGwtY2hlY2sgbV9wYWdlIGxpa2Ugd2UgZG8gZXZlcnl3aGVyZSBl bHNlIGluIHRoaXMgZmlsZSBiZWNhdXNlIGl0IGNhbiBiZSBzZXQgdG8gbnVsbCB3aGVuIGNsb3Np bmcgdGhlIHBhZ2UuCisKIDIwMTgtMDgtMDggIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1xdWV1ZUB3 ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMzQzMTQsIHIy MzQzMjAsIGFuZCByMjM0MzIxLgpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvV2ViQmFj a0ZvcndhcmRMaXN0LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9X ZWJCYWNrRm9yd2FyZExpc3QuY3BwCShyZXZpc2lvbiAyMzQ2NjMpCisrKyBTb3VyY2UvV2ViS2l0 L1VJUHJvY2Vzcy9XZWJCYWNrRm9yd2FyZExpc3QuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00MzMs NiArNDMzLDkgQEAgQmFja0ZvcndhcmRMaXN0U3RhdGUgV2ViQmFja0ZvcndhcmRMaXN0OgogCiB2 b2lkIFdlYkJhY2tGb3J3YXJkTGlzdDo6cmVzdG9yZUZyb21TdGF0ZShCYWNrRm9yd2FyZExpc3RT dGF0ZSBiYWNrRm9yd2FyZExpc3RTdGF0ZSkKIHsKKyAgICBpZiAoIW1fcGFnZSkKKyAgICAgICAg cmV0dXJuOworCiAgICAgVmVjdG9yPFJlZjxXZWJCYWNrRm9yd2FyZExpc3RJdGVtPj4gaXRlbXM7 CiAgICAgaXRlbXMucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShiYWNrRm9yd2FyZExpc3RTdGF0ZS5p dGVtcy5zaXplKCkpOwogCkluZGV4OiBUb29scy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzQ3MTEpCisrKyBUb29scy9DaGFuZ2VMb2cJKHdvcmtp bmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxOC0wOC0wOCAgQWxleCBDaHJpc3RlbnNlbiAg PGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgorCisgICAgICAgIEZpeCBwb3NzaWJsZSBudWxsIGRl cmVmZXJlbmNlIGluIFdlYkJhY2tGb3J3YXJkTGlzdDo6cmVzdG9yZUZyb21TdGF0ZQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4NDE4CisgICAgICAg IDxyZGFyOi8vcHJvYmxlbS80MjUzMTcyNj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0L1Jlc3RvcmVT ZXNzaW9uU3RhdGUuY3BwOgorICAgICAgICAoVGVzdFdlYktpdEFQSTo6VEVTVCk6CisKIDIwMTgt MDgtMDggIFJvc3MgS2lyc2xpbmcgIDxyb3NzLmtpcnNsaW5nQHNvbnkuY29tPgogCiAgICAgICAg IHJ1bi1idWlsdGlucy1nZW5lcmF0b3ItdGVzdHMgZG9lcyBub3QgY29ycmVjdGx5IGhhbmRsZSBD UkxGcyBmcm9tIHN0ZGVycgpJbmRleDogVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQv UmVzdG9yZVNlc3Npb25TdGF0ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFdlYktpdEFQ SS9UZXN0cy9XZWJLaXQvUmVzdG9yZVNlc3Npb25TdGF0ZS5jcHAJKHJldmlzaW9uIDIzNDY3OCkK KysrIFRvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0L1Jlc3RvcmVTZXNzaW9uU3RhdGUu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMjYsNiArMTI2LDE4IEBAIFRFU1QoV2ViS2l0LCBSZXN0 b3JlU2Vzc2lvblN0YXRlQ29udGFpbmkKICAgICBFWFBFQ1RfSlNfRVEod2ViVmlldy5wYWdlKCks ICJoaXN0b3J5LnNjcm9sbFJlc3RvcmF0aW9uIiwgImF1dG8iKTsKIH0KIAorVEVTVChXZWJLaXQs IFJlc3RvcmVTZXNzaW9uU3RhdGVBZnRlckNsb3NlKQoreworICAgIGF1dG8gY29udGV4dCA9IGFk b3B0V0soV0tDb250ZXh0Q3JlYXRlKCkpOworICAgIFBsYXRmb3JtV2ViVmlldyB3ZWJWaWV3KGNv bnRleHQuZ2V0KCkpOworICAgIHNldFBhZ2VMb2FkZXJDbGllbnQod2ViVmlldy5wYWdlKCkpOwor ICAgIGF1dG8gZGF0YSA9IGNyZWF0ZVNlc3Npb25TdGF0ZURhdGEoY29udGV4dC5nZXQoKSk7Cisg ICAgRVhQRUNUX05PVF9OVUxMKGRhdGEpOworICAgIFdLUGFnZUNsb3NlKHdlYlZpZXcucGFnZSgp KTsKKyAgICBhdXRvIHNlc3Npb25TdGF0ZSA9IGFkb3B0V0soV0tTZXNzaW9uU3RhdGVDcmVhdGVG cm9tRGF0YShkYXRhLmdldCgpKSk7CisgICAgV0tQYWdlUmVzdG9yZUZyb21TZXNzaW9uU3RhdGUo d2ViVmlldy5wYWdlKCksIHNlc3Npb25TdGF0ZS5nZXQoKSk7Cit9CisgICAgCiB9IC8vIG5hbWVz cGFjZSBUZXN0V2ViS2l0QVBJCiAKICNlbmRpZgo=