188388 2018-08-07 13:29:00 -0700 REGRESSION(r225765) WKWebViewConfiguration should not keep a strong reference to a WebPageGroup 2018-08-07 14:21:13 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID InRadar P2 Normal --- 1 achristensen achristensen cdumez webkit-bug-importer oldest_to_newest 1448546 0 achristensen 2018-08-07 13:29:00 -0700 REGRESSION(r225765) WKWebViewConfiguration should not keep a strong reference to a WebPageGroup 1448547 1 346726 achristensen 2018-08-07 13:29:55 -0700 Created attachment 346726 Patch 1448548 2 achristensen 2018-08-07 13:29:57 -0700 <rdar://problem/42788651> 1448552 3 346726 cdumez 2018-08-07 13:41:41 -0700 Comment on attachment 346726 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346726&action=review > Source/WebKit/ChangeLog:9 > + Doing so caused a reference cycle. Keep an identifier instead. I do not get why this is OK. In particular in this scenario: 1. I create a WKPageGroup 2. I create a WKWebViewConfiguration 3. I set my WKPageGroup on the WKWebViewConfiguration 4. I deref the WKPageGroup since I expect the WKWebViewConfiguration to hold on to it. -> after your change, the WKPageGroup gets destroyed right? 5. I create a WKWebView using my WKWebViewConfiguration -> It does not end up in the WKPageGroup I specified. 1448586 4 346726 achristensen 2018-08-07 14:21:03 -0700 Comment on attachment 346726 Patch Chris is right. This is no good. 346726 2018-08-07 13:29:55 -0700 2018-08-07 14:21:03 -0700 Patch bug-188388-20180807132954.patch text/plain 2918 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzQ2NjcpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE4LTA4LTA3ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjI1NzY1KSBXS1dlYlZpZXdDb25maWd1cmF0aW9uIHNob3VsZCBub3Qga2VlcCBhIHN0cm9uZyBy ZWZlcmVuY2UgdG8gYSBXZWJQYWdlR3JvdXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE4ODM4OAorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDI3ODg2 NTE+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9p bmcgc28gY2F1c2VkIGEgcmVmZXJlbmNlIGN5Y2xlLiAgS2VlcCBhbiBpZGVudGlmaWVyIGluc3Rl YWQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRp b24ubW06CisgICAgICAgICgtW1dLV2ViVmlld0NvbmZpZ3VyYXRpb24gY29weVdpdGhab25lOl0p OgorICAgICAgICAoLVtXS1dlYlZpZXdDb25maWd1cmF0aW9uIF9wYWdlR3JvdXBdKToKKyAgICAg ICAgKC1bV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBfc2V0UGFnZUdyb3VwOl0pOgorCiAyMDE4LTA4 LTA3ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgU3RvcmFnZU1h bmFnZXIgc2hvdWxkIHN0b3AgcmVmJ2luZyBJUEM6OkNvbm5lY3Rpb25zIGFzIHRoaXMgaXMgbGVh ay1wcm9uZQpJbmRleDogU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL1dLV2ViVmll d0NvbmZpZ3VyYXRpb24ubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdC9VSVByb2Nlc3Mv QVBJL0NvY29hL1dLV2ViVmlld0NvbmZpZ3VyYXRpb24ubW0JKHJldmlzaW9uIDIzNDY2MykKKysr IFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9XS1dlYlZpZXdDb25maWd1cmF0aW9u Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zMSw2ICszMSw3IEBACiAKICNpbXBvcnQgIkFQSVBhZ2VD b25maWd1cmF0aW9uLmgiCiAjaW1wb3J0ICJWZXJzaW9uQ2hlY2tzLmgiCisjaW1wb3J0ICJXS0FQ SUNhc3QuaCIKICNpbXBvcnQgIldLUHJlZmVyZW5jZXMuaCIKICNpbXBvcnQgIldLUHJvY2Vzc1Bv b2wuaCIKICNpbXBvcnQgIldLUmV0YWluUHRyLmgiCkBAIC0zOCw2ICszOSw3IEBACiAjaW1wb3J0 ICJXS1dlYlZpZXcuaCIKICNpbXBvcnQgIldLV2ViVmlld0NvbnRlbnRQcm92aWRlclJlZ2lzdHJ5 LmgiCiAjaW1wb3J0ICJXZWJLaXQySW5pdGlhbGl6ZS5oIgorI2ltcG9ydCAiV2ViUGFnZUdyb3Vw LmgiCiAjaW1wb3J0ICJXZWJVUkxTY2hlbWVIYW5kbGVyQ29jb2EuaCIKICNpbXBvcnQgIl9XS1Zp c2l0ZWRMaW5rU3RvcmUuaCIKICNpbXBvcnQgIl9XS1dlYnNpdGVEYXRhU3RvcmVJbnRlcm5hbC5o IgpAQCAtMTQxLDcgKzE0Myw3IEBAIHN0YXRpYyBfV0tEcmFnTGlmdERlbGF5IHRvRHJhZ0xpZnRE ZWxheSgKICAgICBCT09MIF9tYWluQ29udGVudFVzZXJHZXN0dXJlT3ZlcnJpZGVFbmFibGVkOwog CiAjaWYgUExBVEZPUk0oTUFDKQotICAgIFdLUmV0YWluUHRyPFdLUGFnZUdyb3VwUmVmPiBfcGFn ZUdyb3VwOworICAgIHVpbnQ2NF90IF9wYWdlR3JvdXBJZGVudGlmaWVyOwogICAgIGRvdWJsZSBf Y3B1TGltaXQ7CiAgICAgQk9PTCBfc2hvd3NVUkxzSW5Ub29sVGlwczsKICAgICBCT09MIF9zZXJ2 aWNlQ29udHJvbHNFbmFibGVkOwpAQCAtMzkyLDcgKzM5NCw3IEBAIC0gKGlkKWNvcHlXaXRoWm9u ZTooTlNab25lICopem9uZQogICAgIGNvbmZpZ3VyYXRpb24tPl9zZXJ2aWNlQ29udHJvbHNFbmFi bGVkID0gc2VsZi0+X3NlcnZpY2VDb250cm9sc0VuYWJsZWQ7CiAgICAgY29uZmlndXJhdGlvbi0+ X2ltYWdlQ29udHJvbHNFbmFibGVkID0gc2VsZi0+X2ltYWdlQ29udHJvbHNFbmFibGVkOwogICAg IGNvbmZpZ3VyYXRpb24tPl9yZXF1aXJlc1VzZXJBY3Rpb25Gb3JFZGl0aW5nQ29udHJvbHNNYW5h Z2VyID0gc2VsZi0+X3JlcXVpcmVzVXNlckFjdGlvbkZvckVkaXRpbmdDb250cm9sc01hbmFnZXI7 Ci0gICAgY29uZmlndXJhdGlvbi0+X3BhZ2VHcm91cCA9IHNlbGYuX3BhZ2VHcm91cDsKKyAgICBj b25maWd1cmF0aW9uLT5fcGFnZUdyb3VwSWRlbnRpZmllciA9IHNlbGYtPl9wYWdlR3JvdXBJZGVu dGlmaWVyOwogI2VuZGlmCiAjaWYgRU5BQkxFKERBVEFfREVURUNUSU9OKSAmJiBQTEFURk9STShJ T1MpCiAgICAgY29uZmlndXJhdGlvbi0+X2RhdGFEZXRlY3RvclR5cGVzID0gc2VsZi0+X2RhdGFE ZXRlY3RvclR5cGVzOwpAQCAtOTMwLDEyICs5MzIsMTIgQEAgLSAodm9pZClfc2V0UmVxdWlyZXNV c2VyQWN0aW9uRm9yRWRpdGluZwogCiAtIChXS1BhZ2VHcm91cFJlZilfcGFnZUdyb3VwCiB7Ci0g ICAgcmV0dXJuIF9wYWdlR3JvdXAuZ2V0KCk7CisgICAgcmV0dXJuIHRvQVBJKFdlYktpdDo6V2Vi UGFnZUdyb3VwOjpnZXQoX3BhZ2VHcm91cElkZW50aWZpZXIpKTsKIH0KIAogLSAodm9pZClfc2V0 UGFnZUdyb3VwOihXS1BhZ2VHcm91cFJlZilwYWdlR3JvdXAKIHsKLSAgICBfcGFnZUdyb3VwID0g cGFnZUdyb3VwOworICAgIF9wYWdlR3JvdXBJZGVudGlmaWVyID0gV2ViS2l0Ojp0b0ltcGwocGFn ZUdyb3VwKS0+cGFnZUdyb3VwSUQoKTsKIH0KIAogLSAodm9pZClfc2V0Q1BVTGltaXQ6KGRvdWJs ZSljcHVMaW1pdAo=