188354 2018-08-06 13:31:32 -0700 Make RenderObject noncopyable 2018-08-07 16:15:07 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 achristensen achristensen cdumez oldest_to_newest 1448220 0 achristensen 2018-08-06 13:31:32 -0700 Make RenderObject noncopyable 1448222 1 346649 achristensen 2018-08-06 13:31:53 -0700 Created attachment 346649 Patch 1448615 2 346649 cdumez 2018-08-07 16:06:53 -0700 Comment on attachment 346649 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346649&action=review > Source/WebCore/rendering/RenderObject.h:107 > + WTF_MAKE_NONCOPYABLE(RenderObject); It is already uncopyable given this data member: Node& m_node; 1448618 3 346649 cdumez 2018-08-07 16:15:00 -0700 Comment on attachment 346649 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346649&action=review >> Source/WebCore/rendering/RenderObject.h:107 >> + WTF_MAKE_NONCOPYABLE(RenderObject); > > It is already uncopyable given this data member: > Node& m_node; See following review comment by Darin: https://bugs.webkit.org/show_bug.cgi?id=158111#c45 346649 2018-08-06 13:31:53 -0700 2018-08-07 16:15:07 -0700 Patch bug-188354-20180806133153.patch text/plain 1137 achristensen SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNDYxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE4LTA4LTA2ICBBbGV4IENo cmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgTWFrZSBSZW5k ZXJPYmplY3Qgbm9uY29weWFibGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4ODM1NAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlck9iamVjdC5oOgorCiAyMDE4LTA4LTA2ICBS eWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQs IHJvbGxpbmcgb3V0IHIyMzQ1NjkuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyT2JqZWN0LmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl ck9iamVjdC5oCShyZXZpc2lvbiAyMzQ1MTQpCisrKyBTb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv UmVuZGVyT2JqZWN0LmgJKHdvcmtpbmcgY29weSkKQEAgLTEwNCw2ICsxMDQsNyBAQCBzdHJ1Y3Qg QW5ub3RhdGVkUmVnaW9uVmFsdWUgewogLy8gQmFzZSBjbGFzcyBmb3IgYWxsIHJlbmRlcmluZyB0 cmVlIG9iamVjdHMuCiBjbGFzcyBSZW5kZXJPYmplY3QgOiBwdWJsaWMgQ2FjaGVkSW1hZ2VDbGll bnQsIHB1YmxpYyBDYW5NYWtlV2Vha1B0cjxSZW5kZXJPYmplY3Q+IHsKICAgICBXVEZfTUFLRV9J U09fQUxMT0NBVEVEKFJlbmRlck9iamVjdCk7CisgICAgV1RGX01BS0VfTk9OQ09QWUFCTEUoUmVu ZGVyT2JqZWN0KTsKICAgICBmcmllbmQgY2xhc3MgUmVuZGVyQmxvY2s7CiAgICAgZnJpZW5kIGNs YXNzIFJlbmRlckJsb2NrRmxvdzsKICAgICBmcmllbmQgY2xhc3MgUmVuZGVyRWxlbWVudDsK