188343 2018-08-06 02:05:09 -0700 Make DOMWindow::scrollBy rely on DOMWindow::scrollTo 2018-08-07 01:31:25 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 188300 188043 1 fred.wang fred.wang cdumez commit-queue darin simon.fraser webkit-bug-importer oldest_to_newest 1448088 0 fred.wang 2018-08-06 02:05:09 -0700 Follow-up of bug 188300. 1448092 1 346620 fred.wang 2018-08-06 02:58:09 -0700 Created attachment 346620 Patch 1448138 2 346620 darin 2018-08-06 09:22:32 -0700 Comment on attachment 346620 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346620&action=review > Source/WebCore/page/DOMWindow.cpp:1595 > + scrollToOptions.left.value() += view->mapFromLayoutToCSSUnits(view->contentsScrollPosition().x()); > + scrollToOptions.top.value() += view->mapFromLayoutToCSSUnits(view->contentsScrollPosition().y()); I hope there are no rounding differences caused by converting from layout to CSS and back. 1448163 3 346620 fred.wang 2018-08-06 11:02:56 -0700 Comment on attachment 346620 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346620&action=review >> Source/WebCore/page/DOMWindow.cpp:1595 >> + scrollToOptions.top.value() += view->mapFromLayoutToCSSUnits(view->contentsScrollPosition().y()); > > I hope there are no rounding differences caused by converting from layout to CSS and back. Probably there are, but that does not appear on the current set of tests. Not sure how we can avoid that... What do you suggest? 1448387 4 346620 commit-queue 2018-08-07 01:30:46 -0700 Comment on attachment 346620 Patch Clearing flags on attachment: 346620 Committed r234642: <https://trac.webkit.org/changeset/234642> 1448388 5 commit-queue 2018-08-07 01:30:47 -0700 All reviewed patches have been landed. Closing bug. 1448389 6 webkit-bug-importer 2018-08-07 01:31:25 -0700 <rdar://problem/42998916> 346620 2018-08-06 02:58:09 -0700 2018-08-07 01:30:46 -0700 Patch bug-188343-20180806115808.patch text/plain 2251 fred.wang U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NTk2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjBmYTY4ZjRkOWYzM2Iw ZmFiZjIzMmRhNjk4ZTYxMmU5NDNkOTY4Yy4uZGQwZmFlYzJlOTRmZjQyOThjMDM2ZjUyOWEzNDhk NzQ4MjU5NDJiMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA4LTA2ICBGcmVk ZXJpYyBXYW5nICA8ZndhbmdAaWdhbGlhLmNvbT4KKworICAgICAgICBNYWtlIERPTVdpbmRvdzo6 c2Nyb2xsQnkgcmVseSBvbiBET01XaW5kb3c6OnNjcm9sbFRvCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODgzNDMKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHBhdGNoIG1ha2VzIERPTVdpbmRvdzo6 c2Nyb2xsQnkgcmVseSBvbiBET01XaW5kb3c6OnNjcm9sbFRvIGluIG9yZGVyIHRvIHBlcmZvcm0g YWN0dWFsCisgICAgICAgIHNjcm9sbGluZyBvZiB0aGUgdmlldy4gSW4gcGFydGljdWxhciwgdGhp cyByZWR1Y2VzIHRoZSBudW1iZXIgb2YgY29kZSBwYXRoIHRvIG1vZGlmeSBpbiBvcmRlcgorICAg ICAgICB0byBpbXBsZW1lbnQgdGhlIFNjcm9sbEJlaGF2aW9yIG9wdGlvbiAoYnVnIDE4ODA0Myku IFRoZSBvbmx5IGNoYW5nZSBpcyBhbiBvcHRpbWl6YXRpb24gd2hlbgorICAgICAgICBzY3JvbGxp bmcgdG8gcG9zaXRpb24gKDAsIDApIGJ1dCBpdCBpcyBub3Qgb2JzZXJ2YWJsZS4KKworICAgICAg ICBObyBuZXcgdGVzdHMsIGJlaGF2aW9yIHVuY2hhbmdlZCBhbmQgYWxyZWFkeSB0ZXN0ZWQuCisK KyAgICAgICAgKiBwYWdlL0RPTVdpbmRvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01XaW5k b3c6OnNjcm9sbEJ5IGNvbnN0KTogQWRkIHRoZSBjdXJyZW50IHZpZXcgcG9zaXRpb24gdG8gdGhl IHNjcm9sbEJ5IG9mZnNldCBpbgorICAgICAgICBvcmRlciB0byBvYnRhaW4gdGhlIHNjcm9sbFRv IG9mZnNldC4KKwogMjAxOC0wOC0wNiAgRnJlZGVyaWMgV2FuZyAgPGZ3YW5nQGlnYWxpYS5jb20+ CiAKICAgICAgICAgTWFrZSB0d28tYXJndW1lbnRzIHZlcnNpb25zIG9mIHNjcm9sbEJ5L3Njcm9s bFRvIGRlcGVuZCBvbiB0aGUgb25lLWFyZ3VtZW50IHZlcnNpb25zCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdp bmRvdy5jcHAKaW5kZXggNzMwNzMyNjM2MzlmMDJjZjkxMjhiZDQ0NTg2MDEyYTQ4MWRlYWE3Zi4u NTAyNTRkN2E2NmRlZTdjYjZiMTcwYTE0NTA4YTY5ODFlNDA5ZGM4ZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2Uv RE9NV2luZG93LmNwcApAQCAtMTU5MSw4ICsxNTkxLDkgQEAgdm9pZCBET01XaW5kb3c6OnNjcm9s bEJ5KGNvbnN0IFNjcm9sbFRvT3B0aW9ucyYgb3B0aW9ucykgY29uc3QKICAgICAgICAgcmV0dXJu OwogCiAgICAgU2Nyb2xsVG9PcHRpb25zIHNjcm9sbFRvT3B0aW9ucyA9IG5vcm1hbGl6ZU5vbkZp bml0ZUNvb3JkaW5hdGVzT3JGYWxsQmFja1RvKG9wdGlvbnMsIDAsIDApOwotICAgIEludFNpemUg c2NhbGVkT2Zmc2V0KHZpZXctPm1hcEZyb21DU1NUb0xheW91dFVuaXRzKHNjcm9sbFRvT3B0aW9u cy5sZWZ0LnZhbHVlKCkpLCB2aWV3LT5tYXBGcm9tQ1NTVG9MYXlvdXRVbml0cyhzY3JvbGxUb09w dGlvbnMudG9wLnZhbHVlKCkpKTsKLSAgICB2aWV3LT5zZXRDb250ZW50c1Njcm9sbFBvc2l0aW9u KHZpZXctPmNvbnRlbnRzU2Nyb2xsUG9zaXRpb24oKSArIHNjYWxlZE9mZnNldCk7CisgICAgc2Ny b2xsVG9PcHRpb25zLmxlZnQudmFsdWUoKSArPSB2aWV3LT5tYXBGcm9tTGF5b3V0VG9DU1NVbml0 cyh2aWV3LT5jb250ZW50c1Njcm9sbFBvc2l0aW9uKCkueCgpKTsKKyAgICBzY3JvbGxUb09wdGlv bnMudG9wLnZhbHVlKCkgKz0gdmlldy0+bWFwRnJvbUxheW91dFRvQ1NTVW5pdHModmlldy0+Y29u dGVudHNTY3JvbGxQb3NpdGlvbigpLnkoKSk7CisgICAgc2Nyb2xsVG8oc2Nyb2xsVG9PcHRpb25z KTsKIH0KIAogdm9pZCBET01XaW5kb3c6OnNjcm9sbFRvKGRvdWJsZSB4LCBkb3VibGUgeSwgU2Ny b2xsQ2xhbXBpbmcgY2xhbXBpbmcpIGNvbnN0Cg==