188297 2018-08-02 21:38:59 -0700 [LFC] Do not check margin box while validating geometry. 2018-08-03 07:22:20 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1447514 0 zalan 2018-08-02 21:38:59 -0700 the current RenderBox::marginBox is not spec compliant. 1447516 1 346452 zalan 2018-08-02 21:42:16 -0700 Created attachment 346452 Patch 1447518 2 346452 zalan 2018-08-02 21:43:53 -0700 Comment on attachment 346452 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346452&action=review > Source/WebCore/layout/Verification.cpp:137 > +#if 0 Not sure what WebKit's policy is about keeping such code around. This will be re-enabled at some point (probably by adding a new function to RenderBox) 1447595 3 346477 zalan 2018-08-03 06:42:43 -0700 Created attachment 346477 Patch 1447605 4 zalan 2018-08-03 07:21:27 -0700 Committed r234544: <https://trac.webkit.org/changeset/234544> 1447606 5 webkit-bug-importer 2018-08-03 07:22:20 -0700 <rdar://problem/42898938> 346452 2018-08-02 21:42:16 -0700 2018-08-03 06:42:41 -0700 Patch bug-188297-20180802214215.patch text/plain 1753 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWE1MGVmYWUwNWE1NDEw MTlmYWI5NGU5NWFiMzkyZWI2N2Q4M2Y5MC4uZDE0NGJkNzIxMmQxMDE3NDdlNGIzNmQ4NWNjZmMz MDJjMmQzYWFhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA4LTAyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gRG8gbm90IGNoZWNr IG1hcmdpbiBib3ggd2hpbGUgdmFsaWRhdGluZyBnZW9tZXRyeS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODI5NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBjdXJyZW50IFJlbmRlckJveDo6bWFy Z2luQm94IGltcGxlbWVudGF0aW9uIGlzIG5vdCBzcGVjIGNvbXBsaWFudC4gSWdub3JlIGl0IGZv ciBub3cuCisKKyAgICAgICAgKiBsYXlvdXQvVmVyaWZpY2F0aW9uLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkxheW91dDo6b3V0cHV0TWlzbWF0Y2hpbmdCbG9ja0JveEluZm9ybWF0aW9uSWZOZWVk ZWQpOgorCiAyMDE4LTA4LTAyICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW0xGQ11bQkZDXSBBcHBseSB0aGUgIjEwLjYuNiBDb21wbGljYXRlZCBjYXNlcyIgd2hl biBjb21wdXRpbmcgaGVpZ2h0IGFuZCBtYXJnaW4gZm9yIHRoZSBkb2N1bWVudCByZW5kZXJlcgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L1ZlcmlmaWNhdGlvbi5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvVmVyaWZpY2F0aW9uLmNwcAppbmRleCBlMjExYTdkZTc1OTc3ZTAw N2I5MWU0YTcwMzYxMTllZDNjNzllN2E5Li4zZDYyMzgwN2ViZjAyMDBiMWU5OTVkN2U4ZWFkNWQ2 ZDU0NmVkNTcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvVmVyaWZpY2F0aW9u LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvVmVyaWZpY2F0aW9uLmNwcApAQCAtMTM0 LDEwICsxMzQsMTMgQEAgc3RhdGljIGJvb2wgb3V0cHV0TWlzbWF0Y2hpbmdCbG9ja0JveEluZm9y bWF0aW9uSWZOZWVkZWQoVGV4dFN0cmVhbSYgc3RyZWFtLCBjb24KICAgICAgICAgcmV0dXJuIHRy dWU7CiAgICAgfQogCisjaWYgMAorICAgIC8vIFRoZSBSZW5kZXJCb3g6Om1hcmdpbkJveCgpIGRv ZXMgbm90IGZvbGxvdyB0aGUgc3BlYyBhbmQgaWdub3JlcyBjZXJ0YWluIGNvbnN0cmFpbnRzLiBM ZXQncyBza2lwIHRoZW0gZm9yIG5vdy4KICAgICBpZiAocmVuZGVyZXIubWFyZ2luQm94UmVjdCgp ICE9IGRpc3BsYXlCb3gtPm5vbkNvbGxhcHNlZE1hcmdpbkJveCgpKSB7CiAgICAgICAgIG91dHB1 dFJlY3QoIm1hcmdpbkJveCIsIHJlbmRlcmVyLm1hcmdpbkJveFJlY3QoKSwgZGlzcGxheUJveC0+ bm9uQ29sbGFwc2VkTWFyZ2luQm94KCkpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKICAgICB9Cisj ZW5kaWYKIAogICAgIGlmIChyZW5kZXJlci5ib3JkZXJCb3hSZWN0KCkgIT0gZGlzcGxheUJveC0+ Ym9yZGVyQm94KCkpIHsKICAgICAgICAgb3V0cHV0UmVjdCgiYm9yZGVyQm94IiwgcmVuZGVyZXIu Ym9yZGVyQm94UmVjdCgpLCBkaXNwbGF5Qm94LT5ib3JkZXJCb3goKSk7Cg== 346477 2018-08-03 06:42:43 -0700 2018-08-03 07:17:30 -0700 Patch bug-188297-20180803064242.patch text/plain 1915 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NTM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWE1MGVmYWUwNWE1NDEw MTlmYWI5NGU5NWFiMzkyZWI2N2Q4M2Y5MC4uZDE0NGJkNzIxMmQxMDE3NDdlNGIzNmQ4NWNjZmMz MDJjMmQzYWFhOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA4LTAyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ10gRG8gbm90IGNoZWNr IG1hcmdpbiBib3ggd2hpbGUgdmFsaWRhdGluZyBnZW9tZXRyeS4KKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODI5NworCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBjdXJyZW50IFJlbmRlckJveDo6bWFy Z2luQm94IGltcGxlbWVudGF0aW9uIGlzIG5vdCBzcGVjIGNvbXBsaWFudC4gSWdub3JlIGl0IGZv ciBub3cuCisKKyAgICAgICAgKiBsYXlvdXQvVmVyaWZpY2F0aW9uLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkxheW91dDo6b3V0cHV0TWlzbWF0Y2hpbmdCbG9ja0JveEluZm9ybWF0aW9uSWZOZWVk ZWQpOgorCiAyMDE4LTA4LTAyICBaYWxhbiBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW0xGQ11bQkZDXSBBcHBseSB0aGUgIjEwLjYuNiBDb21wbGljYXRlZCBjYXNlcyIgd2hl biBjb21wdXRpbmcgaGVpZ2h0IGFuZCBtYXJnaW4gZm9yIHRoZSBkb2N1bWVudCByZW5kZXJlcgpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L1ZlcmlmaWNhdGlvbi5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9sYXlvdXQvVmVyaWZpY2F0aW9uLmNwcAppbmRleCBlMjExYTdkZTc1OTc3ZTAw N2I5MWU0YTcwMzYxMTllZDNjNzllN2E5Li4yM2Q2MGFmN2ExY2E5MGIyMmQ5MWQ4YjIwYTdjM2Fk ZDI5MWVlMmUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvVmVyaWZpY2F0aW9u LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvVmVyaWZpY2F0aW9uLmNwcApAQCAtMTM0 LDExICsxMzQsNiBAQCBzdGF0aWMgYm9vbCBvdXRwdXRNaXNtYXRjaGluZ0Jsb2NrQm94SW5mb3Jt YXRpb25JZk5lZWRlZChUZXh0U3RyZWFtJiBzdHJlYW0sIGNvbgogICAgICAgICByZXR1cm4gdHJ1 ZTsKICAgICB9CiAKLSAgICBpZiAocmVuZGVyZXIubWFyZ2luQm94UmVjdCgpICE9IGRpc3BsYXlC b3gtPm5vbkNvbGxhcHNlZE1hcmdpbkJveCgpKSB7Ci0gICAgICAgIG91dHB1dFJlY3QoIm1hcmdp bkJveCIsIHJlbmRlcmVyLm1hcmdpbkJveFJlY3QoKSwgZGlzcGxheUJveC0+bm9uQ29sbGFwc2Vk TWFyZ2luQm94KCkpOwotICAgICAgICByZXR1cm4gdHJ1ZTsKLSAgICB9Ci0KICAgICBpZiAocmVu ZGVyZXIuYm9yZGVyQm94UmVjdCgpICE9IGRpc3BsYXlCb3gtPmJvcmRlckJveCgpKSB7CiAgICAg ICAgIG91dHB1dFJlY3QoImJvcmRlckJveCIsIHJlbmRlcmVyLmJvcmRlckJveFJlY3QoKSwgZGlz cGxheUJveC0+Ym9yZGVyQm94KCkpOwogICAgICAgICByZXR1cm4gdHJ1ZTsKQEAgLTE1NCw2ICsx NDksNyBAQCBzdGF0aWMgYm9vbCBvdXRwdXRNaXNtYXRjaGluZ0Jsb2NrQm94SW5mb3JtYXRpb25J Zk5lZWRlZChUZXh0U3RyZWFtJiBzdHJlYW0sIGNvbgogICAgICAgICByZXR1cm4gdHJ1ZTsKICAg ICB9CiAKKyAgICAvLyBUT0RPOiBUaGUgUmVuZGVyQm94OjptYXJnaW5Cb3goKSBkb2VzIG5vdCBm b2xsb3cgdGhlIHNwZWMgYW5kIGlnbm9yZXMgY2VydGFpbiBjb25zdHJhaW50cy4gU2tpcCB0aGVt IGZvciBub3cuCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCg==