188292 2018-08-02 17:20:00 -0700 PDFPlugin: Context menus in RTL are left-aligned 2018-08-02 18:11:55 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton aestes commit-queue simon.fraser wenson_hsieh oldest_to_newest 1447457 0 thorton 2018-08-02 17:20:00 -0700 PDFPlugin: Context menus in RTL are left-aligned 1447458 1 346434 thorton 2018-08-02 17:20:11 -0700 Created attachment 346434 Patch 1447459 2 thorton 2018-08-02 17:20:36 -0700 <rdar://problem/33781669> 1447465 3 346434 simon.fraser 2018-08-02 17:27:14 -0700 Comment on attachment 346434 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346434&action=review > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1610 > + auto itemCount = [nsMenu numberOfItems]; > + for (int i = 0; i < itemCount; i++) { auto considered harmful: are you going to get signed/unsigned comparison warnings here or not? > Source/WebKit/WebProcess/Plugins/PDF/PDFPlugin.mm:1619 > + std::optional<int> selectedIndex = -1; optional<> but init with -1? Why not optional<optional<>> (j/k) 1447474 4 346434 commit-queue 2018-08-02 18:11:53 -0700 Comment on attachment 346434 Patch Clearing flags on attachment: 346434 Committed r234530: <https://trac.webkit.org/changeset/234530> 1447475 5 commit-queue 2018-08-02 18:11:55 -0700 All reviewed patches have been landed. Closing bug. 346434 2018-08-02 17:20:11 -0700 2018-08-02 18:11:53 -0700 Patch bug-188292-20180802172011.patch text/plain 6052 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDZmODk1ZjM5YmIzNGYxNTUz OTc0ZGNiOWQzMDIwNDNjMjVmOGQ5MTkuLjQ4YzE1MjY3ZTg2MzExZTg2ZDc1M2JhZGEwMDBmNGI0 YmY1MzkwNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMTgtMDgtMDIgIFRpbSBIb3J0 b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisKKyAgICAgICAgUERGUGx1Z2luOiBDb250 ZXh0IG1lbnVzIGluIFJUTCBhcmUgbGVmdC1hbGlnbmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODgyOTIKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt LzMyMjkzNzg3PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZMYXllckNvbnRyb2xsZXJTUEkuaDoKKyAg ICAgICAgQWRkIHNvbWUgU1BJLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9Q REZQbHVnaW4ubW06CisgICAgICAgIChXZWJLaXQ6OlBERlBsdWdpbjo6aGFuZGxlQ29udGV4dE1l bnVFdmVudCk6CisgICAgICAgIFRyYW5zbGF0ZSBVSSBsYXlvdXQgZGlyZWN0aW9uIGJhY2sgaW50 byB0aGUgcGxhdGZvcm0gZW51bSwgYW5kIHBhc3MgaXQgdG8gUERGS2l0LgorCisgICAgICAgICog V2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZTo6 dXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbiBjb25zdCk6CisgICAgICAgIEFkZCBhIGdldHRl ciBmb3IgVUkgbGF5b3V0IGRpcmVjdGlvbi4KKwogMjAxOC0wOC0wMiAgV2Vuc29uIEhzaWVoICA8 d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBLZXlib2FyZCBiZWNvbWVz IHVucmVzcG9uc2l2ZSBhZnRlciBwcmVzc2luZyBkZWxldGUgd2hpbGUgcHJlc3NpbmcgZG93biBv biBhIGNoYXJhY3RlciBrZXkgd2l0aCBhY2NlbnRzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGTGF5ZXJDb250cm9sbGVyU1BJLmggYi9Tb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvUGx1Z2lucy9QREYvUERGTGF5ZXJDb250cm9sbGVyU1BJLmgKaW5k ZXggOGZhZmNmNjBiOTY4MWFiOTc2ZGZmZDc2YzgxNDVkMGE5MjUxZWM0Zi4uNWJmYzI2MWU5NGI5 MDY4NmFjYWRhZDk1NjhmMjNjZDk4MTU5MGY4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERkxheWVyQ29udHJvbGxlclNQSS5oCisrKyBiL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZMYXllckNvbnRyb2xsZXJTUEkuaApA QCAtMTAxLDYgKzEwMSw5IEBAIHR5cGVkZWYgTlNfRU5VTShOU0ludGVnZXIsIFBERkxheWVyQ29u dHJvbGxlckN1cnNvclR5cGUpIHsKIC0gKHZvaWQpbW91c2VFbnRlcmVkOihOU0V2ZW50ICopZXZl bnQ7CiAtICh2b2lkKW1vdXNlRXhpdGVkOihOU0V2ZW50ICopZXZlbnQ7CiAKKyNpZiBfX01BQ19P U19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEwMTMwMAorLSAoTlNNZW51ICopbWVudUZvckV2 ZW50OihOU0V2ZW50ICopZXZlbnQgd2l0aFVzZXJJbnRlcmZhY2VMYXlvdXREaXJlY3Rpb246KE5T VXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbilkaXJlY3Rpb247CisjZW5kaWYKIC0gKE5TTWVu dSAqKW1lbnVGb3JFdmVudDooTlNFdmVudCAqKWV2ZW50OwogCiAtIChOU0FycmF5ICopZmluZFN0 cmluZzooTlNTdHJpbmcgKilzdHJpbmcgY2FzZVNlbnNpdGl2ZTooQk9PTClpc0Nhc2VTZW5zaXRp dmUgaGlnaGxpZ2h0TWF0Y2hlczooQk9PTClzaG91bGRIaWdobGlnaHRNYXRjaGVzOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbSBi L1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9QbHVnaW5zL1BERi9QREZQbHVnaW4ubW0KaW5kZXgg OWYwZDk0ODRjZGRhMDgzNmI2ZWMzMDliZmI1OGVhMmI3M2Y5NTRjOC4uM2M4OTViY2IxYzNmOTg5 NTZmY2UxYjE2YjVhMDRhNWEyZmE2OGE3MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQ cm9jZXNzL1BsdWdpbnMvUERGL1BERlBsdWdpbi5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvUGx1Z2lucy9QREYvUERGUGx1Z2luLm1tCkBAIC0xNTg4LDM0ICsxNTg4LDQxIEBAIGJv b2wgUERGUGx1Z2luOjpzaG93Q29udGV4dE1lbnVBdFBvaW50KGNvbnN0IEludFBvaW50JiBwb2lu dCkKIAogYm9vbCBQREZQbHVnaW46OmhhbmRsZUNvbnRleHRNZW51RXZlbnQoY29uc3QgV2ViTW91 c2VFdmVudCYgZXZlbnQpCiB7CisgICAgaWYgKCF3ZWJGcmFtZSgpLT5wYWdlKCkpCisgICAgICAg IHJldHVybiBmYWxzZTsKKworICAgIFdlYlBhZ2UqIHdlYlBhZ2UgPSB3ZWJGcmFtZSgpLT5wYWdl KCk7CiAgICAgRnJhbWVWaWV3KiBmcmFtZVZpZXcgPSB3ZWJGcmFtZSgpLT5jb3JlRnJhbWUoKS0+ dmlldygpOwogICAgIEludFBvaW50IHBvaW50ID0gZnJhbWVWaWV3LT5jb250ZW50c1RvU2NyZWVu KEludFJlY3QoZnJhbWVWaWV3LT53aW5kb3dUb0NvbnRlbnRzKGV2ZW50LnBvc2l0aW9uKCkpLCBJ bnRTaXplKCkpKS5sb2NhdGlvbigpOwogCi0gICAgaWYgKE5TTWVudSAqbnNNZW51ID0gW21fcGRm TGF5ZXJDb250cm9sbGVyIG1lbnVGb3JFdmVudDpuc0V2ZW50Rm9yV2ViTW91c2VFdmVudChldmVu dCldKSB7Ci0gICAgICAgIFZlY3RvcjxQREZDb250ZXh0TWVudUl0ZW0+IGl0ZW1zOwotICAgICAg ICBhdXRvIGl0ZW1Db3VudCA9IFtuc01lbnUgbnVtYmVyT2ZJdGVtc107Ci0gICAgICAgIGZvciAo aW50IGkgPSAwOyBpIDwgaXRlbUNvdW50OyBpKyspIHsKLSAgICAgICAgICAgIGF1dG8gaXRlbSA9 IFtuc01lbnUgaXRlbUF0SW5kZXg6aV07Ci0gICAgICAgICAgICBpZiAoW2l0ZW0gc3VibWVudV0p Ci0gICAgICAgICAgICAgICAgY29udGludWU7Ci0gICAgICAgICAgICBQREZDb250ZXh0TWVudUl0 ZW0gbWVudUl0ZW0geyBTdHJpbmcoW2l0ZW0gdGl0bGVdKSwgISFbaXRlbSBpc0VuYWJsZWRdLCAh IVtpdGVtIGlzU2VwYXJhdG9ySXRlbV0sIHN0YXRpY19jYXN0PGludD4oW2l0ZW0gc3RhdGVdKSwg W2l0ZW0gYWN0aW9uXSwgaSB9OwotICAgICAgICAgICAgaXRlbXMuYXBwZW5kKFdURk1vdmUobWVu dUl0ZW0pKTsKLSAgICAgICAgfQotICAgICAgICBQREZDb250ZXh0TWVudSBjb250ZXh0TWVudSB7 IHBvaW50LCBXVEZNb3ZlKGl0ZW1zKSB9OworI2lmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVR VUlSRUQgPj0gMTAxMzAwCisgICAgTlNVc2VySW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9uIHVpTGF5 b3V0RGlyZWN0aW9uID0gd2ViUGFnZS0+dXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbigpID09 IFVzZXJJbnRlcmZhY2VMYXlvdXREaXJlY3Rpb246OkxUUiA/IE5TVXNlckludGVyZmFjZUxheW91 dERpcmVjdGlvbkxlZnRUb1JpZ2h0IDogTlNVc2VySW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9uUmln aHRUb0xlZnQ7CisgICAgTlNNZW51ICpuc01lbnUgPSBbbV9wZGZMYXllckNvbnRyb2xsZXIgbWVu dUZvckV2ZW50Om5zRXZlbnRGb3JXZWJNb3VzZUV2ZW50KGV2ZW50KSB3aXRoVXNlckludGVyZmFj ZUxheW91dERpcmVjdGlvbjp1aUxheW91dERpcmVjdGlvbl07CisjZWxzZQorICAgIE5TTWVudSAq bnNNZW51ID0gW21fcGRmTGF5ZXJDb250cm9sbGVyIG1lbnVGb3JFdmVudDpuc0V2ZW50Rm9yV2Vi TW91c2VFdmVudChldmVudCldOworI2VuZGlmCiAKLSAgICAgICAgaWYgKCF3ZWJGcmFtZSgpLT5w YWdlKCkpCi0gICAgICAgICAgICByZXR1cm4gZmFsc2U7CisgICAgaWYgKCFuc01lbnUpCisgICAg ICAgIHJldHVybiBmYWxzZTsKKyAgICAKKyAgICBWZWN0b3I8UERGQ29udGV4dE1lbnVJdGVtPiBp dGVtczsKKyAgICBhdXRvIGl0ZW1Db3VudCA9IFtuc01lbnUgbnVtYmVyT2ZJdGVtc107CisgICAg Zm9yIChpbnQgaSA9IDA7IGkgPCBpdGVtQ291bnQ7IGkrKykgeworICAgICAgICBhdXRvIGl0ZW0g PSBbbnNNZW51IGl0ZW1BdEluZGV4OmldOworICAgICAgICBpZiAoW2l0ZW0gc3VibWVudV0pCisg ICAgICAgICAgICBjb250aW51ZTsKKyAgICAgICAgUERGQ29udGV4dE1lbnVJdGVtIG1lbnVJdGVt IHsgU3RyaW5nKFtpdGVtIHRpdGxlXSksICEhW2l0ZW0gaXNFbmFibGVkXSwgISFbaXRlbSBpc1Nl cGFyYXRvckl0ZW1dLCBzdGF0aWNfY2FzdDxpbnQ+KFtpdGVtIHN0YXRlXSksIFtpdGVtIGFjdGlv bl0sIGkgfTsKKyAgICAgICAgaXRlbXMuYXBwZW5kKFdURk1vdmUobWVudUl0ZW0pKTsKKyAgICB9 CisgICAgUERGQ29udGV4dE1lbnUgY29udGV4dE1lbnUgeyBwb2ludCwgV1RGTW92ZShpdGVtcykg fTsKIAotICAgICAgICBzdGQ6Om9wdGlvbmFsPGludD4gc2VsZWN0ZWRJbmRleCA9IC0xOwotICAg ICAgICB3ZWJGcmFtZSgpLT5wYWdlKCktPnNlbmRTeW5jKE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6 OlNob3dQREZDb250ZXh0TWVudShjb250ZXh0TWVudSksIE1lc3NhZ2VzOjpXZWJQYWdlUHJveHk6 OlNob3dQREZDb250ZXh0TWVudTo6UmVwbHkoc2VsZWN0ZWRJbmRleCkpOworICAgIHN0ZDo6b3B0 aW9uYWw8aW50PiBzZWxlY3RlZEluZGV4ID0gLTE7CisgICAgd2ViUGFnZS0+c2VuZFN5bmMoTWVz c2FnZXM6OldlYlBhZ2VQcm94eTo6U2hvd1BERkNvbnRleHRNZW51KGNvbnRleHRNZW51KSwgTWVz c2FnZXM6OldlYlBhZ2VQcm94eTo6U2hvd1BERkNvbnRleHRNZW51OjpSZXBseShzZWxlY3RlZElu ZGV4KSk7CiAKLSAgICAgICAgaWYgKHNlbGVjdGVkSW5kZXggJiYgKnNlbGVjdGVkSW5kZXggPj0g MCAmJiAqc2VsZWN0ZWRJbmRleCA8IGl0ZW1Db3VudCkKLSAgICAgICAgICAgIFtuc01lbnUgcGVy Zm9ybUFjdGlvbkZvckl0ZW1BdEluZGV4OipzZWxlY3RlZEluZGV4XTsKKyAgICBpZiAoc2VsZWN0 ZWRJbmRleCAmJiAqc2VsZWN0ZWRJbmRleCA+PSAwICYmICpzZWxlY3RlZEluZGV4IDwgaXRlbUNv dW50KQorICAgICAgICBbbnNNZW51IHBlcmZvcm1BY3Rpb25Gb3JJdGVtQXRJbmRleDoqc2VsZWN0 ZWRJbmRleF07CiAKLSAgICAgICAgcmV0dXJuIHRydWU7Ci0gICAgfQotICAgIAotICAgIHJldHVy biBmYWxzZTsKKyAgICByZXR1cm4gdHJ1ZTsKIH0KIAogYm9vbCBQREZQbHVnaW46OmhhbmRsZUtl eWJvYXJkRXZlbnQoY29uc3QgV2ViS2V5Ym9hcmRFdmVudCYgZXZlbnQpCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmggYi9Tb3VyY2UvV2ViS2l0 L1dlYlByb2Nlc3MvV2ViUGFnZS9XZWJQYWdlLmgKaW5kZXggODI3YWQ2YzM3ZGFlZmJmNTIyYjg5 MzI3ZDkyOWI0NDU3N2U2NTEwYy4uY2JiYzQ4Y2RkMjZiMjU2NzI4ZTcwNDA2OTk4NDIxYjhmNDFk YWZiOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvV2ViUGFn ZS5oCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL1dlYlBhZ2UuaApAQCAt MTA4Niw2ICsxMDg2LDggQEAgcHVibGljOgogCiAgICAgVXNlckNvbnRlbnRDb250cm9sbGVySWRl bnRpZmllciB1c2VyQ29udGVudENvbnRyb2xsZXJJZGVudGlmaWVyKCkgY29uc3QgeyByZXR1cm4g bV91c2VyQ29udGVudENvbnRyb2xsZXItPmlkZW50aWZpZXIoKTsgfQogCisgICAgV2ViQ29yZTo6 VXNlckludGVyZmFjZUxheW91dERpcmVjdGlvbiB1c2VySW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9u KCkgY29uc3QgeyByZXR1cm4gbV91c2VySW50ZXJmYWNlTGF5b3V0RGlyZWN0aW9uOyB9CisKICAg ICBib29sIGlzU3VzcGVuZGVkKCkgY29uc3QgeyByZXR1cm4gbV9pc1N1c3BlbmRlZDsgfQogCiAg ICAgdm9pZCBkaWRSZWNlaXZlV2ViUGFnZU1lc3NhZ2UoSVBDOjpDb25uZWN0aW9uJiwgSVBDOjpE ZWNvZGVyJik7Cg==