188286 2018-08-02 16:39:16 -0700 [LFC][Floating] Remove redundant LayoutContext member variable. 2018-08-02 16:47:18 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham simon.fraser webkit-bug-importer zalan oldest_to_newest 1447436 0 zalan 2018-08-02 16:39:16 -0700 ssia. 1447438 1 346431 zalan 2018-08-02 16:40:24 -0700 Created attachment 346431 Patch 1447442 2 zalan 2018-08-02 16:46:17 -0700 Committed r234524: <https://trac.webkit.org/changeset/234524> 1447443 3 webkit-bug-importer 2018-08-02 16:47:18 -0700 <rdar://problem/42879263> 346431 2018-08-02 16:40:24 -0700 2018-08-02 16:43:51 -0700 Patch bug-188286-20180802164023.patch text/plain 4652 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NTIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGVkZTFmNTMwMzFhMjMy YWRiMTdiNzA0MzVhZDRkOTU2NzM3NzM4ZS4uMDlmOTY5ZmMwMDBlZTdkODUyOGRmYmExMGEwNjcz ZjMxZGIyOTUzZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA4LTAyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bRmxvYXRpbmddIFJl bW92ZSByZWR1bmRhbnQgTGF5b3V0Q29udGV4dCBtZW1iZXIgdmFyaWFibGUuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODgyODYKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGxheW91dC9GbG9hdGluZ0Nv bnRleHQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpiZWdpbik6CisgICAgICAgIChX ZWJDb3JlOjpMYXlvdXQ6OmVuZCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkZsb2F0aW5n Q29udGV4dDo6ZmxvYXRpbmdQb3NpdGlvbiBjb25zdCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlv dXQ6OkZsb2F0aW5nUGFpcjo6RmxvYXRpbmdQYWlyKToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91 dDo6SXRlcmF0b3I6Okl0ZXJhdG9yKToKKwogMjAxOC0wOC0wMiAgUnlvc3VrZSBOaXdhICA8cm5p d2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBNb3ZlIHF1ZXVlIHByb2Nlc3NpbmcgbG9naWMgZnJv bSBDdXN0b21FbGVtZW50UmVhY3Rpb25TdGFjayB0byBDdXN0b21FbGVtZW50UmVhY3Rpb25RdWV1 ZQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L0Zsb2F0aW5nQ29udGV4dC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvRmxvYXRpbmdDb250ZXh0LmNwcAppbmRleCA2MDRiYjI3 M2NlZWVjOWFjOWVkMjQ1ZTRkNWM4YTMxNjg4MjIwOTk5Li42Zjc4ZGZjZjFmODhkMGIwNmI5ZWJi NDhlYTliMzNmZjI2ODg0MjE1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvRmxv YXRpbmdDb250ZXh0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvRmxvYXRpbmdDb250 ZXh0LmNwcApAQCAtNzIsOSArNzIsOCBAQCBwdWJsaWM6CiAKIHByaXZhdGU6CiAgICAgZnJpZW5k IGNsYXNzIEl0ZXJhdG9yOwotICAgIEZsb2F0aW5nUGFpcihjb25zdCBMYXlvdXRDb250ZXh0Jiwg Y29uc3QgRmxvYXRpbmdTdGF0ZTo6RmxvYXRMaXN0Jik7CisgICAgRmxvYXRpbmdQYWlyKGNvbnN0 IEZsb2F0aW5nU3RhdGU6OkZsb2F0TGlzdCYpOwogCi0gICAgY29uc3QgTGF5b3V0Q29udGV4dCYg bV9sYXlvdXRDb250ZXh0OwogICAgIGNvbnN0IEZsb2F0aW5nU3RhdGU6OkZsb2F0TGlzdCYgbV9m bG9hdHM7CiAKICAgICBzdGQ6Om9wdGlvbmFsPHVuc2lnbmVkPiBtX2xlZnRJbmRleDsKQEAgLTg0 LDcgKzgzLDcgQEAgcHJpdmF0ZToKIAogY2xhc3MgSXRlcmF0b3IgewogcHVibGljOgotICAgIEl0 ZXJhdG9yKGNvbnN0IExheW91dENvbnRleHQmLCBjb25zdCBGbG9hdGluZ1N0YXRlOjpGbG9hdExp c3QmLCBzdGQ6Om9wdGlvbmFsPExheW91dFVuaXQ+IHZlcnRpY2FsUG9zaXRpb24pOworICAgIEl0 ZXJhdG9yKGNvbnN0IEZsb2F0aW5nU3RhdGU6OkZsb2F0TGlzdCYsIHN0ZDo6b3B0aW9uYWw8TGF5 b3V0VW5pdD4gdmVydGljYWxQb3NpdGlvbik7CiAKICAgICBjb25zdCBGbG9hdGluZ1BhaXImIG9w ZXJhdG9yKigpIGNvbnN0IHsgcmV0dXJuIG1fY3VycmVudDsgfQogICAgIEl0ZXJhdG9yJiBvcGVy YXRvcisrKCk7CkBAIC05NCwyMCArOTMsMTkgQEAgcHVibGljOgogcHJpdmF0ZToKICAgICB2b2lk IHNldChMYXlvdXRVbml0IHZlcnRpY2FsUG9zaXRpb24pOwogCi0gICAgY29uc3QgTGF5b3V0Q29u dGV4dCYgbV9sYXlvdXRDb250ZXh0OwogICAgIGNvbnN0IEZsb2F0aW5nU3RhdGU6OkZsb2F0TGlz dCYgbV9mbG9hdHM7CiAgICAgRmxvYXRpbmdQYWlyIG1fY3VycmVudDsKIH07CiAKLXN0YXRpYyBJ dGVyYXRvciBiZWdpbihjb25zdCBMYXlvdXRDb250ZXh0JiBsYXlvdXRDb250ZXh0LCBjb25zdCBG bG9hdGluZ1N0YXRlJiBmbG9hdGluZ1N0YXRlLCBMYXlvdXRVbml0IGluaXRpYWxWZXJ0aWNhbFBv c2l0aW9uKQorc3RhdGljIEl0ZXJhdG9yIGJlZ2luKGNvbnN0IEZsb2F0aW5nU3RhdGUmIGZsb2F0 aW5nU3RhdGUsIExheW91dFVuaXQgaW5pdGlhbFZlcnRpY2FsUG9zaXRpb24pCiB7CiAgICAgLy8g U3RhcnQgd2l0aCB0aGUgaW5uZXItbW9zdCBmbG9hdGluZyBwYWlyIGZvciB0aGUgaW5pdGlhbCB2 ZXJ0aWNhbCBwb3NpdGlvbi4KLSAgICByZXR1cm4gSXRlcmF0b3IobGF5b3V0Q29udGV4dCwgZmxv YXRpbmdTdGF0ZS5mbG9hdHMoKSwgaW5pdGlhbFZlcnRpY2FsUG9zaXRpb24pOworICAgIHJldHVy biBJdGVyYXRvcihmbG9hdGluZ1N0YXRlLmZsb2F0cygpLCBpbml0aWFsVmVydGljYWxQb3NpdGlv bik7CiB9CiAKLXN0YXRpYyBJdGVyYXRvciBlbmQoY29uc3QgTGF5b3V0Q29udGV4dCYgbGF5b3V0 Q29udGV4dCwgY29uc3QgRmxvYXRpbmdTdGF0ZSYgZmxvYXRpbmdTdGF0ZSkKK3N0YXRpYyBJdGVy YXRvciBlbmQoY29uc3QgRmxvYXRpbmdTdGF0ZSYgZmxvYXRpbmdTdGF0ZSkKIHsKLSAgICByZXR1 cm4gSXRlcmF0b3IobGF5b3V0Q29udGV4dCwgZmxvYXRpbmdTdGF0ZS5mbG9hdHMoKSwgc3RkOjpu dWxsb3B0KTsKKyAgICByZXR1cm4gSXRlcmF0b3IoZmxvYXRpbmdTdGF0ZS5mbG9hdHMoKSwgc3Rk OjpudWxsb3B0KTsKIH0KIAogRmxvYXRpbmdDb250ZXh0OjpGbG9hdGluZ0NvbnRleHQoRmxvYXRp bmdTdGF0ZSYgZmxvYXRpbmdTdGF0ZSkKQEAgLTEzOSwxMCArMTM3LDEwIEBAIFBvc2l0aW9uIEZs b2F0aW5nQ29udGV4dDo6ZmxvYXRpbmdQb3NpdGlvbihjb25zdCBGbG9hdGluZ1N0YXRlOjpGbG9h dEl0ZW0mIGZsb2F0CiAgICAgYXV0byYgZGlzcGxheUJveCA9IGZsb2F0SXRlbS5kaXNwbGF5Qm94 KCk7CiAgICAgYXV0byBtYXJnaW5Cb3hTaXplID0gZGlzcGxheUJveC5tYXJnaW5Cb3goKS5zaXpl KCk7CiAKLSAgICBhdXRvIGVuZCA9IExheW91dDo6ZW5kKGxheW91dENvbnRleHQoKSwgbV9mbG9h dGluZ1N0YXRlKTsKKyAgICBhdXRvIGVuZCA9IExheW91dDo6ZW5kKG1fZmxvYXRpbmdTdGF0ZSk7 CiAgICAgYXV0byB0b3AgPSBpbml0aWFsVmVydGljYWxQb3NpdGlvbjsKICAgICBhdXRvIGJvdHRv bU1vc3QgPSB0b3A7Ci0gICAgZm9yIChhdXRvIGl0ZXJhdG9yID0gYmVnaW4obGF5b3V0Q29udGV4 dCgpLCBtX2Zsb2F0aW5nU3RhdGUsIGluaXRpYWxWZXJ0aWNhbFBvc2l0aW9uKTsgaXRlcmF0b3Ig IT0gZW5kOyArK2l0ZXJhdG9yKSB7CisgICAgZm9yIChhdXRvIGl0ZXJhdG9yID0gYmVnaW4obV9m bG9hdGluZ1N0YXRlLCBpbml0aWFsVmVydGljYWxQb3NpdGlvbik7IGl0ZXJhdG9yICE9IGVuZDsg KytpdGVyYXRvcikgewogICAgICAgICBBU1NFUlQoISgqaXRlcmF0b3IpLmlzRW1wdHkoKSk7CiAK ICAgICAgICAgYXV0byBmbG9hdHMgPSAqaXRlcmF0b3I7CkBAIC0yMzMsOSArMjMxLDggQEAgUG9z aXRpb24gRmxvYXRpbmdDb250ZXh0Ojp0b0NvbnRhaW5pbmdCbG9jayhjb25zdCBGbG9hdGluZ1N0 YXRlOjpGbG9hdEl0ZW0mIGZsb2EKICAgICByZXR1cm4geyBwb3NpdGlvbi54IC0gY29udGFpbmdC bG9ja0Rpc3BsYXlCb3gubGVmdCgpLCBwb3NpdGlvbi55IC0gY29udGFpbmdCbG9ja0Rpc3BsYXlC b3gudG9wKCkgfTsKIH0KIAotRmxvYXRpbmdQYWlyOjpGbG9hdGluZ1BhaXIoY29uc3QgTGF5b3V0 Q29udGV4dCYgbGF5b3V0Q29udGV4dCwgY29uc3QgRmxvYXRpbmdTdGF0ZTo6RmxvYXRMaXN0JiBm bG9hdHMpCi0gICAgOiBtX2xheW91dENvbnRleHQobGF5b3V0Q29udGV4dCkKLSAgICAsIG1fZmxv YXRzKGZsb2F0cykKK0Zsb2F0aW5nUGFpcjo6RmxvYXRpbmdQYWlyKGNvbnN0IEZsb2F0aW5nU3Rh dGU6OkZsb2F0TGlzdCYgZmxvYXRzKQorICAgIDogbV9mbG9hdHMoZmxvYXRzKQogewogfQogCkBA IC0zMDksMTAgKzMwNiw5IEBAIExheW91dFVuaXQgRmxvYXRpbmdQYWlyOjpib3R0b20oKSBjb25z dAogICAgIHJldHVybiAqcmlnaHRCb3R0b207CiB9CiAKLUl0ZXJhdG9yOjpJdGVyYXRvcihjb25z dCBMYXlvdXRDb250ZXh0JiBsYXlvdXRDb250ZXh0LCBjb25zdCBGbG9hdGluZ1N0YXRlOjpGbG9h dExpc3QmIGZsb2F0cywgc3RkOjpvcHRpb25hbDxMYXlvdXRVbml0PiB2ZXJ0aWNhbFBvc2l0aW9u KQotICAgIDogbV9sYXlvdXRDb250ZXh0KGxheW91dENvbnRleHQpCi0gICAgLCBtX2Zsb2F0cyhm bG9hdHMpCi0gICAgLCBtX2N1cnJlbnQobGF5b3V0Q29udGV4dCwgZmxvYXRzKQorSXRlcmF0b3I6 Okl0ZXJhdG9yKGNvbnN0IEZsb2F0aW5nU3RhdGU6OkZsb2F0TGlzdCYgZmxvYXRzLCBzdGQ6Om9w dGlvbmFsPExheW91dFVuaXQ+IHZlcnRpY2FsUG9zaXRpb24pCisgICAgOiBtX2Zsb2F0cyhmbG9h dHMpCisgICAgLCBtX2N1cnJlbnQoZmxvYXRzKQogewogICAgIGlmICh2ZXJ0aWNhbFBvc2l0aW9u KQogICAgICAgICBzZXQoKnZlcnRpY2FsUG9zaXRpb24pOwo=