188274 2018-08-02 13:03:23 -0700 [LFC][Floating] Use displayBox.rectWithMargin().bottom instead of displayBox.bottom() to where applicable. 2018-08-02 13:08:29 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1447352 0 zalan 2018-08-02 13:03:23 -0700 use margin box for computations. 1447354 1 346409 zalan 2018-08-02 13:04:55 -0700 Created attachment 346409 Patch 1447356 2 zalan 2018-08-02 13:07:47 -0700 Committed r234511: <https://trac.webkit.org/changeset/234511> 1447357 3 webkit-bug-importer 2018-08-02 13:08:29 -0700 <rdar://problem/42869723> 346409 2018-08-02 13:04:55 -0700 2018-08-02 13:06:26 -0700 Patch bug-188274-20180802130455.patch text/plain 2889 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NTEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmViNTk1MzA3OTAyNjIx YTQ4Y2QzNWM1NTY2MGYxMjVlMmZkZjRhYS4uMjUxY2MyYTU3ZjU1ZDkyMDhjMGNjNDhjOTU2MDMy YWY4Yjc0M2RlYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA4LTAyICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bRmxvYXRpbmddIFVz ZSBkaXNwbGF5Qm94LnJlY3RXaXRoTWFyZ2luKCkuYm90dG9tIGluc3RlYWQgb2YgZGlzcGxheUJv eC5ib3R0b20oKSB0byB3aGVyZSBhcHBsaWNhYmxlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4Mjc0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgRmxvYXQgcGxhY2VtZW50IHVzZXMgdGhlIG1hcmdpbiBi b3guCisKKyAgICAgICAgKiBsYXlvdXQvRmxvYXRpbmdDb250ZXh0LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkxheW91dDo6RmxvYXRpbmdQYWlyOjpib3R0b20gY29uc3QpOgorICAgICAgICAoV2Vi Q29yZTo6TGF5b3V0OjpJdGVyYXRvcjo6b3BlcmF0b3IrKyk6CisgICAgICAgIChXZWJDb3JlOjpM YXlvdXQ6Okl0ZXJhdG9yOjpzZXQpOgorCiAyMDE4LTA4LTAyICBaYWxhbiBCdWp0YXMgIDx6YWxh bkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bRmxvYXRpbmddIFJpZ2h0IGFsaWduZWQgZmxv YXQncyBob3Jpem9udGFsIGNhbmRpZGF0ZSBwb3NpdGlvbiBpcyBtaXNjb21wdXRlZC4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9GbG9hdGluZ0NvbnRleHQuY3BwIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L0Zsb2F0aW5nQ29udGV4dC5jcHAKaW5kZXggOWVmMDQ3YjlkNjYxYmQ4 OTJjMDUyZjRmYzllYjI5MjllNGVkZGI0Yy4uNjA0YmIyNzNjZWVlYzlhYzllZDI0NWU0ZDVjOGEz MTY4ODIyMDk5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L0Zsb2F0aW5nQ29u dGV4dC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbGF5b3V0L0Zsb2F0aW5nQ29udGV4dC5jcHAK QEAgLTI5Nyw4ICsyOTcsOCBAQCBMYXlvdXRVbml0IEZsb2F0aW5nUGFpcjo6Ym90dG9tKCkgY29u c3QKICAgICBhdXRvKiByaWdodCA9IHRoaXMtPnJpZ2h0KCk7CiAgICAgQVNTRVJUKGxlZnQgfHwg cmlnaHQpOwogCi0gICAgYXV0byBsZWZ0Qm90dG9tID0gbGVmdCA/IHN0ZDo6b3B0aW9uYWw8TGF5 b3V0VW5pdD4obGVmdC0+Ym90dG9tKCkpIDogc3RkOjpudWxsb3B0OwotICAgIGF1dG8gcmlnaHRC b3R0b20gPSByaWdodCA/IHN0ZDo6b3B0aW9uYWw8TGF5b3V0VW5pdD4ocmlnaHQtPmJvdHRvbSgp KSA6IHN0ZDo6bnVsbG9wdDsKKyAgICBhdXRvIGxlZnRCb3R0b20gPSBsZWZ0ID8gc3RkOjpvcHRp b25hbDxMYXlvdXRVbml0PihsZWZ0LT5yZWN0V2l0aE1hcmdpbigpLmJvdHRvbSgpKSA6IHN0ZDo6 bnVsbG9wdDsKKyAgICBhdXRvIHJpZ2h0Qm90dG9tID0gcmlnaHQgPyBzdGQ6Om9wdGlvbmFsPExh eW91dFVuaXQ+KHJpZ2h0LT5yZWN0V2l0aE1hcmdpbigpLmJvdHRvbSgpKSA6IHN0ZDo6bnVsbG9w dDsKIAogICAgIGlmIChsZWZ0Qm90dG9tICYmIHJpZ2h0Qm90dG9tKQogICAgICAgICByZXR1cm4g c3RkOjptYXgoKmxlZnRCb3R0b20sICpyaWdodEJvdHRvbSk7CkBAIC0zNDYsNyArMzQ2LDcgQEAg SXRlcmF0b3ImIEl0ZXJhdG9yOjpvcGVyYXRvcisrKCkKICAgICAgICAgaWYgKCFjdXJyZW50SW5k ZXgpCiAgICAgICAgICAgICByZXR1cm4geyB9OwogCi0gICAgICAgIGF1dG8gY3VycmVudEJvdHRv bSA9IG1fZmxvYXRzW2N1cnJlbnRJbmRleF0uZGlzcGxheUJveCgpLmJvdHRvbSgpOworICAgICAg ICBhdXRvIGN1cnJlbnRCb3R0b20gPSBtX2Zsb2F0c1tjdXJyZW50SW5kZXhdLmRpc3BsYXlCb3go KS5yZWN0V2l0aE1hcmdpbigpLmJvdHRvbSgpOwogCiAgICAgICAgIHN0ZDo6b3B0aW9uYWw8dW5z aWduZWQ+IGluZGV4ID0gY3VycmVudEluZGV4OwogICAgICAgICB3aGlsZSAodHJ1ZSkgewpAQCAt MzU0LDcgKzM1NCw3IEBAIEl0ZXJhdG9yJiBJdGVyYXRvcjo6b3BlcmF0b3IrKygpCiAgICAgICAg ICAgICBpZiAoIWluZGV4KQogICAgICAgICAgICAgICAgIHJldHVybiB7IH07CiAKLSAgICAgICAg ICAgIGlmIChtX2Zsb2F0c1sqaW5kZXhdLmRpc3BsYXlCb3goKS5ib3R0b20oKSA+IGN1cnJlbnRC b3R0b20pCisgICAgICAgICAgICBpZiAobV9mbG9hdHNbKmluZGV4XS5kaXNwbGF5Qm94KCkucmVj dFdpdGhNYXJnaW4oKS5ib3R0b20oKSA+IGN1cnJlbnRCb3R0b20pCiAgICAgICAgICAgICAgICAg cmV0dXJuIGluZGV4OwogICAgICAgICB9CiAKQEAgLTQxOCw3ICs0MTgsNyBAQCB2b2lkIEl0ZXJh dG9yOjpzZXQoTGF5b3V0VW5pdCB2ZXJ0aWNhbFBvc2l0aW9uKQogICAgICAgICAgICAgaWYgKCFp bmRleCkKICAgICAgICAgICAgICAgICByZXR1cm4geyB9OwogCi0gICAgICAgICAgICBhdXRvIGJv dHRvbSA9IG1fZmxvYXRzWyppbmRleF0uZGlzcGxheUJveCgpLmJvdHRvbSgpOworICAgICAgICAg ICAgYXV0byBib3R0b20gPSBtX2Zsb2F0c1sqaW5kZXhdLmRpc3BsYXlCb3goKS5yZWN0V2l0aE1h cmdpbigpLmJvdHRvbSgpOwogICAgICAgICAgICAgLy8gSXMgdGhpcyBmbG9hdGluZyBpbnRydXNp dmUgb24gdGhpcyBwb3NpdGlvbj8KICAgICAgICAgICAgIGlmIChib3R0b20gPiB2ZXJ0aWNhbFBv c2l0aW9uKQogICAgICAgICAgICAgICAgIHJldHVybiBpbmRleDsK