188256 2018-08-02 06:47:16 -0700 Handle zero-sized ISOMP4 boxes appropriately 2018-08-02 10:44:18 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cturner cturner commit-queue jer.noble webkit-bug-importer oldest_to_newest 1447228 0 cturner 2018-08-02 06:47:16 -0700 Handle zero-sized ISOMP4 boxes appropriately 1447229 1 346378 cturner 2018-08-02 06:49:06 -0700 Created attachment 346378 Patch 1447263 2 346386 cturner 2018-08-02 09:55:59 -0700 Created attachment 346386 Patch Modify the ::parse method as well 1447279 3 346386 commit-queue 2018-08-02 10:43:47 -0700 Comment on attachment 346386 Patch Clearing flags on attachment: 346386 Committed r234503: <https://trac.webkit.org/changeset/234503> 1447280 4 commit-queue 2018-08-02 10:43:48 -0700 All reviewed patches have been landed. Closing bug. 1447282 5 webkit-bug-importer 2018-08-02 10:44:18 -0700 <rdar://problem/42862987> 346378 2018-08-02 06:49:06 -0700 2018-08-02 09:55:56 -0700 Patch bug-188256-20180802144905.patch text/plain 2470 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTJlYTc2Yjk4MjFhNmEy MWY4YWE5ZThhOTQ1YmYwNjM0ZTFmNzYxMy4uNDAxNmQ0MjY3ZTEwMGMyMmUyM2Y2NDg1NGYzOThh NTg3M2U2OTM4NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM4IEBACisyMDE4LTA4LTAyICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBIYW5kbGUgemVyby1z aXplZCBJU09NUDQgYm94ZXMgYXBwcm9wcmlhdGVseQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4MjU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjb3JkaW5nIHRvIElTTy9JRUMgMTQ0OTYtMTI6MjAx MihFKSwgd2hlbiB0aGUgQm94IGNsYXNzZXMnIHNpemUKKyAgICAgICAgZmllbGQgaXMgemVybywg dGhlIGltcGxpZWQgc2l6ZSBvZiB0aGUgYm94IGV4dGVuZHMgdG8gdGhlIGVuZCBvZgorICAgICAg ICB0aGUgZmlsZS4gSWYgdGhpcyBkZXRhaWwgaXMgbm90IHRha2VuIGludG8gYWNjb3VudCwgQ0VO QworICAgICAgICBzYW5pdGl6YXRpb24gY2FuIGluY29ycmVjdGx5IHJlcG9ydCBhbiBpbnZhbGlk IGJveCBzaXplLCBzaW5jZSAwCisgICAgICAgICE9IHRoZSBudW1iZXIgb2YgYnl0ZXMgaW4gdGhp cyBib3gsIHNwZWNpZmljYWxseSwgdGhlIGRhdGEgbGF5b3V0CisgICAgICAgIG9mIEJveCBpcyBh cyBmb2xsb3dzLAorCisgICAgICAgIGFsaWduZWQoOCkgY2xhc3MgQm94ICh1bnNpZ25lZCBpbnQo MzIpIGJveHR5cGUsCisgICAgICAgICAgICAgIG9wdGlvbmFsIHVuc2lnbmVkIGludCg4KVsxNl0g ZXh0ZW5kZWRfdHlwZSkgeworICAgICAgICAgICB1bnNpZ25lZCBpbnQoMzIpIHNpemU7CisgICAg ICAgICAgIHVuc2lnbmVkIGludCgzMikgdHlwZSA9IGJveHR5cGU7CisgICAgICAgICAgIGlmIChz aXplPT0xKSB7CisgICAgICAgICAgICAgdW5zaWduZWQgaW50KDY0KSBsYXJnZXNpemU7CisgICAg ICAgICAgIH0gZWxzZSBpZiAoc2l6ZT09MCkgeyAvLyBUaGlzIGlzIHRoZSBjYXNlIG5vdyBoYW5k bGVkLgorICAgICAgICAgICAgIC8vIGJveCBleHRlbmRzIHRvIGVuZCBvZiBmaWxlCisgICAgICAg ICAgIH0KKyAgICAgICAgICAgaWYgKGJveHR5cGU9PeKAmHV1aWTigJkpIHsKKyAgICAgICAgICAg ICB1bnNpZ25lZCBpbnQoOClbMTZdIHVzZXJ0eXBlID0gZXh0ZW5kZWRfdHlwZTsKKyAgICAgICAg ICAgfQorICAgICAgICB9CisKKyAgICAgICAgVGVzdGVkIGJ5IGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvZW5jcnlwdGVkLW1lZGlhL2NsZWFya2V5LWdlbmVyYXRlLXJlcXVlc3QtZGlz YWxsb3dlZC1pbnB1dC5odHRwcy5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9p c28vSVNPQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklTT0JveDo6cGVla0JveCk6IENoZWNr IGlmIHRoZSBwYXJzZWQgc2l6ZSBpcyB6ZXJvLCBhbmQKKyAgICAgICAgaWYgaXQgaXMsIHRoZSBz aXplIGlzIGNhbGN1bGF0ZWQgYXMgdGhlIHRvdGFsIG51bWJlciBvZiBieXRlcyBpbgorICAgICAg ICB0aGUgaW5jb21pbmcgRGF0YVZpZXcuCisKIDIwMTgtMDgtMDIgIENoYXJsaWUgVHVybmVyICA8 Y3R1cm5lckBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIFN0b3AgcHVzaGluZyBi dWZmZXJzIHdoZW4gc2Vla2luZyBzdGF0dXMgY2hhbmdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvaXNvL0lTT0JveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9pc28vSVNPQm94LmNwcAppbmRleCA2NDAwNzk2ZDg5ZDUzNWRhYmQz MjgxZTE2Nzg4ZTYxNWRiNTUzOGY0Li4wMzc0ZjhkNmY3ZDBlZWRhYjdhYmIzOWM5OGQ2N2M5MjQx ZDM2YjJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9pc28v SVNPQm94LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9pc28vSVNP Qm94LmNwcApAQCAtNDQsNiArNDQsOCBAQCBJU09Cb3g6OlBlZWtSZXN1bHQgSVNPQm94OjpwZWVr Qm94KERhdGFWaWV3JiB2aWV3LCB1bnNpZ25lZCBvZmZzZXQpCiAKICAgICBpZiAoc2l6ZSA9PSAx ICYmICFjaGVja2VkUmVhZDx1aW50NjRfdD4oc2l6ZSwgdmlldywgb2Zmc2V0LCBCaWdFbmRpYW4p KQogICAgICAgICByZXR1cm4gc3RkOjpudWxsb3B0OworICAgIGVsc2UgaWYgKCFzaXplKQorICAg ICAgICBzaXplID0gdmlldy5ieXRlTGVuZ3RoKCk7CiAKICAgICByZXR1cm4gc3RkOjptYWtlX3Bh aXIodHlwZSwgc2l6ZSk7CiB9Cg== 346386 2018-08-02 09:55:59 -0700 2018-08-02 10:43:47 -0700 Patch bug-188256-20180802175558.patch text/plain 2814 cturner U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NDk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTJlYTc2Yjk4MjFhNmEy MWY4YWE5ZThhOTQ1YmYwNjM0ZTFmNzYxMy4uNDE5ZTMzNDMxNDQyNjI4NTAzNjFlZGUyYjkzNTFk ZjkyOTlhNmZmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDM5IEBACisyMDE4LTA4LTAyICBDaGFy bGllIFR1cm5lciAgPGN0dXJuZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBIYW5kbGUgemVyby1z aXplZCBJU09NUDQgYm94ZXMgYXBwcm9wcmlhdGVseQorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4MjU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQWNjb3JkaW5nIHRvIElTTy9JRUMgMTQ0OTYtMTI6MjAx MihFKSwgd2hlbiB0aGUgQm94IGNsYXNzZXMnIHNpemUKKyAgICAgICAgZmllbGQgaXMgemVybywg dGhlIGltcGxpZWQgc2l6ZSBvZiB0aGUgYm94IGV4dGVuZHMgdG8gdGhlIGVuZCBvZgorICAgICAg ICB0aGUgZmlsZS4gSWYgdGhpcyBkZXRhaWwgaXMgbm90IHRha2VuIGludG8gYWNjb3VudCwgQ0VO QworICAgICAgICBzYW5pdGl6YXRpb24gY2FuIGluY29ycmVjdGx5IHJlcG9ydCBhbiBpbnZhbGlk IGJveCBzaXplLCBzaW5jZSAwCisgICAgICAgICE9IHRoZSBudW1iZXIgb2YgYnl0ZXMgaW4gdGhp cyBib3gsIHNwZWNpZmljYWxseSwgdGhlIGRhdGEgbGF5b3V0CisgICAgICAgIG9mIEJveCBpcyBh cyBmb2xsb3dzLAorCisgICAgICAgIGFsaWduZWQoOCkgY2xhc3MgQm94ICh1bnNpZ25lZCBpbnQo MzIpIGJveHR5cGUsCisgICAgICAgICAgICAgIG9wdGlvbmFsIHVuc2lnbmVkIGludCg4KVsxNl0g ZXh0ZW5kZWRfdHlwZSkgeworICAgICAgICAgICB1bnNpZ25lZCBpbnQoMzIpIHNpemU7CisgICAg ICAgICAgIHVuc2lnbmVkIGludCgzMikgdHlwZSA9IGJveHR5cGU7CisgICAgICAgICAgIGlmIChz aXplPT0xKSB7CisgICAgICAgICAgICAgdW5zaWduZWQgaW50KDY0KSBsYXJnZXNpemU7CisgICAg ICAgICAgIH0gZWxzZSBpZiAoc2l6ZT09MCkgeyAvLyBUaGlzIGlzIHRoZSBjYXNlIG5vdyBoYW5k bGVkLgorICAgICAgICAgICAgIC8vIGJveCBleHRlbmRzIHRvIGVuZCBvZiBmaWxlCisgICAgICAg ICAgIH0KKyAgICAgICAgICAgaWYgKGJveHR5cGU9PeKAmHV1aWTigJkpIHsKKyAgICAgICAgICAg ICB1bnNpZ25lZCBpbnQoOClbMTZdIHVzZXJ0eXBlID0gZXh0ZW5kZWRfdHlwZTsKKyAgICAgICAg ICAgfQorICAgICAgICB9CisKKyAgICAgICAgVGVzdGVkIGJ5IGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvZW5jcnlwdGVkLW1lZGlhL2NsZWFya2V5LWdlbmVyYXRlLXJlcXVlc3QtZGlz YWxsb3dlZC1pbnB1dC5odHRwcy5odG1sCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9p c28vSVNPQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OklTT0JveDo6cGVla0JveCk6IENoZWNr IGlmIHRoZSBwYXJzZWQgc2l6ZSBpcyB6ZXJvLCBhbmQKKyAgICAgICAgaWYgaXQgaXMsIHRoZSBz aXplIGlzIGNhbGN1bGF0ZWQgYXMgdGhlIHRvdGFsIG51bWJlciBvZiBieXRlcyBpbgorICAgICAg ICB0aGUgaW5jb21pbmcgRGF0YVZpZXcuCisgICAgICAgIChXZWJDb3JlOjpJU09Cb3g6OnBhcnNl KTogRGl0dG8uCisKIDIwMTgtMDgtMDIgIENoYXJsaWUgVHVybmVyICA8Y3R1cm5lckBpZ2FsaWEu Y29tPgogCiAgICAgICAgIFtHU3RyZWFtZXJdIFN0b3AgcHVzaGluZyBidWZmZXJzIHdoZW4gc2Vl a2luZyBzdGF0dXMgY2hhbmdlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvaXNvL0lTT0JveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9pc28vSVNPQm94LmNwcAppbmRleCA2NDAwNzk2ZDg5ZDUzNWRhYmQzMjgxZTE2Nzg4ZTYxNWRi NTUzOGY0Li5jMDZlM2E2MzM4ODYwZjExZWIwZWJjZmE0MzhkMzUyMDI2NmY1ZDQ4IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9pc28vSVNPQm94LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9pc28vSVNPQm94LmNwcApAQCAtNDQs NiArNDQsOCBAQCBJU09Cb3g6OlBlZWtSZXN1bHQgSVNPQm94OjpwZWVrQm94KERhdGFWaWV3JiB2 aWV3LCB1bnNpZ25lZCBvZmZzZXQpCiAKICAgICBpZiAoc2l6ZSA9PSAxICYmICFjaGVja2VkUmVh ZDx1aW50NjRfdD4oc2l6ZSwgdmlldywgb2Zmc2V0LCBCaWdFbmRpYW4pKQogICAgICAgICByZXR1 cm4gc3RkOjpudWxsb3B0OworICAgIGVsc2UgaWYgKCFzaXplKQorICAgICAgICBzaXplID0gdmll dy5ieXRlTGVuZ3RoKCk7CiAKICAgICByZXR1cm4gc3RkOjptYWtlX3BhaXIodHlwZSwgc2l6ZSk7 CiB9CkBAIC03NCw2ICs3Niw4IEBAIGJvb2wgSVNPQm94OjpwYXJzZShEYXRhVmlldyYgdmlldywg dW5zaWduZWQmIG9mZnNldCkKIAogICAgIGlmIChtX3NpemUgPT0gMSAmJiAhY2hlY2tlZFJlYWQ8 dWludDY0X3Q+KG1fc2l6ZSwgdmlldywgb2Zmc2V0LCBCaWdFbmRpYW4pKQogICAgICAgICByZXR1 cm4gZmFsc2U7CisgICAgZWxzZSBpZiAoIW1fc2l6ZSkKKyAgICAgICAgbV9zaXplID0gdmlldy5i eXRlTGVuZ3RoKCk7CiAKICAgICBpZiAobV9ib3hUeXBlID09ICJ1dWlkIikgewogICAgICAgICBz dHJ1Y3QgRXh0ZW5kZWRUeXBlIHsK