188210 2018-07-31 16:36:25 -0700 [GStreamer] Make sure that first buffer running time is 0 in GStreamerMediaStreamSource 2018-08-01 20:25:14 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsaunier tsaunier alex commit-queue lforschler pnormand oldest_to_newest 1446706 0 tsaunier 2018-07-31 16:36:25 -0700 [GStreamer] Make sure that first buffer running time is 0 in GStreamerMediaStreamSource 1446713 1 346222 tsaunier 2018-07-31 16:47:13 -0700 Created attachment 346222 Patch 1446835 2 346222 alex 2018-07-31 23:51:29 -0700 Comment on attachment 346222 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346222&action=review LGTM, just fix the typo. > Source/WebCore/platform/mediastream/gstreamer/GStreamerMediaStreamSource.cpp:512 > + auto pad = adoptGRef(gst_element_get_static_pad(self->videoSrc, "src")); Probably this is a small typo and you wanted to use audioSrc. 1446866 3 346273 tsaunier 2018-08-01 05:41:11 -0700 Created attachment 346273 Patch Fix typo 1446869 4 346273 commit-queue 2018-08-01 06:35:45 -0700 Comment on attachment 346273 Patch Clearing flags on attachment: 346273 Committed r234457: <https://trac.webkit.org/changeset/234457> 1446870 5 commit-queue 2018-08-01 06:35:46 -0700 All reviewed patches have been landed. Closing bug. 1447125 6 webkit-bug-importer 2018-08-01 20:25:14 -0700 <rdar://problem/42840249> 346222 2018-07-31 16:47:13 -0700 2018-08-01 05:41:07 -0700 Patch bug-188210-20180731194712.patch text/plain 3644 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGI3NWM4ZWQ1NGRlOTQz ZTg3OWYwZDJhNzI0YjgzOGMyYTQ4NTk1Ny4uNWMwMTNjYjFhZDE0ZjBiYmNjMWMyZWY3YTFiMWY5 ZTZhZWM1NjAwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA3LTMxICBUaGli YXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBNYWtlIHN1cmUgdGhhdCBmaXJzdCBidWZmZXIgcnVubmluZyB0aW1lIGlzIDAgaW4gR1N0cmVh bWVyTWVkaWFTdHJlYW1Tb3VyY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4ODIxMAorCisgICAgICAgIFRoaXMgaXMgYSBsaXZlIHNvdXJjZSBhbmQg dGhlIGZpcnN0IGZyYW1lIGlzIHRoZSBiZWdpbm5pbmcgb2YgdGhlIHN0cmVhbSwKKyAgICAgICAg YnV0IHRoYXQgZG9lc24ndCBtZWFuIHRoYXQgdGhlIGluY29taW5nIHN0cmVhbSBmcm9tIHRoZSBj YW1lcmEgZGlkbid0IHN0YXJ0CisgICAgICAgIGJlZm9yZS4gV2UgbmVlZCB0byBzZXQgYSBwYWQg b2Zmc2V0IG9uIGVhY2ggc3JjcGFkIG9mIHRoZSBzb3VyY2UgdG8gY29tcGVuc2F0ZQorICAgICAg ICBmb3IgdGhhdC4gVGhpcyBpcyB0aGUgZXhhY3Qgc2FtZSBsb2dpYyBhcyBpbiB3ZWJydGMgR1N0 cmVhbWVyVmlkZW8vRW5jL0RlYy9vZGVyLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVyL0dTdHJl YW1lck1lZGlhU3RyZWFtU291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OndlYmtpdF9tZWRp YV9zdHJlYW1fc3JjX2luaXQpOgorICAgICAgICAoV2ViQ29yZTo6d2Via2l0TWVkaWFTdHJlYW1T cmNQdXNoVmlkZW9TYW1wbGUpOgorICAgICAgICAoV2ViQ29yZTo6d2Via2l0TWVkaWFTdHJlYW1T cmNQdXNoQXVkaW9TYW1wbGUpOgorCiAyMDE4LTA3LTI1ICBUaGliYXVsdCBTYXVuaWVyICA8dHNh dW5pZXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBNYWtlIGNvZGVjcGFyc2Vy cyBvcHRpb25uYWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry ZWFtL2dzdHJlYW1lci9HU3RyZWFtZXJNZWRpYVN0cmVhbVNvdXJjZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyTWVkaWFTdHJlYW1T b3VyY2UuY3BwCmluZGV4IDk1MzYwNzZjYjIyOGUxMzY5YTUwZWY5ZDBlMGNhMmMwMTZmYjJlMzAu LjU4NTkzOTIyMTYxNDU4OTVjYTM0ZDZjMzg2NGY4Y2E0N2E5MTZiODMgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2dzdHJlYW1lci9HU3RyZWFtZXJNZWRp YVN0cmVhbVNvdXJjZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJl YW0vZ3N0cmVhbWVyL0dTdHJlYW1lck1lZGlhU3RyZWFtU291cmNlLmNwcApAQCAtMTQ5LDcgKzE0 OSw5IEBAIHN0cnVjdCBfV2ViS2l0TWVkaWFTdHJlYW1TcmMgewogICAgIGdjaGFyKiB1cmk7CiAK ICAgICBHc3RFbGVtZW50KiBhdWRpb1NyYzsKKyAgICBHc3RDbG9ja1RpbWUgZmlyc3RBdWRpb0J1 ZmZlclB0czsKICAgICBHc3RFbGVtZW50KiB2aWRlb1NyYzsKKyAgICBHc3RDbG9ja1RpbWUgZmly c3RGcmFtZVB0czsKIAogICAgIHN0ZDo6dW5pcXVlX3B0cjxXZWJLaXRNZWRpYVN0cmVhbVRyYWNr T2JzZXJ2ZXI+IG9ic2VydmVyOwogICAgIFN0cmluZyB2aWRlb1RyYWNrSUQ7CkBAIC0zMjAsNiAr MzIyLDggQEAgc3RhdGljIHZvaWQgd2Via2l0X21lZGlhX3N0cmVhbV9zcmNfaW5pdChXZWJLaXRN ZWRpYVN0cmVhbVNyYyogc2VsZikKIHsKICAgICBzZWxmLT5vYnNlcnZlciA9IHN0ZDo6bWFrZV91 bmlxdWU8V2ViS2l0TWVkaWFTdHJlYW1UcmFja09ic2VydmVyPihzZWxmKTsKICAgICBzZWxmLT5m bG93Q29tYmluZXIgPSBnc3RfZmxvd19jb21iaW5lcl9uZXcoKTsKKyAgICBzZWxmLT5maXJzdEF1 ZGlvQnVmZmVyUHRzID0gR1NUX0NMT0NLX1RJTUVfTk9ORTsKKyAgICBzZWxmLT5maXJzdEZyYW1l UHRzID0gR1NUX0NMT0NLX1RJTUVfTk9ORTsKIH0KIAogdHlwZWRlZiBzdHJ1Y3QgewpAQCAtNDg1 LDE0ICs0ODksMzEgQEAgZ2Jvb2xlYW4gd2Via2l0TWVkaWFTdHJlYW1TcmNTZXRTdHJlYW0oV2Vi S2l0TWVkaWFTdHJlYW1TcmMqIHNlbGYsIE1lZGlhU3RyZWFtUHIKIAogc3RhdGljIHZvaWQgd2Vi a2l0TWVkaWFTdHJlYW1TcmNQdXNoVmlkZW9TYW1wbGUoV2ViS2l0TWVkaWFTdHJlYW1TcmMqIHNl bGYsIEdzdFNhbXBsZSogZ3N0c2FtcGxlKQogewotICAgIGlmIChzZWxmLT52aWRlb1NyYykKKyAg ICBpZiAoc2VsZi0+dmlkZW9TcmMpIHsKKyAgICAgICAgaWYgKCFHU1RfQ0xPQ0tfVElNRV9JU19W QUxJRChzZWxmLT5maXJzdEZyYW1lUHRzKSkgeworICAgICAgICAgICAgYXV0byBidWZmZXIgPSBn c3Rfc2FtcGxlX2dldF9idWZmZXIoZ3N0c2FtcGxlKTsKKworICAgICAgICAgICAgc2VsZi0+Zmly c3RGcmFtZVB0cyA9IEdTVF9CVUZGRVJfUFRTKGJ1ZmZlcik7CisgICAgICAgICAgICBhdXRvIHBh ZCA9IGFkb3B0R1JlZihnc3RfZWxlbWVudF9nZXRfc3RhdGljX3BhZChzZWxmLT52aWRlb1NyYywg InNyYyIpKTsKKyAgICAgICAgICAgIGdzdF9wYWRfc2V0X29mZnNldChwYWQuZ2V0KCksIC1zZWxm LT5maXJzdEZyYW1lUHRzKTsKKyAgICAgICAgfQorCiAgICAgICAgIGdzdF9hcHBfc3JjX3B1c2hf c2FtcGxlKEdTVF9BUFBfU1JDKHNlbGYtPnZpZGVvU3JjKSwgZ3N0c2FtcGxlKTsKKyAgICB9CiB9 CiAKIHN0YXRpYyB2b2lkIHdlYmtpdE1lZGlhU3RyZWFtU3JjUHVzaEF1ZGlvU2FtcGxlKFdlYktp dE1lZGlhU3RyZWFtU3JjKiBzZWxmLCBHc3RTYW1wbGUqIGdzdHNhbXBsZSkKIHsKLSAgICBpZiAo c2VsZi0+YXVkaW9TcmMpCisgICAgaWYgKHNlbGYtPmF1ZGlvU3JjKSB7CisgICAgICAgIGlmICgh R1NUX0NMT0NLX1RJTUVfSVNfVkFMSUQoc2VsZi0+Zmlyc3RBdWRpb0J1ZmZlclB0cykpIHsKKyAg ICAgICAgICAgIGF1dG8gYnVmZmVyID0gZ3N0X3NhbXBsZV9nZXRfYnVmZmVyKGdzdHNhbXBsZSk7 CisKKyAgICAgICAgICAgIHNlbGYtPmZpcnN0QXVkaW9CdWZmZXJQdHMgPSBHU1RfQlVGRkVSX1BU UyhidWZmZXIpOworICAgICAgICAgICAgYXV0byBwYWQgPSBhZG9wdEdSZWYoZ3N0X2VsZW1lbnRf Z2V0X3N0YXRpY19wYWQoc2VsZi0+dmlkZW9TcmMsICJzcmMiKSk7CisgICAgICAgICAgICBnc3Rf cGFkX3NldF9vZmZzZXQocGFkLmdldCgpLCAtc2VsZi0+Zmlyc3RBdWRpb0J1ZmZlclB0cyk7Cisg ICAgICAgIH0KICAgICAgICAgZ3N0X2FwcF9zcmNfcHVzaF9zYW1wbGUoR1NUX0FQUF9TUkMoc2Vs Zi0+YXVkaW9TcmMpLCBnc3RzYW1wbGUpOworICAgIH0KIH0KIAogc3RhdGljIHZvaWQgd2Via2l0 TWVkaWFTdHJlYW1TcmNUcmFja0VuZGVkKFdlYktpdE1lZGlhU3RyZWFtU3JjKiBzZWxmLAo= 346273 2018-08-01 05:41:11 -0700 2018-08-01 06:35:45 -0700 Patch bug-188210-20180801084110.patch text/plain 3644 tsaunier U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NDIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGI3NWM4ZWQ1NGRlOTQz ZTg3OWYwZDJhNzI0YjgzOGMyYTQ4NTk1Ny4uNWMwMTNjYjFhZDE0ZjBiYmNjMWMyZWY3YTFiMWY5 ZTZhZWM1NjAwNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE4LTA3LTMxICBUaGli YXVsdCBTYXVuaWVyICA8dHNhdW5pZXJAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBNYWtlIHN1cmUgdGhhdCBmaXJzdCBidWZmZXIgcnVubmluZyB0aW1lIGlzIDAgaW4gR1N0cmVh bWVyTWVkaWFTdHJlYW1Tb3VyY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4ODIxMAorCisgICAgICAgIFRoaXMgaXMgYSBsaXZlIHNvdXJjZSBhbmQg dGhlIGZpcnN0IGZyYW1lIGlzIHRoZSBiZWdpbm5pbmcgb2YgdGhlIHN0cmVhbSwKKyAgICAgICAg YnV0IHRoYXQgZG9lc24ndCBtZWFuIHRoYXQgdGhlIGluY29taW5nIHN0cmVhbSBmcm9tIHRoZSBj YW1lcmEgZGlkbid0IHN0YXJ0CisgICAgICAgIGJlZm9yZS4gV2UgbmVlZCB0byBzZXQgYSBwYWQg b2Zmc2V0IG9uIGVhY2ggc3JjcGFkIG9mIHRoZSBzb3VyY2UgdG8gY29tcGVuc2F0ZQorICAgICAg ICBmb3IgdGhhdC4gVGhpcyBpcyB0aGUgZXhhY3Qgc2FtZSBsb2dpYyBhcyBpbiB3ZWJydGMgR1N0 cmVhbWVyVmlkZW8vRW5jL0RlYy9vZGVyLgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVyL0dTdHJl YW1lck1lZGlhU3RyZWFtU291cmNlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OndlYmtpdF9tZWRp YV9zdHJlYW1fc3JjX2luaXQpOgorICAgICAgICAoV2ViQ29yZTo6d2Via2l0TWVkaWFTdHJlYW1T cmNQdXNoVmlkZW9TYW1wbGUpOgorICAgICAgICAoV2ViQ29yZTo6d2Via2l0TWVkaWFTdHJlYW1T cmNQdXNoQXVkaW9TYW1wbGUpOgorCiAyMDE4LTA3LTI1ICBUaGliYXVsdCBTYXVuaWVyICA8dHNh dW5pZXJAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBNYWtlIGNvZGVjcGFyc2Vy cyBvcHRpb25uYWwKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3Ry ZWFtL2dzdHJlYW1lci9HU3RyZWFtZXJNZWRpYVN0cmVhbVNvdXJjZS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyTWVkaWFTdHJlYW1T b3VyY2UuY3BwCmluZGV4IDk1MzYwNzZjYjIyOGUxMzY5YTUwZWY5ZDBlMGNhMmMwMTZmYjJlMzAu LmZmZGFlNGViNTA4ZWU2MjVkMjgyY2EyMmE5OTg3YzVjYzJmZTMwZDYgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2dzdHJlYW1lci9HU3RyZWFtZXJNZWRp YVN0cmVhbVNvdXJjZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJl YW0vZ3N0cmVhbWVyL0dTdHJlYW1lck1lZGlhU3RyZWFtU291cmNlLmNwcApAQCAtMTQ5LDcgKzE0 OSw5IEBAIHN0cnVjdCBfV2ViS2l0TWVkaWFTdHJlYW1TcmMgewogICAgIGdjaGFyKiB1cmk7CiAK ICAgICBHc3RFbGVtZW50KiBhdWRpb1NyYzsKKyAgICBHc3RDbG9ja1RpbWUgZmlyc3RBdWRpb0J1 ZmZlclB0czsKICAgICBHc3RFbGVtZW50KiB2aWRlb1NyYzsKKyAgICBHc3RDbG9ja1RpbWUgZmly c3RGcmFtZVB0czsKIAogICAgIHN0ZDo6dW5pcXVlX3B0cjxXZWJLaXRNZWRpYVN0cmVhbVRyYWNr T2JzZXJ2ZXI+IG9ic2VydmVyOwogICAgIFN0cmluZyB2aWRlb1RyYWNrSUQ7CkBAIC0zMjAsNiAr MzIyLDggQEAgc3RhdGljIHZvaWQgd2Via2l0X21lZGlhX3N0cmVhbV9zcmNfaW5pdChXZWJLaXRN ZWRpYVN0cmVhbVNyYyogc2VsZikKIHsKICAgICBzZWxmLT5vYnNlcnZlciA9IHN0ZDo6bWFrZV91 bmlxdWU8V2ViS2l0TWVkaWFTdHJlYW1UcmFja09ic2VydmVyPihzZWxmKTsKICAgICBzZWxmLT5m bG93Q29tYmluZXIgPSBnc3RfZmxvd19jb21iaW5lcl9uZXcoKTsKKyAgICBzZWxmLT5maXJzdEF1 ZGlvQnVmZmVyUHRzID0gR1NUX0NMT0NLX1RJTUVfTk9ORTsKKyAgICBzZWxmLT5maXJzdEZyYW1l UHRzID0gR1NUX0NMT0NLX1RJTUVfTk9ORTsKIH0KIAogdHlwZWRlZiBzdHJ1Y3QgewpAQCAtNDg1 LDE0ICs0ODksMzEgQEAgZ2Jvb2xlYW4gd2Via2l0TWVkaWFTdHJlYW1TcmNTZXRTdHJlYW0oV2Vi S2l0TWVkaWFTdHJlYW1TcmMqIHNlbGYsIE1lZGlhU3RyZWFtUHIKIAogc3RhdGljIHZvaWQgd2Vi a2l0TWVkaWFTdHJlYW1TcmNQdXNoVmlkZW9TYW1wbGUoV2ViS2l0TWVkaWFTdHJlYW1TcmMqIHNl bGYsIEdzdFNhbXBsZSogZ3N0c2FtcGxlKQogewotICAgIGlmIChzZWxmLT52aWRlb1NyYykKKyAg ICBpZiAoc2VsZi0+dmlkZW9TcmMpIHsKKyAgICAgICAgaWYgKCFHU1RfQ0xPQ0tfVElNRV9JU19W QUxJRChzZWxmLT5maXJzdEZyYW1lUHRzKSkgeworICAgICAgICAgICAgYXV0byBidWZmZXIgPSBn c3Rfc2FtcGxlX2dldF9idWZmZXIoZ3N0c2FtcGxlKTsKKworICAgICAgICAgICAgc2VsZi0+Zmly c3RGcmFtZVB0cyA9IEdTVF9CVUZGRVJfUFRTKGJ1ZmZlcik7CisgICAgICAgICAgICBhdXRvIHBh ZCA9IGFkb3B0R1JlZihnc3RfZWxlbWVudF9nZXRfc3RhdGljX3BhZChzZWxmLT52aWRlb1NyYywg InNyYyIpKTsKKyAgICAgICAgICAgIGdzdF9wYWRfc2V0X29mZnNldChwYWQuZ2V0KCksIC1zZWxm LT5maXJzdEZyYW1lUHRzKTsKKyAgICAgICAgfQorCiAgICAgICAgIGdzdF9hcHBfc3JjX3B1c2hf c2FtcGxlKEdTVF9BUFBfU1JDKHNlbGYtPnZpZGVvU3JjKSwgZ3N0c2FtcGxlKTsKKyAgICB9CiB9 CiAKIHN0YXRpYyB2b2lkIHdlYmtpdE1lZGlhU3RyZWFtU3JjUHVzaEF1ZGlvU2FtcGxlKFdlYktp dE1lZGlhU3RyZWFtU3JjKiBzZWxmLCBHc3RTYW1wbGUqIGdzdHNhbXBsZSkKIHsKLSAgICBpZiAo c2VsZi0+YXVkaW9TcmMpCisgICAgaWYgKHNlbGYtPmF1ZGlvU3JjKSB7CisgICAgICAgIGlmICgh R1NUX0NMT0NLX1RJTUVfSVNfVkFMSUQoc2VsZi0+Zmlyc3RBdWRpb0J1ZmZlclB0cykpIHsKKyAg ICAgICAgICAgIGF1dG8gYnVmZmVyID0gZ3N0X3NhbXBsZV9nZXRfYnVmZmVyKGdzdHNhbXBsZSk7 CisKKyAgICAgICAgICAgIHNlbGYtPmZpcnN0QXVkaW9CdWZmZXJQdHMgPSBHU1RfQlVGRkVSX1BU UyhidWZmZXIpOworICAgICAgICAgICAgYXV0byBwYWQgPSBhZG9wdEdSZWYoZ3N0X2VsZW1lbnRf Z2V0X3N0YXRpY19wYWQoc2VsZi0+YXVkaW9TcmMsICJzcmMiKSk7CisgICAgICAgICAgICBnc3Rf cGFkX3NldF9vZmZzZXQocGFkLmdldCgpLCAtc2VsZi0+Zmlyc3RBdWRpb0J1ZmZlclB0cyk7Cisg ICAgICAgIH0KICAgICAgICAgZ3N0X2FwcF9zcmNfcHVzaF9zYW1wbGUoR1NUX0FQUF9TUkMoc2Vs Zi0+YXVkaW9TcmMpLCBnc3RzYW1wbGUpOworICAgIH0KIH0KIAogc3RhdGljIHZvaWQgd2Via2l0 TWVkaWFTdHJlYW1TcmNUcmFja0VuZGVkKFdlYktpdE1lZGlhU3RyZWFtU3JjKiBzZWxmLAo=