188201 2018-07-31 11:16:50 -0700 [JSC] Remove unnecessary cellLock() in JSObject's GC marking if IndexingType is contiguous 2018-07-31 11:49:26 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki ews-watchlist fpizlo keith_miller mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1446605 0 ysuzuki 2018-07-31 11:16:50 -0700 [JSC] Remove unnecessary cellLock() in JSObject's GC marking if IndexingType is contiguous 1446606 1 346181 ysuzuki 2018-07-31 11:19:41 -0700 Created attachment 346181 Patch 1446613 2 346181 keith_miller 2018-07-31 11:34:02 -0700 Comment on attachment 346181 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346181&action=review r=me. > Source/JavaScriptCore/runtime/JSObject.cpp:400 > + // that can happen when the butterfly is used for array storage. Nit: Add a comment here repeating what you said in the change log about always reallocating the butterfly when converting to ArrayStorage. 1446616 3 346181 ysuzuki 2018-07-31 11:39:17 -0700 Comment on attachment 346181 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346181&action=review Thanks! >> Source/JavaScriptCore/runtime/JSObject.cpp:400 >> + // that can happen when the butterfly is used for array storage. > > Nit: Add a comment here repeating what you said in the change log about always reallocating the butterfly when converting to ArrayStorage. Sounds nice. Added. 1446623 4 ysuzuki 2018-07-31 11:48:49 -0700 Committed r234434: <https://trac.webkit.org/changeset/234434> 1446624 5 webkit-bug-importer 2018-07-31 11:49:26 -0700 <rdar://problem/42781022> 346181 2018-07-31 11:19:41 -0700 2018-07-31 11:34:02 -0700 Patch bug-188201-20180801031940.patch text/plain 2248 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NDI4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBm NTUyMDQyZTY1OTBiOWRiMTVjY2JkZjYyMDk0Y2YwNWExNjAyNmY4Li41YzE1NzhhOGQ4ZjVjM2Nk YjEwZGFkM2NiZWY3YzdlOTljOWQ5ZmEyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAxOC0wNy0zMSAgWXVzdWtlIFN1enVraSAgPHV0YXRhbmUudGVhQGdtYWls LmNvbT4KKworICAgICAgICBbSlNDXSBSZW1vdmUgdW5uZWNlc3NhcnkgY2VsbExvY2soKSBpbiBK U09iamVjdCdzIEdDIG1hcmtpbmcgaWYgSW5kZXhpbmdUeXBlIGlzIGNvbnRpZ3VvdXMKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODIwMQorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIGRvIG5vdCByZXVz ZSB0aGUgZXhpc3RpbmcgYnV0dGVyZmx5IHdpdGggQ29udGlndW91cyBzaGFwZSBmb3IgbmV3IEFy cmF5U3RvcmFnZSBidXR0ZXJmbHkuCisgICAgICAgIFdoZW4gY29udmVydGluZyB0aGUgYnV0dGVy Zmx5IHdpdGggQ29udGlndW91cyBzaGFwZSB0byBBcnJheVN0b3JhZ2UsIHdlIGFsd2F5cyBhbGxv Y2F0ZSBhCisgICAgICAgIG5ldyBvbmUuIFNvIHRoaXMgY2VsbExvY2soKSBpcyB1bm5lY2Vzc2Fy eSBmb3IgY29udGlndW91cyBzaGFwZSBzaW5jZSBjb250aWdvdXMgc2hhcGVkIGJ1dHRlcmZseQor ICAgICAgICBuZXZlciBiZWNvbWVzIGJyb2tlbiBzdGF0ZS4gVGhpcyBwYXRjaCByZW1vdmVzIHVu bmVjZXNzYXJ5IGxvY2tpbmcuCisKKyAgICAgICAgKiBydW50aW1lL0pTT2JqZWN0LmNwcDoKKyAg ICAgICAgKEpTQzo6SlNPYmplY3Q6OnZpc2l0QnV0dGVyZmx5SW1wbCk6CisKIDIwMTgtMDctMzEg IEd1aWxsYXVtZSBFbW9udCAgPGd1aWplbW9udEBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtKU0Nd IFJlbW92ZSBnY2Mgd2FybmluZ3MgZm9yIDMyLWJpdCBwbGF0Zm9ybXMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcCBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL0pTT2JqZWN0LmNwcAppbmRleCBmOWVkNmVhYmMwMzEyODkyOTgwZmJj OGZlZTkwMDE0NzgyZDRkMTI5Li4zNmRhZGQ2ZDEwNDBlYTZmYzNjNjc1Y2Q0NjNlYTI3MTMzYjA4 MzAxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU09iamVjdC5j cHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNPYmplY3QuY3BwCkBAIC0z OTUsMTIgKzM5NSw5IEBAIEFMV0FZU19JTkxJTkUgU3RydWN0dXJlKiBKU09iamVjdDo6dmlzaXRC dXR0ZXJmbHlJbXBsKFNsb3RWaXNpdG9yJiB2aXNpdG9yKQogICAgIERlcGVuZGVuY3kgaW5kZXhp bmdNb2RlRGVwZW5kZW5jeSA9IERlcGVuZGVuY3k6OmZlbmNlKGluZGV4aW5nTW9kZSk7CiAgICAg TG9ja2VyPEpTQ2VsbExvY2s+IGxvY2tlcihOb0xvY2tpbmdOZWNlc3NhcnkpOwogICAgIHN3aXRj aCAoaW5kZXhpbmdNb2RlKSB7Ci0gICAgY2FzZSBBTExfQ09OVElHVU9VU19JTkRFWElOR19UWVBF UzoKICAgICBjYXNlIEFMTF9BUlJBWV9TVE9SQUdFX0lOREVYSU5HX1RZUEVTOgogICAgICAgICAv LyBXZSBuZWVkIHRvIGhvbGQgdGhpcyBsb2NrIHRvIHByb3RlY3QgYWdhaW5zdCBjaGFuZ2VzIHRv IHRoZSBpbm5hcmRzIG9mIHRoZSBidXR0ZXJmbHkKLSAgICAgICAgLy8gdGhhdCBjYW4gaGFwcGVu IHdoZW4gdGhlIGJ1dHRlcmZseSBpcyB1c2VkIGZvciBhcnJheSBzdG9yYWdlLiBXZSBjb25zZXJ2 YXRpdmVseQotICAgICAgICAvLyBhc3N1bWUgdGhhdCBhIGNvbnRpZ3VvdXMgYnV0dGVyZmx5IG1h eSB0cmFuc2Zvcm0gaW50byBhbiBhcnJheSBzdG9yYWdlIG9uZSwgdGhvdWdoCi0gICAgICAgIC8v IHRoaXMgaXMgcHJvYmFibHkgbW9yZSBjb25zZXJ2YXRpdmUgdGhhbiBuZWNlc3NhcnkuCisgICAg ICAgIC8vIHRoYXQgY2FuIGhhcHBlbiB3aGVuIHRoZSBidXR0ZXJmbHkgaXMgdXNlZCBmb3IgYXJy YXkgc3RvcmFnZS4KICAgICAgICAgbG9ja2VyID0gaG9sZExvY2soY2VsbExvY2soKSk7CiAgICAg ICAgIGJyZWFrOwogICAgIGRlZmF1bHQ6Cg==