<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>188185</bug_id>
          
          <creation_ts>2018-07-30 16:11:43 -0700</creation_ts>
          <short_desc>test wkbi with webkit-patch upload</short_desc>
          <delta_ts>2018-07-30 16:52:24 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Lucas Forschler">lforschler</reporter>
          <assigned_to name="Lucas Forschler">lforschler</assigned_to>
          <cc>dbates</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>glenn</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1446402</commentid>
    <comment_count>0</comment_count>
    <who name="Lucas Forschler">lforschler</who>
    <bug_when>2018-07-30 16:11:43 -0700</bug_when>
    <thetext>test wkbi with webkit-patch upload</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1446403</commentid>
    <comment_count>1</comment_count>
      <attachid>346118</attachid>
    <who name="Lucas Forschler">lforschler</who>
    <bug_when>2018-07-30 16:12:08 -0700</bug_when>
    <thetext>Created attachment 346118
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1446404</commentid>
    <comment_count>2</comment_count>
    <who name="Lucas Forschler">lforschler</who>
    <bug_when>2018-07-30 16:12:09 -0700</bug_when>
    <thetext>&lt;rdar://problem/1234567&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1446431</commentid>
    <comment_count>3</comment_count>
      <attachid>346118</attachid>
    <who name="Daniel Bates">dbates</who>
    <bug_when>2018-07-30 16:52:24 -0700</bug_when>
    <thetext>Comment on attachment 346118
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=346118&amp;action=review

We should add tests for this change. Use the _unittests.py files in Tools/Scripts/webkitpy/tool/steps as examples. You can run the WebKitPy tests using script test-webkitpy.

&gt; Tools/ChangeLog:3
&gt; +        test wkbi with webkit-patch upload

This title does not make sense. I think you meant, CC WebKit Bug Importer when uploading a patch.

&gt; Tools/ChangeLog:8
&gt; +

We should explain that the purpose of this change is to automatically CC WebKit Bug Importer and add keyword InRadar on Bugzilla bugs when a patch is uploaded to the bug that contain a radar URL.

&gt; Tools/Scripts/webkitpy/tool/steps/addwkbi.py:27
&gt; +# Redistribution and use in source and binary forms, with or without
&gt; +# modification, are permitted provided that the following conditions are
&gt; +# met:
&gt; +#
&gt; +#     * Redistributions of source code must retain the above copyright
&gt; +# notice, this list of conditions and the following disclaimer.
&gt; +#     * Redistributions in binary form must reproduce the above
&gt; +# copyright notice, this list of conditions and the following disclaimer
&gt; +# in the documentation and/or other materials provided with the
&gt; +# distribution.
&gt; +#     * Neither the name of Google Inc. nor the names of its
&gt; +# contributors may be used to endorse or promote products derived from
&gt; +# this software without specific prior written permission.
&gt; +#
&gt; +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
&gt; +# &quot;AS IS&quot; AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
&gt; +# LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
&gt; +# A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
&gt; +# OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
&gt; +# SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
&gt; +# LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
&gt; +# DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
&gt; +# THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
&gt; +# (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
&gt; +# OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

This is not the correct license block. Please use the Apple license block text. The text is available at &lt;https://trac.webkit.org/browser/webkit/trunk/Source/WebCore/LICENSE-APPLE&gt;.

&gt; Tools/Scripts/webkitpy/tool/steps/addwkbi.py:46
&gt; +    def GetRadarLinkFromDiff(self, diff):

This name does not match our code style convention of using all lowercase with underscores separating words.

&gt; Tools/Scripts/webkitpy/tool/steps/addwkbi.py:58
&gt; +        matcher = re.compile(r&apos;(&lt;?rdar:\/\/problems?\/)?(?P&lt;radar_id&gt;-?\d{7,})&gt;?&apos;)
&gt; +        match = matcher.search(diff)
&gt; +
&gt; +        if not match:
&gt; +                return None
&gt; +
&gt; +        id = int(match.group(&apos;radar_id&apos;))
&gt; +        if id &lt; 0:
&gt; +            return None
&gt; +
&gt; +        link = &apos;&lt;rdar://problem/{}&gt;&apos;.format(id)
&gt; +        return link

This code finds the first radar URL in the entire diff and returns it. This could cause us to falsely associate the bug with a radar URL that appears in an added or moved comment. It seems sufficient to look for the radar URL only in the added ChangeLog entries. Toward this we can make use of DiffParser to parse a patch and the ChangeLog parsing logic in file &lt;https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/checkout/changelog.py?rev=225733&gt;. You may find inspiration for how to do this logic by looking at the class ValidateChangeLogs: &lt;https://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/tool/steps/validatechangelogs.py?rev=150404&gt;.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>346118</attachid>
            <date>2018-07-30 16:12:08 -0700</date>
            <delta_ts>2018-07-30 16:52:24 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-188185-20180730161207.patch</filename>
            <type>text/plain</type>
            <size>7153</size>
            <attacher name="Lucas Forschler">lforschler</attacher>
            
              <data encoding="base64">SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl
dmlzaW9uIDIzNDM5NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz
ICsxLDIzIEBACisyMDE4LTA3LTMwICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxl
LmNvbT4KKworICAgICAgICB0ZXN0IHdrYmkgd2l0aCB3ZWJraXQtcGF0Y2ggdXBsb2FkCisgICAg
ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODgxODUKKyAgICAg
ICAgPHJkYXI6Ly9wcm9ibGVtLzEyMzQ1Njc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdC1wYXRjaDoKKyAgICAgICAgKiBT
Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVnemlsbGEvYnVnemlsbGEucHk6CisgICAgICAg
IChCdWd6aWxsYS5hZGRfa2V5d29yZF90b19idWcpOgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0
cHkvdG9vbC9jb21tYW5kcy91cGxvYWQucHk6CisgICAgICAgIChVcGxvYWQpOgorICAgICAgICAq
IFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9fX2luaXRfXy5weToKKyAgICAgICAgKiBTY3Jp
cHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvYWRkd2tiaS5weTogQWRkZWQuCisgICAgICAgIChBZGRX
S0JJKToKKyAgICAgICAgKEFkZFdLQkkub3B0aW9ucyk6CisgICAgICAgIChBZGRXS0JJLkdldFJh
ZGFyTGlua0Zyb21EaWZmKToKKyAgICAgICAgKEFkZFdLQkkucnVuKToKKwogMjAxOC0wNy0yNyAg
TWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAKICAgICAgICAgVW5y
ZXZpZXdlZCwgZml4IHR5cG8gaW4gdGVzdCBleHBlY3RhdGlvbnMgYW5kIG1hcmsgYW5vdGhlciB0
ZXN0IGFzIHRpbWluZyBvdXQKSW5kZXg6IFRvb2xzL1NjcmlwdHMvd2Via2l0LXBhdGNoCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0LXBhdGNoCShyZXZpc2lvbiAyMzQzOTIpCisr
KyBUb29scy9TY3JpcHRzL3dlYmtpdC1wYXRjaAkod29ya2luZyBjb3B5KQpAQCAtMSw3ICsxLDgg
QEAKICMhL3Vzci9iaW4vZW52IHB5dGhvbgorCiAjIENvcHlyaWdodCAoYykgMjAxMSBDb2RlIEF1
cm9yYSBGb3J1bS4gQWxsIHJpZ2h0cyByZXNlcnZlZC4KICMgQ29weXJpZ2h0IChjKSAyMDEwIEdv
b2dsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCi0jIENvcHlyaWdodCAoYykgMjAwOSBBcHBs
ZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjIENvcHlyaWdodCAoYykgMjAxOCBBcHBsZSBJ
bmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCiAjIENvcHlyaWdodCAoQykgMjAxMCBDaHJpcyBKZXJk
b25layAoY2plcmRvbmVrQHdlYmtpdC5vcmcpCiAjCiAjIFJlZGlzdHJpYnV0aW9uIGFuZCB1c2Ug
aW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGggb3Igd2l0aG91dApJbmRleDogVG9vbHMv
U2NyaXB0cy93ZWJraXRweS9jb21tb24vbmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5Cj09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxsYS9idWd6aWxs
YS5weQkocmV2aXNpb24gMjM0MzkyKQorKysgVG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v
bmV0L2J1Z3ppbGxhL2J1Z3ppbGxhLnB5CSh3b3JraW5nIGNvcHkpCkBAIC04NTEsNiArODUxLDE1
IEBAIGNsYXNzIEJ1Z3ppbGxhKG9iamVjdCk6CiAgICAgICAgIHNlbGYuYnJvd3NlclsibmV3Y2Mi
XSA9ICIsICIuam9pbihlbWFpbF9hZGRyZXNzX2xpc3QpCiAgICAgICAgIHNlbGYuYnJvd3Nlci5z
dWJtaXQoKQogCisgICAgZGVmIGFkZF9rZXl3b3JkX3RvX2J1ZyhzZWxmLCBidWdfaWQsIGtleXdv
cmQpOgorICAgICAgICBzZWxmLmF1dGhlbnRpY2F0ZSgpCisKKyAgICAgICAgX2xvZy5pbmZvKCJB
ZGRpbmcgJXMgdG8gdGhlIGtleXdvcmQgbGlzdCBmb3IgYnVnICVzIiAlIChrZXl3b3JkLCBidWdf
aWQpKQorICAgICAgICBzZWxmLm9wZW5fdXJsKHNlbGYuYnVnX3VybF9mb3JfYnVnX2lkKGJ1Z19p
ZCkpCisgICAgICAgIHNlbGYuYnJvd3Nlci5zZWxlY3RfZm9ybShuYW1lPSJjaGFuZ2Vmb3JtIikK
KyAgICAgICAgc2VsZi5icm93c2VyWyJrZXl3b3JkcyJdID0ga2V5d29yZAorICAgICAgICBzZWxm
LmJyb3dzZXIuc3VibWl0KCkKKwogICAgIGRlZiBwb3N0X2NvbW1lbnRfdG9fYnVnKHNlbGYsIGJ1
Z19pZCwgY29tbWVudF90ZXh0LCBjYz1Ob25lKToKICAgICAgICAgc2VsZi5hdXRoZW50aWNhdGUo
KQogCkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvY29tbWFuZHMvdXBsb2FkLnB5
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9jb21tYW5kcy91cGxv
YWQucHkJKHJldmlzaW9uIDIzNDM5MikKKysrIFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9j
b21tYW5kcy91cGxvYWQucHkJKHdvcmtpbmcgY29weSkKQEAgLTI4NSw2ICsyODUsNyBAQCBjbGFz
cyBVcGxvYWQoQWJzdHJhY3RQYXRjaFVwbG9hZGluZ0NvbW1hCiAgICAgICAgIHN0ZXBzLlN1Z2dl
c3RSZXZpZXdlcnMsCiAgICAgICAgIHN0ZXBzLkVuc3VyZUJ1Z0lzT3BlbkFuZEFzc2lnbmVkLAog
ICAgICAgICBzdGVwcy5Qb3N0RGlmZiwKKyAgICAgICAgc3RlcHMuQWRkV0tCSSwKICAgICAgICAg
c3RlcHMuU3VibWl0VG9FV1MsCiAgICAgICAgIHN0ZXBzLldQVENoYW5nZUV4cG9ydCwKICAgICBd
CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvX19pbml0X18ucHkKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL19faW5pdF9fLnB5
CShyZXZpc2lvbiAyMzQzOTIpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMv
X19pbml0X18ucHkJKHdvcmtpbmcgY29weSkKQEAgLTI5LDYgKzI5LDcgQEAKIAogIyBGSVhNRTog
SXMgdGhpcyB0aGUgcmlnaHQgd2F5IHRvIGRvIHRoaXM/CiBmcm9tIHdlYmtpdHB5LnRvb2wuc3Rl
cHMuYWRkc3ZubWltZXR5cGVmb3JwbmcgaW1wb3J0IEFkZFN2bk1pbWV0eXBlRm9yUG5nCitmcm9t
IHdlYmtpdHB5LnRvb2wuc3RlcHMuYWRkd2tiaSBpbXBvcnQgQWRkV0tCSQogZnJvbSB3ZWJraXRw
eS50b29sLnN0ZXBzLmFwcGx5cGF0Y2ggaW1wb3J0IEFwcGx5UGF0Y2gKIGZyb20gd2Via2l0cHku
dG9vbC5zdGVwcy5hcHBseXBhdGNod2l0aGxvY2FsY29tbWl0IGltcG9ydCBBcHBseVBhdGNoV2l0
aExvY2FsQ29tbWl0CiBmcm9tIHdlYmtpdHB5LnRvb2wuc3RlcHMuYXBwbHl3YXRjaGxpc3QgaW1w
b3J0IEFwcGx5V2F0Y2hMaXN0CkluZGV4OiBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3Rl
cHMvYWRkd2tiaS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv
c3RlcHMvYWRkd2tiaS5weQkobm9uZXhpc3RlbnQpCisrKyBUb29scy9TY3JpcHRzL3dlYmtpdHB5
L3Rvb2wvc3RlcHMvYWRkd2tiaS5weQkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDc2IEBACisj
IENvcHlyaWdodCAoQykgMjAxOCBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2ZWQuCisjCisj
IFJlZGlzdHJpYnV0aW9uIGFuZCB1c2UgaW4gc291cmNlIGFuZCBiaW5hcnkgZm9ybXMsIHdpdGgg
b3Igd2l0aG91dAorIyBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0
aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCisjIG1ldDoKKyMKKyMgICAgICogUmVkaXN0cmli
dXRpb25zIG9mIHNvdXJjZSBjb2RlIG11c3QgcmV0YWluIHRoZSBhYm92ZSBjb3B5cmlnaHQKKyMg
bm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFp
bWVyLgorIyAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgaW4gYmluYXJ5IGZvcm0gbXVzdCByZXByb2R1
Y2UgdGhlIGFib3ZlCisjIGNvcHlyaWdodCBub3RpY2UsIHRoaXMgbGlzdCBvZiBjb25kaXRpb25z
IGFuZCB0aGUgZm9sbG93aW5nIGRpc2NsYWltZXIKKyMgaW4gdGhlIGRvY3VtZW50YXRpb24gYW5k
L29yIG90aGVyIG1hdGVyaWFscyBwcm92aWRlZCB3aXRoIHRoZQorIyBkaXN0cmlidXRpb24uCisj
ICAgICAqIE5laXRoZXIgdGhlIG5hbWUgb2YgR29vZ2xlIEluYy4gbm9yIHRoZSBuYW1lcyBvZiBp
dHMKKyMgY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9k
dWN0cyBkZXJpdmVkIGZyb20KKyMgdGhpcyBzb2Z0d2FyZSB3aXRob3V0IHNwZWNpZmljIHByaW9y
IHdyaXR0ZW4gcGVybWlzc2lvbi4KKyMKKyMgVEhJUyBTT0ZUV0FSRSBJUyBQUk9WSURFRCBCWSBU
SEUgQ09QWVJJR0hUIEhPTERFUlMgQU5EIENPTlRSSUJVVE9SUworIyAiQVMgSVMiIEFORCBBTlkg
RVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5PVAorIyBMSU1J
VEVEIFRPLCBUSEUgSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklU
TkVTUyBGT1IKKyMgQSBQQVJUSUNVTEFSIFBVUlBPU0UgQVJFIERJU0NMQUlNRUQuIElOIE5PIEVW
RU5UIFNIQUxMIFRIRSBDT1BZUklHSFQKKyMgT1dORVIgT1IgQ09OVFJJQlVUT1JTIEJFIExJQUJM
RSBGT1IgQU5ZIERJUkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsCisjIFNQRUNJQUwsIEVYRU1Q
TEFSWSwgT1IgQ09OU0VRVUVOVElBTCBEQU1BR0VTIChJTkNMVURJTkcsIEJVVCBOT1QKKyMgTElN
SVRFRCBUTywgUFJPQ1VSRU1FTlQgT0YgU1VCU1RJVFVURSBHT09EUyBPUiBTRVJWSUNFUzsgTE9T
UyBPRiBVU0UsCisjIERBVEEsIE9SIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikg
SE9XRVZFUiBDQVVTRUQgQU5EIE9OIEFOWQorIyBUSEVPUlkgT0YgTElBQklMSVRZLCBXSEVUSEVS
IElOIENPTlRSQUNULCBTVFJJQ1QgTElBQklMSVRZLCBPUiBUT1JUCisjIChJTkNMVURJTkcgTkVH
TElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRQor
IyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9G
IFNVQ0ggREFNQUdFLgorCitmcm9tIHdlYmtpdHB5LnRvb2wuc3RlcHMuYWJzdHJhY3RzdGVwIGlt
cG9ydCBBYnN0cmFjdFN0ZXAKK2Zyb20gd2Via2l0cHkudG9vbC5zdGVwcy5vcHRpb25zIGltcG9y
dCBPcHRpb25zCitpbXBvcnQgcmUKKworCitjbGFzcyBBZGRXS0JJKEFic3RyYWN0U3RlcCk6Cisg
ICAgQGNsYXNzbWV0aG9kCisgICAgZGVmIG9wdGlvbnMoY2xzKToKKyAgICAgICAgcmV0dXJuIEFi
c3RyYWN0U3RlcC5vcHRpb25zKCkgKyBbCisgICAgICAgICAgICBPcHRpb25zLmRlc2NyaXB0aW9u
LAorICAgICAgICAgICAgT3B0aW9ucy5jb21tZW50LAorICAgICAgICAgICAgT3B0aW9ucy5yZXZp
ZXcsCisgICAgICAgICAgICBPcHRpb25zLnJlcXVlc3RfY29tbWl0LAorICAgICAgICAgICAgT3B0
aW9ucy5vcGVuX2J1ZywKKyAgICAgICAgICAgIE9wdGlvbnMuZXdzLAorICAgICAgICBdCisKKyAg
ICBkZWYgR2V0UmFkYXJMaW5rRnJvbURpZmYoc2VsZiwgZGlmZik6CisgICAgICAgIG1hdGNoZXIg
PSByZS5jb21waWxlKHInKDw/cmRhcjpcL1wvcHJvYmxlbXM/XC8pPyg/UDxyYWRhcl9pZD4tP1xk
ezcsfSk+PycpCisgICAgICAgIG1hdGNoID0gbWF0Y2hlci5zZWFyY2goZGlmZikKKworICAgICAg
ICBpZiBub3QgbWF0Y2g6CisgICAgICAgICAgICAgICAgcmV0dXJuIE5vbmUKKworICAgICAgICBp
ZCA9IGludChtYXRjaC5ncm91cCgncmFkYXJfaWQnKSkKKyAgICAgICAgaWYgaWQgPCAwOgorICAg
ICAgICAgICAgcmV0dXJuIE5vbmUKKworICAgICAgICBsaW5rID0gJzxyZGFyOi8vcHJvYmxlbS97
fT4nLmZvcm1hdChpZCkKKyAgICAgICAgcmV0dXJuIGxpbmsKKworICAgIGRlZiBydW4oc2VsZiwg
c3RhdGUpOgorICAgICAgICBkaWZmID0gc2VsZi5jYWNoZWRfbG9va3VwKHN0YXRlLCAiZGlmZiIp
CisgICAgICAgIGJ1Z19pZCA9IHN0YXRlWyJidWdfaWQiXQorICAgICAgICBrZXl3b3JkID0gIklu
UmFkYXIiCisgICAgICAgIHdrYmlfZW1haWwgPSAid2Via2l0LWJ1Zy1pbXBvcnRlckBncm91cC5h
cHBsZS5jb20iCisKKyAgICAgICAgIyBjaGVjayBmb3IgcmFkYXIgbGluayAvIHJlZ2V4CisgICAg
ICAgIGNvbW1lbnQgPSBzZWxmLkdldFJhZGFyTGlua0Zyb21EaWZmKGRpZmYpCisKKyAgICAgICAg
cHJpbnQoImFkZHdrYmkucHk6IGNvbW1lbnQgaXM6IHt9Ii5mb3JtYXQoY29tbWVudCkpCisgICAg
ICAgIGlmIGNvbW1lbnQ6CisgICAgICAgICAgICAjIGFkZCAiSW5SYWRhciIga2V5d29yZAorICAg
ICAgICAgICAgc2VsZi5fdG9vbC5idWdzLmFkZF9rZXl3b3JkX3RvX2J1ZyhidWdfaWQsIGtleXdv
cmQpCisgICAgICAgICAgICAjIGFkZCByYWRhciBsaW5rIGFzIGNvbW1lbnQKKyAgICAgICAgICAg
IHNlbGYuX3Rvb2wuYnVncy5wb3N0X2NvbW1lbnRfdG9fYnVnKGJ1Z19pZCwgY29tbWVudCkKKyAg
ICAgICAgICAgICMgY2Mgd2Via2l0LWJ1Zy1pbXBvcnRlcgorICAgICAgICAgICAgc2VsZi5fdG9v
bC5idWdzLmFkZF9jY190b19idWcoc3RhdGVbJ2J1Z19pZCddLCB3a2JpX2VtYWlsKQoKUHJvcGVy
dHkgY2hhbmdlcyBvbjogVG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2FkZHdrYmku
cHkKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fXwpBZGRlZDogc3ZuOmV4ZWN1dGFibGUKIyMgLTAsMCArMSAjIworKgpcIE5v
IG5ld2xpbmUgYXQgZW5kIG9mIHByb3BlcnR5Cg==
</data>
<flag name="review"
          id="364005"
          type_id="1"
          status="-"
          setter="dbates"
    />
          </attachment>
      

    </bug>

</bugzilla>