188179 2018-07-30 13:40:57 -0700 Clarify conversion rules for JSValue property access API 2018-07-30 14:28:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 keith_miller keith_miller commit-queue ews-watchlist ggaren mark.lam msaboff saam webkit-bug-importer oldest_to_newest 1446340 0 keith_miller 2018-07-30 13:40:57 -0700 Clarify conversion rules for JSValue property access API 1446341 1 346096 keith_miller 2018-07-30 13:41:21 -0700 Created attachment 346096 Patch 1446348 2 346096 ggaren 2018-07-30 14:00:24 -0700 Comment on attachment 346096 Patch r=me 1446354 3 346096 commit-queue 2018-07-30 14:27:50 -0700 Comment on attachment 346096 Patch Clearing flags on attachment: 346096 Committed r234383: <https://trac.webkit.org/changeset/234383> 1446355 4 commit-queue 2018-07-30 14:27:51 -0700 All reviewed patches have been landed. Closing bug. 1446356 5 webkit-bug-importer 2018-07-30 14:28:21 -0700 <rdar://problem/42746953> 346096 2018-07-30 13:41:21 -0700 2018-07-30 14:27:50 -0700 Patch bug-188179-20180730134120.patch text/plain 5775 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl OTcyZjAyMDAyY2RhMDhjMjM0MjUxYzMzYzY4MDQxNzhhYjdjYThhLi4wNGM4ODRiYjJjNzBjNTUx OGI2ZDhiYmJjZDg5MTllNThkYmFmNWExIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAxOC0wNy0zMCAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBDbGFyaWZ5IGNvbnZlcnNpb24gcnVsZXMgZm9yIEpTVmFsdWUgcHJv cGVydHkgYWNjZXNzIEFQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTg4MTc5CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgKiBBUEkvSlNWYWx1ZS5oOgorCiAyMDE4LTA3LTMwICBLZWl0aCBNaWxsZXIgIDxr ZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJlbmFtZSBzb21lIEpTQyBBUEkgZnVu Y3Rpb25zL3R5cGVzLgpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU1Zh bHVlLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmFsdWUuaAppbmRleCAyYzIwM2Zi MTczYzgyNmI0NmI0NzUxZmVlNzc0MGM1YTRkYzZlODhmLi41NTJkNDcwY2FlNzExM2Y5ODg2YWQ4 MWM1NDAxYmU1OTkxZTE2Y2UwIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJ L0pTVmFsdWUuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvQVBJL0pTVmFsdWUuaApAQCAt MzI2LDE0ICszMjYsMTQgQEAgdHlwZWRlZiBpZCBKU1ZhbHVlUHJvcGVydHk7CiBAYWJzdHJhY3Qg QWNjZXNzIGEgcHJvcGVydHkgb2YgYSBKU1ZhbHVlLgogQHJlc3VsdCBUaGUgSlNWYWx1ZSBmb3Ig dGhlIHJlcXVlc3RlZCBwcm9wZXJ0eSBvciB0aGUgSlNWYWx1ZSA8Y29kZT51bmRlZmluZWQ8L2Nv ZGU+IAogIGlmIHRoZSBwcm9wZXJ0eSBkb2VzIG5vdCBleGlzdC4KLUBkaXNjdXNzaW9uIENvcnJl c3BvbmRzIHRvIHRoZSBKYXZhU2NyaXB0IG9wZXJhdGlvbiA8Y29kZT5vYmplY3RbcHJvcGVydHld PC9jb2RlPi4gUGFzcyBhbiBOU1N0cmluZyAqIHRvIGFjY2VzcyBhIG5hbWVkIHByb3BlcnR5LiBP dGhlciB2YWxpZCBwcm9wZXJ0aWVzIGluY2x1ZGUgc3ltYm9scywgbnVtYmVycywgYW5kIHN0cmlu Z2lmaWFibGUgb2JqZWN0cy4gSW4gbWFjT1MgMTAuMTMgYW5kIGlPUyAxMSBhbmQgYmVsb3csICdw cm9wZXJ0eScgd2FzIGFuIE5TU3RyaW5nICouCitAZGlzY3Vzc2lvbiBDb3JyZXNwb25kcyB0byB0 aGUgSmF2YVNjcmlwdCBvcGVyYXRpb24gPGNvZGU+b2JqZWN0W3Byb3BlcnR5XTwvY29kZT4uIEFm dGVyIG1hY09TIFRCQSBhbmQgaU9TIFRCQSwgJ3Byb3BlcnR5JyBjYW4gYmUgYW55ICdpZCcgYW5k IHdpbGwgYmUgY29udmVydGVkIHRvIGEgSlNWYWx1ZSB1c2luZyB0aGUgY29udmVyc2lvbiBydWxl cyBvZiA8Y29kZT52YWx1ZVdpdGhPYmplY3Q6aW5Db250ZXh0OjwvY29kZT4uIFByaW9yIHRvIG1h Y09TIFRCQSBhbmQgaU9TIFRCQSwgJ3Byb3BlcnR5JyB3YXMgZXhwZWN0ZWQgdG8gYmUgYW4gTlNT dHJpbmcgKi4KICovCiAtIChKU1ZhbHVlICopdmFsdWVGb3JQcm9wZXJ0eTooSlNWYWx1ZVByb3Bl cnR5KXByb3BlcnR5OwogCiAvKiEKIEBtZXRob2QKIEBhYnN0cmFjdCBTZXQgYSBwcm9wZXJ0eSBv biBhIEpTVmFsdWUuCi1AZGlzY3Vzc2lvbiBDb3JyZXNwb25kcyB0byB0aGUgSmF2YVNjcmlwdCBv cGVyYXRpb24gPGNvZGU+b2JqZWN0W3Byb3BlcnR5XSA9IHZhbHVlPC9jb2RlPi4gUGFzcyBhbiBO U1N0cmluZyAqIHRvIGFjY2VzcyBhIG5hbWVkIHByb3BlcnR5LiBPdGhlciB2YWxpZCBwcm9wZXJ0 aWVzIGluY2x1ZGUgc3ltYm9scywgbnVtYmVycywgYW5kIHN0cmluZ2lmaWFibGUgb2JqZWN0cy4g SW4gbWFjT1MgMTAuMTMgYW5kIGlPUyAxMSBhbmQgYmVsb3csICdwcm9wZXJ0eScgd2FzIGFuIE5T U3RyaW5nICouCitAZGlzY3Vzc2lvbiBDb3JyZXNwb25kcyB0byB0aGUgSmF2YVNjcmlwdCBvcGVy YXRpb24gPGNvZGU+b2JqZWN0W3Byb3BlcnR5XSA9IHZhbHVlPC9jb2RlPi4gQWZ0ZXIgbWFjT1Mg VEJBIGFuZCBpT1MgVEJBLCAncHJvcGVydHknIGNhbiBiZSBhbnkgJ2lkJyBhbmQgd2lsbCBiZSBj b252ZXJ0ZWQgdG8gYSBKU1ZhbHVlIHVzaW5nIHRoZSBjb252ZXJzaW9uIHJ1bGVzIG9mIDxjb2Rl PnZhbHVlV2l0aE9iamVjdDppbkNvbnRleHQ6PC9jb2RlPi4gUHJpb3IgdG8gbWFjT1MgVEJBIGFu ZCBpT1MgVEJBLCAncHJvcGVydHknIHdhcyBleHBlY3RlZCB0byBiZSBhbiBOU1N0cmluZyAqLgog Ki8KIC0gKHZvaWQpc2V0VmFsdWU6KGlkKXZhbHVlIGZvclByb3BlcnR5OihKU1ZhbHVlUHJvcGVy dHkpcHJvcGVydHk7CiAKQEAgLTM0MSw3ICszNDEsNyBAQCB0eXBlZGVmIGlkIEpTVmFsdWVQcm9w ZXJ0eTsKIEBtZXRob2QKIEBhYnN0cmFjdCBEZWxldGUgYSBwcm9wZXJ0eSBmcm9tIGEgSlNWYWx1 ZS4KIEByZXN1bHQgWUVTIGlmIGRlbGV0aW9uIGlzIHN1Y2Nlc3NmdWwsIE5PIG90aGVyd2lzZS4K LUBkaXNjdXNzaW9uIENvcnJlc3BvbmRzIHRvIHRoZSBKYXZhU2NyaXB0IG9wZXJhdGlvbiA8Y29k ZT5kZWxldGUgb2JqZWN0W3Byb3BlcnR5XTwvY29kZT4uIFBhc3MgYW4gTlNTdHJpbmcgKiB0byBh Y2Nlc3MgYSBuYW1lZCBwcm9wZXJ0eS4gT3RoZXIgdmFsaWQgcHJvcGVydGllcyBpbmNsdWRlIHN5 bWJvbHMsIG51bWJlcnMsIGFuZCBzdHJpbmdpZmlhYmxlIG9iamVjdHMuIEluIG1hY09TIDEwLjEz IGFuZCBpT1MgMTEgYW5kIGJlbG93LCAncHJvcGVydHknIHdhcyBhbiBOU1N0cmluZyAqLgorQGRp c2N1c3Npb24gQ29ycmVzcG9uZHMgdG8gdGhlIEphdmFTY3JpcHQgb3BlcmF0aW9uIDxjb2RlPmRl bGV0ZSBvYmplY3RbcHJvcGVydHldPC9jb2RlPi4gQWZ0ZXIgbWFjT1MgVEJBIGFuZCBpT1MgVEJB LCAncHJvcGVydHknIGNhbiBiZSBhbnkgJ2lkJyBhbmQgd2lsbCBiZSBjb252ZXJ0ZWQgdG8gYSBK U1ZhbHVlIHVzaW5nIHRoZSBjb252ZXJzaW9uIHJ1bGVzIG9mIDxjb2RlPnZhbHVlV2l0aE9iamVj dDppbkNvbnRleHQ6PC9jb2RlPi4gUHJpb3IgdG8gbWFjT1MgVEJBIGFuZCBpT1MgVEJBLCAncHJv cGVydHknIHdhcyBleHBlY3RlZCB0byBiZSBhbiBOU1N0cmluZyAqLgogKi8KIC0gKEJPT0wpZGVs ZXRlUHJvcGVydHk6KEpTVmFsdWVQcm9wZXJ0eSlwcm9wZXJ0eTsKIApAQCAtMzUwLDcgKzM1MCw3 IEBAIHR5cGVkZWYgaWQgSlNWYWx1ZVByb3BlcnR5OwogQGFic3RyYWN0IENoZWNrIGlmIGEgSlNW YWx1ZSBoYXMgYSBwcm9wZXJ0eS4KIEBkaXNjdXNzaW9uIFRoaXMgbWV0aG9kIGhhcyB0aGUgc2Ft ZSBmdW5jdGlvbiBhcyB0aGUgSmF2YVNjcmlwdCBvcGVyYXRvciA8Y29kZT5pbjwvY29kZT4uCiBA cmVzdWx0IFJldHVybnMgWUVTIGlmIHByb3BlcnR5IGlzIHByZXNlbnQgb24gdGhlIHZhbHVlLgot QGRpc2N1c3Npb24gQ29ycmVzcG9uZHMgdG8gdGhlIEphdmFTY3JpcHQgb3BlcmF0aW9uIDxjb2Rl PnByb3BlcnR5IGluIG9iamVjdDwvY29kZT4uIFBhc3MgYW4gTlNTdHJpbmcgKiB0byBhY2Nlc3Mg YSBuYW1lZCBwcm9wZXJ0eS4gT3RoZXIgdmFsaWQgcHJvcGVydGllcyBpbmNsdWRlIHN5bWJvbHMs IG51bWJlcnMsIGFuZCBzdHJpbmdpZmlhYmxlIG9iamVjdHMuIEluIG1hY09TIDEwLjEzIGFuZCBp T1MgMTEgYW5kIGJlbG93LCAncHJvcGVydHknIHdhcyBhbiBOU1N0cmluZyAqLgorQGRpc2N1c3Np b24gQ29ycmVzcG9uZHMgdG8gdGhlIEphdmFTY3JpcHQgb3BlcmF0aW9uIDxjb2RlPnByb3BlcnR5 IGluIG9iamVjdDwvY29kZT4uIEFmdGVyIG1hY09TIFRCQSBhbmQgaU9TIFRCQSwgJ3Byb3BlcnR5 JyBjYW4gYmUgYW55ICdpZCcgYW5kIHdpbGwgYmUgY29udmVydGVkIHRvIGEgSlNWYWx1ZSB1c2lu ZyB0aGUgY29udmVyc2lvbiBydWxlcyBvZiA8Y29kZT52YWx1ZVdpdGhPYmplY3Q6aW5Db250ZXh0 OjwvY29kZT4uIFByaW9yIHRvIG1hY09TIFRCQSBhbmQgaU9TIFRCQSwgJ3Byb3BlcnR5JyB3YXMg ZXhwZWN0ZWQgdG8gYmUgYW4gTlNTdHJpbmcgKi4KICovCiAtIChCT09MKWhhc1Byb3BlcnR5OihK U1ZhbHVlUHJvcGVydHkpcHJvcGVydHk7CiAKQEAgLTM1OCw4ICszNTgsNyBAQCB0eXBlZGVmIGlk IEpTVmFsdWVQcm9wZXJ0eTsKIEBtZXRob2QKIEBhYnN0cmFjdCBEZWZpbmUgcHJvcGVydGllcyB3 aXRoIGN1c3RvbSBkZXNjcmlwdG9ycyBvbiBKU1ZhbHVlcy4KIEBkaXNjdXNzaW9uIFRoaXMgbWV0 aG9kIG1heSBiZSB1c2VkIHRvIGNyZWF0ZSBhIGRhdGEgb3IgYWNjZXNzb3IgcHJvcGVydHkgb24g YW4gb2JqZWN0LgotIFRoaXMgbWV0aG9kIG9wZXJhdGVzIGluIGFjY29yZGFuY2Ugd2l0aCB0aGUg T2JqZWN0LmRlZmluZVByb3BlcnR5IG1ldGhvZCBpbiB0aGUgCi0gSmF2YVNjcmlwdCBsYW5ndWFn ZS4gUGFzcyBhbiBOU1N0cmluZyAqIHRvIGFjY2VzcyBhIG5hbWVkIHByb3BlcnR5LiBPdGhlciB2 YWxpZCBwcm9wZXJ0aWVzIGluY2x1ZGUgc3ltYm9scywgbnVtYmVycywgYW5kIHN0cmluZ2lmaWFi bGUgb2JqZWN0cy4gSW4gbWFjT1MgMTAuMTMgYW5kIGlPUyAxMSBhbmQgYmVsb3csICdwcm9wZXJ0 eScgd2FzIGFuIE5TU3RyaW5nICouCisgVGhpcyBtZXRob2Qgb3BlcmF0ZXMgaW4gYWNjb3JkYW5j ZSB3aXRoIHRoZSBPYmplY3QuZGVmaW5lUHJvcGVydHkgbWV0aG9kIGluIHRoZSBKYXZhU2NyaXB0 IGxhbmd1YWdlLiBBZnRlciBtYWNPUyBUQkEgYW5kIGlPUyBUQkEsICdwcm9wZXJ0eScgY2FuIGJl IGFueSAnaWQnIGFuZCB3aWxsIGJlIGNvbnZlcnRlZCB0byBhIEpTVmFsdWUgdXNpbmcgdGhlIGNv bnZlcnNpb24gcnVsZXMgb2YgPGNvZGU+dmFsdWVXaXRoT2JqZWN0OmluQ29udGV4dDo8L2NvZGU+ LiBQcmlvciB0byBtYWNPUyBUQkEgYW5kIGlPUyBUQkEsICdwcm9wZXJ0eScgd2FzIGV4cGVjdGVk IHRvIGJlIGFuIE5TU3RyaW5nICouCiAqLwogLSAodm9pZClkZWZpbmVQcm9wZXJ0eTooSlNWYWx1 ZVByb3BlcnR5KXByb3BlcnR5IGRlc2NyaXB0b3I6KGlkKWRlc2NyaXB0b3I7CiAKQEAgLTU5NSw4 ICs1OTQsOCBAQCBDcmVhdGUgYSBKU1ZhbHVlIGZyb20gYSBDR1JlY3QuCiBAL3RleHRibG9jawog CiAgQW4gb2JqZWN0IGtleSBwYXNzZWQgYXMgYSBzdWJzY3JpcHQgd2lsbCBiZSBjb252ZXJ0ZWQg dG8gYSBKYXZhU2NyaXB0IHZhbHVlLAotIGFuZCB0aGVuIHRoZSB2YWx1ZSBjb252ZXJ0ZWQgdG8g YSBzdHJpbmcgdXNlZCBhcyBhIHByb3BlcnR5IG5hbWUuIEluIG1hY09TCi0gMTAuMTMgYW5kIGlP UyAxMSBhbmQgYmVsb3csIHRoZSA8Y29kZT5rZXk8L2NvZGU+IGFyZ3VtZW50IG9mCisgYW5kIHRo ZW4gdGhlIHZhbHVlIHVzaW5nIHRoZSBzYW1lIHJ1bGVzIGFzIDxjb2RlPnZhbHVlV2l0aE9iamVj dDppbkNvbnRleHQ6PC9jb2RlPi4gSW4gbWFjT1MKKyBUQkEgYW5kIGlPUyBUQkEgYW5kIGJlbG93 LCB0aGUgPGNvZGU+a2V5PC9jb2RlPiBhcmd1bWVudCBvZgogIDxjb2RlPnNldE9iamVjdDpvYmpl Y3QgZm9yS2V5ZWRTdWJzY3JpcHQ6a2V5PC9jb2RlPiB3YXMgcmVzdHJpY3RlZCB0byBhbgogIDxj b2RlPk5TU3RyaW5nIDxOU0NvcHlpbmc+ICo8L2NvZGU+IGJ1dCB0aGF0IHJlc3RyaWN0aW9uIHdh cyBuZXZlciB1c2VkLgogKi8K