188177 2018-07-30 12:18:01 -0700 Add missing CoreGraphics SPI 2018-07-30 13:39:22 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 hi hi cdumez commit-queue joepeck pvollan webkit-bug-importer oldest_to_newest 1446300 0 hi 2018-07-30 12:18:01 -0700 From error when building: > Source/WebKit/WebProcess/cocoa/WebProcessCocoa.mm:319:5: error: use of undeclared identifier 'CGSSetDenyWindowServerConnections' 1446301 1 346082 hi 2018-07-30 12:20:27 -0700 Created attachment 346082 Patch 1446305 2 346082 joepeck 2018-07-30 12:24:22 -0700 Comment on attachment 346082 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346082&action=review r=me > Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:305 > +#if ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) You could probably drop the `ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)` if/endifs. This SPI exists on Mac, regardless of whether or not we decide to use it based on this feature. 1446308 3 346082 hi 2018-07-30 12:34:18 -0700 Comment on attachment 346082 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346082&action=review >> Source/WebCore/PAL/pal/spi/cg/CoreGraphicsSPI.h:305 >> +#if ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING) > > You could probably drop the `ENABLE(WEBPROCESS_WINDOWSERVER_BLOCKING)` if/endifs. This SPI exists on Mac, regardless of whether or not we decide to use it based on this feature. I did this to follow it's usage in WebProcessCocoa.mm. I built it once without it and there was no issue, but I figured it couldn't hurt to match. 1446335 4 346082 commit-queue 2018-07-30 13:38:27 -0700 Comment on attachment 346082 Patch Clearing flags on attachment: 346082 Committed r234382: <https://trac.webkit.org/changeset/234382> 1446336 5 commit-queue 2018-07-30 13:38:28 -0700 All reviewed patches have been landed. Closing bug. 1446337 6 webkit-bug-importer 2018-07-30 13:39:22 -0700 <rdar://problem/42744931> 346082 2018-07-30 12:20:27 -0700 2018-07-30 13:38:27 -0700 Patch bug-188177-20180730122026.patch text/plain 2432 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29y ZS9QQUwvQ2hhbmdlTG9nCmluZGV4IGZkYTU3NzVlNjllNDc5YTMyMDdjMGNmYzg4MTg2ZjIyN2Nk Y2VjMDcuLjU3Mzc2MjJiNTg0ZDRlNzI4ODAzNTM1MmI4YjNlYjlkZTJiZjQwOWUgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvUEFM L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE4LTA3LTMwICBEZXZpbiBSb3Vzc28gIDx3 ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCisgICAgICAgIEFkZCBtaXNzaW5nIENvcmVHcmFwaGlj cyBTUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4 ODE3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog cGFsL3NwaS9jZy9Db3JlR3JhcGhpY3NTUEkuaDoKKwogMjAxOC0wNy0yNiAgQW5keSBWYW5XYWdv bmVyICA8YW5keUB2YW53YWdvbmVyLmZhbWlseT4KIAogICAgICAgICBbSU5UTF0gUmVtb3ZlIElO VEwgc3ViLWZlYXR1cmUgY29tcGlsZSBmbGFncwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCA4YjQ3N2M1YWRiZjg1YmU1 YmRmMzdmMjQ2MzcwOGY5NjcwMGIyYWZkLi43Y2FjMDEwOGZkOGMzM2JlODEyMDYxODhlNmYzZjRk ZWQxNTU3Y2E5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE4LTA3LTMwICBEZXZpbiBS b3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCisgICAgICAgIEFkZCBtaXNzaW5nIENv cmVHcmFwaGljcyBTUEkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4ODE3NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgICogV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW06CisKIDIwMTgtMDct MzAgIERhdmlkIEZlbnRvbiAgPGRhdmlkX2ZlbnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgVW5y ZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIzNDMyNy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L1BBTC9wYWwvc3BpL2NnL0NvcmVHcmFwaGljc1NQSS5oIGIvU291cmNlL1dlYkNvcmUvUEFML3Bh bC9zcGkvY2cvQ29yZUdyYXBoaWNzU1BJLmgKaW5kZXggZjE2Nzc2NDQyMDg4MDFhOTkzNGM2ZGM5 MDlmZjc5MGUzNmJjNzFjMy4uZTg5N2M2YmMyOTVkNGU0NGY1NTllMTYwYTZhZjgyOTE5ZWRhNjIx OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY2cvQ29yZUdyYXBoaWNz U1BJLmgKKysrIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkvY2cvQ29yZUdyYXBoaWNzU1BJ LmgKQEAgLTMwMiw2ICszMDIsMTAgQEAgYm9vbCBDb2xvclN5bmNQcm9maWxlSXNXaWRlR2FtdXQo Q29sb3JTeW5jUHJvZmlsZVJlZik7CiBzaXplX3QgQ0dEaXNwbGF5TW9kZUdldFBpeGVsc1dpZGUo Q0dEaXNwbGF5TW9kZVJlZik7CiBzaXplX3QgQ0dEaXNwbGF5TW9kZUdldFBpeGVsc0hpZ2goQ0dE aXNwbGF5TW9kZVJlZik7CiAKKyNpZiBFTkFCTEUoV0VCUFJPQ0VTU19XSU5ET1dTRVJWRVJfQkxP Q0tJTkcpCitDR0Vycm9yIENHU1NldERlbnlXaW5kb3dTZXJ2ZXJDb25uZWN0aW9ucyhib29sKTsK KyNlbmRpZiAvLyBFTkFCTEUoV0VCUFJPQ0VTU19XSU5ET1dTRVJWRVJfQkxPQ0tJTkcpCisKICNl bmRpZgogCiBXVEZfRVhURVJOX0NfRU5ECmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlBy b2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0NvY29hLm1tIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNz L2NvY29hL1dlYlByb2Nlc3NDb2NvYS5tbQppbmRleCA3Y2RmMjg3MWQ0OGIxZDM2Y2ZiYzBiYTQ5 YTAwMzRhNjBhMmM0M2E2Li4wMTAzNTVmZjVmNmM4NGY0MTEwYjZlNjc1M2E0NzNhMjBlMmM0NzE5 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvY29jb2EvV2ViUHJvY2Vzc0Nv Y29hLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29j b2EubW0KQEAgLTY0LDYgKzY0LDcgQEAKICNpbXBvcnQgPGFsZ29yaXRobT4KICNpbXBvcnQgPGRp c3BhdGNoL2Rpc3BhdGNoLmg+CiAjaW1wb3J0IDxvYmpjL3J1bnRpbWUuaD4KKyNpbXBvcnQgPHBh bC9zcGkvY2cvQ29yZUdyYXBoaWNzU1BJLmg+CiAjaW1wb3J0IDxwYWwvc3BpL2NvY29hL0xhdW5j aFNlcnZpY2VzU1BJLmg+CiAjaW1wb3J0IDxwYWwvc3BpL2NvY29hL1F1YXJ0ekNvcmVTUEkuaD4K ICNpbXBvcnQgPHBhbC9zcGkvY29jb2EvcHRocmVhZFNQSS5oPgo=