188171 2018-07-30 10:15:46 -0700 [macOS] All WindowServer connections should be closed before denying WindowServer access. 2019-09-03 08:14:32 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified NEW P2 Normal --- 1 pvollan pvollan ajuma bfulgham darin oldest_to_newest 1446248 0 pvollan 2018-07-30 10:15:46 -0700 All WindowServer connections in the WebContent process should be closed before denying access to the WindowServer, otherwise calling CGSSetDenyWindowServerConnections(true) will fail. Currently, there are no open WindowServer connections at this point, but this might change in the future. We should call CGSShutdownServerConnections() before calling CGSSetDenyWindowServerConnections(true) to make sure WindowServer connections are always successfully denied. Thanks to Alex Gaynor at Mozilla (agaynor@mozilla.com) for identifying this issue. 1446250 1 346066 pvollan 2018-07-30 10:19:20 -0700 Created attachment 346066 Patch 1447638 2 pvollan 2018-08-03 08:49:17 -0700 Thanks for reviewing! 1567386 3 ajuma 2019-09-03 08:14:32 -0700 Just wondering if you're still planning on landing this patch, and if this might prevent error output like the following: FAILED TO establish the default connection to the WindowServer, _CGSDefaultConnection() is NULL 346066 2018-07-30 10:19:20 -0700 2018-07-30 19:34:47 -0700 Patch bug-188171-20180730101920.patch text/plain 2362 pvollan SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzQzNzMpCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA3LTMwICBQZXIgQXJuZSBW b2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBbbWFjT1NdIEFsbCBXaW5kb3dT ZXJ2ZXIgY29ubmVjdGlvbnMgc2hvdWxkIGJlIGNsb3NlZCBiZWZvcmUgZGVueWluZyBXaW5kb3dT ZXJ2ZXIgYWNjZXNzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTg4MTcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWxsIFdpbmRvd1NlcnZlciBjb25uZWN0aW9ucyBpbiB0aGUgV2ViQ29udGVudCBwcm9j ZXNzIHNob3VsZCBiZSBjbG9zZWQgYmVmb3JlIGRlbnlpbmcgYWNjZXNzIHRvIHRoZSBXaW5kb3dT ZXJ2ZXIsCisgICAgICAgIG90aGVyd2lzZSBjYWxsaW5nIENHU1NldERlbnlXaW5kb3dTZXJ2ZXJD b25uZWN0aW9ucyh0cnVlKSB3aWxsIGZhaWwuIEN1cnJlbnRseSwgdGhlcmUgYXJlIG5vIG9wZW4g V2luZG93U2VydmVyCisgICAgICAgIGNvbm5lY3Rpb25zIGF0IHRoaXMgcG9pbnQsIGJ1dCB0aGlz IG1pZ2h0IGNoYW5nZSBpbiB0aGUgZnV0dXJlLiBXZSBzaG91bGQgY2FsbCBDR1NTaHV0ZG93blNl cnZlckNvbm5lY3Rpb25zKCkKKyAgICAgICAgYmVmb3JlIGNhbGxpbmcgQ0dTU2V0RGVueVdpbmRv d1NlcnZlckNvbm5lY3Rpb25zKHRydWUpIHRvIG1ha2Ugc3VyZSBXaW5kb3dTZXJ2ZXIgY29ubmVj dGlvbnMgYXJlIGFsd2F5cworICAgICAgICBzdWNjZXNzZnVsbHkgZGVuaWVkLiBUaGFua3MgdG8g QWxleCBHYXlub3IgYXQgTW96aWxsYSAoYWdheW5vckBtb3ppbGxhLmNvbSkgZm9yIGlkZW50aWZ5 aW5nIHRoaXMgaXNzdWUuCisKKyAgICAgICAgKiBXZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3ND b2NvYS5tbToKKyAgICAgICAgKFdlYktpdDo6V2ViUHJvY2Vzczo6cGxhdGZvcm1Jbml0aWFsaXpl UHJvY2Vzcyk6CisKIDIwMTgtMDctMzAgIERhdmlkIEZlbnRvbiAgPGRhdmlkX2ZlbnRvbkBhcHBs ZS5jb20+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjIzNDMyNy4KSW5kZXg6 IFNvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb2NvYS9XZWJQcm9jZXNzQ29jb2EubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dlYlByb2Nlc3NDb2NvYS5t bQkocmV2aXNpb24gMjM0MzYyKQorKysgU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvY29hL1dl YlByb2Nlc3NDb2NvYS5tbQkod29ya2luZyBjb3B5KQpAQCAtMzE0LDExICszMTQsMTIgQEAgdm9p ZCBXZWJQcm9jZXNzOjpwbGF0Zm9ybUluaXRpYWxpemVQcm9jZQogewogI2lmIFBMQVRGT1JNKE1B QykKICNpZiBFTkFCTEUoV0VCUFJPQ0VTU19XSU5ET1dTRVJWRVJfQkxPQ0tJTkcpCisgICAgLy8g TWFrZSBzdXJlIHdlIGNsb3NlIGFueSBXaW5kb3dTZXJ2ZXIgY29ubmVjdGlvbnMgYmVmb3JlIHBl cm1hbmVudGx5IGRlbnlpbmcgdGhlbS4KKyAgICBDR1NTaHV0ZG93blNlcnZlckNvbm5lY3Rpb25z KCk7CiAgICAgLy8gRGVueSB0aGUgV2ViQ29udGVudCBwcm9jZXNzIGFjY2VzcyB0byB0aGUgV2lu ZG93U2VydmVyLgogICAgIC8vIFRoaXMgY2FsbCB3aWxsIG5vdCBzdWNjZWVkIGlmIHRoZXJlIGFy ZSBvcGVuIFdpbmRvd1NlcnZlciBjb25uZWN0aW9ucyBhdCB0aGlzIHBvaW50LgotICAgIENHU1Nl dERlbnlXaW5kb3dTZXJ2ZXJDb25uZWN0aW9ucyh0cnVlKTsKLSAgICAvLyBNYWtlIHN1cmUgdGhh dCB3ZSBjbG9zZSBhbnkgV2luZG93U2VydmVyIGNvbm5lY3Rpb25zIGFmdGVyIGNoZWNraW5nIGlu IHdpdGggTGF1bmNoIFNlcnZpY2VzLgotICAgIENHU1NodXRkb3duU2VydmVyQ29ubmVjdGlvbnMo KTsKKyAgICBDR0Vycm9yIGVycm9yID0gQ0dTU2V0RGVueVdpbmRvd1NlcnZlckNvbm5lY3Rpb25z KHRydWUpOworICAgIEFTU0VSVF9VTlVTRUQoZXJyb3IsIGVycm9yID09IGtDR0Vycm9yU3VjY2Vz cyk7CiAjZWxzZQogICAgIGlmICghW05TQXBwIGlzUnVubmluZ10pIHsKICAgICAgICAgLy8gVGhp cyBjYWxsIGlzIG5lZWRlZCB3aGVuIHRoZSBXZWJQcm9jZXNzIGlzIG5vdCBydW5uaW5nIHRoZSBO U0FwcGxpY2F0aW9uIGV2ZW50IGxvb3AuCg==