188160 2018-07-30 02:38:06 -0700 server_process.py should print returncode in debug log if the process crashed 2018-08-01 18:27:12 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 188036 1 fujii fujii annulen commit-queue ddkilzer don.olmstead ews-watchlist glenn jbedard lforschler webkit-bug-importer oldest_to_newest 1446179 0 fujii 2018-07-30 02:38:06 -0700 server_process.py should print returncode in debug log if the process crashed 1446181 1 346056 fujii 2018-07-30 02:41:43 -0700 Created attachment 346056 Patch 1446455 2 fujii 2018-07-30 18:17:31 -0700 Hi Jonathan, could you review this patch. You seems the best person because you did Bug 160943. 1446527 3 346056 annulen 2018-07-31 06:10:05 -0700 Comment on attachment 346056 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346056&action=review > Tools/Scripts/webkitpy/port/server_process.py:326 > + _log.debug('This test marked as a crash because of failure to poll the server process. (returncode %s)' % self._proc.returncode) I think it should say 'This test marked as a crash because of failure to poll the server process (return code was %).' 1446532 4 346056 fujii 2018-07-31 06:19:26 -0700 Comment on attachment 346056 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=346056&action=review Thank you for the review. >> Tools/Scripts/webkitpy/port/server_process.py:326 >> + _log.debug('This test marked as a crash because of failure to poll the server process. (returncode %s)' % self._proc.returncode) > > I think it should say 'This test marked as a crash because of failure to poll the server process (return code was %).' Make sense. Will Fix. 1446533 5 346162 fujii 2018-07-31 06:22:44 -0700 Created attachment 346162 Patch * Addressed the review feedback. 1446600 6 346162 commit-queue 2018-07-31 11:07:38 -0700 Comment on attachment 346162 Patch Clearing flags on attachment: 346162 Committed r234430: <https://trac.webkit.org/changeset/234430> 1446601 7 commit-queue 2018-07-31 11:07:39 -0700 All reviewed patches have been landed. Closing bug. 1446603 8 webkit-bug-importer 2018-07-31 11:12:12 -0700 <rdar://problem/42779206> 1446892 9 jbedard 2018-08-01 09:40:27 -0700 I think this is/was a good idea, but I want to make sure that you're aware of a notable limitation: If we're controlling a device (iOS Simulator is the most notable example of this) we don't have a 'real' Popen object and can't determine what the actual return code is, in which case we will assign a returncode of 1. 1447100 10 fujii 2018-08-01 18:27:12 -0700 Thank you for the feedback. I didn't know that. I will check it. 346056 2018-07-30 02:41:43 -0700 2018-07-31 06:26:51 -0700 Patch bug-188160-20180730184142.patch text/plain 1552 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MzYwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODZkNDQ5MDIxYmZiYjFkNGRjZTI1ZGRjZjZiNjk2YTNm ZmE1ODMwMy4uZjU5MWVkNjIwNWUyNmNjMjk0MTI5NzlmZDkyOGQ3ZGFjNTc0Mzg4ZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTA3LTMwICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIHNlcnZlcl9wcm9jZXNzLnB5IHNob3VsZCBwcmludCByZXR1cm5jb2RlIGlu IGRlYnVnIGxvZyBpZiB0aGUgcHJvY2VzcyBjcmFzaGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODgxNjAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9zZXJ2ZXJf cHJvY2Vzcy5weToKKyAgICAgICAgKFNlcnZlclByb2Nlc3MuaGFzX2NyYXNoZWQpOiBQdXQgc2Vs Zi5fcHJvYy5yZXR1cm5jb2RlIGludG8gdGhlIGRlYnVnIGxvZyBtZXNzYWdlLgorCiAyMDE4LTA3 LTI3ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAg ICBVbnJldmlld2VkLCBmaXggdHlwbyBpbiB0ZXN0IGV4cGVjdGF0aW9ucyBhbmQgbWFyayBhbm90 aGVyIHRlc3QgYXMgdGltaW5nIG91dApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw eS9wb3J0L3NlcnZlcl9wcm9jZXNzLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3Nl cnZlcl9wcm9jZXNzLnB5CmluZGV4IDFhMzkyNDJkOTE4MDYwYWVjY2ZlMDQ5ZmJhNTkwODViZmVk NWNiYzQuLjQxODg3NTQ3ODJlMDYyY2I3OTQzMWU5MDY5NzRjMGU5OTE4ZDhiNWMgMTAwNjQ0Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vzcy5weQorKysgYi9U b29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2VydmVyX3Byb2Nlc3MucHkKQEAgLTMyMyw3ICsz MjMsNyBAQCBjbGFzcyBTZXJ2ZXJQcm9jZXNzKG9iamVjdCk6CiAKICAgICBkZWYgaGFzX2NyYXNo ZWQoc2VsZik6CiAgICAgICAgIGlmIG5vdCBzZWxmLl9jcmFzaGVkIGFuZCBzZWxmLnBvbGwoKToK LSAgICAgICAgICAgIF9sb2cuZGVidWcoJ1RoaXMgdGVzdCBtYXJrZWQgYXMgYSBjcmFzaCBiZWNh dXNlIG9mIGZhaWx1cmUgdG8gcG9sbCB0aGUgc2VydmVyIHByb2Nlc3MuJykKKyAgICAgICAgICAg IF9sb2cuZGVidWcoJ1RoaXMgdGVzdCBtYXJrZWQgYXMgYSBjcmFzaCBiZWNhdXNlIG9mIGZhaWx1 cmUgdG8gcG9sbCB0aGUgc2VydmVyIHByb2Nlc3MuIChyZXR1cm5jb2RlICVzKScgJSBzZWxmLl9w cm9jLnJldHVybmNvZGUpCiAgICAgICAgICAgICBzZWxmLl9jcmFzaGVkID0gVHJ1ZQogICAgICAg ICAgICAgc2VsZi5faGFuZGxlX3Bvc3NpYmxlX2ludGVycnVwdCgpCiAgICAgICAgIHJldHVybiBz ZWxmLl9jcmFzaGVkCg== 346162 2018-07-31 06:22:44 -0700 2018-07-31 11:07:38 -0700 Patch bug-188160-20180731222243.patch text/plain 1517 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0NDIyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDdhZWI5MjU5NGQ5ZDU1ZDU1OTYzN2QwMjJhMDVkMjUx Yjg1MjE5Zi4uZTRjZTIzMjM2OTA0OTY4YThiODQ0OWM2YjA0YTliMzJlZTIxNjVmNSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE4LTA3LTMxICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIHNlcnZlcl9wcm9jZXNzLnB5IHNob3VsZCBwcmludCByZXR1cm5jb2RlIGlu IGRlYnVnIGxvZyBpZiB0aGUgcHJvY2VzcyBjcmFzaGVkCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODgxNjAKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvcG9ydC9zZXJ2ZXJf cHJvY2Vzcy5weToKKyAgICAgICAgKFNlcnZlclByb2Nlc3MuaGFzX2NyYXNoZWQpOiBQdXQgc2Vs Zi5fcHJvYy5yZXR1cm5jb2RlIGludG8gdGhlIGRlYnVnIGxvZyBtZXNzYWdlLgorCiAyMDE4LTA3 LTMxICBUb21hcyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CiAKICAgICAgICAgW1dURl0g U3RyaW5nOjpmb3JtYXRXaXRoQXJndW1lbnRzKCkgaXMgdW51c2VkCmRpZmYgLS1naXQgYS9Ub29s cy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvc2VydmVyX3Byb2Nlc3MucHkgYi9Ub29scy9TY3JpcHRz L3dlYmtpdHB5L3BvcnQvc2VydmVyX3Byb2Nlc3MucHkKaW5kZXggMWEzOTI0MmQ5MTgwNjBhZWNj ZmUwNDlmYmE1OTA4NWJmZWQ1Y2JjNC4uNDUzZDFiYTAyNTc5YmI1YTNlZWRjODU2NGI0NzcyYTlk YjA5MDdhOCAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L3NlcnZlcl9w cm9jZXNzLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9zZXJ2ZXJfcHJvY2Vz cy5weQpAQCAtMzIzLDcgKzMyMyw3IEBAIGNsYXNzIFNlcnZlclByb2Nlc3Mob2JqZWN0KToKIAog ICAgIGRlZiBoYXNfY3Jhc2hlZChzZWxmKToKICAgICAgICAgaWYgbm90IHNlbGYuX2NyYXNoZWQg YW5kIHNlbGYucG9sbCgpOgotICAgICAgICAgICAgX2xvZy5kZWJ1ZygnVGhpcyB0ZXN0IG1hcmtl ZCBhcyBhIGNyYXNoIGJlY2F1c2Ugb2YgZmFpbHVyZSB0byBwb2xsIHRoZSBzZXJ2ZXIgcHJvY2Vz cy4nKQorICAgICAgICAgICAgX2xvZy5kZWJ1ZygnVGhpcyB0ZXN0IG1hcmtlZCBhcyBhIGNyYXNo IGJlY2F1c2Ugb2YgZmFpbHVyZSB0byBwb2xsIHRoZSBzZXJ2ZXIgcHJvY2VzcyAocmV0dXJuIGNv ZGUgd2FzICVzKS4nICUgc2VsZi5fcHJvYy5yZXR1cm5jb2RlKQogICAgICAgICAgICAgc2VsZi5f Y3Jhc2hlZCA9IFRydWUKICAgICAgICAgICAgIHNlbGYuX2hhbmRsZV9wb3NzaWJsZV9pbnRlcnJ1 cHQoKQogICAgICAgICByZXR1cm4gc2VsZi5fY3Jhc2hlZAo=