188127 2018-07-27 15:53:44 -0700 [iOS] Don't deactivate audio session 2019-01-07 13:22:23 -0800 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue darin jonlee webkit-bug-importer oldest_to_newest 1445905 0 eric.carlson 2018-07-27 15:53:44 -0700 r233435 includes a change that deactivates the shared audio session when there are no more active media elements. This is a good in WK2 because it allows other applications to resume playing audio when WebKit stops playing, but it is potentially bad in WK1 where the host app may also be playing audio. Remove the code for now. 1445909 1 eric.carlson 2018-07-27 15:55:28 -0700 <rdar://problem/42544143> 1445916 2 345966 eric.carlson 2018-07-27 16:11:21 -0700 Created attachment 345966 Patch 1445936 3 345966 jonlee 2018-07-27 16:57:36 -0700 Comment on attachment 345966 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345966&action=review > Source/WebCore/platform/audio/PlatformMediaSessionManager.cpp:-167 > -#endif Can we write a test for this? 1445943 4 345966 commit-queue 2018-07-27 17:24:09 -0700 Comment on attachment 345966 Patch Clearing flags on attachment: 345966 Committed r234339: <https://trac.webkit.org/changeset/234339> 1445944 5 commit-queue 2018-07-27 17:24:11 -0700 All reviewed patches have been landed. Closing bug. 1446023 6 345966 darin 2018-07-28 15:28:56 -0700 Comment on attachment 345966 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345966&action=review > Source/WebCore/ChangeLog:12 > + r233435 includes a change that deactivates the shared audio session when there are no more > + active media sessions. This is a good in WK2 because it allows other applications to resume > + playing audio when WebKit stops playing, but it is potentially bad in WK1 where the host > + app may also be playing audio. So why didn’t we keep it for WK2? 1446030 7 345966 eric.carlson 2018-07-28 17:12:52 -0700 Comment on attachment 345966 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345966&action=review >> Source/WebCore/ChangeLog:12 >> + app may also be playing audio. > > So why didn’t we keep it for WK2? I filed rdar://42678977 to add it back for WK2, but there are potential issues we need to investigate first (eg. rdar://42672521, rdar://42267132). 1492364 8 eric.carlson 2019-01-07 13:22:23 -0800 (In reply to Eric Carlson from comment #7) > Comment on attachment 345966 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345966&action=review > > >> Source/WebCore/ChangeLog:12 > >> + app may also be playing audio. > > > > So why didn’t we keep it for WK2? > > I filed rdar://42678977 to add it back for WK2, but there are potential > issues we need to investigate first (eg. rdar://42672521, rdar://42267132). Fixed in bug 193188. 345966 2018-07-27 16:11:21 -0700 2018-07-27 17:24:09 -0700 Patch bug-188127-20180727161120.patch text/plain 1955 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MzM2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYWJjYWRiMDE4MDdlMGU4 MWYxZjI0YmRjODIyZmZhYjljMmU1MTExOC4uMGNlMTQyZDVhYTQ3NTQ1NTRkYWFjMGRmZmJiNjZi YjA4ZjdjZDRjOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE4LTA3LTI3ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIERvbid0 IGRlYWN0aXZhdGUgYXVkaW8gc2Vzc2lvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTg4MTI3CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MjU0NDE0 Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAg ICAgIHIyMzM0MzUgaW5jbHVkZXMgYSBjaGFuZ2UgdGhhdCBkZWFjdGl2YXRlcyB0aGUgc2hhcmVk IGF1ZGlvIHNlc3Npb24gd2hlbiB0aGVyZSBhcmUgbm8gbW9yZQorICAgICAgICBhY3RpdmUgbWVk aWEgc2Vzc2lvbnMuIFRoaXMgaXMgYSBnb29kIGluIFdLMiBiZWNhdXNlIGl0IGFsbG93cyBvdGhl ciBhcHBsaWNhdGlvbnMgdG8gcmVzdW1lCisgICAgICAgIHBsYXlpbmcgYXVkaW8gd2hlbiBXZWJL aXQgc3RvcHMgcGxheWluZywgYnV0IGl0IGlzIHBvdGVudGlhbGx5IGJhZCBpbiBXSzEgd2hlcmUg dGhlIGhvc3QKKyAgICAgICAgYXBwIG1heSBhbHNvIGJlIHBsYXlpbmcgYXVkaW8uCisKKyAgICAg ICAgKiBwbGF0Zm9ybS9hdWRpby9QbGF0Zm9ybU1lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6UGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyOjpyZW1vdmVTZXNzaW9u KTogRG9uJ3QgZGVhY3RpdmF0ZSB0aGUgYXVkaW8gc2Vzc2lvbi4KKwogMjAxOC0wNy0yNyAgQ2hy aXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEZpeCB0aHJlYWQtc2FmZXR5 IGlzc3VlcyByZWxhdGVkIHRvIFJlYWx0aW1lTWVkaWFTb3VyY2U6OmF1ZGlvU2FtcGxlc0F2YWls YWJsZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9QbGF0Zm9y bU1lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8v UGxhdGZvcm1NZWRpYVNlc3Npb25NYW5hZ2VyLmNwcAppbmRleCBjYTcyZDQyYTk3NDI0MGRiMWU5 ZjAxOTBhMDQzOWI1YTc5MWEyMGMwLi5mOGM1MzFhN2JjMjRjNmU0MmI2Njc3ZDczYWYxNjRlMDNl MWNmZDA2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9QbGF0Zm9y bU1lZGlhU2Vzc2lvbk1hbmFnZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1 ZGlvL1BsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlci5jcHAKQEAgLTE2Miw5ICsxNjIsNiBAQCB2 b2lkIFBsYXRmb3JtTWVkaWFTZXNzaW9uTWFuYWdlcjo6cmVtb3ZlU2Vzc2lvbihQbGF0Zm9ybU1l ZGlhU2Vzc2lvbiYgc2Vzc2lvbikKICAgICBpZiAobV9zZXNzaW9ucy5pc0VtcHR5KCkgfHwgc3Rk OjphbGxfb2YobV9zZXNzaW9ucy5iZWdpbigpLCBtX3Nlc3Npb25zLmVuZCgpLCBzdGQ6OmxvZ2lj YWxfbm90PHZvaWQ+KCkpKSB7CiAgICAgICAgIG1fcmVtb3RlQ29tbWFuZExpc3RlbmVyID0gbnVs bHB0cjsKICAgICAgICAgbV9hdWRpb0hhcmR3YXJlTGlzdGVuZXIgPSBudWxscHRyOwotI2lmIFVT RShBVURJT19TRVNTSU9OKQotICAgICAgICBBdWRpb1Nlc3Npb246OnNoYXJlZFNlc3Npb24oKS50 cnlUb1NldEFjdGl2ZShmYWxzZSk7Ci0jZW5kaWYKICAgICB9CiAKICAgICBzY2hlZHVsZVVwZGF0 ZVNlc3Npb25TdGF0ZSgpOwo=