188082 2018-07-26 15:27:21 -0700 Web Inspector: REGRESSION (r233824): execution highlight range missing/incorrect in pretty printed code 2018-10-15 14:21:27 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P1 Normal --- 1 mattbaker mattbaker commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1445570 0 345881 mattbaker 2018-07-26 15:27:21 -0700 Created attachment 345881 [Webarchive] reduced test case Summary: Execution highlight range missing/incorrect in pretty printed code. Regressed in http://trac.webkit.org/changeset/233824. Steps to Reproduce: 1. Inspect the attached webarchive 2. View chained-property-stepping-min.js in Debugger tab 3. Enable pretty printing 4. Set breakpoint at line 13 5. Reload page => Paused in debugger Expected: => Expression-level execution highlight: |return 42| Actual: => Expression-level execution highlight missing (whole line is highlighted) 1445572 1 webkit-bug-importer 2018-07-26 15:27:50 -0700 <rdar://problem/42640580> 1468743 2 352246 mattbaker 2018-10-12 17:56:38 -0700 Created attachment 352246 Patch 1469435 3 352246 joepeck 2018-10-15 13:55:59 -0700 Comment on attachment 352246 Patch r=me 1469460 4 352246 commit-queue 2018-10-15 14:21:25 -0700 Comment on attachment 352246 Patch Clearing flags on attachment: 352246 Committed r237145: <https://trac.webkit.org/changeset/237145> 1469461 5 commit-queue 2018-10-15 14:21:27 -0700 All reviewed patches have been landed. Closing bug. 345881 2018-07-26 15:27:21 -0700 2018-07-26 15:27:21 -0700 [Webarchive] reduced test case chained-property-stepping.html.webarchive application/x-webarchive 2552 mattbaker YnBsaXN0MDDSAQIDEV8QD1dlYlN1YnJlc291cmNlc18QD1dlYk1haW5SZXNvdXJjZaIEDdQFBgcI CQoLDF8QE1dlYlJlc291cmNlUmVzcG9uc2VeV2ViUmVzb3VyY2VVUkxfEA9XZWJSZXNvdXJjZURh dGFfEBNXZWJSZXNvdXJjZU1JTUVUeXBlTxEDF2JwbGlzdDAw1AECAwQFBjQ1WCR2ZXJzaW9uWCRv YmplY3RzWSRhcmNoaXZlclQkdG9wEgABhqCrBwgfJSYsFi0uLzBVJG51bGzbCQoLDA0ODxAREhMU FRYXGBkaGxwdHlYkY2xhc3NfEB9fX25zdXJscmVxdWVzdF9wcm90b19wcm9wX29ial82UiQxXxAf X19uc3VybHJlcXVlc3RfcHJvdG9fcHJvcF9vYmpfNF8QH19fbnN1cmxyZXF1ZXN0X3Byb3RvX3By b3Bfb2JqXzNfEB9fX25zdXJscmVxdWVzdF9wcm90b19wcm9wX29ial8yXxAfX19uc3VybHJlcXVl c3RfcHJvdG9fcHJvcF9vYmpfMVIkMl8QH19fbnN1cmxyZXF1ZXN0X3Byb3RvX3Byb3Bfb2JqXzBf EB9fX25zdXJscmVxdWVzdF9wcm90b19wcm9wX29ial81UiQwgAqACRAAgACAB4AGgAUQB4ACgAgQ CNMgCSEXIyRXTlMuYmFzZVtOUy5yZWxhdGl2ZYAAgASAA18QTWZpbGU6Ly8vVXNlcnMvbWF0dGJh a2VyL0Rlc2t0b3AvRGVidWdnZXIlMjB0ZXN0cy9jaGFpbmVkLXByb3BlcnR5LXN0ZXBwaW5nLmpz 0icoKSpaJGNsYXNzbmFtZVgkY2xhc3Nlc1VOU1VSTKIpK1hOU09iamVjdCNBwIU/8Ny44V8QD3Rl eHQvamF2YXNjcmlwdBDDI3/v////////0icoMTJdTlNVUkxSZXNwb25zZaIzK11OU1VSTFJlc3Bv bnNlXxAPTlNLZXllZEFyY2hpdmVy0TY3XxATV2ViUmVzb3VyY2VSZXNwb25zZYABAAgAEQAaACMA LQAyADcAQwBJAGAAZwCJAIwArgDQAPIBFAEXATkBWwFeAWABYgFkAWYBaAFqAWwBbgFwAXIBdAF7 AYMBjwGRAZMBlQHlAeoB9QH+AgQCBwIQAhkCKwItAjYCOwJJAkwCWgJsAm8ChQAAAAAAAAIBAAAA AAAAADgAAAAAAAAAAAAAAAAAAAKHXxBNZmlsZTovLy9Vc2Vycy9tYXR0YmFrZXIvRGVza3RvcC9E ZWJ1Z2dlciUyMHRlc3RzL2NoYWluZWQtcHJvcGVydHktc3RlcHBpbmcuanNPEMMoKCkgPT4gewpj bGFzcyBGb28gewogICAgZ2V0IHgoKQogICAgewogICAgICAgIHJldHVybiB0aGlzOwogICAgfQoK ICAgIGdldCB5KCkKICAgIHsKICAgICAgICByZXR1cm4gdGhpczsKICAgIH0KCiAgICBnZXQgeigp CiAgICB7CiAgICAgICAgcmV0dXJuIDQyOwogICAgfQp9CgpsZXQgZm9vID0gbmV3IEZvbzsKZm9v LngueS56Owp9KSgpOwpfEA90ZXh0L2phdmFzY3JpcHTUBQYHCA4PEAxPEQMbYnBsaXN0MDDUAQID BAUGNDVYJHZlcnNpb25YJG9iamVjdHNZJGFyY2hpdmVyVCR0b3ASAAGGoKsHCB8lJiwWLS4vMFUk bnVsbNsJCgsMDQ4PEBESExQVFhcYGRobHB0eViRjbGFzc18QH19fbnN1cmxyZXF1ZXN0X3Byb3Rv X3Byb3Bfb2JqXzZSJDFfEB9fX25zdXJscmVxdWVzdF9wcm90b19wcm9wX29ial80XxAfX19uc3Vy bHJlcXVlc3RfcHJvdG9fcHJvcF9vYmpfM18QH19fbnN1cmxyZXF1ZXN0X3Byb3RvX3Byb3Bfb2Jq XzJfEB9fX25zdXJscmVxdWVzdF9wcm90b19wcm9wX29ial8xUiQyXxAfX19uc3VybHJlcXVlc3Rf cHJvdG9fcHJvcF9vYmpfMF8QH19fbnN1cmxyZXF1ZXN0X3Byb3RvX3Byb3Bfb2JqXzVSJDCACoAJ EACAAIAHgAaABRAHgAKACBAI0yAJIRcjJFdOUy5iYXNlW05TLnJlbGF0aXZlgACABIADXxBRZmls ZTovLy9Vc2Vycy9tYXR0YmFrZXIvRGVza3RvcC9EZWJ1Z2dlciUyMHRlc3RzL2NoYWluZWQtcHJv cGVydHktc3RlcHBpbmctbWluLmpz0icoKSpaJGNsYXNzbmFtZVgkY2xhc3Nlc1VOU1VSTKIpK1hO U09iamVjdCNBwIU/8NzCBV8QD3RleHQvamF2YXNjcmlwdBBhI3/v////////0icoMTJdTlNVUkxS ZXNwb25zZaIzK11OU1VSTFJlc3BvbnNlXxAPTlNLZXllZEFyY2hpdmVy0TY3XxATV2ViUmVzb3Vy Y2VSZXNwb25zZYABAAgAEQAaACMALQAyADcAQwBJAGAAZwCJAIwArgDQAPIBFAEXATkBWwFeAWAB YgFkAWYBaAFqAWwBbgFwAXIBdAF7AYMBjwGRAZMBlQHpAe4B+QICAggCCwIUAh0CLwIxAjoCPwJN AlACXgJwAnMCiQAAAAAAAAIBAAAAAAAAADgAAAAAAAAAAAAAAAAAAAKLXxBRZmlsZTovLy9Vc2Vy cy9tYXR0YmFrZXIvRGVza3RvcC9EZWJ1Z2dlciUyMHRlc3RzL2NoYWluZWQtcHJvcGVydHktc3Rl cHBpbmctbWluLmpzTxBhKCgpPT57Y2xhc3MgYXtnZXQgeCgpe3JldHVybiB0aGlzfWdldCB5KCl7 cmV0dXJuIHRoaXN9Z2V0IHooKXtyZXR1cm4gNDJ9fWxldCBiPW5ldyBhO2IueC55Lnp9KSgpO9QG EgcIExQVFl8QFFdlYlJlc291cmNlRnJhbWVOYW1lXxBPZmlsZTovLy9Vc2Vycy9tYXR0YmFrZXIv RGVza3RvcC9EZWJ1Z2dlciUyMHRlc3RzL2NoYWluZWQtcHJvcGVydHktc3RlcHBpbmcuaHRtbFBP EH08aHRtbD4KPHNjcmlwdCBzcmM9ImNoYWluZWQtcHJvcGVydHktc3RlcHBpbmctbWluLmpzIj48 L3NjcmlwdD4KPHNjcmlwdCBzcmM9ImNoYWluZWQtcHJvcGVydHktc3RlcHBpbmcuanMiPjwvc2Ny aXB0Pgo8L2h0bWw+Cll0ZXh0L2h0bWwACAANAB8AMQA0AD0AUwBiAHQAigOlA/UEuwTNBNYH9QhJ CK0ItgjNCR8JIAmgAAAAAAAAAgEAAAAAAAAAFwAAAAAAAAAAAAAAAAAACao= 352246 2018-10-12 17:56:38 -0700 2018-10-15 14:21:25 -0700 Patch bug-188082-20181012175637.patch text/plain 3416 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjM3MDUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBi ZGY2Yzg5ZDRmZGQ5ZjhmYTM4YjU2YjEyYmQxZmU0MzhjMWU2NzdjLi45MDRlZjlmNjY4YWU2NDg0 NTlmN2VkMzA1MjgzMjA2ODgzMmJmNDcyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMSBAQAorMjAxOC0xMC0xMiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTiAocjIzMzgyNCk6IGV4ZWN1dGlv biBoaWdobGlnaHQgcmFuZ2UgbWlzc2luZy9pbmNvcnJlY3QgaW4gcHJldHR5IHByaW50ZWQgY29k ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4MDgy CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MjY0MDU4MD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvU291cmNl Q29kZVRleHRFZGl0b3IuanM6CisgICAgICAgIChXSS5Tb3VyY2VDb2RlVGV4dEVkaXRvci5wcm90 b3R5cGUudGV4dEVkaXRvckV4ZWN1dGlvbkhpZ2hsaWdodFJhbmdlKToKKyAgICAgICAgVGV4dEVk aXRvciBleHBlY3RzIHBvc2l0aW9ucyByZXR1cm5lZCBieSB0aGUgZGVsZWdhdGUgdG8gYmUgcmVs YXRpdmUgdG8KKyAgICAgICAgdGhlIGVkaXRvcidzIHRleHQgY29udGVudCwgbm90IHRoZSBvcmln aW5hbCBzb3VyY2UgY29kZSBjb250ZW50LgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3 cy9UZXh0RWRpdG9yLmpzOgorICAgICAgICAoV0kuVGV4dEVkaXRvci5wcm90b3R5cGUuX3VwZGF0 ZUV4ZWN1dGlvblJhbmdlSGlnaGxpZ2h0KToKKyAgICAgICAgQ29udmVydCBwb3NpdGlvbnMgdG8g Q29kZU1pcnJvciBmb3JtYXQgaGVyZSByYXRoZXIgdGhhbiBpbiB0aGUgZGVsZWdhdGUKKyAgICAg ICAgbWV0aG9kLCB3aGljaCBpcyBhIGxheWVyIHJlbW92ZWQgZnJvbSBDb2RlTWlycm9yLgorCiAy MDE4LTEwLTExICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWIgSW5zcGVjdG9yOiByZW1vdmUgdW51c2VkICBUcmVlT3V0bGluZSBzdHlsZSAuZm9yY2UtZm9j dXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L1NvdXJjZUNvZGVUZXh0RWRpdG9yLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMKaW5kZXggZDI3MWIzYWRmNzIwODkx M2Q0ODVjNjkyNjc1MzUyNjI0NjdkZDlkNi4uMmE4NWI5YmFmOWI1YzA1ZGUzM2E0ZDM1YjdjOGEz NTVlMjNmNTdlMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU291cmNlQ29kZVRleHRFZGl0b3IuanMKQEAgLTE0MjYs MTAgKzE0MjYsMTAgQEAgV0kuU291cmNlQ29kZVRleHRFZGl0b3IgPSBjbGFzcyBTb3VyY2VDb2Rl VGV4dEVkaXRvciBleHRlbmRzIFdJLlRleHRFZGl0b3IKICAgICAgICAgICAgIHJldHVybiBuZXcg V0kuU291cmNlQ29kZVBvc2l0aW9uKHBvc2l0aW9uLmxpbmVOdW1iZXIgKyBzdGFydExpbmUsIGNv bHVtbk51bWJlcik7CiAgICAgICAgIH0KIAotICAgICAgICAvLyBXaGVuIHJldHVybmluZyBvZmZz ZXRzLCBjb252ZXJ0IHRvIG9mZnNldHMgd2l0aGluIHRoZSBTb3VyY2VDb2RlIGJlaW5nIHZpZXdl ZC4KKyAgICAgICAgLy8gV2hlbiByZXR1cm5pbmcgcG9zaXRpb25zLCBjb252ZXJ0IHRvIHBvc2l0 aW9ucyByZWxhdGl2ZSB0byB0aGUgVGV4dEVkaXRvciBjb250ZW50LgogICAgICAgICBsZXQgaGln aGxpZ2h0U291cmNlQ29kZVJhbmdlID0gKHN0YXJ0UG9zaXRpb24sIGVuZFBvc2l0aW9uKSA9PiB7 Ci0gICAgICAgICAgICBzdGFydFBvc2l0aW9uID0gZnJvbUlubGluZVNjcmlwdFBvc2l0aW9uKHN0 YXJ0UG9zaXRpb24pLnRvQ29kZU1pcnJvcigpOwotICAgICAgICAgICAgZW5kUG9zaXRpb24gPSBm cm9tSW5saW5lU2NyaXB0UG9zaXRpb24oZW5kUG9zaXRpb24pLnRvQ29kZU1pcnJvcigpOworICAg ICAgICAgICAgc3RhcnRQb3NpdGlvbiA9IHRoaXMub3JpZ2luYWxQb3NpdGlvblRvQ3VycmVudFBv c2l0aW9uKGZyb21JbmxpbmVTY3JpcHRQb3NpdGlvbihzdGFydFBvc2l0aW9uKSk7CisgICAgICAg ICAgICBlbmRQb3NpdGlvbiA9IHRoaXMub3JpZ2luYWxQb3NpdGlvblRvQ3VycmVudFBvc2l0aW9u KGZyb21JbmxpbmVTY3JpcHRQb3NpdGlvbihlbmRQb3NpdGlvbikpOwogICAgICAgICAgICAgY2Fs bGJhY2soe3N0YXJ0UG9zaXRpb24sIGVuZFBvc2l0aW9ufSk7CiAgICAgICAgIH07CiAKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0 b3IuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRp dG9yLmpzCmluZGV4IDI1ZWE0YTE4NWQ2ZDc1ZjdjMzUzM2FhODgwMDA1MzhiYTEyN2Q3ZWYuLjkx YmNmZmI4ZDMyMjI5MmNiZDA0MjI1ZjdjZDhlMmY2ZmI0NjczNmQgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcwpA QCAtMTM0NSw4ICsxMzQ1LDggQEAgV0kuVGV4dEVkaXRvciA9IGNsYXNzIFRleHRFZGl0b3IgZXh0 ZW5kcyBXSS5WaWV3CiAgICAgICAgICAgICAgICAgZW5kID0ge2xpbmU6IHRoaXMuX2V4ZWN1dGlv bkxpbmVOdW1iZXJ9OwogICAgICAgICAgICAgfSBlbHNlIHsKICAgICAgICAgICAgICAgICAvLyBI aWdobGlnaHQgdGhlIHJhbmdlLgotICAgICAgICAgICAgICAgIHN0YXJ0ID0gcmFuZ2Uuc3RhcnRQ b3NpdGlvbjsKLSAgICAgICAgICAgICAgICBlbmQgPSByYW5nZS5lbmRQb3NpdGlvbjsKKyAgICAg ICAgICAgICAgICBzdGFydCA9IHJhbmdlLnN0YXJ0UG9zaXRpb24udG9Db2RlTWlycm9yKCk7Cisg ICAgICAgICAgICAgICAgZW5kID0gcmFuZ2UuZW5kUG9zaXRpb24udG9Db2RlTWlycm9yKCk7CiAg ICAgICAgICAgICB9CiAKICAgICAgICAgICAgIC8vIEVuc3VyZSB0aGUgbWFya2VyIGlzIGNsZWFy ZWQgaW4gY2FzZSB0aGVyZSB3ZXJlIG11bHRpcGxlIHVwZGF0ZXMgdmVyeSBxdWlja2x5Lgo=