188074 2018-07-26 13:51:13 -0700 Fix assertions introduced in r234210 2018-07-26 14:47:12 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 achristensen achristensen cdumez commit-queue webkit-bug-importer oldest_to_newest 1445509 0 achristensen 2018-07-26 13:51:13 -0700 Fix assertions introduced in r234210 1445511 1 345863 achristensen 2018-07-26 13:55:07 -0700 Created attachment 345863 Patch 1445519 2 345866 achristensen 2018-07-26 14:04:04 -0700 Created attachment 345866 Patch 1445531 3 345866 cdumez 2018-07-26 14:22:41 -0700 Comment on attachment 345866 Patch r=me 1445541 4 achristensen 2018-07-26 14:44:16 -0700 http://trac.webkit.org/r234276 1445544 5 webkit-bug-importer 2018-07-26 14:47:12 -0700 <rdar://problem/42638996> 345863 2018-07-26 13:55:07 -0700 2018-07-26 14:04:02 -0700 Patch bug-188074-20180726135506.patch text/plain 3538 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzQyNzApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA3LTI2ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGFzc2VydGlv bnMgaW50cm9kdWNlZCBpbiByMjM0MjEwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODgwNzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGVyZSBpcyBhIGNsaWVudCB0aGF0IHVzZXMgV0tGcmFtZVBvbGlj eUxpc3RlbmVyVXNlV2l0aFBvbGljaWVzIHRvIHNlbmQgd2Vic2l0ZSBwb2xpY2llcyBhcworICAg ICAgICBhIHJlc3BvbnNlIHRvIHRoZSBXS1BhZ2VOYXZpZ2F0aW9uQ2xpZW50J3MgZGVjaWRlUG9s aWN5Rm9yTmF2aWdhdGlvblJlc3BvbnNlLiAgVGhhdCBpcyB3YXN0aW5nCisgICAgICAgIGVmZm9y dCB0byBnZW5lcmF0ZSBwb2xpY2llcyB0aGF0IGRvbid0IGNoYW5nZSBhbnl0aGluZy4gT25jZSB0 aGF0IGNsaWVudCBhZG9wdHMgV0tXZWJWaWV3CisgICAgICAgIHRoZXkgd29uJ3QgYmUgYWJsZSB0 byBkbyB0aGlzIGFueSBtb3JlLCBzbyB0ZW1wb3JhcmlseSByZW1vdmUgdGhlIGFzc2VydGlvbi4K KyAgICAgICAgQWxzbywgbWFrZSB0aGUgYXNzZXJ0aW9uIGFib3V0IHByb2Nlc3Mgc3dhcHBpbmcg YSByZWxlYXNlIGFzc2VydCB0byBwcmV2ZW50IHRoYXQgY2xpZW50CisgICAgICAgIGZyb20gYWRv cHRpbmcgV0tGcmFtZVBvbGljeUxpc3RlbmVyVXNlSW5OZXdQcm9jZXNzV2l0aFBvbGljaWVzIGZv ciBuYXZpZ2F0aW9uIHJlc3BvbnNlcy4KKyAgICAgICAgSXQgc2hvdWxkIG9ubHkgYmUgdXNlZCBm b3IgbmF2aWdhdGlvbiBhY3Rpb25zLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94 eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6ZGVjaWRlUG9saWN5Rm9yTmV3 V2luZG93QWN0aW9uKToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpkZWNpZGVQb2xp Y3lGb3JSZXNwb25zZSk6CisKIDIwMTgtMDctMjYgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KIAogICAgICAgICBFUlJPUjogVW5oYW5kbGVkIHdlYiBwcm9jZXNzIG1lc3NhZ2UgJ1dl YlBhZ2U6U2V0VXNlRGFya0FwcGVhcmFuY2UnIHdoZW4gYnJvd3NpbmcgaW4gZGFyayBtb2RlCklu ZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHJldmlzaW9uIDIz NDIxMCkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTQwODIsOSArNDA4Miw5IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpkZWNpZGVQ b2xpY3lGb3JOZXdXaW4KICAgICBNRVNTQUdFX0NIRUNLKGZyYW1lKTsKICAgICBNRVNTQUdFX0NI RUNLX1VSTChyZXF1ZXN0LnVybCgpKTsKIAotICAgIGF1dG8gbGlzdGVuZXIgPSBtYWtlUmVmKGZy YW1lLT5zZXRVcFBvbGljeUxpc3RlbmVyUHJveHkoW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBtYWtl UmVmKCp0aGlzKSwgbGlzdGVuZXJJRCwgZnJhbWUgPSBtYWtlUmVmKCpmcmFtZSldIChXZWJDb3Jl OjpQb2xpY3lBY3Rpb24gcG9saWN5QWN0aW9uLCBBUEk6OldlYnNpdGVQb2xpY2llcyogcG9saWNp ZXMsIFNob3VsZFByb2Nlc3NTd2FwSWZQb3NzaWJsZSBzd2FwKSB7Ci0gICAgICAgIEFTU0VSVF9V TlVTRUQocG9saWNpZXMsICFwb2xpY2llcyk7Ci0gICAgICAgIEFTU0VSVF9VTlVTRUQoc3dhcCwg c3dhcCA9PSBTaG91bGRQcm9jZXNzU3dhcElmUG9zc2libGU6Ok5vKTsKKyAgICBhdXRvIGxpc3Rl bmVyID0gbWFrZVJlZihmcmFtZS0+c2V0VXBQb2xpY3lMaXN0ZW5lclByb3h5KFt0aGlzLCBwcm90 ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIGxpc3RlbmVySUQsIGZyYW1lID0gbWFrZVJlZigq ZnJhbWUpXSAoV2ViQ29yZTo6UG9saWN5QWN0aW9uIHBvbGljeUFjdGlvbiwgQVBJOjpXZWJzaXRl UG9saWNpZXMqLCBTaG91bGRQcm9jZXNzU3dhcElmUG9zc2libGUgc3dhcCkgeworICAgICAgICAv LyBGSVhNRTogQXNzZXJ0IHRoZSBBUEk6OldlYnNpdGVQb2xpY2llcyogaXMgbnVsbHB0ciBoZXJl IG9uY2UgY2xpZW50cyBvZiBXS0ZyYW1lUG9saWN5TGlzdGVuZXJVc2VXaXRoUG9saWNpZXMgZ28g YXdheS4KKyAgICAgICAgUkVMRUFTRV9BU1NFUlRfVU5VU0VEKHN3YXAsIHN3YXAgPT0gU2hvdWxk UHJvY2Vzc1N3YXBJZlBvc3NpYmxlOjpObyk7CiAgICAgICAgIHJlY2VpdmVkUG9saWN5RGVjaXNp b24ocG9saWN5QWN0aW9uLCBmcmFtZS5nZXQoKSwgbGlzdGVuZXJJRCwgbnVsbHB0ciwgc3RkOjpu dWxsb3B0KTsKICAgICB9KSk7CiAKQEAgLTQxMTYsOCArNDExNiw4IEBAIHZvaWQgV2ViUGFnZVBy b3h5OjpkZWNpZGVQb2xpY3lGb3JSZXNwb24KIAogICAgIFJlZlB0cjxBUEk6Ok5hdmlnYXRpb24+ IG5hdmlnYXRpb24gPSBuYXZpZ2F0aW9uSUQgPyAmbV9uYXZpZ2F0aW9uU3RhdGUtPm5hdmlnYXRp b24obmF2aWdhdGlvbklEKSA6IG51bGxwdHI7CiAgICAgYXV0byBsaXN0ZW5lciA9IG1ha2VSZWYo ZnJhbWUtPnNldFVwUG9saWN5TGlzdGVuZXJQcm94eShbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1h a2VSZWYoKnRoaXMpLCBmcmFtZSA9IG1ha2VSZWYoKmZyYW1lKSwgbGlzdGVuZXJJRCwgbmF2aWdh dGlvbiA9IFdURk1vdmUobmF2aWdhdGlvbildIChXZWJDb3JlOjpQb2xpY3lBY3Rpb24gcG9saWN5 QWN0aW9uLCBBUEk6OldlYnNpdGVQb2xpY2llcyogcG9saWNpZXMsIFNob3VsZFByb2Nlc3NTd2Fw SWZQb3NzaWJsZSBzd2FwKSB7Ci0gICAgICAgIEFTU0VSVF9VTlVTRUQocG9saWNpZXMsICFwb2xp Y2llcyk7Ci0gICAgICAgIEFTU0VSVF9VTlVTRUQoc3dhcCwgc3dhcCA9PSBTaG91bGRQcm9jZXNz U3dhcElmUG9zc2libGU6Ok5vKTsKKyAgICAgICAgLy8gRklYTUU6IEFzc2VydCB0aGUgQVBJOjpX ZWJzaXRlUG9saWNpZXMqIGlzIG51bGxwdHIgaGVyZSBvbmNlIGNsaWVudHMgb2YgV0tGcmFtZVBv bGljeUxpc3RlbmVyVXNlV2l0aFBvbGljaWVzIGdvIGF3YXkuCisgICAgICAgIFJFTEVBU0VfQVNT RVJUX1VOVVNFRChzd2FwLCBzd2FwID09IFNob3VsZFByb2Nlc3NTd2FwSWZQb3NzaWJsZTo6Tm8p OwogICAgICAgICByZWNlaXZlZFBvbGljeURlY2lzaW9uKHBvbGljeUFjdGlvbiwgZnJhbWUuZ2V0 KCksIGxpc3RlbmVySUQsIG5hdmlnYXRpb24uZ2V0KCksIHN0ZDo6bnVsbG9wdCk7CiAgICAgfSkp OwogCg== 345866 2018-07-26 14:04:04 -0700 2018-07-26 14:41:53 -0700 Patch bug-188074-20180726140404.patch text/plain 3819 achristensen SW5kZXg6IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJL aXQvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMzQyNzApCisrKyBTb3VyY2UvV2ViS2l0L0NoYW5nZUxv Zwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE4LTA3LTI2ICBBbGV4IENocmlz dGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IGFzc2VydGlv bnMgaW50cm9kdWNlZCBpbiByMjM0MjEwCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xODgwNzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGVyZSBpcyBhIGNsaWVudCB0aGF0IHVzZXMgV0tGcmFtZVBvbGlj eUxpc3RlbmVyVXNlV2l0aFBvbGljaWVzIHRvIHNlbmQgd2Vic2l0ZSBwb2xpY2llcyBhcworICAg ICAgICBhIHJlc3BvbnNlIHRvIHRoZSBXS1BhZ2VOYXZpZ2F0aW9uQ2xpZW50J3MgZGVjaWRlUG9s aWN5Rm9yTmF2aWdhdGlvblJlc3BvbnNlLiAgVGhhdCBpcyB3YXN0aW5nCisgICAgICAgIGVmZm9y dCB0byBnZW5lcmF0ZSBwb2xpY2llcyB0aGF0IGRvbid0IGNoYW5nZSBhbnl0aGluZy4gT25jZSB0 aGF0IGNsaWVudCBhZG9wdHMgV0tXZWJWaWV3CisgICAgICAgIHRoZXkgd29uJ3QgYmUgYWJsZSB0 byBkbyB0aGlzIGFueSBtb3JlLCBzbyB0ZW1wb3JhcmlseSByZW1vdmUgdGhlIGFzc2VydGlvbi4K KyAgICAgICAgQWxzbywgbWFrZSB0aGUgYXNzZXJ0aW9uIGFib3V0IHByb2Nlc3Mgc3dhcHBpbmcg YSByZWxlYXNlIGFzc2VydCB0byBwcmV2ZW50IHRoYXQgY2xpZW50CisgICAgICAgIGZyb20gYWRv cHRpbmcgV0tGcmFtZVBvbGljeUxpc3RlbmVyVXNlSW5OZXdQcm9jZXNzV2l0aFBvbGljaWVzIGZv ciBuYXZpZ2F0aW9uIHJlc3BvbnNlcy4KKyAgICAgICAgSXQgc2hvdWxkIG9ubHkgYmUgdXNlZCBm b3IgbmF2aWdhdGlvbiBhY3Rpb25zLgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYlBhZ2VQcm94 eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6ZGVjaWRlUG9saWN5Rm9yTmV3 V2luZG93QWN0aW9uKToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVByb3h5OjpkZWNpZGVQb2xp Y3lGb3JSZXNwb25zZSk6CisKIDIwMTgtMDctMjYgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxl LmNvbT4KIAogICAgICAgICBFUlJPUjogVW5oYW5kbGVkIHdlYiBwcm9jZXNzIG1lc3NhZ2UgJ1dl YlBhZ2U6U2V0VXNlRGFya0FwcGVhcmFuY2UnIHdoZW4gYnJvd3NpbmcgaW4gZGFyayBtb2RlCklu ZGV4OiBTb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHJldmlzaW9uIDIz NDIxMCkKKysrIFNvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTQwODIsOSArNDA4Miw5IEBAIHZvaWQgV2ViUGFnZVByb3h5OjpkZWNpZGVQ b2xpY3lGb3JOZXdXaW4KICAgICBNRVNTQUdFX0NIRUNLKGZyYW1lKTsKICAgICBNRVNTQUdFX0NI RUNLX1VSTChyZXF1ZXN0LnVybCgpKTsKIAotICAgIGF1dG8gbGlzdGVuZXIgPSBtYWtlUmVmKGZy YW1lLT5zZXRVcFBvbGljeUxpc3RlbmVyUHJveHkoW3RoaXMsIHByb3RlY3RlZFRoaXMgPSBtYWtl UmVmKCp0aGlzKSwgbGlzdGVuZXJJRCwgZnJhbWUgPSBtYWtlUmVmKCpmcmFtZSldIChXZWJDb3Jl OjpQb2xpY3lBY3Rpb24gcG9saWN5QWN0aW9uLCBBUEk6OldlYnNpdGVQb2xpY2llcyogcG9saWNp ZXMsIFNob3VsZFByb2Nlc3NTd2FwSWZQb3NzaWJsZSBzd2FwKSB7Ci0gICAgICAgIEFTU0VSVF9V TlVTRUQocG9saWNpZXMsICFwb2xpY2llcyk7Ci0gICAgICAgIEFTU0VSVF9VTlVTRUQoc3dhcCwg c3dhcCA9PSBTaG91bGRQcm9jZXNzU3dhcElmUG9zc2libGU6Ok5vKTsKKyAgICBhdXRvIGxpc3Rl bmVyID0gbWFrZVJlZihmcmFtZS0+c2V0VXBQb2xpY3lMaXN0ZW5lclByb3h5KFt0aGlzLCBwcm90 ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIGxpc3RlbmVySUQsIGZyYW1lID0gbWFrZVJlZigq ZnJhbWUpXSAoV2ViQ29yZTo6UG9saWN5QWN0aW9uIHBvbGljeUFjdGlvbiwgQVBJOjpXZWJzaXRl UG9saWNpZXMqLCBTaG91bGRQcm9jZXNzU3dhcElmUG9zc2libGUgc3dhcCkgeworICAgICAgICAv LyBGSVhNRTogQXNzZXJ0IHRoZSBBUEk6OldlYnNpdGVQb2xpY2llcyogaXMgbnVsbHB0ciBoZXJl IG9uY2UgY2xpZW50cyBvZiBXS0ZyYW1lUG9saWN5TGlzdGVuZXJVc2VXaXRoUG9saWNpZXMgZ28g YXdheS4KKyAgICAgICAgUkVMRUFTRV9BU1NFUlQoc3dhcCA9PSBTaG91bGRQcm9jZXNzU3dhcElm UG9zc2libGU6Ok5vKTsKICAgICAgICAgcmVjZWl2ZWRQb2xpY3lEZWNpc2lvbihwb2xpY3lBY3Rp b24sIGZyYW1lLmdldCgpLCBsaXN0ZW5lcklELCBudWxscHRyLCBzdGQ6Om51bGxvcHQpOwogICAg IH0pKTsKIApAQCAtNDExNSw5ICs0MTE1LDkgQEAgdm9pZCBXZWJQYWdlUHJveHk6OmRlY2lkZVBv bGljeUZvclJlc3BvbgogICAgIE1FU1NBR0VfQ0hFQ0tfVVJMKHJlc3BvbnNlLnVybCgpKTsKIAog ICAgIFJlZlB0cjxBUEk6Ok5hdmlnYXRpb24+IG5hdmlnYXRpb24gPSBuYXZpZ2F0aW9uSUQgPyAm bV9uYXZpZ2F0aW9uU3RhdGUtPm5hdmlnYXRpb24obmF2aWdhdGlvbklEKSA6IG51bGxwdHI7Ci0g ICAgYXV0byBsaXN0ZW5lciA9IG1ha2VSZWYoZnJhbWUtPnNldFVwUG9saWN5TGlzdGVuZXJQcm94 eShbdGhpcywgcHJvdGVjdGVkVGhpcyA9IG1ha2VSZWYoKnRoaXMpLCBmcmFtZSA9IG1ha2VSZWYo KmZyYW1lKSwgbGlzdGVuZXJJRCwgbmF2aWdhdGlvbiA9IFdURk1vdmUobmF2aWdhdGlvbildIChX ZWJDb3JlOjpQb2xpY3lBY3Rpb24gcG9saWN5QWN0aW9uLCBBUEk6OldlYnNpdGVQb2xpY2llcyog cG9saWNpZXMsIFNob3VsZFByb2Nlc3NTd2FwSWZQb3NzaWJsZSBzd2FwKSB7Ci0gICAgICAgIEFT U0VSVF9VTlVTRUQocG9saWNpZXMsICFwb2xpY2llcyk7Ci0gICAgICAgIEFTU0VSVF9VTlVTRUQo c3dhcCwgc3dhcCA9PSBTaG91bGRQcm9jZXNzU3dhcElmUG9zc2libGU6Ok5vKTsKKyAgICBhdXRv IGxpc3RlbmVyID0gbWFrZVJlZihmcmFtZS0+c2V0VXBQb2xpY3lMaXN0ZW5lclByb3h5KFt0aGlz LCBwcm90ZWN0ZWRUaGlzID0gbWFrZVJlZigqdGhpcyksIGZyYW1lID0gbWFrZVJlZigqZnJhbWUp LCBsaXN0ZW5lcklELCBuYXZpZ2F0aW9uID0gV1RGTW92ZShuYXZpZ2F0aW9uKV0gKFdlYkNvcmU6 OlBvbGljeUFjdGlvbiBwb2xpY3lBY3Rpb24sIEFQSTo6V2Vic2l0ZVBvbGljaWVzKiwgU2hvdWxk UHJvY2Vzc1N3YXBJZlBvc3NpYmxlIHN3YXApIHsKKyAgICAgICAgLy8gRklYTUU6IEFzc2VydCB0 aGUgQVBJOjpXZWJzaXRlUG9saWNpZXMqIGlzIG51bGxwdHIgaGVyZSBvbmNlIGNsaWVudHMgb2Yg V0tGcmFtZVBvbGljeUxpc3RlbmVyVXNlV2l0aFBvbGljaWVzIGdvIGF3YXkuCisgICAgICAgIFJF TEVBU0VfQVNTRVJUKHN3YXAgPT0gU2hvdWxkUHJvY2Vzc1N3YXBJZlBvc3NpYmxlOjpObyk7CiAg ICAgICAgIHJlY2VpdmVkUG9saWN5RGVjaXNpb24ocG9saWN5QWN0aW9uLCBmcmFtZS5nZXQoKSwg bGlzdGVuZXJJRCwgbmF2aWdhdGlvbi5nZXQoKSwgc3RkOjpudWxsb3B0KTsKICAgICB9KSk7CiAK