188067 2018-07-26 11:44:44 -0700 Use the Page's appearance when converting pasteboard attributed strings 2018-07-26 13:30:16 -0700 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1445476 0 timothy 2018-07-26 11:44:44 -0700 The color conversion of NSAttributedString rely on the appearance. We should use the page's appearance in this case. 1445477 1 webkit-bug-importer 2018-07-26 11:45:11 -0700 <rdar://problem/42632246> 1445478 2 345856 timothy 2018-07-26 11:48:53 -0700 Created attachment 345856 Patch 1445481 3 345856 megan_gardner 2018-07-26 11:54:35 -0700 Comment on attachment 345856 Patch r=me, unofficial 1445486 4 345856 wenson_hsieh 2018-07-26 12:39:13 -0700 Comment on attachment 345856 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345856&action=review Is this testable in any way? > Source/WebCore/editing/cocoa/WebContentReaderCocoa.mm:128 > + auto* page = frame.page(); I was wondering if there's ever a case where page could be null, but it looks like we're okay here because createFragmentAndAddResources will bail if !frame.page(). 1445497 5 timothy 2018-07-26 13:02:12 -0700 (In reply to Wenson Hsieh from comment #4) > Comment on attachment 345856 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345856&action=review > > Is this testable in any way? Not currently. I am working on dark mode testing support in general and have many tests to add. 1445506 6 345856 commit-queue 2018-07-26 13:30:14 -0700 Comment on attachment 345856 Patch Clearing flags on attachment: 345856 Committed r234270: <https://trac.webkit.org/changeset/234270> 1445507 7 commit-queue 2018-07-26 13:30:16 -0700 All reviewed patches have been landed. Closing bug. 345856 2018-07-26 11:48:53 -0700 2018-07-26 13:30:14 -0700 Patch bug-188067-20180726114852.patch text/plain 4205 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzU0ZGQwODczNmRhNzIz YzllY2UzOWI3YTEzMzljNDA3NDMzOTJkMi4uOTBlM2RjMzUzMWIzZTg3YjJmMTliZTNhNzY2YmJm YTZjZWFiMDQ3NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA3LTI2ICBUaW1v dGh5IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgdGhlIFBhZ2Un cyBhcHBlYXJhbmNlIHdoZW4gY29udmVydGluZyBwYXN0ZWJvYXJkIGF0dHJpYnV0ZWQgc3RyaW5n cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODA2 NworICAgICAgICByZGFyOi8vcHJvYmxlbS80MjYzMjI0NgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZWRpdGluZy9jb2NvYS9XZWJDb250ZW50UmVh ZGVyQ29jb2EubW06CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVGcmFnbWVudCk6IENyZWF0ZSBh IExvY2FsRGVmYXVsdFN5c3RlbUFwcGVhcmFuY2UgYmFzZWQgb24gdGhlIFBhZ2UuCisKIDIwMTgt MDctMjIgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAgIGZ1bGxzY3Jl ZW4gZW52KCkgdmFyaWFibGVzIHNob3VsZCBoYXZlIGluaXRpYWwgdmFsdWVzCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5 L21hYy9DaGFuZ2VMb2cKaW5kZXggZjBmNDgyZWZiZGJhMjZhODI3NmJhNWUyMmJjNWJkNWFkODg4 MTRiYS4uMmNjYmIwNzE3NTE3NWI0M2UyMjY2MGQxNDBkZWMzZGVlOTE2ZDJiOCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRM ZWdhY3kvbWFjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE4LTA3LTI2ICBUaW1vdGh5 IEhhdGNoZXIgIDx0aW1vdGh5QGFwcGxlLmNvbT4KKworICAgICAgICBVc2UgdGhlIFBhZ2UncyBh cHBlYXJhbmNlIHdoZW4gY29udmVydGluZyBwYXN0ZWJvYXJkIGF0dHJpYnV0ZWQgc3RyaW5ncy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODA2Nwor ICAgICAgICByZGFyOi8vcHJvYmxlbS80MjYzMjI0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50 Lm1tOgorICAgICAgICAoX1dlYkNyZWF0ZUZyYWdtZW50KTogQ3JlYXRlIGEgTG9jYWxEZWZhdWx0 U3lzdGVtQXBwZWFyYW5jZSBiYXNlZCBvbiB0aGUgUGFnZS4KKwogMjAxOC0wNy0yMCAgUnlvc3Vr ZSBOaXdhICA8cm5pd2FAYXBwbGUuY29tPgogCiAgICAgICAgIFBpY2tpbmcgYSBjb2xvciBmcm9t IHRoZSBjb2xvciBwYW5lbCBmb3IgdHlwaW5nIGF0dHJpYnV0ZXMgbmVlZHMgdG8gaW52ZXJzZSB0 cmFuc2Zvcm0gdGhyb3VnaCBjb2xvci1maWx0ZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2VkaXRpbmcvY29jb2EvV2ViQ29udGVudFJlYWRlckNvY29hLm1tIGIvU291cmNlL1dlYkNvcmUv ZWRpdGluZy9jb2NvYS9XZWJDb250ZW50UmVhZGVyQ29jb2EubW0KaW5kZXggYjNiY2ZmNjMxZTQ4 OTQyZGY3NTFiMjgwODI0YWU1NDVjNDYwZTM5Yi4uNmY0YjNmYmM1ZGJiZGQ1M2VkZDdhOWM4Y2Y3 ZWEzMzJjZDRlNWE3OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZWRpdGluZy9jb2NvYS9X ZWJDb250ZW50UmVhZGVyQ29jb2EubW0KKysrIGIvU291cmNlL1dlYkNvcmUvZWRpdGluZy9jb2Nv YS9XZWJDb250ZW50UmVhZGVyQ29jb2EubW0KQEAgLTYxLDYgKzYxLDEwIEBACiAjaW1wb3J0IDxw YWwvc3BpL2NvY29hL05TQXR0cmlidXRlZFN0cmluZ1NQSS5oPgogI2ltcG9ydCA8d3RmL1NvZnRM aW5raW5nLmg+CiAKKyNpZiBQTEFURk9STShNQUMpCisjaW5jbHVkZSAiTG9jYWxEZWZhdWx0U3lz dGVtQXBwZWFyYW5jZS5oIgorI2VuZGlmCisKICNpZiAoUExBVEZPUk0oSU9TKSAmJiBfX0lQSE9O RV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxMTAwMDApIHx8IChQTEFURk9STShNQUMpICYm IF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQgPj0gMTAxMzAwKQogQGludGVyZmFjZSBO U0F0dHJpYnV0ZWRTdHJpbmcgKCkKIC0gKE5TU3RyaW5nICopX2h0bWxEb2N1bWVudEZyYWdtZW50 U3RyaW5nOihOU1JhbmdlKXJhbmdlIGRvY3VtZW50QXR0cmlidXRlczooTlNEaWN0aW9uYXJ5ICop ZGljdCBzdWJyZXNvdXJjZXM6KE5TQXJyYXkgKiopc3VicmVzb3VyY2VzOwpAQCAtMTIwLDYgKzEy NCwxMSBAQCBzdGF0aWMgRnJhZ21lbnRBbmRSZXNvdXJjZXMgY3JlYXRlRnJhZ21lbnQoRnJhbWUm IGZyYW1lLCBOU0F0dHJpYnV0ZWRTdHJpbmcgKnN0cgogICAgIEZyYWdtZW50QW5kUmVzb3VyY2Vz IHJlc3VsdDsKICAgICBEb2N1bWVudCYgZG9jdW1lbnQgPSAqZnJhbWUuZG9jdW1lbnQoKTsKIAor I2lmIFBMQVRGT1JNKE1BQykKKyAgICBhdXRvKiBwYWdlID0gZnJhbWUucGFnZSgpOworICAgIExv Y2FsRGVmYXVsdFN5c3RlbUFwcGVhcmFuY2UgbG9jYWxBcHBlYXJhbmNlKHBhZ2UtPnVzZVN5c3Rl bUFwcGVhcmFuY2UoKSwgcGFnZS0+dXNlRGFya0FwcGVhcmFuY2UoKSk7CisjZW5kaWYKKwogICAg IE5TQXJyYXkgKnN1YnJlc291cmNlcyA9IG5pbDsKICAgICBOU1N0cmluZyAqZnJhZ21lbnRTdHJp bmcgPSBbc3RyaW5nIF9odG1sRG9jdW1lbnRGcmFnbWVudFN0cmluZzpOU01ha2VSYW5nZSgwLCBb c3RyaW5nIGxlbmd0aF0pIGRvY3VtZW50QXR0cmlidXRlczphdHRyaWJ1dGVzRm9yQXR0cmlidXRl ZFN0cmluZ0NvbnZlcnNpb24oKSBzdWJyZXNvdXJjZXM6JnN1YnJlc291cmNlc107CiAgICAgYXV0 byBmcmFnbWVudCA9IERvY3VtZW50RnJhZ21lbnQ6OmNyZWF0ZShkb2N1bWVudCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JDbGll bnQubW0gYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJDb3JlU3VwcG9ydC9XZWJFZGl0b3JD bGllbnQubW0KaW5kZXggNjEwZjhlMDgzZDFlMDcwM2Y3OWE5MTVlNmQ4ZTJhODJkNWJiY2E4Yy4u MmVmZjc2MTEyZWE5Zjg5NTg1NDgzNTYxOGZlYzdjODcyZGJlYmYzNiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViQ29yZVN1cHBvcnQvV2ViRWRpdG9yQ2xpZW50Lm1tCisr KyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYkNvcmVTdXBwb3J0L1dlYkVkaXRvckNsaWVu dC5tbQpAQCAtOTIsNiArOTIsMTAgQEAKICNpbXBvcnQgIldlYlVJS2l0RGVsZWdhdGUuaCIKICNl bmRpZgogCisjaWYgUExBVEZPUk0oTUFDKQorI2ltcG9ydCA8V2ViQ29yZS9Mb2NhbERlZmF1bHRT eXN0ZW1BcHBlYXJhbmNlLmg+CisjZW5kaWYKKwogdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAK IHVzaW5nIG5hbWVzcGFjZSBIVE1MTmFtZXM7CkBAIC00NzMsNiArNDc3LDExIEBAIHN0YXRpYyBO U0RpY3Rpb25hcnkgKmF0dHJpYnV0ZXNGb3JBdHRyaWJ1dGVkU3RyaW5nQ29udmVyc2lvbigpCiAK IHZvaWQgX1dlYkNyZWF0ZUZyYWdtZW50KERvY3VtZW50JiBkb2N1bWVudCwgTlNBdHRyaWJ1dGVk U3RyaW5nICpzdHJpbmcsIEZyYWdtZW50QW5kUmVzb3VyY2VzJiByZXN1bHQpCiB7CisjaWYgUExB VEZPUk0oTUFDKQorICAgIGF1dG8qIHBhZ2UgPSBkb2N1bWVudC5wYWdlKCk7CisgICAgTG9jYWxE ZWZhdWx0U3lzdGVtQXBwZWFyYW5jZSBsb2NhbEFwcGVhcmFuY2UocGFnZS0+dXNlU3lzdGVtQXBw ZWFyYW5jZSgpLCBwYWdlLT51c2VEYXJrQXBwZWFyYW5jZSgpKTsKKyNlbmRpZgorCiAgICAgc3Rh dGljIE5TRGljdGlvbmFyeSAqZG9jdW1lbnRBdHRyaWJ1dGVzID0gW2F0dHJpYnV0ZXNGb3JBdHRy aWJ1dGVkU3RyaW5nQ29udmVyc2lvbigpIHJldGFpbl07CiAgICAgTlNBcnJheSAqc3VicmVzb3Vy Y2VzOwogICAgIERPTURvY3VtZW50RnJhZ21lbnQqIGZyYWdtZW50ID0gW3N0cmluZyBfZG9jdW1l bnRGcm9tUmFuZ2U6TlNNYWtlUmFuZ2UoMCwgW3N0cmluZyBsZW5ndGhdKQo=