188065 2018-07-26 11:16:33 -0700 arrayProtoPrivateFuncConcatMemcpy() should handle copying from an Undecided type array. 2020-04-30 00:06:28 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo keith_miller king_pirate11 msaboff rmorisset saam tzagallo webkit-bug-importer oldest_to_newest 1445468 0 mark.lam 2018-07-26 11:16:33 -0700 <rdar://problem/42515726> 1445469 1 345853 mark.lam 2018-07-26 11:24:32 -0700 Created attachment 345853 proposed patch. 1445471 2 345853 saam 2018-07-26 11:29:13 -0700 Comment on attachment 345853 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=345853&action=review > Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1307 > +template<typename T, bool isDouble = std::is_same<T, double>::value> why do you need isDouble? > Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1308 > +void copyElements(T* buffer, unsigned offset, void* source, unsigned sourceSize, IndexingType sourceType) ALWAYS_INLINE? 1445472 3 345853 mark.lam 2018-07-26 11:30:14 -0700 Comment on attachment 345853 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=345853&action=review >> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1307 >> +template<typename T, bool isDouble = std::is_same<T, double>::value> > > why do you need isDouble? Oops ... old code that is now solved by a superior method. Will delete this. >> Source/JavaScriptCore/runtime/ArrayPrototype.cpp:1308 >> +void copyElements(T* buffer, unsigned offset, void* source, unsigned sourceSize, IndexingType sourceType) > > ALWAYS_INLINE? OK. 1445473 4 345854 mark.lam 2018-07-26 11:33:05 -0700 Created attachment 345854 patch for landing. 1445492 5 mark.lam 2018-07-26 12:50:06 -0700 Thanks for the review. Landed in r234269: <http://trac.webkit.org/r234269>. 345853 2018-07-26 11:24:32 -0700 2018-07-26 11:33:05 -0700 proposed patch. bug-188065.patch text/plain 4539 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzQyNjcpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTA3LTI2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBhcnJheVByb3RvUHJpdmF0ZUZ1bmNDb25jYXRNZW1jcHkoKSBzaG91bGQg aGFuZGxlIGNvcHlpbmcgZnJvbSBhbiBVbmRlY2lkZWQgdHlwZSBhcnJheS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODA2NQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNDI1MTU3MjY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBzdHJlc3MvcmVncmVzcy0xODgwNjUuanM6IEFkZGVkLgorCiAyMDE4 LTA3LTI1ICBBbmR5IFZhbldhZ29uZXIgIDxhbmR5QHZhbndhZ29uZXIuZmFtaWx5PgogCiAgICAg ICAgIFtJTlRMXSBDYWxsIFR5cGVkIEFycmF5IGVsZW1lbnRzIHRvTG9jYWxlU3RyaW5nIHdpdGgg bG9jYWxlIGFuZCBvcHRpb25zCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9yZWdyZXNzLTE4ODA2NS5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9yZWdyZXNzLTE4ODA2NS5qcwkobm9uZXhp c3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9yZWdyZXNzLTE4ODA2NS5qcwkod29ya2luZyBjb3B5 KQpAQCAtMCwwICsxLDggQEAKK2Z1bmN0aW9uIHRlc3QoKSB7CisgICAgdmFyIGFyciA9IG5ldyBB cnJheSg0MDApOworICAgIGFyci5jb25jYXQoWzEuMV0pOworfQorbm9JbmxpbmUodGVzdCk7CisK K2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDA7IGkrKykKKyAgICB0ZXN0KCk7CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNDI2MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxOC0wNy0y NiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAgYXJyYXlQcm90b1By aXZhdGVGdW5jQ29uY2F0TWVtY3B5KCkgc2hvdWxkIGhhbmRsZSBjb3B5aW5nIGZyb20gYW4gVW5k ZWNpZGVkIHR5cGUgYXJyYXkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODgwNjUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQyNTE1NzI2PgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVudGltZS9B cnJheVByb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OmNsZWFyRWxlbWVudCk6CisgICAgICAg IChKU0M6OmNvcHlFbGVtZW50cyk6CisgICAgICAgIChKU0M6OmFycmF5UHJvdG9Qcml2YXRlRnVu Y0NvbmNhdE1lbWNweSk6CisKIDIwMTgtMDctMjYgIEFuZHkgVmFuV2Fnb25lciAgPGFuZHlAdmFu d2Fnb25lci5mYW1pbHk+CiAKICAgICAgICAgSlNDOiBJbnRsIEFQSSBzaG91bGQgaWdub3JlIGVu Y29kaW5nIHdoZW4gcGFyc2luZyBCQ1AgNDcgbGFuZ3VhZ2UgdGFnIGZyb20gSVNPIDE1ODk3IGxv Y2FsZSBzdHJpbmcgKHBhc3NlZCB2aWEgTEFORykKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHAJKHJldmlzaW9uIDIzNDI2MSkKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTI5Miw2ICsxMjkyLDI5IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBjb25j YXRBcHBlbmRPbmUoRXgKIAogfQogCit0ZW1wbGF0ZTx0eXBlbmFtZSBUPgordm9pZCBjbGVhckVs ZW1lbnQoVCYgZWxlbWVudCkKK3sKKyAgICBlbGVtZW50LmNsZWFyKCk7Cit9CisKK3RlbXBsYXRl PD4KK3ZvaWQgY2xlYXJFbGVtZW50KGRvdWJsZSYgZWxlbWVudCkKK3sKKyAgICBlbGVtZW50ID0g UE5hTjsKK30KKwordGVtcGxhdGU8dHlwZW5hbWUgVCwgYm9vbCBpc0RvdWJsZSA9IHN0ZDo6aXNf c2FtZTxULCBkb3VibGU+Ojp2YWx1ZT4KK3ZvaWQgY29weUVsZW1lbnRzKFQqIGJ1ZmZlciwgdW5z aWduZWQgb2Zmc2V0LCB2b2lkKiBzb3VyY2UsIHVuc2lnbmVkIHNvdXJjZVNpemUsIEluZGV4aW5n VHlwZSBzb3VyY2VUeXBlKQoreworICAgIGlmIChzb3VyY2VUeXBlICE9IEFycmF5V2l0aFVuZGVj aWRlZCkgeworICAgICAgICBtZW1jcHkoYnVmZmVyICsgb2Zmc2V0LCBzb3VyY2UsIHNpemVvZihK U1ZhbHVlKSAqIHNvdXJjZVNpemUpOworICAgICAgICByZXR1cm47CisgICAgfQorCisgICAgZm9y ICh1bnNpZ25lZCBpID0gc291cmNlU2l6ZTsgaS0tOykKKyAgICAgICAgY2xlYXJFbGVtZW50PFQ+ KGJ1ZmZlcltpICsgb2Zmc2V0XSk7Cit9OwogCiBFbmNvZGVkSlNWYWx1ZSBKU0NfSE9TVF9DQUxM IGFycmF5UHJvdG9Qcml2YXRlRnVuY0NvbmNhdE1lbWNweShFeGVjU3RhdGUqIGV4ZWMpCiB7CkBA IC0xMzY3LDI2ICsxMzkwLDE2IEBAIEVuY29kZWRKU1ZhbHVlIEpTQ19IT1NUX0NBTEwgYXJyYXlQ cm90b1AKICAgICAgICAgdGhyb3dPdXRPZk1lbW9yeUVycm9yKGV4ZWMsIHNjb3BlKTsKICAgICAg ICAgcmV0dXJuIGVuY29kZWRKU1ZhbHVlKCk7CiAgICAgfQotICAgIAorCiAgICAgaWYgKHR5cGUg PT0gQXJyYXlXaXRoRG91YmxlKSB7CiAgICAgICAgIGRvdWJsZSogYnVmZmVyID0gcmVzdWx0LT5i dXR0ZXJmbHkoKS0+Y29udGlndW91c0RvdWJsZSgpLmRhdGEoKTsKLSAgICAgICAgbWVtY3B5KGJ1 ZmZlciwgZmlyc3RCdXR0ZXJmbHktPmNvbnRpZ3VvdXNEb3VibGUoKS5kYXRhKCksIHNpemVvZihK U1ZhbHVlKSAqIGZpcnN0QXJyYXlTaXplKTsKLSAgICAgICAgbWVtY3B5KGJ1ZmZlciArIGZpcnN0 QXJyYXlTaXplLCBzZWNvbmRCdXR0ZXJmbHktPmNvbnRpZ3VvdXNEb3VibGUoKS5kYXRhKCksIHNp emVvZihKU1ZhbHVlKSAqIHNlY29uZEFycmF5U2l6ZSk7CisgICAgICAgIGNvcHlFbGVtZW50cyhi dWZmZXIsIDAsIGZpcnN0QnV0dGVyZmx5LT5jb250aWd1b3VzRG91YmxlKCkuZGF0YSgpLCBmaXJz dEFycmF5U2l6ZSwgZmlyc3RUeXBlKTsKKyAgICAgICAgY29weUVsZW1lbnRzKGJ1ZmZlciwgZmly c3RBcnJheVNpemUsIHNlY29uZEJ1dHRlcmZseS0+Y29udGlndW91c0RvdWJsZSgpLmRhdGEoKSwg c2Vjb25kQXJyYXlTaXplLCBzZWNvbmRUeXBlKTsKKwogICAgIH0gZWxzZSBpZiAodHlwZSAhPSBB cnJheVdpdGhVbmRlY2lkZWQpIHsKICAgICAgICAgV3JpdGVCYXJyaWVyPFVua25vd24+KiBidWZm ZXIgPSByZXN1bHQtPmJ1dHRlcmZseSgpLT5jb250aWd1b3VzKCkuZGF0YSgpOwotICAgICAgICAK LSAgICAgICAgYXV0byBjb3B5ID0gWyZdICh1bnNpZ25lZCBvZmZzZXQsIHZvaWQqIHNvdXJjZSwg dW5zaWduZWQgc2l6ZSwgSW5kZXhpbmdUeXBlIHR5cGUpIHsKLSAgICAgICAgICAgIGlmICh0eXBl ICE9IEFycmF5V2l0aFVuZGVjaWRlZCkgewotICAgICAgICAgICAgICAgIG1lbWNweShidWZmZXIg KyBvZmZzZXQsIHNvdXJjZSwgc2l6ZW9mKEpTVmFsdWUpICogc2l6ZSk7Ci0gICAgICAgICAgICAg ICAgcmV0dXJuOwotICAgICAgICAgICAgfQotICAgICAgICAgICAgCi0gICAgICAgICAgICBmb3Ig KHVuc2lnbmVkIGkgPSBzaXplOyBpLS07KQotICAgICAgICAgICAgICAgIGJ1ZmZlcltpICsgb2Zm c2V0XS5jbGVhcigpOwotICAgICAgICB9OwotICAgICAgICAKLSAgICAgICAgY29weSgwLCBmaXJz dEJ1dHRlcmZseS0+Y29udGlndW91cygpLmRhdGEoKSwgZmlyc3RBcnJheVNpemUsIGZpcnN0VHlw ZSk7Ci0gICAgICAgIGNvcHkoZmlyc3RBcnJheVNpemUsIHNlY29uZEJ1dHRlcmZseS0+Y29udGln dW91cygpLmRhdGEoKSwgc2Vjb25kQXJyYXlTaXplLCBzZWNvbmRUeXBlKTsKKyAgICAgICAgY29w eUVsZW1lbnRzKGJ1ZmZlciwgMCwgZmlyc3RCdXR0ZXJmbHktPmNvbnRpZ3VvdXMoKS5kYXRhKCks IGZpcnN0QXJyYXlTaXplLCBmaXJzdFR5cGUpOworICAgICAgICBjb3B5RWxlbWVudHMoYnVmZmVy LCBmaXJzdEFycmF5U2l6ZSwgc2Vjb25kQnV0dGVyZmx5LT5jb250aWd1b3VzKCkuZGF0YSgpLCBz ZWNvbmRBcnJheVNpemUsIHNlY29uZFR5cGUpOwogICAgIH0KIAogICAgIHJlc3VsdC0+YnV0dGVy Zmx5KCktPnNldFB1YmxpY0xlbmd0aChyZXN1bHRTaXplKTsK 345854 2018-07-26 11:33:05 -0700 2018-07-26 11:33:05 -0700 patch for landing. bug-188065.patch text/plain 4502 mark.lam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzQyNjcpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDEzIEBACisyMDE4LTA3LTI2ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNv bT4KKworICAgICAgICBhcnJheVByb3RvUHJpdmF0ZUZ1bmNDb25jYXRNZW1jcHkoKSBzaG91bGQg aGFuZGxlIGNvcHlpbmcgZnJvbSBhbiBVbmRlY2lkZWQgdHlwZSBhcnJheS4KKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODA2NQorICAgICAgICA8cmRh cjovL3Byb2JsZW0vNDI1MTU3MjY+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgKiBzdHJlc3MvcmVncmVzcy0xODgwNjUuanM6IEFkZGVkLgorCiAyMDE4 LTA3LTI1ICBBbmR5IFZhbldhZ29uZXIgIDxhbmR5QHZhbndhZ29uZXIuZmFtaWx5PgogCiAgICAg ICAgIFtJTlRMXSBDYWxsIFR5cGVkIEFycmF5IGVsZW1lbnRzIHRvTG9jYWxlU3RyaW5nIHdpdGgg bG9jYWxlIGFuZCBvcHRpb25zCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9yZWdyZXNzLTE4ODA2NS5q cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9yZWdyZXNzLTE4ODA2NS5qcwkobm9uZXhp c3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9yZWdyZXNzLTE4ODA2NS5qcwkod29ya2luZyBjb3B5 KQpAQCAtMCwwICsxLDggQEAKK2Z1bmN0aW9uIHRlc3QoKSB7CisgICAgdmFyIGFyciA9IG5ldyBB cnJheSg0MDApOworICAgIGFyci5jb25jYXQoWzEuMV0pOworfQorbm9JbmxpbmUodGVzdCk7CisK K2ZvciAodmFyIGkgPSAwOyBpIDwgMTAwMDA7IGkrKykKKyAgICB0ZXN0KCk7CkluZGV4OiBTb3Vy Y2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2Ny aXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNDI2MSkKKysrIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxOC0wNy0y NiAgTWFyayBMYW0gIDxtYXJrLmxhbUBhcHBsZS5jb20+CisKKyAgICAgICAgYXJyYXlQcm90b1By aXZhdGVGdW5jQ29uY2F0TWVtY3B5KCkgc2hvdWxkIGhhbmRsZSBjb3B5aW5nIGZyb20gYW4gVW5k ZWNpZGVkIHR5cGUgYXJyYXkuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xODgwNjUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQyNTE1NzI2PgorCisg ICAgICAgIFJldmlld2VkIGJ5IFNhYW0gQmFyYXRpLgorCisgICAgICAgICogcnVudGltZS9BcnJh eVByb3RvdHlwZS5jcHA6CisgICAgICAgIChKU0M6OmNsZWFyRWxlbWVudCk6CisgICAgICAgIChK U0M6OmNvcHlFbGVtZW50cyk6CisgICAgICAgIChKU0M6OmFycmF5UHJvdG9Qcml2YXRlRnVuY0Nv bmNhdE1lbWNweSk6CisKIDIwMTgtMDctMjYgIEFuZHkgVmFuV2Fnb25lciAgPGFuZHlAdmFud2Fn b25lci5mYW1pbHk+CiAKICAgICAgICAgSlNDOiBJbnRsIEFQSSBzaG91bGQgaWdub3JlIGVuY29k aW5nIHdoZW4gcGFyc2luZyBCQ1AgNDcgbGFuZ3VhZ2UgdGFnIGZyb20gSVNPIDE1ODk3IGxvY2Fs ZSBzdHJpbmcgKHBhc3NlZCB2aWEgTEFORykKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9y dW50aW1lL0FycmF5UHJvdG90eXBlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlw dENvcmUvcnVudGltZS9BcnJheVByb3RvdHlwZS5jcHAJKHJldmlzaW9uIDIzNDI2MSkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0FycmF5UHJvdG90eXBlLmNwcAkod29ya2luZyBj b3B5KQpAQCAtMTI5Miw2ICsxMjkyLDI5IEBAIHN0YXRpYyBFbmNvZGVkSlNWYWx1ZSBjb25jYXRB cHBlbmRPbmUoRXgKIAogfQogCit0ZW1wbGF0ZTx0eXBlbmFtZSBUPgordm9pZCBjbGVhckVsZW1l bnQoVCYgZWxlbWVudCkKK3sKKyAgICBlbGVtZW50LmNsZWFyKCk7Cit9CisKK3RlbXBsYXRlPD4K K3ZvaWQgY2xlYXJFbGVtZW50KGRvdWJsZSYgZWxlbWVudCkKK3sKKyAgICBlbGVtZW50ID0gUE5h TjsKK30KKwordGVtcGxhdGU8dHlwZW5hbWUgVD4KK0FMV0FZU19JTkxJTkUgdm9pZCBjb3B5RWxl bWVudHMoVCogYnVmZmVyLCB1bnNpZ25lZCBvZmZzZXQsIHZvaWQqIHNvdXJjZSwgdW5zaWduZWQg c291cmNlU2l6ZSwgSW5kZXhpbmdUeXBlIHNvdXJjZVR5cGUpCit7CisgICAgaWYgKHNvdXJjZVR5 cGUgIT0gQXJyYXlXaXRoVW5kZWNpZGVkKSB7CisgICAgICAgIG1lbWNweShidWZmZXIgKyBvZmZz ZXQsIHNvdXJjZSwgc2l6ZW9mKEpTVmFsdWUpICogc291cmNlU2l6ZSk7CisgICAgICAgIHJldHVy bjsKKyAgICB9CisKKyAgICBmb3IgKHVuc2lnbmVkIGkgPSBzb3VyY2VTaXplOyBpLS07KQorICAg ICAgICBjbGVhckVsZW1lbnQ8VD4oYnVmZmVyW2kgKyBvZmZzZXRdKTsKK307CiAKIEVuY29kZWRK U1ZhbHVlIEpTQ19IT1NUX0NBTEwgYXJyYXlQcm90b1ByaXZhdGVGdW5jQ29uY2F0TWVtY3B5KEV4 ZWNTdGF0ZSogZXhlYykKIHsKQEAgLTEzNjcsMjYgKzEzOTAsMTYgQEAgRW5jb2RlZEpTVmFsdWUg SlNDX0hPU1RfQ0FMTCBhcnJheVByb3RvUAogICAgICAgICB0aHJvd091dE9mTWVtb3J5RXJyb3Io ZXhlYywgc2NvcGUpOwogICAgICAgICByZXR1cm4gZW5jb2RlZEpTVmFsdWUoKTsKICAgICB9Ci0g ICAgCisKICAgICBpZiAodHlwZSA9PSBBcnJheVdpdGhEb3VibGUpIHsKICAgICAgICAgZG91Ymxl KiBidWZmZXIgPSByZXN1bHQtPmJ1dHRlcmZseSgpLT5jb250aWd1b3VzRG91YmxlKCkuZGF0YSgp OwotICAgICAgICBtZW1jcHkoYnVmZmVyLCBmaXJzdEJ1dHRlcmZseS0+Y29udGlndW91c0RvdWJs ZSgpLmRhdGEoKSwgc2l6ZW9mKEpTVmFsdWUpICogZmlyc3RBcnJheVNpemUpOwotICAgICAgICBt ZW1jcHkoYnVmZmVyICsgZmlyc3RBcnJheVNpemUsIHNlY29uZEJ1dHRlcmZseS0+Y29udGlndW91 c0RvdWJsZSgpLmRhdGEoKSwgc2l6ZW9mKEpTVmFsdWUpICogc2Vjb25kQXJyYXlTaXplKTsKKyAg ICAgICAgY29weUVsZW1lbnRzKGJ1ZmZlciwgMCwgZmlyc3RCdXR0ZXJmbHktPmNvbnRpZ3VvdXNE b3VibGUoKS5kYXRhKCksIGZpcnN0QXJyYXlTaXplLCBmaXJzdFR5cGUpOworICAgICAgICBjb3B5 RWxlbWVudHMoYnVmZmVyLCBmaXJzdEFycmF5U2l6ZSwgc2Vjb25kQnV0dGVyZmx5LT5jb250aWd1 b3VzRG91YmxlKCkuZGF0YSgpLCBzZWNvbmRBcnJheVNpemUsIHNlY29uZFR5cGUpOworCiAgICAg fSBlbHNlIGlmICh0eXBlICE9IEFycmF5V2l0aFVuZGVjaWRlZCkgewogICAgICAgICBXcml0ZUJh cnJpZXI8VW5rbm93bj4qIGJ1ZmZlciA9IHJlc3VsdC0+YnV0dGVyZmx5KCktPmNvbnRpZ3VvdXMo KS5kYXRhKCk7Ci0gICAgICAgIAotICAgICAgICBhdXRvIGNvcHkgPSBbJl0gKHVuc2lnbmVkIG9m ZnNldCwgdm9pZCogc291cmNlLCB1bnNpZ25lZCBzaXplLCBJbmRleGluZ1R5cGUgdHlwZSkgewot ICAgICAgICAgICAgaWYgKHR5cGUgIT0gQXJyYXlXaXRoVW5kZWNpZGVkKSB7Ci0gICAgICAgICAg ICAgICAgbWVtY3B5KGJ1ZmZlciArIG9mZnNldCwgc291cmNlLCBzaXplb2YoSlNWYWx1ZSkgKiBz aXplKTsKLSAgICAgICAgICAgICAgICByZXR1cm47Ci0gICAgICAgICAgICB9Ci0gICAgICAgICAg ICAKLSAgICAgICAgICAgIGZvciAodW5zaWduZWQgaSA9IHNpemU7IGktLTspCi0gICAgICAgICAg ICAgICAgYnVmZmVyW2kgKyBvZmZzZXRdLmNsZWFyKCk7Ci0gICAgICAgIH07Ci0gICAgICAgIAot ICAgICAgICBjb3B5KDAsIGZpcnN0QnV0dGVyZmx5LT5jb250aWd1b3VzKCkuZGF0YSgpLCBmaXJz dEFycmF5U2l6ZSwgZmlyc3RUeXBlKTsKLSAgICAgICAgY29weShmaXJzdEFycmF5U2l6ZSwgc2Vj b25kQnV0dGVyZmx5LT5jb250aWd1b3VzKCkuZGF0YSgpLCBzZWNvbmRBcnJheVNpemUsIHNlY29u ZFR5cGUpOworICAgICAgICBjb3B5RWxlbWVudHMoYnVmZmVyLCAwLCBmaXJzdEJ1dHRlcmZseS0+ Y29udGlndW91cygpLmRhdGEoKSwgZmlyc3RBcnJheVNpemUsIGZpcnN0VHlwZSk7CisgICAgICAg IGNvcHlFbGVtZW50cyhidWZmZXIsIGZpcnN0QXJyYXlTaXplLCBzZWNvbmRCdXR0ZXJmbHktPmNv bnRpZ3VvdXMoKS5kYXRhKCksIHNlY29uZEFycmF5U2l6ZSwgc2Vjb25kVHlwZSk7CiAgICAgfQog CiAgICAgcmVzdWx0LT5idXR0ZXJmbHkoKS0+c2V0UHVibGljTGVuZ3RoKHJlc3VsdFNpemUpOwo=