188054 2018-07-26 07:42:34 -0700 Switching tabs should not close PiP window 2018-07-26 10:03:46 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson commit-queue jonlee webkit-bug-importer oldest_to_newest 1445404 0 eric.carlson 2018-07-26 07:42:34 -0700 The changes for bug 187623 cause the PiP window to close when switching tabs. 1445405 1 eric.carlson 2018-07-26 07:43:10 -0700 <rdar://problem/41212379> 1445411 2 345843 eric.carlson 2018-07-26 07:58:53 -0700 Created attachment 345843 Patch 1445444 3 webkit-bug-importer 2018-07-26 09:25:43 -0700 <rdar://problem/42626485> 1445448 4 jonlee 2018-07-26 09:50:43 -0700 rdar://problem/42599543 1445454 5 345843 commit-queue 2018-07-26 10:03:45 -0700 Comment on attachment 345843 Patch Clearing flags on attachment: 345843 Committed r234264: <https://trac.webkit.org/changeset/234264> 1445455 6 commit-queue 2018-07-26 10:03:46 -0700 All reviewed patches have been landed. Closing bug. 345843 2018-07-26 07:58:53 -0700 2018-07-26 10:03:45 -0700 Patch bug-188054-20180726075853.patch text/plain 4346 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MjEwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWU2NDNkNTA1ZjljMTQ3 MWJiOWY0YTcyZDE1YmJjN2U1ZjJhYWUwMC4uNDcyMmI0Y2YxYTNhZjgzNmMxMmVkZmVhZWFlMTcz ZDViYWM1ZTkwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI5IEBACisyMDE4LTA3LTI2ICBFcmlj IENhcmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFN3aXRjaGluZyB0 YWJzIHNob3VsZCBub3QgY2xvc2UgUGlQIHdpbmRvdworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg4MDU0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80 MTIxMjM3OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBObyBuZXcgdGVzdHMsIGZpeGVzIGFuIGV4aXN0aW5nIHRlc3QuCisgICAgICAgIAorICAgICAg ICBQcmlvciB0byByMjMzOTI2LCBjYWxsaW5nIFZpZGVvRnVsbHNjcmVlbkludGVyZmFjZU1hYzo6 cmVxdWVzdEhpZGVBbmRFeGl0RnVsbHNjcmVlbiB3YXMgYSBub29wLgorICAgICAgICBJbiByMjMz OTI2IGl0IHdhcyB1cGRhdGVkIHRvIGNsb3NlIHRoZSBQaVAgd2luZG93IGFuZCB3YXMgY2FsbGVk IGZyb20gdGhlIFBJUFZpZXdDb250cm9sbGVyRGVsZWdhdGUKKyAgICAgICAgc2VsZWN0b3JzIHRv IGNsb3NlIHRoZSBQaVAgd2luZG93LiByZXF1ZXN0SGlkZUFuZEV4aXRGdWxsc2NyZWVuIGlzIGFs c28gY2FsbGVkIGZyb20gCisgICAgICAgIFdlYlBhZ2VQcm94eTo6dmlld0RpZExlYXZlV2luZG93 IHdoZW4gdGhlIHdlYiB2aWV3IGlzIHJlbW92ZWQgZnJvbSBpdCB3aW5kb3csIHNvIHN3aXRjaGlu ZworICAgICAgICB0YWJzIGFsc28gY2xvc2VkIHRoZSBQaVAgd2luZG93LiBSZXZlcnQgdGhlIGNo YW5nZXMgdG8gcmVxdWVzdEhpZGVBbmRFeGl0RnVsbHNjcmVlbiwgYW5kIGFkZAorICAgICAgICBh IG5ldyBtZXRob2QgdGhhdCBpcyBvbmx5IHVzZWQgYnkgdGhlIGRlbGVnYXRlIHRvIGV4aXQgUGlQ LgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZU1hYy5o OgorICAgICAgICAoV2ViQ29yZTo6VmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlTWFjOjpyZXF1ZXN0 SGlkZUFuZEV4aXRGdWxsc2NyZWVuKTogTWFrZSB0aGlzIGFuIGVtcHR5LAorICAgICAgICBkby1u b3RoaW5nIG1ldGhvZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvVmlkZW9GdWxsc2NyZWVuSW50 ZXJmYWNlTWFjLm1tOgorICAgICAgICAoLVtXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VNYWNP YmpDIHBpcFNob3VsZENsb3NlOl0pOiBDYWxsIHJlcXVlc3RIaWRlQW5kRXhpdFBpUC4KKyAgICAg ICAgKC1bV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlTWFjT2JqQyBwaXBBY3Rpb25TdG9wOl0p OiBEaXR0by4KKyAgICAgICAgKFdlYkNvcmU6OlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZU1hYzo6 cmVxdWVzdEhpZGVBbmRFeGl0UGlQKTogUmVuYW1lZCBmcm9tIHJlcXVlc3RIaWRlQW5kRXhpdEZ1 bGxzY3JlZW4uCisgICAgICAgIChXZWJDb3JlOjpWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VNYWM6 OnJlcXVlc3RIaWRlQW5kRXhpdEZ1bGxzY3JlZW4pOiBEZWxldGVkLgorCiAyMDE4LTA3LTI1ICBE YXZpZCBGZW50b24gIDxkYXZpZF9mZW50b25AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQsIHJvbGxpbmcgb3V0IHIyMzQxODcuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9tYWMvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlTWFjLmggYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9tYWMvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlTWFjLmgKaW5kZXggOGI2OGM2YjFm OGUyMTAxOTRmYzQ5Y2U3Y2UwODc3NTVmZTU2ZjQ0Ny4uYWYyYzY0OWY1N2U1ZTE1ODU4MzFkZjhi MjQ2MjYyYjJlNzNkNmNiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFj L1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZU1hYy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL21hYy9WaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VNYWMuaApAQCAtNzcsNyArNzcsNyBAQCBw dWJsaWM6CiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBleGl0RnVsbHNjcmVlbldpdGhvdXRBbmlt YXRpb25Ub01vZGUoSFRNTE1lZGlhRWxlbWVudEVudW1zOjpWaWRlb0Z1bGxzY3JlZW5Nb2RlKTsK ICAgICBXRUJDT1JFX0VYUE9SVCB2b2lkIGNsZWFudXBGdWxsc2NyZWVuKCk7CiAgICAgV0VCQ09S RV9FWFBPUlQgdm9pZCBpbnZhbGlkYXRlKCk7Ci0gICAgV0VCQ09SRV9FWFBPUlQgdm9pZCByZXF1 ZXN0SGlkZUFuZEV4aXRGdWxsc2NyZWVuKCk7CisgICAgdm9pZCByZXF1ZXN0SGlkZUFuZEV4aXRG dWxsc2NyZWVuKCkgeyB9CiAgICAgV0VCQ09SRV9FWFBPUlQgdm9pZCBwcmVwYXJlZFRvUmV0dXJu VG9JbmxpbmUoYm9vbCB2aXNpYmxlLCBjb25zdCBJbnRSZWN0JiBpbmxpbmVSZWN0LCBOU1dpbmRv dyAqcGFyZW50V2luZG93KTsKICAgICB2b2lkIHByZXBhcmVkVG9FeGl0RnVsbHNjcmVlbigpIHsg fQogCkBAIC05NCw2ICs5NCw4IEBAIHB1YmxpYzoKIAogICAgIFdFQkNPUkVfRVhQT1JUIFdlYlZp ZGVvRnVsbHNjcmVlbkludGVyZmFjZU1hY09iakMgKnZpZGVvRnVsbHNjcmVlbkludGVyZmFjZU9i akMoKTsKIAorICAgIFdFQkNPUkVfRVhQT1JUIHZvaWQgcmVxdWVzdEhpZGVBbmRFeGl0UGlQKCk7 CisKIHByaXZhdGU6CiAgICAgV0VCQ09SRV9FWFBPUlQgVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNl TWFjKFBsYXliYWNrU2Vzc2lvbkludGVyZmFjZU1hYyYpOwogICAgIFJlZjxQbGF5YmFja1Nlc3Np b25JbnRlcmZhY2VNYWM+IG1fcGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWFjL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZU1hYy5t bSBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21hYy9WaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VN YWMubW0KaW5kZXggOGQyNDEzMzc3NDE5NzNlOTc5ZTZjNjUwNTVkOWQ5YWI4OTJhZDZmMi4uOGEw ZDAyMDUzZGYxMzRiMmY1YWViMGU4ZGI0OWU1Y2RiYjc5OGUzYyAxMDA2NDQKLS0tIGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vbWFjL1ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZU1hYy5tbQorKysg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tYWMvVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlTWFj Lm1tCkBAIC0yNzQsNyArMjc0LDcgQEAgZW51bSBjbGFzcyBQSVBTdGF0ZSB7CiAgICAgaWYgKCFf dmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlTWFjIHx8ICFfdmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNl TWFjLT52aWRlb0Z1bGxzY3JlZW5DaGFuZ2VPYnNlcnZlcigpKQogICAgICAgICByZXR1cm4gWUVT OwogCi0gICAgX3ZpZGVvRnVsbHNjcmVlbkludGVyZmFjZU1hYy0+cmVxdWVzdEhpZGVBbmRFeGl0 RnVsbHNjcmVlbigpOworICAgIF92aWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VNYWMtPnJlcXVlc3RI aWRlQW5kRXhpdFBpUCgpOwogCiAgICAgcmV0dXJuIE5POwogfQpAQCAtMzM1LDcgKzMzNSw3IEBA IGVudW0gY2xhc3MgUElQU3RhdGUgewogICAgIGlmIChQbGF5YmFja1Nlc3Npb25Nb2RlbCogcGxh eWJhY2tTZXNzaW9uTW9kZWwgPSBfdmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlTWFjLT5wbGF5YmFj a1Nlc3Npb25Nb2RlbCgpKQogICAgICAgICBwbGF5YmFja1Nlc3Npb25Nb2RlbC0+cGF1c2UoKTsK IAotICAgIF92aWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VNYWMtPnJlcXVlc3RIaWRlQW5kRXhpdEZ1 bGxzY3JlZW4oKTsKKyAgICBfdmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlTWFjLT5yZXF1ZXN0SGlk ZUFuZEV4aXRQaVAoKTsKICAgICBfcGlwU3RhdGUgPSBQSVBTdGF0ZTo6RXhpdGluZ1BJUDsKIH0K IApAQCAtNTA4LDcgKzUwOCw3IEBAIHZvaWQgVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlTWFjOjpp bnZhbGlkYXRlKCkKICAgICBtX3dlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZU9iakMgPSBuaWw7 CiB9CiAKLXZvaWQgVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlTWFjOjpyZXF1ZXN0SGlkZUFuZEV4 aXRGdWxsc2NyZWVuKCkKK3ZvaWQgVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlTWFjOjpyZXF1ZXN0 SGlkZUFuZEV4aXRQaVAoKQogewogICAgIGlmICghbV92aWRlb0Z1bGxzY3JlZW5Nb2RlbCkKICAg ICAgICAgcmV0dXJuOwo=