188045 2018-07-26 06:53:29 -0700 [WebIDL] Element's scrollLeft and scrollTop should be unrestricted double 2022-08-10 10:59:36 -0700 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 5991 1 fred.wang webkit-unassigned ahmad.saleem792 ap bfulgham cdumez cmarcelo dbates emilio esprehn+autocc ews-watchlist gyuyoung.kim kangil.han kondapallykalyan rado rniwa simon.fraser webkit-bug-importer oldest_to_newest 1445386 0 fred.wang 2018-07-26 06:53:29 -0700 Follow-up of bug 161610: (In reply to Simon Fraser (smfr) from comment #3) > > > Source/WebCore/dom/Element.idl:75 > > > - attribute long scrollLeft; > > > - attribute long scrollTop; > > > + attribute long scrollLeft; // FIXME: should be unrestricted double > > > + attribute long scrollTop; // FIXME: should be unrestricted double > > > > Seems relatively straightforward to fix this. > > I didn't want to make a web-facing change here in the same patch. 1445418 1 345845 fred.wang 2018-07-26 08:17:38 -0700 Created attachment 345845 Patch Just some quick patch for testing purpose... 1455611 2 fred.wang 2018-08-31 01:36:33 -0700 > (In reply to Simon Fraser (smfr) from comment #3) > > > > Source/WebCore/dom/Element.idl:75 > > > > - attribute long scrollLeft; > > > > - attribute long scrollTop; > > > > + attribute long scrollLeft; // FIXME: should be unrestricted double > > > > + attribute long scrollTop; // FIXME: should be unrestricted double > > > > > > Seems relatively straightforward to fix this. > > > > I didn't want to make a web-facing change here in the same patch. @Simon: Any idea how this change could be visible to the user? And hence whether we can can/should test it? I tried using values larger than the max long or non-integer values, but scrollable overflow elements/frames seem to have a limited size and to round up scroll position, so that does not seem easy. 1703464 3 emilio 2020-11-02 01:44:56 -0800 This should be user-visible, see https://bugzilla.mozilla.org/show_bug.cgi?id=1674687 for a test-case. Modulo compat I'm probably going to try changing Gecko to follow the spec. 1719895 4 rado 2021-01-15 08:58:35 -0800 Please fix this, because it makes a Scroll Snap Points carousel extremely hard to achieve. Thanks. 1719904 5 simon.fraser 2021-01-15 09:38:25 -0800 How so? 1719922 6 rado 2021-01-15 10:30:49 -0800 The container must be scrolled programmatically or with snapping to increments of its width. If the width is sub pixel, this is impossible as the browsers can only scroll to integer. 1890085 7 ahmad.saleem792 2022-08-09 13:40:13 -0700 I am able to reproduce this bug using test case from Mozilla bug: Test case - https://bug1674687.bmoattachments.org/attachment.cgi?id=9185098 Here are outputs across browsers: *** Safari 15.6 on macOS 12.5 *** max scrollTop is: 50 rect offset (real scroll top)is: 50 dpi is: 2 *** Firefox Nightly 105 *** max scrollTop is: 50 rect offset (real scroll top)is: 49.5 dpi is: 2 *** Chrome Canary 106 *** max scrollTop is: 49.5 rect offset (real scroll top)is: 49.5 dpi is: 2 ______ As per Mozilla bug, it should be 49.5 for both like Chrome. Just wanted to share updated testing results. Thanks! 1890350 8 webkit-bug-importer 2022-08-10 10:59:36 -0700 <rdar://problem/98460291> 345845 2018-07-26 08:17:38 -0700 2018-07-26 08:17:38 -0700 Patch 188045.patch text/plain 4567 fred.wang ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJD b3JlL2RvbS9FbGVtZW50LmNwcAppbmRleCAyMjYzMzQ5YzIyMC4uNWRlMjk5MDNjN2QgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9kb20vRWxlbWVudC5jcHAKQEAgLTkzNSw3ICs5MzUsNyBAQCBkb3VibGUgRWxlbWVudDo6Y2xp ZW50SGVpZ2h0KCkKICAgICByZXR1cm4gMDsKIH0KIAotaW50IEVsZW1lbnQ6OnNjcm9sbExlZnQo KQorZG91YmxlIEVsZW1lbnQ6OnNjcm9sbExlZnQoKQogewogICAgIGRvY3VtZW50KCkudXBkYXRl TGF5b3V0SWdub3JlUGVuZGluZ1N0eWxlc2hlZXRzKCk7CiAKQEAgLTk0NCw3ICs5NDQsNyBAQCBp bnQgRWxlbWVudDo6c2Nyb2xsTGVmdCgpCiAgICAgcmV0dXJuIDA7CiB9CiAKLWludCBFbGVtZW50 OjpzY3JvbGxUb3AoKQorZG91YmxlIEVsZW1lbnQ6OnNjcm9sbFRvcCgpCiB7CiAgICAgZG9jdW1l bnQoKS51cGRhdGVMYXlvdXRJZ25vcmVQZW5kaW5nU3R5bGVzaGVldHMoKTsKIApAQCAtOTUzLDcg Kzk1Myw3IEBAIGludCBFbGVtZW50OjpzY3JvbGxUb3AoKQogICAgIHJldHVybiAwOwogfQogCi12 b2lkIEVsZW1lbnQ6OnNldFNjcm9sbExlZnQoaW50IG5ld0xlZnQpCit2b2lkIEVsZW1lbnQ6OnNl dFNjcm9sbExlZnQoZG91YmxlIG5ld0xlZnQpCiB7CiAgICAgZG9jdW1lbnQoKS51cGRhdGVMYXlv dXRJZ25vcmVQZW5kaW5nU3R5bGVzaGVldHMoKTsKIApAQCAtOTY0LDcgKzk2NCw3IEBAIHZvaWQg RWxlbWVudDo6c2V0U2Nyb2xsTGVmdChpbnQgbmV3TGVmdCkKICAgICB9CiB9CiAKLXZvaWQgRWxl bWVudDo6c2V0U2Nyb2xsVG9wKGludCBuZXdUb3ApCit2b2lkIEVsZW1lbnQ6OnNldFNjcm9sbFRv cChkb3VibGUgbmV3VG9wKQogewogICAgIGRvY3VtZW50KCkudXBkYXRlTGF5b3V0SWdub3JlUGVu ZGluZ1N0eWxlc2hlZXRzKCk7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9FbGVt ZW50LmggYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCmluZGV4IDg0MmEyMDgwZTY2Li43 YzcyOTM3MTEyYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQuaAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5oCkBAIC0xNjYsMTAgKzE2NiwxMCBAQCBwdWJs aWM6CiAgICAgV0VCQ09SRV9FWFBPUlQgZG91YmxlIGNsaWVudFdpZHRoKCk7CiAgICAgV0VCQ09S RV9FWFBPUlQgZG91YmxlIGNsaWVudEhlaWdodCgpOwogCi0gICAgdmlydHVhbCBpbnQgc2Nyb2xs TGVmdCgpOwotICAgIHZpcnR1YWwgaW50IHNjcm9sbFRvcCgpOwotICAgIHZpcnR1YWwgdm9pZCBz ZXRTY3JvbGxMZWZ0KGludCk7Ci0gICAgdmlydHVhbCB2b2lkIHNldFNjcm9sbFRvcChpbnQpOwor ICAgIHZpcnR1YWwgZG91YmxlIHNjcm9sbExlZnQoKTsKKyAgICB2aXJ0dWFsIGRvdWJsZSBzY3Jv bGxUb3AoKTsKKyAgICB2aXJ0dWFsIHZvaWQgc2V0U2Nyb2xsTGVmdChkb3VibGUpOworICAgIHZp cnR1YWwgdm9pZCBzZXRTY3JvbGxUb3AoZG91YmxlKTsKICAgICB2aXJ0dWFsIGludCBzY3JvbGxX aWR0aCgpOwogICAgIHZpcnR1YWwgaW50IHNjcm9sbEhlaWdodCgpOwogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9kb20vRWxlbWVudC5pZGwgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRWxlbWVu dC5pZGwKaW5kZXggNzJmOWExNDgxNTEuLjExNDJjOGM0OTQyIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9kb20vRWxlbWVudC5pZGwKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0VsZW1lbnQu aWRsCkBAIC03OCw4ICs3OCw4IEBACiAgICAgdm9pZCBzY3JvbGxUbyh1bnJlc3RyaWN0ZWQgZG91 YmxlIHgsIHVucmVzdHJpY3RlZCBkb3VibGUgeSk7CiAgICAgdm9pZCBzY3JvbGxCeShvcHRpb25h bCBTY3JvbGxUb09wdGlvbnMgb3B0aW9uKTsKICAgICB2b2lkIHNjcm9sbEJ5KHVucmVzdHJpY3Rl ZCBkb3VibGUgeCwgdW5yZXN0cmljdGVkIGRvdWJsZSB5KTsKLSAgICBhdHRyaWJ1dGUgbG9uZyBz Y3JvbGxUb3A7IC8vIEZJWE1FKHdlYmtpdC5vcmcvYi8xODgwNDUpOiBzaG91bGQgYmUgdW5yZXN0 cmljdGVkIGRvdWJsZS4KLSAgICBhdHRyaWJ1dGUgbG9uZyBzY3JvbGxMZWZ0OyAvLyBGSVhNRSh3 ZWJraXQub3JnL2IvMTg4MDQ1KTogc2hvdWxkIGJlIHVucmVzdHJpY3RlZCBkb3VibGUuCisgICAg YXR0cmlidXRlIHVucmVzdHJpY3RlZCBkb3VibGUgc2Nyb2xsVG9wOworICAgIGF0dHJpYnV0ZSB1 bnJlc3RyaWN0ZWQgZG91YmxlIHNjcm9sbExlZnQ7CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGxv bmcgc2Nyb2xsV2lkdGg7CiAgICAgcmVhZG9ubHkgYXR0cmlidXRlIGxvbmcgc2Nyb2xsSGVpZ2h0 OwogICAgIHJlYWRvbmx5IGF0dHJpYnV0ZSBkb3VibGUgY2xpZW50VG9wOyAvLyBGSVhNRTogU2hv dWxkIGJlIG9mIHR5cGUgbG9uZy4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TEJvZHlFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJvZHlFbGVtZW50LmNw cAppbmRleCA4NDQyYWM5MjQyOC4uNzA5MmQzMjBjY2YgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTEJvZHlFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL0hU TUxCb2R5RWxlbWVudC5jcHAKQEAgLTI0Miw3ICsyNDIsNyBAQCBzdGF0aWMgaW50IGFkanVzdEZv clpvb20oaW50IHZhbHVlLCBjb25zdCBGcmFtZSYgZnJhbWUpCiAgICAgcmV0dXJuIHN0YXRpY19j YXN0PGludD4odmFsdWUgLyB6b29tRmFjdG9yKTsKIH0KIAotaW50IEhUTUxCb2R5RWxlbWVudDo6 c2Nyb2xsTGVmdCgpCitkb3VibGUgSFRNTEJvZHlFbGVtZW50OjpzY3JvbGxMZWZ0KCkKIHsKICAg ICBpZiAoaXNGaXJzdEJvZHlFbGVtZW50T2ZEb2N1bWVudCgpKSB7CiAgICAgICAgIGRvY3VtZW50 KCkudXBkYXRlTGF5b3V0SWdub3JlUGVuZGluZ1N0eWxlc2hlZXRzKCk7CkBAIC0yNTcsNyArMjU3 LDcgQEAgaW50IEhUTUxCb2R5RWxlbWVudDo6c2Nyb2xsTGVmdCgpCiAgICAgcmV0dXJuIEhUTUxF bGVtZW50OjpzY3JvbGxMZWZ0KCk7CiB9CiAKLXZvaWQgSFRNTEJvZHlFbGVtZW50OjpzZXRTY3Jv bGxMZWZ0KGludCBzY3JvbGxMZWZ0KQordm9pZCBIVE1MQm9keUVsZW1lbnQ6OnNldFNjcm9sbExl ZnQoZG91YmxlIHNjcm9sbExlZnQpCiB7CiAgICAgaWYgKGlzRmlyc3RCb2R5RWxlbWVudE9mRG9j dW1lbnQoKSkgewogICAgICAgICBkb2N1bWVudCgpLnVwZGF0ZUxheW91dElnbm9yZVBlbmRpbmdT dHlsZXNoZWV0cygpOwpAQCAtMjcyLDcgKzI3Miw3IEBAIHZvaWQgSFRNTEJvZHlFbGVtZW50Ojpz ZXRTY3JvbGxMZWZ0KGludCBzY3JvbGxMZWZ0KQogICAgIEhUTUxFbGVtZW50OjpzZXRTY3JvbGxM ZWZ0KHNjcm9sbExlZnQpOwogfQogCi1pbnQgSFRNTEJvZHlFbGVtZW50OjpzY3JvbGxUb3AoKQor ZG91YmxlIEhUTUxCb2R5RWxlbWVudDo6c2Nyb2xsVG9wKCkKIHsKICAgICBpZiAoaXNGaXJzdEJv ZHlFbGVtZW50T2ZEb2N1bWVudCgpKSB7CiAgICAgICAgIGRvY3VtZW50KCkudXBkYXRlTGF5b3V0 SWdub3JlUGVuZGluZ1N0eWxlc2hlZXRzKCk7CkBAIC0yODcsNyArMjg3LDcgQEAgaW50IEhUTUxC b2R5RWxlbWVudDo6c2Nyb2xsVG9wKCkKICAgICByZXR1cm4gSFRNTEVsZW1lbnQ6OnNjcm9sbFRv cCgpOwogfQogCi12b2lkIEhUTUxCb2R5RWxlbWVudDo6c2V0U2Nyb2xsVG9wKGludCBzY3JvbGxU b3ApCit2b2lkIEhUTUxCb2R5RWxlbWVudDo6c2V0U2Nyb2xsVG9wKGRvdWJsZSBzY3JvbGxUb3Ap CiB7CiAgICAgaWYgKGlzRmlyc3RCb2R5RWxlbWVudE9mRG9jdW1lbnQoKSkgewogICAgICAgICBk b2N1bWVudCgpLnVwZGF0ZUxheW91dElnbm9yZVBlbmRpbmdTdHlsZXNoZWV0cygpOwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MQm9keUVsZW1lbnQuaCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTEJvZHlFbGVtZW50LmgKaW5kZXggOTE5N2VjYzBhMzAuLmJhODRmMjgyNDQx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxCb2R5RWxlbWVudC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEJvZHlFbGVtZW50LmgKQEAgLTUyLDExICs1MiwxMSBA QCBwcml2YXRlOgogICAgIAogICAgIGJvb2wgc3VwcG9ydHNGb2N1cygpIGNvbnN0IGZpbmFsOwog Ci0gICAgaW50IHNjcm9sbExlZnQoKSBmaW5hbDsKLSAgICB2b2lkIHNldFNjcm9sbExlZnQoaW50 KSBmaW5hbDsKKyAgICBkb3VibGUgc2Nyb2xsTGVmdCgpIGZpbmFsOworICAgIHZvaWQgc2V0U2Ny b2xsTGVmdChkb3VibGUpIGZpbmFsOwogICAgIAotICAgIGludCBzY3JvbGxUb3AoKSBmaW5hbDsK LSAgICB2b2lkIHNldFNjcm9sbFRvcChpbnQpIGZpbmFsOworICAgIGRvdWJsZSBzY3JvbGxUb3Ao KSBmaW5hbDsKKyAgICB2b2lkIHNldFNjcm9sbFRvcChkb3VibGUpIGZpbmFsOwogCiAgICAgdm9p ZCBzY3JvbGxUbyhjb25zdCBTY3JvbGxUb09wdGlvbnMmLCBTY3JvbGxDbGFtcGluZykgZmluYWw7 CiAgICAgCg==