<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>188039</bug_id>
          
          <creation_ts>2018-07-26 01:22:50 -0700</creation_ts>
          <short_desc>[LayoutTests][Win] Configure perl binary location for CGI execution.</short_desc>
          <delta_ts>2019-03-04 12:27:09 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>CONFIGURATION CHANGED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Basuke Suzuki">basuke</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>ap</cc>
    
    <cc>basuke</cc>
    
    <cc>don.olmstead</cc>
    
    <cc>fujii</cc>
    
    <cc>lforschler</cc>
    
    <cc>ross.kirsling</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1445349</commentid>
    <comment_count>0</comment_count>
    <who name="Basuke Suzuki">basuke</who>
    <bug_when>2018-07-26 01:22:50 -0700</bug_when>
    <thetext>There are many CGIs used for http tests. It contains shbang line in it and usually point to /usr/bin/perl, which is not suitable for native Windows environment. PHP is more portable and I believe there&apos;s almost no case only Perl can handle some task. Let&apos;s convert&apos;em one by one. This is the meta bug for that task.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1445369</commentid>
    <comment_count>1</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-07-26 03:39:33 -0700</bug_when>
    <thetext>AppleWin port is also using XAMPP Apache. I think just a mis-configuration.

There is a comment.

https://github.com/WebKit/webkit/blob/master/LayoutTests/http/conf/apache2.4-httpd-win.conf#L57

&gt; # When using the above setting, specify the path to the Perl binary
&gt; # using the registry keys below:
&gt; # [HKEY_CLASSES_ROOT\.pl\Shell\ExecCGI\Command] @=&quot;c:\\PATH\TO\perl\\bin\\perl.exe&quot;
&gt; # HKEY_CLASSES_ROOT\.cgi\Shell\ExecCGI\Command] @=&quot;c:\\PATH\TO\perl\\bin\\perl.exe&quot;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1445370</commentid>
    <comment_count>2</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-07-26 03:40:59 -0700</bug_when>
    <thetext>There are some perl scripts in imported directory. I think it&apos;s not feasible to convert.


&gt; imported/blink/http/tests/misc/resources/image-slow-out-of-viewport.pl
&gt; imported/blink/http/tests/plugins/resources/mock-plugin-with-csp.pl
&gt; imported/blink/http/tests/security/contentSecurityPolicy/resources/frame-ancestors.pl
&gt; imported/blink/http/tests/security/contentSecurityPolicy/resources/frame-in-frame.pl
&gt; imported/blink/http/tests/security/contentSecurityPolicy/resources/redirect.pl
&gt; imported/blink/http/tests/security/contentSecurityPolicy/resources/test-csp-header.pl
&gt; imported/blink/http/tests/security/contentSecurityPolicy/resources/xhr-redirect-not-allowed.pl
&gt; imported/blink/http/tests/xmlhttprequest/resources/invalid-utf8-json.pl</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1445443</commentid>
    <comment_count>3</comment_count>
    <who name="Basuke Suzuki">basuke</who>
    <bug_when>2018-07-26 09:25:43 -0700</bug_when>
    <thetext>(In reply to Fujii Hironori from comment #1)
&gt; AppleWin port is also using XAMPP Apache. I think just a mis-configuration.
&gt; 
&gt; There is a comment.
&gt; 
&gt; https://github.com/WebKit/webkit/blob/master/LayoutTests/http/conf/apache2.4-
&gt; httpd-win.conf#L57
&gt; 
&gt; &gt; # When using the above setting, specify the path to the Perl binary
&gt; &gt; # using the registry keys below:
&gt; &gt; # [HKEY_CLASSES_ROOT\.pl\Shell\ExecCGI\Command] @=&quot;c:\\PATH\TO\perl\\bin\\perl.exe&quot;
&gt; &gt; # HKEY_CLASSES_ROOT\.cgi\Shell\ExecCGI\Command] @=&quot;c:\\PATH\TO\perl\\bin\\perl.exe&quot;

Oh, thank you for the info. This should be documented or showing warning in some where during the launching httpd.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1445447</commentid>
    <comment_count>4</comment_count>
    <who name="Basuke Suzuki">basuke</who>
    <bug_when>2018-07-26 09:43:51 -0700</bug_when>
    <thetext>Renamed summary from : [LayoutTests] Convert CGI written in Perl to PHP.

On Windows, XAMPP is used for layout test. We can assume perl is installed in XAMPP directory.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1445681</commentid>
    <comment_count>5</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-07-27 02:04:31 -0700</bug_when>
    <thetext>You need to install xammp-perl for WinCairo Docker.
https://github.com/WebKitForWindows/powershell-webkit-dev/blob/master/WebKitDev/Functions/Install-Xampp.ps1#L34</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1445952</commentid>
    <comment_count>6</comment_count>
    <who name="Basuke Suzuki">basuke</who>
    <bug_when>2018-07-27 17:43:46 -0700</bug_when>
    <thetext>(In reply to Fujii Hironori from comment #5)
&gt; You need to install xammp-perl for WinCairo Docker.
&gt; https://github.com/WebKitForWindows/powershell-webkit-dev/blob/master/
&gt; WebKitDev/Functions/Install-Xampp.ps1#L34

Right. Or make it configurable by env var. Or respect the predefined registry value.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1445953</commentid>
    <comment_count>7</comment_count>
    <who name="Basuke Suzuki">basuke</who>
    <bug_when>2018-07-27 17:44:36 -0700</bug_when>
    <thetext>Some CGI put &quot;-T&quot; option in the shebang line. So is the registry value.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1449227</commentid>
    <comment_count>8</comment_count>
    <who name="Basuke Suzuki">basuke</who>
    <bug_when>2018-08-09 22:06:07 -0700</bug_when>
    <thetext>These registry must be set for bots.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1477932</commentid>
    <comment_count>9</comment_count>
    <who name="Fujii Hironori">fujii</who>
    <bug_when>2018-11-13 00:00:09 -0800</bug_when>
    <thetext>https://github.com/WebKitForWindows/docker-webkit-dev/issues/7</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1512302</commentid>
    <comment_count>10</comment_count>
    <who name="Don Olmstead">don.olmstead</who>
    <bug_when>2019-03-04 12:27:09 -0800</bug_when>
    <thetext>This was fixed in the build bot image for wincairo.</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>