188035 2018-07-25 21:01:50 -0700 Manually activate the selection assistant for Tap and a Half gestures 2018-07-26 12:05:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED WONTFIX InRadar P2 Normal --- 1 megan_gardner megan_gardner simon.fraser thorton oldest_to_newest 1445281 0 megan_gardner 2018-07-25 21:01:50 -0700 Manually activate the selection assistant for Tap and a Half gestures 1445282 1 345816 megan_gardner 2018-07-25 21:04:53 -0700 Created attachment 345816 Patch 1445284 2 megan_gardner 2018-07-25 21:06:17 -0700 <rdar://problem/42595472> 1445290 3 345816 thorton 2018-07-25 21:39:27 -0700 Comment on attachment 345816 Patch Eww? Also, test? 1445296 4 345816 simon.fraser 2018-07-25 21:48:29 -0700 Comment on attachment 345816 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345816&action=review > Source/WebKit/ChangeLog:11 > + is starting. This does not interfear with activation for other gestures, and it ensures that interfere > Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2731 > + // <rdar://problem/42610532> Find a better way to make sure that the selection assistant is activated for tap and a half gestures Maybe don't include the radar title. 1445299 5 345816 thorton 2018-07-25 21:57:52 -0700 Comment on attachment 345816 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345816&action=review >> Source/WebKit/ChangeLog:11 >> + is starting. This does not interfear with activation for other gestures, and it ensures that > > interfere You don’t fear it? >> Source/WebKit/UIProcess/ios/WKContentViewInteraction.mm:2731 >> + // <rdar://problem/42610532> Find a better way to make sure that the selection assistant is activated for tap and a half gestures > > Maybe don't include the radar title. Yeah, this can be one line even, with the radar in parens after fixme. 1445482 6 megan_gardner 2018-07-26 12:05:20 -0700 Decided to go with a change in UIKit instead, as it was less hacky. 345816 2018-07-25 21:04:53 -0700 2018-07-25 21:39:27 -0700 Patch bug-188035-20180725210452.patch text/plain 2843 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNkMGQyMDc0NmUzOWM0ODlj MzhhMzM2NTQxNGUxZjY1ZmMyNTM0ZWQuLmY4OWI3YTIxMTgwYWFjNTg3ODZiNjUwMWFkOGVkZDYx OGQ3ZDE4OGMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTgtMDctMjUgIE1lZ2FuIEdh cmRuZXIgIDxtZWdhbl9nYXJkbmVyQGFwcGxlLmNvbT4KKworICAgICAgICBNYW51YWxseSBhY3Rp dmF0ZSB0aGUgc2VsZWN0aW9uIGFzc2lzdGFudCBmb3IgVGFwIGFuZCBhIEhhbGYgZ2VzdHVyZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODAzNQor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZvciBzb21l IHJlYXNvbiB0aGF0IGlzIG5vdCBmdWxseSB1bmRlcnN0b29kIHlldCwgdGhlIHRhcCBhbmQgYSBo YWxmIGdlc3R1cmUgZG9lcyBub3QgYWN0aXZhdGUKKyAgICAgICAgdGhlIHNlbGVjdGlvbiBhc3Np c3RhbnQsIGFuZCB0aHVzIHRoZSBzZWxlY3Rpb24gdmlldyB3aGVuIHRoZSBnZXN0dXJlIGlzIHN0 YXJ0aW5nLiBUaGUgZWFzaWVzdAorICAgICAgICBmaXggZm9yIHRoaXMgaXMgdG8gYWN0aXZhdGUg dGhlIHNlbGVjdGlvbiBtYW51YWxseSB3aGVuIHdlIGRldGVjdCB0aGF0IGEgdGFwIGFuZCBhIGhh bGYgZ2VzdHVyZQorICAgICAgICBpcyBzdGFydGluZy4gVGhpcyBkb2VzIG5vdCBpbnRlcmZlYXIg d2l0aCBhY3RpdmF0aW9uIGZvciBvdGhlciBnZXN0dXJlcywgYW5kIGl0IGVuc3VyZXMgdGhhdAor ICAgICAgICB0aGUgc2VsZWN0aW9uIGFzc2lzdGFudCBpcyBhY3RpdmUgZm9yIHRoaXMgY2FzZSB0 aGF0IGlzIG1pc3NlZC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0lu dGVyYWN0aW9uLm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGNoYW5nZVNlbGVjdGlvbldp dGhHZXN0dXJlQXQ6d2l0aEdlc3R1cmU6d2l0aFN0YXRlOndpdGhGbGFnczpdKToKKwogMjAxOC0w Ny0yMCAgVGltIEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBP Y2Nhc2lvbmFsIGNyYXNoIHVuZGVyIC1bV0tGb3JtSW5wdXRTZXNzaW9uIHNldFN1Z2dlc3Rpb25z Ol0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3 SW50ZXJhY3Rpb24ubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmll d0ludGVyYWN0aW9uLm1tCmluZGV4IGM4OTM5N2NkY2YxNWRlNzg2MzkzYTU1ZmU5NjllOGVjNGQ5 ZGUwYjIuLmYxZmNkMGY1NTFkYzk4NDZjNjNlNjIwNmJhNmNmZmY4NDYwMzJlMzggMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj dGlvbi5tbQpAQCAtMjcyNiw2ICsyNzI2LDEyIEBAIHN0YXRpYyB2b2lkIHNlbGVjdGlvbkNoYW5n ZWRXaXRoVG91Y2goV0tDb250ZW50VmlldyAqdmlldywgY29uc3QgV2ViQ29yZTo6SW50UG9pCiAt ICh2b2lkKWNoYW5nZVNlbGVjdGlvbldpdGhHZXN0dXJlQXQ6KENHUG9pbnQpcG9pbnQgd2l0aEdl c3R1cmU6KFVJV0tHZXN0dXJlVHlwZSlnZXN0dXJlVHlwZSB3aXRoU3RhdGU6KFVJR2VzdHVyZVJl Y29nbml6ZXJTdGF0ZSlzdGF0ZSB3aXRoRmxhZ3M6KFVJV0tTZWxlY3Rpb25GbGFncylmbGFncwog ewogICAgIF91c2luZ0dlc3R1cmVGb3JTZWxlY3Rpb24gPSBZRVM7CisgICAgCisgICAgLy8gRklY TUU6IFRoaXMgaXMgYSBoYWNreSB3YXkgdG8gZml4IHRoaXMKKyAgICAvLyA8cmRhcjovL3Byb2Js ZW0vNDI2MTA1MzI+IEZpbmQgYSBiZXR0ZXIgd2F5IHRvIG1ha2Ugc3VyZSB0aGF0IHRoZSBzZWxl Y3Rpb24gYXNzaXN0YW50IGlzIGFjdGl2YXRlZCBmb3IgdGFwIGFuZCBhIGhhbGYgZ2VzdHVyZXMK KyAgICBpZiAoc3RhdGUgPT0gVUlHZXN0dXJlUmVjb2duaXplclN0YXRlQmVnYW4gJiYgZ2VzdHVy ZVR5cGUgPT0gVUlXS0dlc3R1cmVUYXBBbmRBSGFsZikKKyAgICAgICAgW190ZXh0U2VsZWN0aW9u QXNzaXN0YW50IGFjdGl2YXRlU2VsZWN0aW9uXTsKKyAgICAKICAgICBfcGFnZS0+c2VsZWN0V2l0 aEdlc3R1cmUoV2ViQ29yZTo6SW50UG9pbnQocG9pbnQpLCBDaGFyYWN0ZXJHcmFudWxhcml0eSwg c3RhdGljX2Nhc3Q8dWludDMyX3Q+KHRvR2VzdHVyZVR5cGUoZ2VzdHVyZVR5cGUpKSwgc3RhdGlj X2Nhc3Q8dWludDMyX3Q+KHRvR2VzdHVyZVJlY29nbml6ZXJTdGF0ZShzdGF0ZSkpLCBbc2VsZiBf aXNJbnRlcmFjdGluZ1dpdGhBc3Npc3RlZE5vZGVdLCBbc2VsZiwgc3RhdGUsIGZsYWdzXShjb25z dCBXZWJDb3JlOjpJbnRQb2ludCYgcG9pbnQsIHVpbnQzMl90IGdlc3R1cmVUeXBlLCB1aW50MzJf dCBnZXN0dXJlU3RhdGUsIHVpbnQzMl90IGlubmVyRmxhZ3MsIFdlYktpdDo6Q2FsbGJhY2tCYXNl OjpFcnJvciBlcnJvcikgewogICAgICAgICBzZWxlY3Rpb25DaGFuZ2VkV2l0aEdlc3R1cmUoc2Vs ZiwgcG9pbnQsIGdlc3R1cmVUeXBlLCBnZXN0dXJlU3RhdGUsIGZsYWdzIHwgaW5uZXJGbGFncywg ZXJyb3IpOwogICAgICAgICBpZiAoc3RhdGUgPT0gVUlHZXN0dXJlUmVjb2duaXplclN0YXRlRW5k ZWQgfHwgc3RhdGUgPT0gVUlHZXN0dXJlUmVjb2duaXplclN0YXRlQ2FuY2VsbGVkKQo=