188031 2018-07-25 17:09:24 -0700 [ews-build] Add build steps DownloadBuiltProduct and ExtractBuiltProduct 2018-07-25 17:26:45 -0700 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=188016 https://bugs.webkit.org/show_bug.cgi?id=188014 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap ews-watchlist lforschler webkit-bug-importer oldest_to_newest 1445230 0 aakash_jain 2018-07-25 17:09:24 -0700 Builders on OpenSource EWS buildbot should archive the built product and upload the archive to the server, so that the testers can download the archive and run the tests. This would also help in re-using the archives for various kind of testers (WK1, WK2 etc.), being more efficient and speed-up the overall system. For that, we should add DownloadBuiltProduct and ExtractBuiltProduct build steps. 1445233 1 345804 aakash_jain 2018-07-25 17:12:00 -0700 Created attachment 345804 Proposed patch Sample run: http://ews-build.webkit-uat.org/#/builders/18/builds/26 1445234 2 345804 aakash_jain 2018-07-25 17:12:50 -0700 Comment on attachment 345804 Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=345804&action=review > Tools/BuildSlaveSupport/ews-build/steps.py:29 > +EWS_URL = 'http://ews-build.webkit-uat.org/' Note that this URL would be updated later on when the server is deployed in production. 1445235 3 ews-watchlist 2018-07-25 17:14:04 -0700 Attachment 345804 did not pass style-queue: ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:843: [TestExtractBuiltProduct.test_success] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:843: [TestExtractBuiltProduct.test_success] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:857: [TestExtractBuiltProduct.test_failure] Passing unexpected keyword argument 'state_string' in function call [pylint/E1123] [5] ERROR: Tools/BuildSlaveSupport/ews-build/steps_unittest.py:857: [TestExtractBuiltProduct.test_failure] No value passed for parameter 'status_text' in function call [pylint/E1120] [5] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1445239 4 aakash_jain 2018-07-25 17:24:03 -0700 Committed r234220: <https://trac.webkit.org/changeset/234220> 1445241 5 webkit-bug-importer 2018-07-25 17:26:45 -0700 <rdar://problem/42605103> 345804 2018-07-25 17:12:00 -0700 2018-07-25 17:17:45 -0700 Proposed patch ews_DownloadBuiltProduct.patch text/plain 4312 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzNDIxOCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE4LTA3LTI1ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgYnVpbGQgc3RlcHMgRG93bmxvYWRCdWlsdFBy b2R1Y3QgYW5kIEV4dHJhY3RCdWlsdFByb2R1Y3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE4ODAzMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBz LnB5OgorICAgICAgICAoRG93bmxvYWRCdWlsdFByb2R1Y3QpOiBBZGRlZCBidWlsZCBzdGVwIERv d25sb2FkQnVpbHRQcm9kdWN0LgorICAgICAgICAoRXh0cmFjdEJ1aWx0UHJvZHVjdCk6IEFkZGVk IGJ1aWxkIHN0ZXAgRXh0cmFjdEJ1aWx0UHJvZHVjdC4KKyAgICAgICAgKiBCdWlsZFNsYXZlU3Vw cG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHk6IEFkZGVkIHVuaXQtdGVzdHMuCisKIDIw MTgtMDctMjUgIEFha2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAg IFtld3MtYnVpbGRdIEFkZCBidWlsZCBzdGVwIFVwbG9hZEJ1aWx0UHJvZHVjdApJbmRleDogVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjM0MjE4 KQorKysgVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvZXdzLWJ1aWxkL3N0ZXBzLnB5CSh3b3JraW5n IGNvcHkpCkBAIC0yNiw2ICsyNiw3IEBAIGZyb20gYnVpbGRib3Quc3RlcHMgaW1wb3J0IHNoZWxs LCB0cmFuc2YKIGZyb20gYnVpbGRib3Quc3RlcHMuc291cmNlIGltcG9ydCBzdm4KIGZyb20gdHdp c3RlZC5pbnRlcm5ldCBpbXBvcnQgZGVmZXIKIAorRVdTX1VSTCA9ICdodHRwOi8vZXdzLWJ1aWxk LndlYmtpdC11YXQub3JnLycKIFdpdGhQcm9wZXJ0aWVzID0gcHJvcGVydGllcy5XaXRoUHJvcGVy dGllcwogCiAKQEAgLTMwOCwzICszMDksMjQgQEAgY2xhc3MgVXBsb2FkQnVpbHRQcm9kdWN0KHRy YW5zZmVyLkZpbGVVcAogICAgICAgICBrd2FyZ3NbJ21vZGUnXSA9IDA2NDQKICAgICAgICAga3dh cmdzWydibG9ja3NpemUnXSA9IDEwMjQgKiAyNTYKICAgICAgICAgdHJhbnNmZXIuRmlsZVVwbG9h ZC5fX2luaXRfXyhzZWxmLCAqKmt3YXJncykKKworCitjbGFzcyBEb3dubG9hZEJ1aWx0UHJvZHVj dChzaGVsbC5TaGVsbENvbW1hbmQpOgorICAgIGNvbW1hbmQgPSBbJ3B5dGhvbicsICdUb29scy9C dWlsZFNsYXZlU3VwcG9ydC9kb3dubG9hZC1idWlsdC1wcm9kdWN0JywKKyAgICAgICAgV2l0aFBy b3BlcnRpZXMoJy0tcGxhdGZvcm09JShwbGF0Zm9ybSlzJyksIFdpdGhQcm9wZXJ0aWVzKCctLSUo Y29uZmlndXJhdGlvbilzJyksCisgICAgICAgIFdpdGhQcm9wZXJ0aWVzKEVXU19VUkwgKyAnYXJj aGl2ZXMvJShmdWxsUGxhdGZvcm0pcy0lKGFyY2hpdGVjdHVyZSlzLSUoY29uZmlndXJhdGlvbilz LyUoZXdzcGF0Y2hpZClzLnppcCcpXQorICAgIG5hbWUgPSAnZG93bmxvYWQtYnVpbHQtcHJvZHVj dCcKKyAgICBkZXNjcmlwdGlvbiA9IFsnZG93bmxvYWRpbmcgYnVpbHQgcHJvZHVjdCddCisgICAg ZGVzY3JpcHRpb25Eb25lID0gWydkb3dubG9hZGVkIGJ1aWx0IHByb2R1Y3QnXQorICAgIGhhbHRP bkZhaWx1cmUgPSBUcnVlCisgICAgZmx1bmtPbkZhaWx1cmUgPSBUcnVlCisKKworY2xhc3MgRXh0 cmFjdEJ1aWx0UHJvZHVjdChzaGVsbC5TaGVsbENvbW1hbmQpOgorICAgIGNvbW1hbmQgPSBbJ3B5 dGhvbicsICdUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsdC1wcm9kdWN0LWFyY2hpdmUnLAor ICAgICAgICAgICAgICAgV2l0aFByb3BlcnRpZXMoJy0tcGxhdGZvcm09JShmdWxsUGxhdGZvcm0p cycpLCBXaXRoUHJvcGVydGllcygnLS0lKGNvbmZpZ3VyYXRpb24pcycpLCAnZXh0cmFjdCddCisg ICAgbmFtZSA9ICdleHRyYWN0LWJ1aWx0LXByb2R1Y3QnCisgICAgZGVzY3JpcHRpb24gPSBbJ2V4 dHJhY3RpbmcgYnVpbHQgcHJvZHVjdCddCisgICAgZGVzY3JpcHRpb25Eb25lID0gWydleHRyYWN0 ZWQgYnVpbHQgcHJvZHVjdCddCisgICAgaGFsdE9uRmFpbHVyZSA9IFRydWUKKyAgICBmbHVua09u RmFpbHVyZSA9IFRydWUKSW5kZXg6IFRvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9z dGVwc191bml0dGVzdC5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9l d3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDIzNDIxOCkKKysrIFRvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5 KQpAQCAtODIyLDUgKzgyMiw0MSBAQCBjbGFzcyBUZXN0VXBsb2FkQnVpbHRQcm9kdWN0KEJ1aWxk U3RlcE1pCiAgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQogCiAKK2NsYXNzIFRlc3RFeHRy YWN0QnVpbHRQcm9kdWN0KEJ1aWxkU3RlcE1peGluQWRkaXRpb25zLCB1bml0dGVzdC5UZXN0Q2Fz ZSk6CisgICAgZGVmIHNldFVwKHNlbGYpOgorICAgICAgICBzZWxmLmxvbmdNZXNzYWdlID0gVHJ1 ZQorICAgICAgICByZXR1cm4gc2VsZi5zZXRVcEJ1aWxkU3RlcCgpCisKKyAgICBkZWYgdGVhckRv d24oc2VsZik6CisgICAgICAgIHJldHVybiBzZWxmLnRlYXJEb3duQnVpbGRTdGVwKCkKKworICAg IGRlZiB0ZXN0X3N1Y2Nlc3Moc2VsZik6CisgICAgICAgIHNlbGYuc2V0dXBTdGVwKEV4dHJhY3RC dWlsdFByb2R1Y3QoKSkKKyAgICAgICAgc2VsZi5zZXRQcm9wZXJ0eSgnZnVsbFBsYXRmb3JtJywg J2lvcy1zaW11bGF0b3InKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5KCdjb25maWd1cmF0aW9u JywgJ3JlbGVhc2UnKQorICAgICAgICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1hbmRzKAorICAgICAg ICAgICAgRXhwZWN0U2hlbGwod29ya2Rpcj0nd2tkaXInLAorICAgICAgICAgICAgICAgICAgICAg ICAgY29tbWFuZD1bJ3B5dGhvbicsICdUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsdC1wcm9k dWN0LWFyY2hpdmUnLCAnLS1wbGF0Zm9ybT1pb3Mtc2ltdWxhdG9yJywgICctLXJlbGVhc2UnLCAn ZXh0cmFjdCddLAorICAgICAgICAgICAgICAgICAgICAgICAgKQorICAgICAgICAgICAgKyAwLAor ICAgICAgICApCisgICAgICAgIHNlbGYuZXhwZWN0T3V0Y29tZShyZXN1bHQ9U1VDQ0VTUywgc3Rh dGVfc3RyaW5nPSdleHRyYWN0ZWQgYnVpbHQgcHJvZHVjdCcpCisgICAgICAgIHJldHVybiBzZWxm LnJ1blN0ZXAoKQorCisgICAgZGVmIHRlc3RfZmFpbHVyZShzZWxmKToKKyAgICAgICAgc2VsZi5z ZXR1cFN0ZXAoRXh0cmFjdEJ1aWx0UHJvZHVjdCgpKQorICAgICAgICBzZWxmLnNldFByb3BlcnR5 KCdmdWxsUGxhdGZvcm0nLCAnbWFjLXNpZXJyYScpCisgICAgICAgIHNlbGYuc2V0UHJvcGVydHko J2NvbmZpZ3VyYXRpb24nLCAnZGVidWcnKQorICAgICAgICBzZWxmLmV4cGVjdFJlbW90ZUNvbW1h bmRzKAorICAgICAgICAgICAgRXhwZWN0U2hlbGwod29ya2Rpcj0nd2tkaXInLAorICAgICAgICAg ICAgICAgICAgICAgICAgY29tbWFuZD1bJ3B5dGhvbicsICdUb29scy9CdWlsZFNsYXZlU3VwcG9y dC9idWlsdC1wcm9kdWN0LWFyY2hpdmUnLCAnLS1wbGF0Zm9ybT1tYWMtc2llcnJhJywgICctLWRl YnVnJywgJ2V4dHJhY3QnXSwKKyAgICAgICAgICAgICAgICAgICAgICAgICkKKyAgICAgICAgICAg ICsgRXhwZWN0U2hlbGwubG9nKCdzdGRpbycsIHN0ZG91dD0nVW5leHBlY3RlZCBmYWlsdXJlLicp CisgICAgICAgICAgICArIDIsCisgICAgICAgICkKKyAgICAgICAgc2VsZi5leHBlY3RPdXRjb21l KHJlc3VsdD1GQUlMVVJFLCBzdGF0ZV9zdHJpbmc9J2V4dHJhY3RlZCBidWlsdCBwcm9kdWN0IChm YWlsdXJlKScpCisgICAgICAgIHJldHVybiBzZWxmLnJ1blN0ZXAoKQorCisKIGlmIF9fbmFtZV9f ID09ICdfX21haW5fXyc6CiAgICAgdW5pdHRlc3QubWFpbigpCg==