187976 2018-07-24 15:36:18 -0700 Mask AVBackgroundView to the corner radius. 2019-06-16 21:05:29 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 jeremyj-wk webkit-unassigned commit-queue eric.carlson fred.wang jonlee sam simon.fraser webkit-bug-importer oldest_to_newest 1444861 0 jeremyj-wk 2018-07-24 15:36:18 -0700 Mask AVBackgroundView to the corner radius. 1444862 1 jeremyj-wk 2018-07-24 15:37:17 -0700 rdar://problem/41810866 1444863 2 345721 jeremyj-wk 2018-07-24 15:40:42 -0700 Created attachment 345721 Patch 1444908 3 345721 sam 2018-07-24 17:38:09 -0700 Comment on attachment 345721 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345721&action=review > Source/WebKit/ChangeLog:12 > + This changes sets the appropriate mask to the layer so the corners look correct. > + > + * UIProcess/ios/fullscreen/WKFullscreenStackView.mm: > + (-[WKFullscreenStackView init]): How can this be tested? 1444952 4 345721 jonlee 2018-07-24 20:46:42 -0700 Comment on attachment 345721 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345721&action=review > Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:63 > + [_backgroundView setClipsToBounds:YES]; Please add a FIXME for reverting this workaround. 1445172 5 jeremyj-wk 2018-07-25 14:38:31 -0700 (In reply to Jon Lee from comment #4) > Comment on attachment 345721 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345721&action=review > > > Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:63 > > + [_backgroundView setClipsToBounds:YES]; > > Please add a FIXME for reverting this workaround. Added bugzilla bug for the cleanup: https://bugs.webkit.org/show_bug.cgi?id=188022 1445174 6 345785 jeremyj-wk 2018-07-25 14:42:51 -0700 Created attachment 345785 Patch for landing. 1445175 7 jeremyj-wk 2018-07-25 14:43:36 -0700 (In reply to Sam Weinig from comment #3) > Comment on attachment 345721 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345721&action=review > > > Source/WebKit/ChangeLog:12 > > + This changes sets the appropriate mask to the layer so the corners look correct. > > + > > + * UIProcess/ios/fullscreen/WKFullscreenStackView.mm: > > + (-[WKFullscreenStackView init]): > > How can this be tested? We don't have a way to test this. 1445199 8 345785 commit-queue 2018-07-25 15:51:30 -0700 Comment on attachment 345785 Patch for landing. Clearing flags on attachment: 345785 Committed r234216: <https://trac.webkit.org/changeset/234216> 1461508 9 345785 fred.wang 2018-09-20 13:30:14 -0700 Comment on attachment 345785 Patch for landing. View in context: https://bugs.webkit.org/attachment.cgi?id=345785&action=review > Source/WebKit/UIProcess/ios/fullscreen/WKFullscreenStackView.mm:65 > + [_backgroundView.get().layer setContinuousCorners:YES]; For the record, this is causing build failure with XCode 10 (public SDK). I opened https://bugs.webkit.org/show_bug.cgi?id=189786 345721 2018-07-24 15:40:42 -0700 2018-07-24 20:46:42 -0700 Patch bug-187976-20180724154042.patch text/plain 1585 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFjMjhmYTBkYjQxMDM2NmE5 YzViZDg4YjdhNzVjZDQ4OWRlYzU0OWIuLmY4YjIxMDE4OTk4MDFkYTZlNzRlMWJmNjYyMjliZDBj ZGRhZjYwY2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDctMjQgIEplcmVteSBK b25lcyAgPGplcmVteWpAYXBwbGUuY29tPgorCisgICAgICAgIE1hc2sgQVZCYWNrZ3JvdW5kVmll dyB0byB0aGUgY29ybmVyIHJhZGl1cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4Nzk3NgorICAgICAgICByZGFyOi8vcHJvYmxlbS80MTgxMDg2Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgY2hh bmdlcyBzZXRzIHRoZSBhcHByb3ByaWF0ZSBtYXNrIHRvIHRoZSBsYXllciBzbyB0aGUgY29ybmVy cyBsb29rIGNvcnJlY3QuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL2Z1bGxzY3JlZW4vV0tG dWxsc2NyZWVuU3RhY2tWaWV3Lm1tOgorICAgICAgICAoLVtXS0Z1bGxzY3JlZW5TdGFja1ZpZXcg aW5pdF0pOgorCiAyMDE4LTA3LTIzICBKb2huIFdpbGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29t PgogCiAgICAgICAgIFJlc291cmNlIExvYWQgU3RhdGlzdGljczogQWRkIGxvZ2dpbmcgb2YgU3Rv cmFnZSBBY2Nlc3MgQVBJIHVzZSBpbiBleHBlcmltZW50YWwgZGVidWcgbW9kZQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Z1bGxzY3JlZW4vV0tGdWxsc2NyZWVuU3Rh Y2tWaWV3Lm1tIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Z1bGxzY3JlZW4vV0tGdWxs c2NyZWVuU3RhY2tWaWV3Lm1tCmluZGV4IDYxMTUxYjgyZjMwOTkxNTZjNzA2NjY2YTA5Y2Y4MDY3 NDgzOTUzOTkuLjZjNmFkYWZjNTkwOGJhNDI5NDEzYzlkNDc5NzA3ODM1YmYwOTU2YmMgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dLRnVsbHNjcmVl blN0YWNrVmlldy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNjcmVl bi9XS0Z1bGxzY3JlZW5TdGFja1ZpZXcubW0KQEAgLTYwLDYgKzYwLDEwIEBAIC0gKGluc3RhbmNl dHlwZSlpbml0CiAgICAgX2JhY2tncm91bmRWaWV3ID0gYWRvcHROUyhbYWxsb2NBVkJhY2tncm91 bmRWaWV3SW5zdGFuY2UoKSBpbml0V2l0aEZyYW1lOmZyYW1lXSk7CiAgICAgW3NlbGYgYWRkU3Vi dmlldzpfYmFja2dyb3VuZFZpZXcuZ2V0KCldOwogCisgICAgW19iYWNrZ3JvdW5kVmlldyBzZXRD bGlwc1RvQm91bmRzOllFU107CisgICAgW19iYWNrZ3JvdW5kVmlldy5nZXQoKS5sYXllciBzZXRD b250aW51b3VzQ29ybmVyczpZRVNdOworICAgIFtfYmFja2dyb3VuZFZpZXcuZ2V0KCkubGF5ZXIg c2V0Q29ybmVyUmFkaXVzOjE2XTsKKwogICAgIHJldHVybiBzZWxmOwogfQogCg== 345785 2018-07-25 14:42:51 -0700 2018-07-25 15:51:30 -0700 Patch for landing. bug-187976-20180725144251.patch text/plain 1688 jeremyj-wk U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MTA5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFjMjhmYTBkYjQxMDM2NmE5 YzViZDg4YjdhNzVjZDQ4OWRlYzU0OWIuLjM4YzI5OTE2ZTdiMmE2MWI2YWM0YWJmMTg0MjQ0ZWE0 ZTBiODUzNTIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDctMjQgIEplcmVteSBK b25lcyAgPGplcmVteWpAYXBwbGUuY29tPgorCisgICAgICAgIE1hc2sgQVZCYWNrZ3JvdW5kVmll dyB0byB0aGUgY29ybmVyIHJhZGl1cy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4Nzk3NgorICAgICAgICByZGFyOi8vcHJvYmxlbS80MTgxMDg2Ngor CisgICAgICAgIFJldmlld2VkIGJ5IEpvbiBMZWUuCisKKyAgICAgICAgVGhpcyBjaGFuZ2VzIHNl dHMgdGhlIGFwcHJvcHJpYXRlIG1hc2sgdG8gdGhlIGxheWVyIHNvIHRoZSBjb3JuZXJzIGxvb2sg Y29ycmVjdC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1bGxzY3Jl ZW5TdGFja1ZpZXcubW06CisgICAgICAgICgtW1dLRnVsbHNjcmVlblN0YWNrVmlldyBpbml0XSk6 CisKIDIwMTgtMDctMjMgIEpvaG4gV2lsYW5kZXIgIDx3aWxhbmRlckBhcHBsZS5jb20+CiAKICAg ICAgICAgUmVzb3VyY2UgTG9hZCBTdGF0aXN0aWNzOiBBZGQgbG9nZ2luZyBvZiBTdG9yYWdlIEFj Y2VzcyBBUEkgdXNlIGluIGV4cGVyaW1lbnRhbCBkZWJ1ZyBtb2RlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1bGxzY3JlZW5TdGFja1ZpZXcu bW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9pb3MvZnVsbHNjcmVlbi9XS0Z1bGxzY3JlZW5T dGFja1ZpZXcubW0KaW5kZXggNjExNTFiODJmMzA5OTE1NmM3MDY2NjZhMDljZjgwNjc0ODM5NTM5 OS4uY2RjODJjOGQwOTk5Yjg2MTU4OGQ5NzJiZjhlZWE3ZWJjOTljOTcxYiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL2Z1bGxzY3JlZW4vV0tGdWxsc2NyZWVuU3RhY2tW aWV3Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9mdWxsc2NyZWVuL1dLRnVs bHNjcmVlblN0YWNrVmlldy5tbQpAQCAtNjAsNiArNjAsMTEgQEAgLSAoaW5zdGFuY2V0eXBlKWlu aXQKICAgICBfYmFja2dyb3VuZFZpZXcgPSBhZG9wdE5TKFthbGxvY0FWQmFja2dyb3VuZFZpZXdJ bnN0YW5jZSgpIGluaXRXaXRoRnJhbWU6ZnJhbWVdKTsKICAgICBbc2VsZiBhZGRTdWJ2aWV3Ol9i YWNrZ3JvdW5kVmlldy5nZXQoKV07CiAKKyAgICAvLyBGSVhNRTogcmVtb3ZlIHRoaXMgb25jZSBB VkJhY2tncm91bmRWaWV3IGhhbmRsZXMgdGhpcy4gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4ODAyMgorICAgIFtfYmFja2dyb3VuZFZpZXcgc2V0Q2xpcHNUb0JvdW5k czpZRVNdOworICAgIFtfYmFja2dyb3VuZFZpZXcuZ2V0KCkubGF5ZXIgc2V0Q29udGludW91c0Nv cm5lcnM6WUVTXTsKKyAgICBbX2JhY2tncm91bmRWaWV3LmdldCgpLmxheWVyIHNldENvcm5lclJh ZGl1czoxNl07CisKICAgICByZXR1cm4gc2VsZjsKIH0KIAo=