187970 2018-07-24 13:27:46 -0700 [LFC][BFC] Do not try to access containing block's height during descendant height computation 2018-07-26 07:27:19 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1444810 0 zalan 2018-07-24 13:27:46 -0700 mostly because it's not computed yet. 1444816 1 345707 zalan 2018-07-24 13:32:55 -0700 Created attachment 345707 Patch 1445396 2 zalan 2018-07-26 07:26:05 -0700 Committed r234255: <https://trac.webkit.org/changeset/234255> 1445397 3 webkit-bug-importer 2018-07-26 07:27:19 -0700 <rdar://problem/42623313> 345707 2018-07-24 13:32:55 -0700 2018-07-26 02:56:03 -0700 Patch bug-187970-20180724133254.patch text/plain 7546 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MTY2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDFjZjIwNzVlNjFiZTNm N2I3N2I5MTYzOGRjZjQ4ZDNhMDIxNTdmYi4uYjdhNjIzY2U4MmRjNTYzZmM3M2UyNzg4NmMxYzNm NjE1MTA5NGFhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE4LTA3LTI0ICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bQkZDXSBEbyBub3Qg dHJ5IHRvIGFjY2VzcyBjb250YWluaW5nIGJsb2NrJ3MgaGVpZ2h0IGR1cmluZyBkZXNjZW5kYW50 IGhlaWdodCBjb21wdXRhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTg3OTcwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTW9zdGx5IGJlY2FzdWUgaW4gQkZDLCB3ZSBjb21wdXRlIHRoZSBkZXNjZW5k ZW50cycgaGVpZ2h0IGZpcnN0IHNvIHRoZSBjb250YWluaW5nIGJsb2NrJ3MgaGVpZ2h0IGlzIHBy b2JhYmx5IG5vdCBjb21wdXRlZCB5ZXQuIAorCisgICAgICAgICogbGF5b3V0L0Zvcm1hdHRpbmdD b250ZXh0R2VvbWV0cnkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpGb3JtYXR0aW5n Q29udGV4dDo6R2VvbWV0cnk6OmZsb2F0aW5nTm9uUmVwbGFjZWRIZWlnaHRBbmRNYXJnaW4pOgor ICAgICAgICAoV2ViQ29yZTo6TGF5b3V0OjpGb3JtYXR0aW5nQ29udGV4dDo6R2VvbWV0cnk6Omlu bGluZVJlcGxhY2VkSGVpZ2h0QW5kTWFyZ2luKToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6 Rm9ybWF0dGluZ0NvbnRleHQ6Okdlb21ldHJ5OjppbmxpbmVSZXBsYWNlZFdpZHRoQW5kTWFyZ2lu KToKKwogMjAxOC0wNy0yNCAgQW50b2luZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAg ICAgICAgIFtXZWIgQW5pbWF0aW9uc10gQWRkIGFuIEFTU0VSVCgpIHRvIGNoZWNrIHRoZSBjb250 cmFjdCB0aGF0IGEgQ1NTVHJhbnNpdGlvbiBoYXMgYSB2YWxpZCBlZmZlY3QgaW4gc2V0VGltaW5n UHJvcGVydGllcygpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvRm9ybWF0dGlu Z0NvbnRleHRHZW9tZXRyeS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvRm9ybWF0dGluZ0Nv bnRleHRHZW9tZXRyeS5jcHAKaW5kZXggNDE0YjM2NDgzMGZmZDRlNzAwMjRiNWEyODc0OTdkMzFi OGY4MjIzZC4uZmJmZmU3M2NkNzg5MzhhNDUwYWJkNjdkMzJhZGVlOTA3Y2M0NGQ2OSAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L0Zvcm1hdHRpbmdDb250ZXh0R2VvbWV0cnkuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9Gb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNw cApAQCAtNTg2LDEwICs1ODYsOSBAQCBIZWlnaHRBbmRNYXJnaW4gRm9ybWF0dGluZ0NvbnRleHQ6 Okdlb21ldHJ5OjpmbG9hdGluZ05vblJlcGxhY2VkSGVpZ2h0QW5kTWFyZ2luKAogICAgIGF1dG8m IHN0eWxlID0gbGF5b3V0Qm94LnN0eWxlKCk7CiAgICAgYXV0byYgY29udGFpbmluZ0Jsb2NrID0g KmxheW91dEJveC5jb250YWluaW5nQmxvY2soKTsKICAgICBhdXRvJiBjb250YWluaW5nQmxvY2tE aXNwbGF5Qm94ID0gKmxheW91dENvbnRleHQuZGlzcGxheUJveEZvckxheW91dEJveChjb250YWlu aW5nQmxvY2spOwotICAgIGF1dG8gY29udGFpbmluZ0Jsb2NrSGVpZ2h0ID0gY29udGFpbmluZ0Js b2NrRGlzcGxheUJveC5jb250ZW50Qm94SGVpZ2h0KCk7CiAgICAgYXV0byBjb250YWluaW5nQmxv Y2tXaWR0aCA9IGNvbnRhaW5pbmdCbG9ja0Rpc3BsYXlCb3guY29udGVudEJveFdpZHRoKCk7CiAK LSAgICBhdXRvIGhlaWdodCA9IGNvbXB1dGVkVmFsdWVJZk5vdEF1dG8oc3R5bGUubG9naWNhbEhl aWdodCgpLCBjb250YWluaW5nQmxvY2tIZWlnaHQpOworICAgIGF1dG8gaGVpZ2h0ID0gZml4ZWRW YWx1ZShzdHlsZS5sb2dpY2FsSGVpZ2h0KCkpOwogICAgIGF1dG8gbWFyZ2luVG9wID0gY29tcHV0 ZWRWYWx1ZUlmTm90QXV0byhzdHlsZS5tYXJnaW5Ub3AoKSwgY29udGFpbmluZ0Jsb2NrV2lkdGgp OwogICAgIGF1dG8gbWFyZ2luQm90dG9tID0gY29tcHV0ZWRWYWx1ZUlmTm90QXV0byhzdHlsZS5t YXJnaW5Cb3R0b20oKSwgY29udGFpbmluZ0Jsb2NrV2lkdGgpOwogCkBAIC01OTcsOCArNTk2LDE2 IEBAIEhlaWdodEFuZE1hcmdpbiBGb3JtYXR0aW5nQ29udGV4dDo6R2VvbWV0cnk6OmZsb2F0aW5n Tm9uUmVwbGFjZWRIZWlnaHRBbmRNYXJnaW4oCiAgICAgbWFyZ2luVG9wID0gbWFyZ2luVG9wLnZh bHVlX29yKDApOwogICAgIG1hcmdpbkJvdHRvbSA9IG1hcmdpbkJvdHRvbS52YWx1ZV9vcigwKTsK ICAgICAvLyAjMgotICAgIGlmICghaGVpZ2h0KQotICAgICAgICBoZWlnaHQgPSBjb250ZW50SGVp Z2h0Rm9yRm9ybWF0dGluZ0NvbnRleHRSb290KGxheW91dENvbnRleHQsIGxheW91dEJveCk7Cisg ICAgaWYgKCFoZWlnaHQpIHsKKyAgICAgICAgaWYgKHN0eWxlLmxvZ2ljYWxIZWlnaHQoKS5pc0F1 dG8oKSkKKyAgICAgICAgICAgIGhlaWdodCA9IGNvbnRlbnRIZWlnaHRGb3JGb3JtYXR0aW5nQ29u dGV4dFJvb3QobGF5b3V0Q29udGV4dCwgbGF5b3V0Qm94KTsKKyAgICAgICAgZWxzZQorICAgICAg ICAgICAgQVNTRVJUX05PVF9JTVBMRU1FTlRFRF9ZRVQoKTsKKyAgICB9CisKKyAgICBBU1NFUlQo aGVpZ2h0KTsKKyAgICBBU1NFUlQobWFyZ2luVG9wKTsKKyAgICBBU1NFUlQobWFyZ2luQm90dG9t KTsKIAogICAgIExPR19XSVRIX1NUUkVBTShGb3JtYXR0aW5nQ29udGV4dExheW91dCwgc3RyZWFt IDw8ICJbSGVpZ2h0XVtNYXJnaW5dIC0+IGZsb2F0aW5nIG5vbi1yZXBsYWNlZCAtPiBoZWlnaHQo IiA8PCAqaGVpZ2h0IDw8ICJweCkgbWFyZ2luKCIgPDwgKm1hcmdpblRvcCA8PCAicHgsICIgPDwg Km1hcmdpbkJvdHRvbSA8PCAicHgpIC0+IGxheW91dEJveCgiIDw8ICZsYXlvdXRCb3ggPDwgIiki KTsKICAgICByZXR1cm4gSGVpZ2h0QW5kTWFyZ2luIHsgKmhlaWdodCwgeyAqbWFyZ2luVG9wLCAq bWFyZ2luQm90dG9tIH0sIHsgfSB9OwpAQCAtNzA3LDIyICs3MTQsMjUgQEAgSGVpZ2h0QW5kTWFy Z2luIEZvcm1hdHRpbmdDb250ZXh0OjpHZW9tZXRyeTo6aW5saW5lUmVwbGFjZWRIZWlnaHRBbmRN YXJnaW4oTGF5b3UKICAgICBhdXRvJiBzdHlsZSA9IGxheW91dEJveC5zdHlsZSgpOwogICAgIGF1 dG8gcmVwbGFjZWQgPSBsYXlvdXRCb3gucmVwbGFjZWQoKTsKICAgICBhdXRvJiBjb250YWluaW5n QmxvY2tEaXNwbGF5Qm94ID0gKmxheW91dENvbnRleHQuZGlzcGxheUJveEZvckxheW91dEJveCgq bGF5b3V0Qm94LmNvbnRhaW5pbmdCbG9jaygpKTsKLSAgICBhdXRvIGNvbnRhaW5pbmdCbG9ja0hl aWdodCA9IGNvbnRhaW5pbmdCbG9ja0Rpc3BsYXlCb3guaGVpZ2h0KCk7CiAgICAgYXV0byBjb250 YWluaW5nQmxvY2tXaWR0aCA9IGNvbnRhaW5pbmdCbG9ja0Rpc3BsYXlCb3gud2lkdGgoKTsKIAot ICAgIGF1dG8gaGVpZ2h0ID0gY29tcHV0ZWRWYWx1ZUlmTm90QXV0byhzdHlsZS5sb2dpY2FsSGVp Z2h0KCksIGNvbnRhaW5pbmdCbG9ja0hlaWdodCk7CisgICAgYXV0byBoZWlnaHQgPSBmaXhlZFZh bHVlKHN0eWxlLmxvZ2ljYWxIZWlnaHQoKSk7CisgICAgYXV0byBoZWlnaHRJc0F1dG8gPSBzdHls ZS5sb2dpY2FsSGVpZ2h0KCkuaXNBdXRvKCk7CiAgICAgYXV0byB3aWR0aCA9IGNvbXB1dGVkVmFs dWVJZk5vdEF1dG8oc3R5bGUubG9naWNhbFdpZHRoKCksIGNvbnRhaW5pbmdCbG9ja1dpZHRoKTsK IAotICAgIGlmICghaGVpZ2h0ICYmICF3aWR0aCAmJiByZXBsYWNlZC0+aGFzSW50cmluc2ljSGVp Z2h0KCkpIHsKKyAgICBpZiAoIWhlaWdodCAmJiAhaGVpZ2h0SXNBdXRvKQorICAgICAgICBBU1NF UlRfTk9UX0lNUExFTUVOVEVEX1lFVCgpOworCisgICAgaWYgKGhlaWdodElzQXV0byAmJiAhd2lk dGggJiYgcmVwbGFjZWQtPmhhc0ludHJpbnNpY0hlaWdodCgpKSB7CiAgICAgICAgIC8vICMyCiAg ICAgICAgIGhlaWdodCA9IHJlcGxhY2VkLT5pbnRyaW5zaWNIZWlnaHQoKTsKLSAgICB9IGVsc2Ug aWYgKCFoZWlnaHQgJiYgcmVwbGFjZWQtPmhhc0ludHJpbnNpY1JhdGlvKCkpIHsKKyAgICB9IGVs c2UgaWYgKGhlaWdodElzQXV0byAmJiByZXBsYWNlZC0+aGFzSW50cmluc2ljUmF0aW8oKSkgewog ICAgICAgICAvLyAjMwogICAgICAgICBoZWlnaHQgPSAqd2lkdGggLyByZXBsYWNlZC0+aW50cmlu c2ljUmF0aW8oKTsKLSAgICB9IGVsc2UgaWYgKCFoZWlnaHQgJiYgcmVwbGFjZWQtPmhhc0ludHJp bnNpY0hlaWdodCgpKSB7CisgICAgfSBlbHNlIGlmIChoZWlnaHRJc0F1dG8gJiYgcmVwbGFjZWQt Pmhhc0ludHJpbnNpY0hlaWdodCgpKSB7CiAgICAgICAgIC8vICM0CiAgICAgICAgIGhlaWdodCA9 IHJlcGxhY2VkLT5pbnRyaW5zaWNIZWlnaHQoKTsKLSAgICB9IGVsc2UgaWYgKCFoZWlnaHQpIHsK KyAgICB9IGVsc2UgaWYgKGhlaWdodElzQXV0bykgewogICAgICAgICAvLyAjNQogICAgICAgICBo ZWlnaHQgPSB7IDE1MCB9OwogICAgIH0KQEAgLTc1OSw3ICs3NjksNiBAQCBXaWR0aEFuZE1hcmdp biBGb3JtYXR0aW5nQ29udGV4dDo6R2VvbWV0cnk6OmlubGluZVJlcGxhY2VkV2lkdGhBbmRNYXJn aW4oTGF5b3V0QwogCiAgICAgYXV0byYgc3R5bGUgPSBsYXlvdXRCb3guc3R5bGUoKTsKICAgICBh dXRvJiBjb250YWluaW5nQmxvY2tEaXNwbGF5Qm94ID0gKmxheW91dENvbnRleHQuZGlzcGxheUJv eEZvckxheW91dEJveCgqbGF5b3V0Qm94LmNvbnRhaW5pbmdCbG9jaygpKTsKLSAgICBhdXRvIGNv bnRhaW5pbmdCbG9ja0hlaWdodCA9IGNvbnRhaW5pbmdCbG9ja0Rpc3BsYXlCb3guaGVpZ2h0KCk7 CiAgICAgYXV0byBjb250YWluaW5nQmxvY2tXaWR0aCA9IGNvbnRhaW5pbmdCbG9ja0Rpc3BsYXlC b3gud2lkdGgoKTsKIAogICAgIGF1dG8gY29tcHV0ZU1hcmdpblJpZ2h0ID0gWyZdKCkgewpAQCAt Nzc2LDI0ICs3ODUsMjYgQEAgV2lkdGhBbmRNYXJnaW4gRm9ybWF0dGluZ0NvbnRleHQ6Okdlb21l dHJ5OjppbmxpbmVSZXBsYWNlZFdpZHRoQW5kTWFyZ2luKExheW91dEMKICAgICAgICAgcmV0dXJu IG1hcmdpbkxlZnQudmFsdWVfb3IoTGF5b3V0VW5pdCB7IDAgfSk7CiAgICAgfTsKIAotICAgIExh eW91dFVuaXQgbWFyZ2luTGVmdCA9IGNvbXB1dGVNYXJnaW5MZWZ0KCk7Ci0gICAgTGF5b3V0VW5p dCBtYXJnaW5SaWdodCA9IGNvbXB1dGVNYXJnaW5SaWdodCgpOwotCiAgICAgYXV0byByZXBsYWNl ZCA9IGxheW91dEJveC5yZXBsYWNlZCgpOwotICAgIGF1dG8gaGVpZ2h0ID0gY29tcHV0ZWRWYWx1 ZUlmTm90QXV0byhzdHlsZS5sb2dpY2FsSGVpZ2h0KCksIGNvbnRhaW5pbmdCbG9ja0hlaWdodCk7 CisgICAgQVNTRVJUKHJlcGxhY2VkKTsKKworICAgIGF1dG8gbWFyZ2luTGVmdCA9IGNvbXB1dGVN YXJnaW5MZWZ0KCk7CisgICAgYXV0byBtYXJnaW5SaWdodCA9IGNvbXB1dGVNYXJnaW5SaWdodCgp OwogICAgIGF1dG8gd2lkdGggPSBjb21wdXRlZFZhbHVlSWZOb3RBdXRvKHN0eWxlLmxvZ2ljYWxX aWR0aCgpLCBjb250YWluaW5nQmxvY2tXaWR0aCk7CiAKLSAgICBBU1NFUlQocmVwbGFjZWQpOwor ICAgIGF1dG8gaGVpZ2h0SXNBdXRvID0gc3R5bGUubG9naWNhbEhlaWdodCgpLmlzQXV0bygpOwor ICAgIGF1dG8gaGVpZ2h0ID0gZml4ZWRWYWx1ZShzdHlsZS5sb2dpY2FsSGVpZ2h0KCkpOworICAg IGlmICghaGVpZ2h0ICYmICFoZWlnaHRJc0F1dG8pCisgICAgICAgIEFTU0VSVF9OT1RfSU1QTEVN RU5URURfWUVUKCk7CiAKLSAgICBpZiAoIXdpZHRoICYmICFoZWlnaHQgJiYgcmVwbGFjZWQtPmhh c0ludHJpbnNpY1dpZHRoKCkpIHsKKyAgICBpZiAoIXdpZHRoICYmIGhlaWdodElzQXV0byAmJiBy ZXBsYWNlZC0+aGFzSW50cmluc2ljV2lkdGgoKSkgewogICAgICAgICAvLyAjMQogICAgICAgICB3 aWR0aCA9IHJlcGxhY2VkLT5pbnRyaW5zaWNXaWR0aCgpOwotICAgIH0gZWxzZSBpZiAoKCF3aWR0 aCAmJiAhaGVpZ2h0ICYmICFyZXBsYWNlZC0+aGFzSW50cmluc2ljV2lkdGgoKSAmJiByZXBsYWNl ZC0+aGFzSW50cmluc2ljSGVpZ2h0KCkgJiYgcmVwbGFjZWQtPmhhc0ludHJpbnNpY1JhdGlvKCkp Ci0gICAgICAgIHx8ICghd2lkdGggJiYgaGVpZ2h0ICYmIHJlcGxhY2VkLT5oYXNJbnRyaW5zaWNS YXRpbygpKSkgeyAKKyAgICB9IGVsc2UgaWYgKCghd2lkdGggJiYgaGVpZ2h0SXNBdXRvICYmICFy ZXBsYWNlZC0+aGFzSW50cmluc2ljV2lkdGgoKSAmJiByZXBsYWNlZC0+aGFzSW50cmluc2ljSGVp Z2h0KCkgJiYgcmVwbGFjZWQtPmhhc0ludHJpbnNpY1JhdGlvKCkpCisgICAgICAgIHx8ICghd2lk dGggJiYgaGVpZ2h0ICYmIHJlcGxhY2VkLT5oYXNJbnRyaW5zaWNSYXRpbygpKSkgewogICAgICAg ICAvLyAjMgotICAgICAgICBhdXRvIHVzZWRIZWlnaHQgPSBoZWlnaHQudmFsdWVfb3IocmVwbGFj ZWQtPmludHJpbnNpY0hlaWdodCgpKTsKLSAgICAgICAgd2lkdGggPSB1c2VkSGVpZ2h0ICogcmVw bGFjZWQtPmludHJpbnNpY1JhdGlvKCk7Ci0gICAgfSBlbHNlIGlmICghd2lkdGggJiYgIWhlaWdo dCAmJiByZXBsYWNlZC0+aGFzSW50cmluc2ljUmF0aW8oKSAmJiAhcmVwbGFjZWQtPmhhc0ludHJp bnNpY1dpZHRoKCkgJiYgIXJlcGxhY2VkLT5oYXNJbnRyaW5zaWNIZWlnaHQoKSkgeworICAgICAg ICB3aWR0aCA9IGhlaWdodC52YWx1ZV9vcihyZXBsYWNlZC0+aGFzSW50cmluc2ljSGVpZ2h0KCkp ICogcmVwbGFjZWQtPmludHJpbnNpY1JhdGlvKCk7CisgICAgfSBlbHNlIGlmICghd2lkdGggJiYg aGVpZ2h0SXNBdXRvICYmIHJlcGxhY2VkLT5oYXNJbnRyaW5zaWNSYXRpbygpICYmICFyZXBsYWNl ZC0+aGFzSW50cmluc2ljV2lkdGgoKSAmJiAhcmVwbGFjZWQtPmhhc0ludHJpbnNpY0hlaWdodCgp KSB7CiAgICAgICAgIC8vICMzCiAgICAgICAgIC8vIEZJWE1FOiB1bmRlZmluZWQgYnV0IHN1cmVs eSBkb2FibGUuCiAgICAgICAgIEFTU0VSVF9OT1RfSU1QTEVNRU5URURfWUVUKCk7CkBAIC04MDUs NiArODE2LDggQEAgV2lkdGhBbmRNYXJnaW4gRm9ybWF0dGluZ0NvbnRleHQ6Okdlb21ldHJ5Ojpp bmxpbmVSZXBsYWNlZFdpZHRoQW5kTWFyZ2luKExheW91dEMKICAgICAgICAgd2lkdGggPSB7IDMw MCB9OwogICAgIH0KIAorICAgIEFTU0VSVCh3aWR0aCk7CisKICAgICBMT0dfV0lUSF9TVFJFQU0o Rm9ybWF0dGluZ0NvbnRleHRMYXlvdXQsIHN0cmVhbSA8PCAiW1dpZHRoXVtNYXJnaW5dIC0+IGlu ZmxvdyByZXBsYWNlZCAtPiB3aWR0aCgiIDw8ICp3aWR0aCA8PCAicHgpIG1hcmdpbigiIDw8IG1h cmdpbkxlZnQgPDwgInB4LCAiIDw8IG1hcmdpblJpZ2h0IDw8ICJweCkgLT4gbGF5b3V0Qm94KCIg PDwgJmxheW91dEJveCA8PCAiKSIpOwogICAgIHJldHVybiB7ICp3aWR0aCwgeyBtYXJnaW5MZWZ0 LCBtYXJnaW5SaWdodCB9IH07CiB9Cg==