187961 2018-07-24 10:03:42 -0700 Placate exception check verification after recent changes. 2018-07-24 12:02:11 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam commit-queue ews-watchlist keith_miller msaboff realdawei saam webkit-bug-importer oldest_to_newest 1444719 0 mark.lam 2018-07-24 10:03:42 -0700 See JSC errors on the bots after this revision, is it related? sample output: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/1302/steps/jscore-test/logs/stdio ASSERTION FAILED: !m_needExceptionCheck jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: ./runtime/VM.cpp(1188) : void JSC::VM::verifyExceptionCheckNeedIsSatisfied(unsigned int, JSC::ExceptionEventLocation &) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 1 0x10a780dc9 WTFCrash jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 2 0x10bc07fe9 JSC::VM::verifyExceptionCheckNeedIsSatisfied(unsigned int, JSC::ExceptionEventLocation&) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 3 0x10bbe1a1b JSC::ThrowScope::~ThrowScope() jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 4 0x10bbe1df5 JSC::ThrowScope::~ThrowScope() jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 5 0x10b9e91bf JSC::intlNumberOption(JSC::ExecState&, JSC::JSValue, JSC::PropertyName, unsigned int, unsigned int, unsigned int) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 6 0x10b9dc745 JSC::IntlNumberFormat::initializeNumberFormat(JSC::ExecState&, JSC::JSValue, JSC::JSValue) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 7 0x10b9e037b JSC::constructIntlNumberFormat(JSC::ExecState*) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 8 0x4e2c6ec90cd jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 9 0x10a874d5f llint_entry jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 10 0x10a86c3d2 vmEntryToJavaScript jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 11 0x10b6c2f2a JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 12 0x10b6c3503 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 13 0x10b95319a JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 14 0x10b92a315 JSC::arrayProtoFuncToLocaleString(JSC::ExecState*) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 15 0x4e2c6ec9177 jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 16 0x10a8749e6 llint_entry jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 17 0x10a86c3d2 vmEntryToJavaScript jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 18 0x10b6c2f2a JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 19 0x10b6bdfb1 JSC::Interpreter::execute(JSC::EvalExecutable*, JSC::ExecState*, JSC::JSValue, JSC::JSScope*) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 20 0x10b6bc982 JSC::eval(JSC::ExecState*) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 21 0x10b7adfc5 llint_slow_path_call_eval jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 22 0x10a875293 llint_entry jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 23 0x10a87496c llint_entry jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 24 0x10a8749e6 llint_entry jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 25 0x10a86c3d2 vmEntryToJavaScript jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 26 0x10b6c2f2a JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 27 0x10b6c24d1 JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::ExecState*, JSC::JSObject*) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 28 0x10b97b597 JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 29 0x10a6bdd10 runWithOptions(GlobalObject*, CommandLine&, bool&) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 30 0x10a69567c jscmain(int, char**)::$_3::operator()(JSC::VM&, GlobalObject*, bool&) const jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 31 0x10a67ce24 int runJSC<jscmain(int, char**)::$_3>(CommandLine, bool, jscmain(int, char**)::$_3 const&) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: test_script_39150: line 2: 74689 Segmentation fault: 11 ( "$@" ../../../../.vm/JavaScriptCore.framework/Resources/jsc --useFTLJIT\=false --useFunctionDotArguments\=true --validateExceptionChecks\=true --useDollarVM\=true --maxPerThreadStackUsage\=1572864 --testTheFTL\=true --useFTLJIT\=true resources/standalone-pre.js array-string-recursion.js resources/standalone-post.js ) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: ERROR: Unexpected exit code: 139 1444721 1 webkit-bug-importer 2018-07-24 10:05:18 -0700 <rdar://problem/42545394> 1444735 2 345688 mark.lam 2018-07-24 10:32:38 -0700 Created attachment 345688 proposed patch. 1444763 3 345688 mark.lam 2018-07-24 11:34:08 -0700 Comment on attachment 345688 proposed patch. Thanks for the review. 1444771 4 345688 commit-queue 2018-07-24 12:02:09 -0700 Comment on attachment 345688 proposed patch. Clearing flags on attachment: 345688 Committed r234160: <https://trac.webkit.org/changeset/234160> 1444772 5 commit-queue 2018-07-24 12:02:11 -0700 All reviewed patches have been landed. Closing bug. 345688 2018-07-24 10:32:38 -0700 2018-07-24 12:02:09 -0700 proposed patch. bug-187961.patch text/plain 1178 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM0MTUzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBA CisyMDE4LTA3LTI0ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBQ bGFjYXRlIGV4Y2VwdGlvbiBjaGVjayB2ZXJpZmljYXRpb24gYWZ0ZXIgcmVjZW50IGNoYW5nZXMu CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODc5NjEK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQyNTQ1Mzk0PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcnVudGltZS9JbnRsT2JqZWN0LmNwcDoKKyAg ICAgICAgKEpTQzo6aW50bE51bWJlck9wdGlvbik6CisKIDIwMTgtMDctMjMgIFNhYW0gQmFyYXRp ICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgbmVlZCB0byBkaWRGb2xkQ2xvYmJlcldv cmxkIHdoZW4gd2UgY29uc3RhbnQgZm9sZCBHZXRCeVZhbApJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSW50bE9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSW50bE9iamVjdC5jcHAJKHJldmlzaW9uIDIzNDE1MCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1lL0ludGxPYmplY3QuY3BwCSh3b3JraW5nIGNvcHkp CkBAIC0yMDIsNiArMjAyLDcgQEAgdW5zaWduZWQgaW50bE51bWJlck9wdGlvbihFeGVjU3RhdGUm IHN0YQogICAgIEpTVmFsdWUgdmFsdWUgPSBvcHRzLT5nZXQoJnN0YXRlLCBwcm9wZXJ0eSk7CiAg ICAgUkVUVVJOX0lGX0VYQ0VQVElPTihzY29wZSwgMCk7CiAKKyAgICBzY29wZS5yZWxlYXNlKCk7 CiAgICAgcmV0dXJuIGludGxEZWZhdWx0TnVtYmVyT3B0aW9uKHN0YXRlLCB2YWx1ZSwgcHJvcGVy dHksIG1pbmltdW0sIG1heGltdW0sIGZhbGxiYWNrKTsKIH0KIAo=