187955 2018-07-24 04:44:20 -0700 [WTF] String::formatWithArguments() is unused 2019-02-03 11:05:54 -0800 1 1 1 Unclassified WebKit Web Template Framework WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 30342 1 tpopela tpopela benjamin cdumez cmarcelo darin dbates ews-watchlist webkit-bug-importer oldest_to_newest 1444630 0 tpopela 2018-07-24 04:44:20 -0700 String::formatWithArguments() in Source/WTF/wtf/text/WTFString.h is unused, let's remove it. 1444633 1 345659 tpopela 2018-07-24 04:45:45 -0700 Created attachment 345659 Patch 1444654 2 345668 tpopela 2018-07-24 06:36:27 -0700 Created attachment 345668 Patch 1446058 3 darin 2018-07-28 23:30:35 -0700 After doing this we should rename String::format to String::deprecatedFormat and start phasing it out. Clients can and should use string concatenation, clearly invokable as makeString or possibly just with the + operator, instead. More efficient, likely safer. A few clients might be using advanced features of printf, but even those could probably be added to the concatenation. 1446494 4 tpopela 2018-07-31 01:11:15 -0700 (In reply to Darin Adler from comment #3) > After doing this we should rename String::format to String::deprecatedFormat > and start phasing it out. Clients can and should use string concatenation, > clearly invokable as makeString or possibly just with the + operator, > instead. More efficient, likely safer. A few clients might be using advanced > features of printf, but even those could probably be added to the > concatenation. Thank you for the review Darin! I open bug 188191 for that. 1446496 5 tpopela 2018-07-31 02:21:04 -0700 Committed r234411: <https://trac.webkit.org/changeset/234411> 1446497 6 webkit-bug-importer 2018-07-31 02:22:26 -0700 <rdar://problem/42765297> 345659 2018-07-24 04:45:45 -0700 2018-07-24 06:36:22 -0700 Patch bug-187955-20180724134543.patch text/plain 2065 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZlYzYzNDMwMzQyMmVkNmU4OTc3MzNk NGJlMmYzZmE4MjYzNmViZGIuLjAwOWZkZGIwNzlhNzIzNmEyNDYwMmE1YTUwMzZmZTZjMzU4Njdl YzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDctMjQgIFRvbWFzIFBvcGVsYSAgPHRwb3Bl bGFAcmVkaGF0LmNvbT4KKworICAgICAgICBbV1RGXSBTdHJpbmc6OmZvcm1hdFdpdGhBcmd1bWVu dHMoKSBpcyB1bnVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4Nzk1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgbWV0aG9kIGlzIHVudXNlZCwgcmVtb3ZlIGl0LgorCisgICAgICAgICogd3Rm L3RleHQvV1RGU3RyaW5nLmNwcDoKKyAgICAgICAgKFdURjo6U3RyaW5nOjpmb3JtYXRXaXRoQXJn dW1lbnRzKTogRGVsZXRlZC4KKyAgICAgICAgKiB3dGYvdGV4dC9XVEZTdHJpbmcuaDoKKwogMjAx OC0wNy0yNCAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29tPgogCiAgICAgICAgIENv cnJlY3RseSBjbG9zZSB0aGUgdmFyaWFibGUgYXJndW1lbnQgbGlzdApkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcuY3BwIGIvU291cmNlL1dURi93dGYvdGV4dC9XVEZT dHJpbmcuY3BwCmluZGV4IDU3YmYxZjhkMDZhY2Q5OGVmNjJiODBiMTY5NzA0MmY0ZGRlNmJjMDMu LjUyMmU0ZGYzZGY0ZWM0NzJiMWQ2NjI3ZjhiZWYxMmM3MjU5NWE3NDUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5nLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0 L1dURlN0cmluZy5jcHAKQEAgLTQ5OSwxMSArNDk5LDYgQEAgV1RGX0FUVFJJQlVURV9QUklOVEYo MSwgMCkgc3RhdGljIFN0cmluZyBjcmVhdGVXaXRoRm9ybWF0QW5kQXJndW1lbnRzKGNvbnN0IGNo YXIKICAgICByZXR1cm4gU3RyaW5nSW1wbDo6Y3JlYXRlKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3Qg TENoYXIqPihidWZmZXIuZGF0YSgpKSwgbGVuKTsKIH0KIAotU3RyaW5nIFN0cmluZzo6Zm9ybWF0 V2l0aEFyZ3VtZW50cyhjb25zdCBjaGFyICpmb3JtYXQsIHZhX2xpc3QgYXJncykKLXsKLSAgICBy ZXR1cm4gY3JlYXRlV2l0aEZvcm1hdEFuZEFyZ3VtZW50cyhmb3JtYXQsIGFyZ3MpOwotfQotCiBT dHJpbmcgU3RyaW5nOjpmb3JtYXQoY29uc3QgY2hhciAqZm9ybWF0LCAuLi4pCiB7CiAgICAgdmFf bGlzdCBhcmdzOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcuaCBi L1NvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5nLmgKaW5kZXggNDM1NDVmMmMyZjdiM2U2MTU4 ZGE4OWI5MmRkY2U3YTA2NWY0Nzg5MS4uZTQwYTk5NGYwZTJiYjY2YzgxOWM4NGRjMGI5ODhkNWIx MDg0ZGMyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcuaAorKysg Yi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5oCkBAIC0yNjMsNyArMjYzLDYgQEAgcHVi bGljOgogICAgIFdURl9FWFBPUlRfUFJJVkFURSBTdHJpbmcgZm9sZENhc2UoKSBjb25zdDsKIAog ICAgIFdURl9FWFBPUlRfUFJJVkFURSBzdGF0aWMgU3RyaW5nIGZvcm1hdChjb25zdCBjaGFyICos IC4uLikgV1RGX0FUVFJJQlVURV9QUklOVEYoMSwgMik7Ci0gICAgV1RGX0VYUE9SVF9QUklWQVRF IHN0YXRpYyBTdHJpbmcgZm9ybWF0V2l0aEFyZ3VtZW50cyhjb25zdCBjaGFyICosIHZhX2xpc3Qp IFdURl9BVFRSSUJVVEVfUFJJTlRGKDEsIDApOwogCiAgICAgLy8gUmV0dXJucyBhbiB1bmluaXRp YWxpemVkIHN0cmluZy4gVGhlIGNoYXJhY3RlcnMgbmVlZHMgdG8gYmUgd3JpdHRlbgogICAgIC8v IGludG8gdGhlIGJ1ZmZlciByZXR1cm5lZCBpbiBkYXRhIGJlZm9yZSB0aGUgcmV0dXJuZWQgc3Ry aW5nIGlzIHVzZWQuCg== 345668 2018-07-24 06:36:27 -0700 2018-07-28 23:28:44 -0700 Patch bug-187955-20180724153625.patch text/plain 4744 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MTQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZlYzYzNDMwMzQyMmVkNmU4OTc3MzNk NGJlMmYzZmE4MjYzNmViZGIuLjAwOWZkZGIwNzlhNzIzNmEyNDYwMmE1YTUwMzZmZTZjMzU4Njdl YzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTgtMDctMjQgIFRvbWFzIFBvcGVsYSAgPHRwb3Bl bGFAcmVkaGF0LmNvbT4KKworICAgICAgICBbV1RGXSBTdHJpbmc6OmZvcm1hdFdpdGhBcmd1bWVu dHMoKSBpcyB1bnVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTE4Nzk1NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFRoaXMgbWV0aG9kIGlzIHVudXNlZCwgcmVtb3ZlIGl0LgorCisgICAgICAgICogd3Rm L3RleHQvV1RGU3RyaW5nLmNwcDoKKyAgICAgICAgKFdURjo6U3RyaW5nOjpmb3JtYXRXaXRoQXJn dW1lbnRzKTogRGVsZXRlZC4KKyAgICAgICAgKiB3dGYvdGV4dC9XVEZTdHJpbmcuaDoKKwogMjAx OC0wNy0yNCAgVG9tYXMgUG9wZWxhICA8dHBvcGVsYUByZWRoYXQuY29tPgogCiAgICAgICAgIENv cnJlY3RseSBjbG9zZSB0aGUgdmFyaWFibGUgYXJndW1lbnQgbGlzdApkaWZmIC0tZ2l0IGEvU291 cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcuY3BwIGIvU291cmNlL1dURi93dGYvdGV4dC9XVEZT dHJpbmcuY3BwCmluZGV4IDU3YmYxZjhkMDZhY2Q5OGVmNjJiODBiMTY5NzA0MmY0ZGRlNmJjMDMu LjUyMmU0ZGYzZGY0ZWM0NzJiMWQ2NjI3ZjhiZWYxMmM3MjU5NWE3NDUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5nLmNwcAorKysgYi9Tb3VyY2UvV1RGL3d0Zi90ZXh0 L1dURlN0cmluZy5jcHAKQEAgLTQ5OSwxMSArNDk5LDYgQEAgV1RGX0FUVFJJQlVURV9QUklOVEYo MSwgMCkgc3RhdGljIFN0cmluZyBjcmVhdGVXaXRoRm9ybWF0QW5kQXJndW1lbnRzKGNvbnN0IGNo YXIKICAgICByZXR1cm4gU3RyaW5nSW1wbDo6Y3JlYXRlKHJlaW50ZXJwcmV0X2Nhc3Q8Y29uc3Qg TENoYXIqPihidWZmZXIuZGF0YSgpKSwgbGVuKTsKIH0KIAotU3RyaW5nIFN0cmluZzo6Zm9ybWF0 V2l0aEFyZ3VtZW50cyhjb25zdCBjaGFyICpmb3JtYXQsIHZhX2xpc3QgYXJncykKLXsKLSAgICBy ZXR1cm4gY3JlYXRlV2l0aEZvcm1hdEFuZEFyZ3VtZW50cyhmb3JtYXQsIGFyZ3MpOwotfQotCiBT dHJpbmcgU3RyaW5nOjpmb3JtYXQoY29uc3QgY2hhciAqZm9ybWF0LCAuLi4pCiB7CiAgICAgdmFf bGlzdCBhcmdzOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcuaCBi L1NvdXJjZS9XVEYvd3RmL3RleHQvV1RGU3RyaW5nLmgKaW5kZXggNDM1NDVmMmMyZjdiM2U2MTU4 ZGE4OWI5MmRkY2U3YTA2NWY0Nzg5MS4uZTQwYTk5NGYwZTJiYjY2YzgxOWM4NGRjMGI5ODhkNWIx MDg0ZGMyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvdGV4dC9XVEZTdHJpbmcuaAorKysg Yi9Tb3VyY2UvV1RGL3d0Zi90ZXh0L1dURlN0cmluZy5oCkBAIC0yNjMsNyArMjYzLDYgQEAgcHVi bGljOgogICAgIFdURl9FWFBPUlRfUFJJVkFURSBTdHJpbmcgZm9sZENhc2UoKSBjb25zdDsKIAog ICAgIFdURl9FWFBPUlRfUFJJVkFURSBzdGF0aWMgU3RyaW5nIGZvcm1hdChjb25zdCBjaGFyICos IC4uLikgV1RGX0FUVFJJQlVURV9QUklOVEYoMSwgMik7Ci0gICAgV1RGX0VYUE9SVF9QUklWQVRF IHN0YXRpYyBTdHJpbmcgZm9ybWF0V2l0aEFyZ3VtZW50cyhjb25zdCBjaGFyICosIHZhX2xpc3Qp IFdURl9BVFRSSUJVVEVfUFJJTlRGKDEsIDApOwogCiAgICAgLy8gUmV0dXJucyBhbiB1bmluaXRp YWxpemVkIHN0cmluZy4gVGhlIGNoYXJhY3RlcnMgbmVlZHMgdG8gYmUgd3JpdHRlbgogICAgIC8v IGludG8gdGhlIGJ1ZmZlciByZXR1cm5lZCBpbiBkYXRhIGJlZm9yZSB0aGUgcmV0dXJuZWQgc3Ry aW5nIGlzIHVzZWQuCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VM b2cKaW5kZXggYjkyY2UyODkwMGJmMTM0N2Y5Njk3ZGMyYjQzOTc0MzkzYjc0YzNlYy4uNGU2NThi YWIwMDZjNWE5ZGY5ODEwNzVhOGY5MWNhZTQ0ZDEwNTE0NCAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hh bmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE4LTA3LTI0 ICBUb21hcyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAgICAgICAgW1dURl0gU3Ry aW5nOjpmb3JtYXRXaXRoQXJndW1lbnRzKCkgaXMgdW51c2VkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODc5NTUKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUgdGVzdHMgZm9yIFdURjo6U3RyaW5n Ojpmb3JtYXRXaXRoQXJndW1lbnRzKCkgYXMgaXQncyB1bnVzZWQgYW5kCisgICAgICAgIHdlIGFy ZSByZW1vdmluZyBpdC4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1dURlN0 cmluZy5jcHA6CisKIDIwMTgtMDctMjQgIFRoaWJhdWx0IFNhdW5pZXIgIDx0c2F1bmllckBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtGbGF0cGFrXSBSZW1vdmUgbm93IHVubmVjZXNzYXJ5ICdoYWNr cycgZm9yIHJ1bm5pbmcgdGVzdHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVz dHMvV1RGL1dURlN0cmluZy5jcHAgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dURi9XVEZT dHJpbmcuY3BwCmluZGV4IDVjYjZjNzZlNmMzYmQ0ZjI5NzA4Njc5ZTc3NWE3MTgzNTE5NDQ3OTIu LjkzNzBkNTk1MzM1ZjEyODdlNWJhMWQxOTY1ODRkZWM0MmU5MmUyMDEgMTAwNjQ0Ci0tLSBhL1Rv b2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV1RGL1dURlN0cmluZy5jcHAKKysrIGIvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XVEYvV1RGU3RyaW5nLmNwcApAQCAtNDYwLDQzICs0NjAsNCBAQCBU RVNUKFdURiwgU3RyaW5nUmV2ZXJzZUZpbmRCYXNpYykKICAgICBFWFBFQ1RfRVEocmVmZXJlbmNl LnJldmVyc2VGaW5kKCdjJywgNCksIG5vdEZvdW5kKTsKIH0KIAotV1RGX0FUVFJJQlVURV9QUklO VEYoMiwgMykKLXN0YXRpYyB2b2lkIHRlc3RXaXRoRm9ybWF0QW5kQXJndW1lbnRzKGNvbnN0IGNo YXIqIGV4cGVjdGVkLCBjb25zdCBjaGFyKiBmb3JtYXQsIC4uLikKLXsKLSAgICB2YV9saXN0IGFy Z3VtZW50czsKLSAgICB2YV9zdGFydChhcmd1bWVudHMsIGZvcm1hdCk7Ci0KLSNpZiBDT01QSUxF UihHQ0NfT1JfQ0xBTkcpCi0jcHJhZ21hIEdDQyBkaWFnbm9zdGljIHB1c2gKLSNwcmFnbWEgR0ND IGRpYWdub3N0aWMgaWdub3JlZCAiLVdmb3JtYXQtbm9ubGl0ZXJhbCIKLSNlbmRpZgotICAgIFN0 cmluZyByZXN1bHQgPSBTdHJpbmc6OmZvcm1hdFdpdGhBcmd1bWVudHMoZm9ybWF0LCBhcmd1bWVu dHMpOwotI2lmIENPTVBJTEVSKEdDQ19PUl9DTEFORykKLSNwcmFnbWEgR0NDIGRpYWdub3N0aWMg cG9wCi0jZW5kaWYKLQotICAgIHZhX2VuZChhcmd1bWVudHMpOwotCi0gICAgRVhQRUNUX1NUUkVR KGV4cGVjdGVkLCByZXN1bHQudXRmOCgpLmRhdGEoKSk7Ci19Ci0KLVRFU1QoV1RGLCBTdHJpbmdG b3JtYXRXaXRoQXJndW1lbnRzKQotewotICAgIHRlc3RXaXRoRm9ybWF0QW5kQXJndW1lbnRzKCJo ZWxsbyBjcnVlbCB3b3JsZCIsICIlcyAlcyAlcyIsICJoZWxsbyIsICJjcnVlbCIgLCAid29ybGQi KTsKLQotICAgIHRlc3RXaXRoRm9ybWF0QW5kQXJndW1lbnRzKCJoZWxsbyAxNzg5MCB3b3JsZCIs ICIlcyV1JXMiLCAiaGVsbG8gIiwgMTc4OTB1LCAiIHdvcmxkIik7Ci0KLSAgICB0ZXN0V2l0aEZv cm1hdEFuZEFyZ3VtZW50cygiaGVsbG8gMTc4OTAuMDAwIHdvcmxkIiwgIiVzICUuM2YgJXMiLCAi aGVsbG8iLCAxNzg5MC4wZiwgIndvcmxkIik7Ci0gICAgdGVzdFdpdGhGb3JtYXRBbmRBcmd1bWVu dHMoImhlbGxvIDE3ODkwLjUwIHdvcmxkIiwgIiVzICUuMmYgJXMiLCAiaGVsbG8iLCAxNzg5MC41 ZiwgIndvcmxkIik7Ci0KLSAgICB0ZXN0V2l0aEZvcm1hdEFuZEFyZ3VtZW50cygiaGVsbG8gLTE3 ODkwIHdvcmxkIiwgIiVzICUuMGYgJXMiLCAiaGVsbG8iLCAtMTc4OTAuMGYsICJ3b3JsZCIpOwot ICAgIHRlc3RXaXRoRm9ybWF0QW5kQXJndW1lbnRzKCJoZWxsbyAtMTc4OTAuNSB3b3JsZCIsICIl cyAlLjFmICVzIiwgImhlbGxvIiwgLTE3ODkwLjVmLCAid29ybGQiKTsKLQotICAgIHRlc3RXaXRo Rm9ybWF0QW5kQXJndW1lbnRzKCJoZWxsbyAxNzg5MCB3b3JsZCIsICIlcyAlLjBmICVzIiwgImhl bGxvIiwgMTc4OTAuMCwgIndvcmxkIik7Ci0gICAgdGVzdFdpdGhGb3JtYXRBbmRBcmd1bWVudHMo ImhlbGxvIDE3ODkwLjUgd29ybGQiLCAiJXMgJS4xZiAlcyIsICJoZWxsbyIsIDE3ODkwLjUsICJ3 b3JsZCIpOwotCi0gICAgdGVzdFdpdGhGb3JtYXRBbmRBcmd1bWVudHMoImhlbGxvIC0xNzg5MCB3 b3JsZCIsICIlcyAlLjBmICVzIiwgImhlbGxvIiwgLTE3ODkwLjAsICJ3b3JsZCIpOwotICAgIHRl c3RXaXRoRm9ybWF0QW5kQXJndW1lbnRzKCJoZWxsbyAtMTc4OTAuNSB3b3JsZCIsICIlcyAlLjFm ICVzIiwgImhlbGxvIiwgLTE3ODkwLjUsICJ3b3JsZCIpOwotfQotCiB9IC8vIG5hbWVzcGFjZSBU ZXN0V2ViS2l0QVBJCg==