187917 2018-07-23 11:46:35 -0700 need to didFoldClobberWorld when we constant fold GetByVal 2018-07-24 10:35:33 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam benjamin commit-queue fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff realdawei rmorisset ticaiolima webkit-bug-importer ysuzuki oldest_to_newest 1444346 0 saam 2018-07-23 11:46:35 -0700 ... 1444347 1 saam 2018-07-23 11:47:03 -0700 <rdar://problem/42505095> 1444351 2 345593 saam 2018-07-23 11:57:19 -0700 Created attachment 345593 patch 1444519 3 345593 ysuzuki 2018-07-23 18:03:09 -0700 Comment on attachment 345593 patch r=me 1444525 4 345593 commit-queue 2018-07-23 18:32:27 -0700 Comment on attachment 345593 patch Clearing flags on attachment: 345593 Committed r234128: <https://trac.webkit.org/changeset/234128> 1444526 5 commit-queue 2018-07-23 18:32:29 -0700 All reviewed patches have been landed. Closing bug. 1444699 6 realdawei 2018-07-24 09:20:16 -0700 (In reply to WebKit Commit Bot from comment #4) > Comment on attachment 345593 [details] > patch > > Clearing flags on attachment: 345593 > > Committed r234128: <https://trac.webkit.org/changeset/234128> See JSC errors on the bots after this revision, is it related? sample output: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20JSC%20%28Tests%29/builds/1302/steps/jscore-test/logs/stdio ASSERTION FAILED: !m_needExceptionCheck jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: ./runtime/VM.cpp(1188) : void JSC::VM::verifyExceptionCheckNeedIsSatisfied(unsigned int, JSC::ExceptionEventLocation &) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 1 0x10a780dc9 WTFCrash jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 2 0x10bc07fe9 JSC::VM::verifyExceptionCheckNeedIsSatisfied(unsigned int, JSC::ExceptionEventLocation&) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 3 0x10bbe1a1b JSC::ThrowScope::~ThrowScope() jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 4 0x10bbe1df5 JSC::ThrowScope::~ThrowScope() jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 5 0x10b9e91bf JSC::intlNumberOption(JSC::ExecState&, JSC::JSValue, JSC::PropertyName, unsigned int, unsigned int, unsigned int) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 6 0x10b9dc745 JSC::IntlNumberFormat::initializeNumberFormat(JSC::ExecState&, JSC::JSValue, JSC::JSValue) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 7 0x10b9e037b JSC::constructIntlNumberFormat(JSC::ExecState*) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 8 0x4e2c6ec90cd jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 9 0x10a874d5f llint_entry jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 10 0x10a86c3d2 vmEntryToJavaScript jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 11 0x10b6c2f2a JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 12 0x10b6c3503 JSC::Interpreter::executeCall(JSC::ExecState*, JSC::JSObject*, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 13 0x10b95319a JSC::call(JSC::ExecState*, JSC::JSValue, JSC::CallType, JSC::CallData const&, JSC::JSValue, JSC::ArgList const&) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 14 0x10b92a315 JSC::arrayProtoFuncToLocaleString(JSC::ExecState*) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 15 0x4e2c6ec9177 jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 16 0x10a8749e6 llint_entry jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 17 0x10a86c3d2 vmEntryToJavaScript jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 18 0x10b6c2f2a JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 19 0x10b6bdfb1 JSC::Interpreter::execute(JSC::EvalExecutable*, JSC::ExecState*, JSC::JSValue, JSC::JSScope*) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 20 0x10b6bc982 JSC::eval(JSC::ExecState*) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 21 0x10b7adfc5 llint_slow_path_call_eval jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 22 0x10a875293 llint_entry jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 23 0x10a87496c llint_entry jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 24 0x10a8749e6 llint_entry jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 25 0x10a86c3d2 vmEntryToJavaScript jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 26 0x10b6c2f2a JSC::JITCode::execute(JSC::VM*, JSC::ProtoCallFrame*) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 27 0x10b6c24d1 JSC::Interpreter::executeProgram(JSC::SourceCode const&, JSC::ExecState*, JSC::JSObject*) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 28 0x10b97b597 JSC::evaluate(JSC::ExecState*, JSC::SourceCode const&, JSC::JSValue, WTF::NakedPtr<JSC::Exception>&) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 29 0x10a6bdd10 runWithOptions(GlobalObject*, CommandLine&, bool&) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 30 0x10a69567c jscmain(int, char**)::$_3::operator()(JSC::VM&, GlobalObject*, bool&) const jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: 31 0x10a67ce24 int runJSC<jscmain(int, char**)::$_3>(CommandLine, bool, jscmain(int, char**)::$_3 const&) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: test_script_39150: line 2: 74689 Segmentation fault: 11 ( "$@" ../../../../.vm/JavaScriptCore.framework/Resources/jsc --useFTLJIT\=false --useFunctionDotArguments\=true --validateExceptionChecks\=true --useDollarVM\=true --maxPerThreadStackUsage\=1572864 --testTheFTL\=true --useFTLJIT\=true resources/standalone-pre.js array-string-recursion.js resources/standalone-post.js ) jsc-layout-tests.yaml/js/script-tests/array-string-recursion.js.layout: ERROR: Unexpected exit code: 139 1444720 7 mark.lam 2018-07-24 10:04:13 -0700 (In reply to David Fenton (:realdawei) from comment #6) > (In reply to WebKit Commit Bot from comment #4) > > Comment on attachment 345593 [details] > > patch > > > > Clearing flags on attachment: 345593 > > > > Committed r234128: <https://trac.webkit.org/changeset/234128> > > See JSC errors on the bots after this revision, is it related? I'll take care of this in https://bugs.webkit.org/show_bug.cgi?id=187961. 1444728 8 mark.lam 2018-07-24 10:23:50 -0700 (In reply to Mark Lam from comment #7) > (In reply to David Fenton (:realdawei) from comment #6) > > (In reply to WebKit Commit Bot from comment #4) > > > Comment on attachment 345593 [details] > > > patch > > > > > > Clearing flags on attachment: 345593 > > > > > > Committed r234128: <https://trac.webkit.org/changeset/234128> > > > > See JSC errors on the bots after this revision, is it related? > > I'll take care of this in https://bugs.webkit.org/show_bug.cgi?id=187961. Turns out this exception issue has nothing to do with this bug. It's due to another Intl patch. 1444738 9 realdawei 2018-07-24 10:35:33 -0700 (In reply to Mark Lam from comment #8) > (In reply to Mark Lam from comment #7) > > (In reply to David Fenton (:realdawei) from comment #6) > > > (In reply to WebKit Commit Bot from comment #4) > > > > Comment on attachment 345593 [details] > > > > patch > > > > > > > > Clearing flags on attachment: 345593 > > > > > > > > Committed r234128: <https://trac.webkit.org/changeset/234128> > > > > > > See JSC errors on the bots after this revision, is it related? > > > > I'll take care of this in https://bugs.webkit.org/show_bug.cgi?id=187961. > > Turns out this exception issue has nothing to do with this bug. It's due to > another Intl patch. Okay Thanks for confirming. 345593 2018-07-23 11:57:19 -0700 2018-07-23 18:32:27 -0700 patch c-backup.diff text/plain 4116 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMzQxMDQpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE0IEBACisyMDE4LTA3LTIzICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIG5lZWQgdG8gZGlkRm9sZENsb2JiZXJXb3JsZCB3aGVuIHdlIGNvbnN0 YW50IGZvbGQgR2V0QnlWYWwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTE4NzkxNworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDI1MDUwOTU+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBzdHJlc3MvZ2V0 LWJ5LXZhbC1mb2xkLWRpZC1jbG9iYmVyLXdvcmxkLmpzOiBBZGRlZC4KKyAgICAgICAgKF9fZl80 NDMpOgorCiAyMDE4LTA3LTIyICBZdXN1a2UgU3V6dWtpICA8dXRhdGFuZS50ZWFAZ21haWwuY29t PgogCiAgICAgICAgIFtKU0NdIEdldEJ5SWRWYXJpYW50IGFuZCBJbkJ5SWRWYXJpYW50IGRvIG5v dCBuZWVkIHNsb3QgYmFzZSBpZiB0aGV5IGFyZSBub3QgImhpdCIgdmFyaWFudHMKSW5kZXg6IEpT VGVzdHMvc3RyZXNzL2dldC1ieS12YWwtZm9sZC1kaWQtY2xvYmJlci13b3JsZC5qcwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9nZXQtYnktdmFsLWZvbGQtZGlkLWNsb2JiZXItd29ybGQu anMJKG5vbmV4aXN0ZW50KQorKysgSlNUZXN0cy9zdHJlc3MvZ2V0LWJ5LXZhbC1mb2xkLWRpZC1j bG9iYmVyLXdvcmxkLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsOSBAQAordmFyIF9fdl8x NjczID0gWzE2XTsKK2Z1bmN0aW9uIF9fZl80NDMoKSB7CisgICAgZm9yICh2YXIgX192XzE2Nzkg PSAwOyBfX3ZfMTY3OSA8IDFlNTsgKytfX3ZfMTY3OSkgeworICAgICAgICBmb3IgKHZhciBfX3Zf MTY4MCA9IDA7IF9fdl8xNjgwIDwgNzsgKytfX3ZfMTY4MCkgeworICAgICAgICAgICAgdmFyIF9f dl8xNjgxID0gX192XzE2NzNbX192XzE2ODBdOworICAgICAgICB9CisgICAgfQorfQorX19mXzQ0 MygpCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIzNDEwNCkKKysrIFNv dXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwx NCBAQAorMjAxOC0wNy0yMyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAg ICAgICBuZWVkIHRvIGRpZEZvbGRDbG9iYmVyV29ybGQgd2hlbiB3ZSBjb25zdGFudCBmb2xkIEdl dEJ5VmFsCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODc5MTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQyNTA1MDk1PgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZGZnL0RGR0Fic3RyYWN0SW50ZXJw cmV0ZXJJbmxpbmVzLmg6CisgICAgICAgIChKU0M6OkRGRzo6QWJzdHJhY3RJbnRlcnByZXRlcjxB YnN0cmFjdFN0YXRlVHlwZT46OmV4ZWN1dGVFZmZlY3RzKToKKwogMjAxOC0wNy0yMyAgRmlsaXAg UGl6bG8gIDxmcGl6bG9AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIGZpeCBuby1K SVQgYnVpbGQuCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0SW50 ZXJwcmV0ZXJJbmxpbmVzLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2Rm Zy9ERkdBYnN0cmFjdEludGVycHJldGVySW5saW5lcy5oCShyZXZpc2lvbiAyMzQxMDQpCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0Fic3RyYWN0SW50ZXJwcmV0ZXJJbmxpbmVzLmgJ KHdvcmtpbmcgY29weSkKQEAgLTE4ODYsNyArMTg4Niw2IEBAIGJvb2wgQWJzdHJhY3RJbnRlcnBy ZXRlcjxBYnN0cmFjdFN0YXRlVHkKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAmJiBnbG9i YWxPYmplY3QtPmFycmF5UHJvdG90eXBlQ2hhaW5Jc1NhbmUoKSkgewogICAgICAgICAgICAgICAg ICAgICAgICAgICAgIG1fZ3JhcGgucmVnaXN0ZXJBbmRXYXRjaFN0cnVjdHVyZVRyYW5zaXRpb24o YXJyYXlQcm90b3R5cGVTdHJ1Y3R1cmUpOwogICAgICAgICAgICAgICAgICAgICAgICAgICAgIG1f Z3JhcGgucmVnaXN0ZXJBbmRXYXRjaFN0cnVjdHVyZVRyYW5zaXRpb24ob2JqZWN0UHJvdG90eXBl U3RydWN0dXJlKTsKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaWRGb2xkQ2xvYmJlcldv cmxkKCk7CiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgLy8gTm90ZSB0aGF0IEFycmF5OjpE b3VibGUgYW5kIEFycmF5OjpJbnQzMiByZXR1cm4gSlNWYWx1ZSBpZiBhcnJheSBtb2RlIGlzIE91 dE9mQm91bmRzLgogICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNldENvbnN0YW50KG5vZGUs IGpzVW5kZWZpbmVkKCkpOwogICAgICAgICAgICAgICAgICAgICAgICAgICAgIHJldHVybiB0cnVl OwpAQCAtMTkyMyw5ICsxOTIyLDYgQEAgYm9vbCBBYnN0cmFjdEludGVycHJldGVyPEFic3RyYWN0 U3RhdGVUeQogICAgICAgICAgICAgICAgICAgICBpZiAoIXZhbHVlKQogICAgICAgICAgICAgICAg ICAgICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgICAgICAgICAgICAgICAgIGlmIChub2RlLT5h cnJheU1vZGUoKS5pc091dE9mQm91bmRzKCkpCi0gICAgICAgICAgICAgICAgICAgICAgICBkaWRG b2xkQ2xvYmJlcldvcmxkKCk7Ci0KICAgICAgICAgICAgICAgICAgICAgaWYgKHZhbHVlLmlzQ2Vs bCgpKQogICAgICAgICAgICAgICAgICAgICAgICAgc2V0Q29uc3RhbnQobm9kZSwgKm1fZ3JhcGgu ZnJlZXplKHZhbHVlLmFzQ2VsbCgpKSk7CiAgICAgICAgICAgICAgICAgICAgIGVsc2UKQEAgLTE5 MzYsNyArMTkzMiwyNSBAQCBib29sIEFic3RyYWN0SW50ZXJwcmV0ZXI8QWJzdHJhY3RTdGF0ZVR5 CiAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICAgICAgfTsKIAotICAgICAg ICAgICAgaWYgKGZvbGRHZXRCeVZhbE9uQ29uc3RhbnRQcm9wZXJ0eShtX2dyYXBoLmNoaWxkKG5v ZGUsIDApLCBtX2dyYXBoLmNoaWxkKG5vZGUsIDEpKSkKKyAgICAgICAgICAgIGJvb2wgZGlkRm9s ZCA9IGZhbHNlOworICAgICAgICAgICAgc3dpdGNoIChub2RlLT5hcnJheU1vZGUoKS50eXBlKCkp IHsKKyAgICAgICAgICAgIGNhc2UgQXJyYXk6OkdlbmVyaWM6CisgICAgICAgICAgICBjYXNlIEFy cmF5OjpJbnQzMjoKKyAgICAgICAgICAgIGNhc2UgQXJyYXk6OkRvdWJsZToKKyAgICAgICAgICAg IGNhc2UgQXJyYXk6OkNvbnRpZ3VvdXM6CisgICAgICAgICAgICBjYXNlIEFycmF5OjpBcnJheVN0 b3JhZ2U6CisgICAgICAgICAgICBjYXNlIEFycmF5OjpTbG93UHV0QXJyYXlTdG9yYWdlOgorICAg ICAgICAgICAgICAgIGlmIChmb2xkR2V0QnlWYWxPbkNvbnN0YW50UHJvcGVydHkobV9ncmFwaC5j aGlsZChub2RlLCAwKSwgbV9ncmFwaC5jaGlsZChub2RlLCAxKSkpIHsKKyAgICAgICAgICAgICAg ICAgICAgaWYgKCFub2RlLT5hcnJheU1vZGUoKS5pc0luQm91bmRzKCkpCisgICAgICAgICAgICAg ICAgICAgICAgICBkaWRGb2xkQ2xvYmJlcldvcmxkKCk7CisgICAgICAgICAgICAgICAgICAgIGRp ZEZvbGQgPSB0cnVlOworICAgICAgICAgICAgICAgIH0KKyAgICAgICAgICAgICAgICBicmVhazsK KyAgICAgICAgICAgIGRlZmF1bHQ6CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAg ICB9CisKKyAgICAgICAgICAgIGlmIChkaWRGb2xkKQogICAgICAgICAgICAgICAgIGJyZWFrOwog ICAgICAgICB9CiAK