187915 2018-07-23 11:36:37 -0700 Add some asserts to help diagnose a crash. 2018-07-23 12:33:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer oldest_to_newest 1444336 0 mark.lam 2018-07-23 11:36:37 -0700 <rdar://problem/42508166> 1444340 1 345589 mark.lam 2018-07-23 11:41:28 -0700 Created attachment 345589 proposed patch. 1444343 2 345589 msaboff 2018-07-23 11:43:13 -0700 Comment on attachment 345589 proposed patch. r=me 1444354 3 345589 saam 2018-07-23 11:59:46 -0700 Comment on attachment 345589 proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=345589&action=review > Source/JavaScriptCore/bytecode/CodeBlock.cpp:2424 > + RELEASE_ASSERT(jitType() == JITCode::BaselineJIT); why not WTFCrashWithInfo? 1444356 4 mark.lam 2018-07-23 12:07:09 -0700 (In reply to Saam Barati from comment #3) > Comment on attachment 345589 [details] > proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345589&action=review > > > Source/JavaScriptCore/bytecode/CodeBlock.cpp:2424 > > + RELEASE_ASSERT(jitType() == JITCode::BaselineJIT); > > why not WTFCrashWithInfo? I just didn't think to use that. I'll change this to: CRASH_WITH_INFO(type); 1444362 5 mark.lam 2018-07-23 12:29:44 -0700 (In reply to Mark Lam from comment #4) > I just didn't think to use that. I'll change this to: > CRASH_WITH_INFO(type); Make that: CRASH_WITH_INFO(bitwise_cast<uintptr_t>(jitCode().get()), type); 1444364 6 mark.lam 2018-07-23 12:33:32 -0700 Thanks for the reviews. Landed in r234106: <http://trac.webkit.org/r234106>. 345589 2018-07-23 11:41:28 -0700 2018-07-23 11:43:13 -0700 proposed patch. bug-187915.patch text/plain 2479 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjM0MTA0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBA CisyMDE4LTA3LTIzICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBB ZGQgc29tZSBhc3NlcnRzIHRvIGhlbHAgZGlhZ25vc2UgYSByYXJlIGNyYXNoLgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3OTE1CisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS80MjUwODE2Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBBZGQgc29tZSBhc3NlcnRzIHRvIHZlcmlmeSB0aGF0IGFuIENvZGVC bG9jayBhbHRlcm5hdGl2ZSBzaG91bGQgYWx3YXlzIGhhdmUgYQorICAgICAgICBub24tbnVsbCBq aXRDb2RlLiAgQWxzbyBjaGFuZ2UgYSBSRUxFQVNFX0FTU0VSVF9OT1RfUkVBQ0hFRCgpIGluCisg ICAgICAgIENvZGVCbG9jazo6c2V0T3B0aW1pemF0aW9uVGhyZXNob2xkQmFzZWRPbkNvbXBpbGF0 aW9uUmVzdWx0KCkgdG8gYSBSRUxFQVNFX0FTU0VSVCgpCisgICAgICAgIHNvIHRoYXQgd2UnbGwg cmV0YWluIHRoZSBzdGF0ZSBvZiB0aGUgdmFyaWFibGVzIHRoYXQgZmFpbGVkIHRoZSBhc3NlcnRp b24gKGFnYWluCisgICAgICAgIHRvIGhlbHAgd2l0aCBkaWFnbm9zaXMpLgorCisgICAgICAgICog Ynl0ZWNvZGUvQ29kZUJsb2NrLmNwcDoKKyAgICAgICAgKEpTQzo6Q29kZUJsb2NrOjpzZXRBbHRl cm5hdGl2ZSk6CisgICAgICAgIChKU0M6OkNvZGVCbG9jazo6c2V0T3B0aW1pemF0aW9uVGhyZXNo b2xkQmFzZWRPbkNvbXBpbGF0aW9uUmVzdWx0KToKKyAgICAgICAgKiBkZmcvREZHUGxhbi5jcHA6 CisgICAgICAgIChKU0M6OkRGRzo6UGxhbjo6UGxhbik6CisKIDIwMTgtMDctMjMgIEZpbGlwIFBp emxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkLCBmaXggbm8tSklU IGJ1aWxkLgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9jay5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2J5dGVjb2RlL0NvZGVCbG9j ay5jcHAJKHJldmlzaW9uIDIzNDA5OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ieXRlY29k ZS9Db2RlQmxvY2suY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NzMsNiArOTczLDggQEAgdm9pZCBD b2RlQmxvY2s6OnNldENvbnN0YW50UmVnaXN0ZXJzKGNvbgogCiB2b2lkIENvZGVCbG9jazo6c2V0 QWx0ZXJuYXRpdmUoVk0mIHZtLCBDb2RlQmxvY2sqIGFsdGVybmF0aXZlKQogeworICAgIFJFTEVB U0VfQVNTRVJUKGFsdGVybmF0aXZlKTsKKyAgICBSRUxFQVNFX0FTU0VSVChhbHRlcm5hdGl2ZS0+ aml0Q29kZSgpKTsKICAgICBtX2FsdGVybmF0aXZlLnNldCh2bSwgdGhpcywgYWx0ZXJuYXRpdmUp OwogfQogCkBAIC0yNDE5LDcgKzI0MjEsNyBAQCB2b2lkIENvZGVCbG9jazo6c2V0T3B0aW1pemF0 aW9uVGhyZXNob2xkCiAgICAgSklUQ29kZTo6SklUVHlwZSB0eXBlID0gaml0VHlwZSgpOwogICAg IGlmICh0eXBlICE9IEpJVENvZGU6OkJhc2VsaW5lSklUKSB7CiAgICAgICAgIGRhdGFMb2coKnRo aXMsICI6IGV4cGVjdGVkIHRvIGhhdmUgYmFzZWxpbmUgY29kZSBidXQgaGF2ZSAiLCB0eXBlLCAi XG4iKTsKLSAgICAgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgUkVM RUFTRV9BU1NFUlQoaml0VHlwZSgpID09IEpJVENvZGU6OkJhc2VsaW5lSklUKTsKICAgICB9CiAg ICAgCiAgICAgQ29kZUJsb2NrKiByZXBsYWNlbWVudCA9IHRoaXMtPnJlcGxhY2VtZW50KCk7Cklu ZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR1BsYW4uY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUGxhbi5jcHAJKHJldmlzaW9uIDIzNDA5OCkK KysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHUGxhbi5jcHAJKHdvcmtpbmcgY29weSkK QEAgLTE0OCw2ICsxNDgsNyBAQCBQbGFuOjpQbGFuKENvZGVCbG9jayogcGFzc2VkQ29kZUJsb2Nr LCBDCiAgICAgLCB3ZWFrUmVmZXJlbmNlcyhjb2RlQmxvY2spCiAgICAgLCBzdGFnZShQcmVwYXJp bmcpCiB7CisgICAgUkVMRUFTRV9BU1NFUlQoY29kZUJsb2NrLT5hbHRlcm5hdGl2ZSgpLT5qaXRD b2RlKCkpOwogfQogCiBQbGFuOjp+UGxhbigpCg==