187876 2018-07-20 17:08:07 -0700 REGRESSION(r233925): Can't go into PiP twice 2018-09-07 10:36:44 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified REOPENED InRadar P2 Normal --- 1 jer.noble jer.noble commit-queue eric.carlson jeremyj-wk jonlee realdawei ryanhaddad tsavell webkit-bug-importer oldest_to_newest 1443969 0 jer.noble 2018-07-20 17:08:07 -0700 REGRESSION(r233925): Can't go into PiP twice 1443970 1 jer.noble 2018-07-20 17:11:33 -0700 <rdar://problem/42444520> 1443971 2 345492 jer.noble 2018-07-20 17:12:25 -0700 Created attachment 345492 Patch 1443976 3 345492 jeremyj-wk 2018-07-20 17:24:08 -0700 Comment on attachment 345492 Patch provisional r=me In this case the clientCount is unexpectedly not dropping to zero. There should be a bug filed about that too. 1444015 4 345492 commit-queue 2018-07-20 20:50:53 -0700 Comment on attachment 345492 Patch Clearing flags on attachment: 345492 Committed r234081: <https://trac.webkit.org/changeset/234081> 1444016 5 commit-queue 2018-07-20 20:50:55 -0700 All reviewed patches have been landed. Closing bug. 1448277 6 realdawei 2018-08-06 16:23:16 -0700 After this revision The bots (High Sierra WK2 Debug) have been seeing flaky timeouts on TestWebKitAPI.VideoControlsManager.VideoControlsManagerAudioElementFollowingUserInteraction output from latest run: https://build.webkit.org/builders/Apple%20High%20Sierra%20Debug%20WK2%20(Tests)/builds/4382/steps/run-api-tests/logs/stdio 1457521 7 ryanhaddad 2018-09-07 10:11:30 -0700 (In reply to Dawei Fenton (:realdawei) from comment #6) > After this revision The bots (High Sierra WK2 Debug) have been seeing flaky > timeouts on > TestWebKitAPI.VideoControlsManager. > VideoControlsManagerAudioElementFollowingUserInteraction This is still happening. Dawei, please file a bug. 1457535 8 realdawei 2018-09-07 10:36:44 -0700 (In reply to Ryan Haddad from comment #7) > (In reply to Dawei Fenton (:realdawei) from comment #6) > > After this revision The bots (High Sierra WK2 Debug) have been seeing flaky > > timeouts on > > TestWebKitAPI.VideoControlsManager. > > VideoControlsManagerAudioElementFollowingUserInteraction > > This is still happening. Dawei, please file a bug. tracking it here: https://bugs.webkit.org/show_bug.cgi?id=187972 345492 2018-07-20 17:12:25 -0700 2018-07-20 20:50:53 -0700 Patch bug-187876-20180720171224.patch text/plain 2434 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MDYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGNjYzYwZDA2Nzk3Yjc4ZDMx ZDgzYTc2N2FlOTFjMzJlYjFiNTVhM2QuLjVlYjkwN2VmNTRkYWE3OGRhYmI4ODQ2NTljNWQ3NGQ2 NDcxYmQ4ODQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTgtMDctMjAgIEplciBOb2Js ZSAgPGplci5ub2JsZUBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMjMzOTI1KTog Q2FuJ3QgZ28gaW50byBQaVAgdHdpY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTE4Nzg3NgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDI0NDQ1MjA+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgV2UgZmFp bCB0byBlbnRlciBQaVAgdGhlIHNlY29uZCB0aW1lIGJlY2F1c2UgdGhlIHZpZGVvIGZ1bGxzY3Jl ZW4gaW50ZXJmYWNlIG5vIGxvbmdlciBoYXMgYQorICAgICAgICBtb2RlbCwgYW5kIHNvIGdpdmVz IGEgY29udGVudFNpemUgb2YgMHgwLiBUaGlzIGhhcHBlbnMgYmVjYXVzZSB3ZSBkaXNhc3NvY2lh dGUgdGhlCisgICAgICAgIGludGVyZmFjZSBmcm9tIHRoZSBtb2RlbCBpbiBkaWRDbGVhbnVwRnVs bHNjcmVlbi4gSG93ZXZlciwgdGhlIGludGVyZmFjZSBhbmQgbW9kZWwgY2FuIHN0aWxsCisgICAg ICAgIGJlIHJlLXVzZWQgaWYgdGhleSdyZSBrZXB0IGFsaXZlIGJ5IGFub3RoZXIgY2xpZW50LiBX ZSBzaG91bGQgZGVsYXkgZGlzYXNzb2NpYXRpbmcgdGhlIG1vZGVsCisgICAgICAgIGZyb20gdGhl IGludGVyZmFjZSB1bnRpbCBqdXN0IGJlZm9yZSB0aGUgbW9kZWwgaXMgZGVzdHJveWVkIGluIHJl bW92ZUNsaWVudEZvckNvbnRleHQuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQ29jb2EvVmlkZW9G dWxsc2NyZWVuTWFuYWdlclByb3h5Lm1tOgorICAgICAgICAoV2ViS2l0OjpWaWRlb0Z1bGxzY3Jl ZW5NYW5hZ2VyUHJveHk6OnJlbW92ZUNsaWVudEZvckNvbnRleHQpOgorICAgICAgICAoV2ViS2l0 OjpWaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyUHJveHk6OmRpZENsZWFudXBGdWxsc2NyZWVuKToKKwog MjAxOC0wNy0yMCAgQnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAg ICBbbWFjT1NdIFJlbGF4IFdlYktpdCBzYW5kYm94IHRvIHBlcm1pdCBwcm9wZXIgQXBwIFN0b3Jl IGJlaGF2aW9yCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2NvYS9WaWRl b0Z1bGxzY3JlZW5NYW5hZ2VyUHJveHkubW0gYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Db2Nv YS9WaWRlb0Z1bGxzY3JlZW5NYW5hZ2VyUHJveHkubW0KaW5kZXggMGU5ZTllNGI4YTgyN2I3ZDAz NDlmZWJkNzQxMmViM2M2MmY1N2Y1Yy4uOTEwMGFmZDhjNDExMjBiYjVlNTgxZDIzMGEyNDc2Zjc1 NDJmZWQyMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQ29jb2EvVmlkZW9G dWxsc2NyZWVuTWFuYWdlclByb3h5Lm1tCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0Nv Y29hL1ZpZGVvRnVsbHNjcmVlbk1hbmFnZXJQcm94eS5tbQpAQCAtNDQ5LDYgKzQ0OSw3IEBAIHZv aWQgVmlkZW9GdWxsc2NyZWVuTWFuYWdlclByb3h5OjpyZW1vdmVDbGllbnRGb3JDb250ZXh0KHVp bnQ2NF90IGNvbnRleHRJZCkKICAgICBjbGllbnRDb3VudC0tOwogCiAgICAgaWYgKGNsaWVudENv dW50IDw9IDApIHsKKyAgICAgICAgZW5zdXJlSW50ZXJmYWNlKGNvbnRleHRJZCkuc2V0VmlkZW9G dWxsc2NyZWVuTW9kZWwobnVsbHB0cik7CiAgICAgICAgIG1fcGxheWJhY2tTZXNzaW9uTWFuYWdl clByb3h5LT5yZW1vdmVDbGllbnRGb3JDb250ZXh0KGNvbnRleHRJZCk7CiAgICAgICAgIG1fY2xp ZW50Q291bnRzLnJlbW92ZShjb250ZXh0SWQpOwogICAgICAgICBtX2NvbnRleHRNYXAucmVtb3Zl KGNvbnRleHRJZCk7CkBAIC02NDYsNyArNjQ3LDYgQEAgdm9pZCBWaWRlb0Z1bGxzY3JlZW5NYW5h Z2VyUHJveHk6OmRpZENsZWFudXBGdWxsc2NyZWVuKHVpbnQ2NF90IGNvbnRleHRJZCkKICAgICBt X3BhZ2UtPnNlbmQoTWVzc2FnZXM6OlZpZGVvRnVsbHNjcmVlbk1hbmFnZXI6OkRpZENsZWFudXBG dWxsc2NyZWVuKGNvbnRleHRJZCksIG1fcGFnZS0+cGFnZUlEKCkpOwogCiAgICAgaW50ZXJmYWNl LT5zZXRNb2RlKEhUTUxNZWRpYUVsZW1lbnRFbnVtczo6VmlkZW9GdWxsc2NyZWVuTW9kZU5vbmUp OwotICAgIGludGVyZmFjZS0+c2V0VmlkZW9GdWxsc2NyZWVuTW9kZWwobnVsbHB0cik7CiAgICAg cmVtb3ZlQ2xpZW50Rm9yQ29udGV4dChjb250ZXh0SWQpOwogfQogCg==