187854 2018-07-20 08:38:28 -0700 FrameView::paintContents should release log when the render tree is dirty. 2018-07-20 10:37:05 -0700 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham commit-queue simon.fraser webkit-bug-importer zalan oldest_to_newest 1443748 0 zalan 2018-07-20 08:38:28 -0700 ssia 1443778 1 webkit-bug-importer 2018-07-20 09:37:01 -0700 <rdar://problem/42432371> 1443781 2 345451 zalan 2018-07-20 09:43:22 -0700 Created attachment 345451 Patch 1443796 3 345451 simon.fraser 2018-07-20 10:03:58 -0700 Comment on attachment 345451 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345451&action=review > Source/WebCore/page/FrameView.cpp:4146 > + RELEASE_LOG_IF_ALLOWED("painting: Render tree needs layout. Can't paint at this time -is mainframe(%d)", frame().isMainFrame()); Let's put "FrameView::paintContents" in the log message somewhere. Maybe "FrameView::paintContents() - not painting because render tree needs layout (is main frame %d)". 1443801 4 345455 zalan 2018-07-20 10:09:39 -0700 Created attachment 345455 Patch 1443816 5 345455 commit-queue 2018-07-20 10:37:04 -0700 Comment on attachment 345455 Patch Clearing flags on attachment: 345455 Committed r234053: <https://trac.webkit.org/changeset/234053> 1443817 6 commit-queue 2018-07-20 10:37:05 -0700 All reviewed patches have been landed. Closing bug. 345451 2018-07-20 09:43:22 -0700 2018-07-20 10:09:36 -0700 Patch bug-187854-20180720094322.patch text/plain 1796 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODhkZTg0ZDcwMWRkNjk4 MjBkZmM4OTA4NGI3MmI0OWUzNWY2ZTFhYi4uNjJlODcyYjdhMGQ1MDI1ZjE3YWM0YWJiZDk2NDA1 MzgxOWQ5YWYxZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA3LTIwICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIEZyYW1lVmlldzo6 cGFpbnRDb250ZW50cyB0byB1c2UgcmVsZWFzZSBsb2dnaW5nLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3ODU0CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80MjQzMjM3MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGRpbmcgcmVsZWFzZSBsb2dnaW5nIGhlbHBzIGlkZW50aWZ5aW5nIGJsYW5rIGNv bnRlbnQgY2FzZXMuIAorCisgICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAo V2ViQ29yZTo6RnJhbWVWaWV3OjpwYWludENvbnRlbnRzKToKKwogMjAxOC0wNy0xOSAgQW50b2lu ZSBRdWludCAgPGdyYW91dHNAYXBwbGUuY29tPgogCiAgICAgICAgIEZsYWt5IGNyYXNoIGluIEFu aW1hdGlvblRpbWVsaW5lOjpjYW5jZWxPclJlbW92ZURlY2xhcmF0aXZlQW5pbWF0aW9uCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wYWdlL0ZyYW1lVmlldy5jcHAKaW5kZXggZTAzYmUzZjJiYWNkNjI0MzMzN2JiZWIwMjg5MTY2 MzNkNjk3OThhZi4uY2M1MTFjNTc2MDdkZTdkYmU1Y2Q0NDI1ZWEyOGI0ZWE4MTNmYzE1YSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwCisrKyBiL1NvdXJjZS9X ZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcApAQCAtMTE4LDYgKzExOCw4IEBACiAjaW5jbHVkZSAi TGVnYWN5VGlsZUNhY2hlLmgiCiAjZW5kaWYKIAorI2RlZmluZSBSRUxFQVNFX0xPR19JRl9BTExP V0VEKGZtdCwgLi4uKSBSRUxFQVNFX0xPR19JRihmcmFtZSgpLnBhZ2UoKSAmJiBmcmFtZSgpLnBh Z2UoKS0+aXNBbHdheXNPbkxvZ2dpbmdBbGxvd2VkKCksIExheW91dCwgIiVwIC0gRnJhbWVWaWV3 OjoiIGZtdCwgdGhpcywgIyNfX1ZBX0FSR1NfXykKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiB1 c2luZyBuYW1lc3BhY2UgSFRNTE5hbWVzOwpAQCAtNDE0MCw4ICs0MTQyLDEwIEBAIHZvaWQgRnJh bWVWaWV3OjpwYWludENvbnRlbnRzKEdyYXBoaWNzQ29udGV4dCYgY29udGV4dCwgY29uc3QgSW50 UmVjdCYgZGlydHlSZWN0CiAgICAgICAgIHJldHVybjsKIAogICAgIEFTU0VSVCghbmVlZHNMYXlv dXQoKSk7Ci0gICAgaWYgKG5lZWRzTGF5b3V0KCkpCisgICAgaWYgKG5lZWRzTGF5b3V0KCkpIHsK KyAgICAgICAgUkVMRUFTRV9MT0dfSUZfQUxMT1dFRCgicGFpbnRpbmc6IFJlbmRlciB0cmVlIG5l ZWRzIGxheW91dC4gQ2FuJ3QgcGFpbnQgYXQgdGhpcyB0aW1lIC1pcyBtYWluZnJhbWUoJWQpIiwg ZnJhbWUoKS5pc01haW5GcmFtZSgpKTsKICAgICAgICAgcmV0dXJuOworICAgIH0KIAogICAgIFBh aW50aW5nU3RhdGUgcGFpbnRpbmdTdGF0ZTsKICAgICB3aWxsUGFpbnRDb250ZW50cyhjb250ZXh0 LCBkaXJ0eVJlY3QsIHBhaW50aW5nU3RhdGUpOwo= 345455 2018-07-20 10:09:39 -0700 2018-07-20 10:37:04 -0700 Patch bug-187854-20180720100938.patch text/plain 1809 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjM0MDM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODhkZTg0ZDcwMWRkNjk4 MjBkZmM4OTA4NGI3MmI0OWUzNWY2ZTFhYi4uNmExYjU1NDYxOWRiOWJhNzkwZGFiOTM4NjhjMDU4 ZDViMWQxOThlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE4LTA3LTIwICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgVXBkYXRlIEZyYW1lVmlldzo6 cGFpbnRDb250ZW50cyB0byB1c2UgcmVsZWFzZSBsb2dnaW5nLgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3ODU0CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS80MjQzMjM3MT4KKworICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAg ICAgICAgQWRkaW5nIHJlbGVhc2UgbG9nZ2luZyBoZWxwcyBpZGVudGlmeWluZyBibGFuayBjb250 ZW50IGNhc2VzLiAKKworICAgICAgICAqIHBhZ2UvRnJhbWVWaWV3LmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OkZyYW1lVmlldzo6cGFpbnRDb250ZW50cyk6CisKIDIwMTgtMDctMTkgIEFudG9pbmUg UXVpbnQgIDxncmFvdXRzQGFwcGxlLmNvbT4KIAogICAgICAgICBGbGFreSBjcmFzaCBpbiBBbmlt YXRpb25UaW1lbGluZTo6Y2FuY2VsT3JSZW1vdmVEZWNsYXJhdGl2ZUFuaW1hdGlvbgpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuY3BwIGIvU291cmNlL1dlYkNvcmUv cGFnZS9GcmFtZVZpZXcuY3BwCmluZGV4IGUwM2JlM2YyYmFjZDYyNDMzMzdiYmViMDI4OTE2NjMz ZDY5Nzk4YWYuLjUxODlhY2Q5NmNhMDBlNDVkNWU5YzUwZjc1M2QyOWM2NGM2YmJlZDkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTExOCw2ICsxMTgsOCBAQAogI2luY2x1ZGUgIkxl Z2FjeVRpbGVDYWNoZS5oIgogI2VuZGlmCiAKKyNkZWZpbmUgUkVMRUFTRV9MT0dfSUZfQUxMT1dF RChmbXQsIC4uLikgUkVMRUFTRV9MT0dfSUYoZnJhbWUoKS5wYWdlKCkgJiYgZnJhbWUoKS5wYWdl KCktPmlzQWx3YXlzT25Mb2dnaW5nQWxsb3dlZCgpLCBMYXlvdXQsICIlcCAtIEZyYW1lVmlldzo6 IiBmbXQsIHRoaXMsICMjX19WQV9BUkdTX18pCisKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogdXNp bmcgbmFtZXNwYWNlIEhUTUxOYW1lczsKQEAgLTQxNDAsOCArNDE0MiwxMCBAQCB2b2lkIEZyYW1l Vmlldzo6cGFpbnRDb250ZW50cyhHcmFwaGljc0NvbnRleHQmIGNvbnRleHQsIGNvbnN0IEludFJl Y3QmIGRpcnR5UmVjdAogICAgICAgICByZXR1cm47CiAKICAgICBBU1NFUlQoIW5lZWRzTGF5b3V0 KCkpOwotICAgIGlmIChuZWVkc0xheW91dCgpKQorICAgIGlmIChuZWVkc0xheW91dCgpKSB7Cisg ICAgICAgIFJFTEVBU0VfTE9HX0lGX0FMTE9XRUQoIkZyYW1lVmlldzo6cGFpbnRDb250ZW50cygp IC0gbm90IHBhaW50aW5nIGJlY2F1c2UgcmVuZGVyIHRyZWUgbmVlZHMgbGF5b3V0IChpcyBtYWlu IGZyYW1lICVkKSIsIGZyYW1lKCkuaXNNYWluRnJhbWUoKSk7CiAgICAgICAgIHJldHVybjsKKyAg ICB9CiAKICAgICBQYWludGluZ1N0YXRlIHBhaW50aW5nU3RhdGU7CiAgICAgd2lsbFBhaW50Q29u dGVudHMoY29udGV4dCwgZGlydHlSZWN0LCBwYWludGluZ1N0YXRlKTsK