187817 2018-07-19 13:16:39 -0700 Teach the AWS Lambda to use the [minified]-platforms database 2018-07-19 16:42:25 -0700 1 1 1 Unclassified WebKit Tools / Tests Safari 11 Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 lforschler lforschler aakash_jain ddkilzer dewei_zhu ews-watchlist lforschler webkit-bug-importer oldest_to_newest 1443476 0 lforschler 2018-07-19 13:16:39 -0700 When archives are uploaded to S3, we need to keep track of what platforms are available. We can easily do this with the current lambda function which parses the rest of the metadata. 1443477 1 webkit-bug-importer 2018-07-19 13:17:08 -0700 <rdar://problem/42396841> 1443478 2 345375 lforschler 2018-07-19 13:19:06 -0700 Created attachment 345375 patch for review 1443479 3 345375 dewei_zhu 2018-07-19 13:20:56 -0700 Comment on attachment 345375 patch for review looks good to me. 1443480 4 ews-watchlist 2018-07-19 13:22:17 -0700 Attachment 345375 did not pass style-queue: ERROR: Tools/WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py:45: trailing whitespace [pep8/W291] [5] ERROR: Tools/WebKitArchiveSupport/lambda/register-archive-in-dynamodb.py:53: trailing whitespace [pep8/W291] [5] ERROR: Tools/WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py:45: trailing whitespace [pep8/W291] [5] ERROR: Tools/WebKitArchiveSupport/lambda/register-minified-s3-archive-in-dynamodb.py:53: trailing whitespace [pep8/W291] [5] Total errors found: 4 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 1443481 5 345376 lforschler 2018-07-19 13:28:35 -0700 Created attachment 345376 v2 patch to fix style errors. 1443587 6 345376 ddkilzer 2018-07-19 16:32:26 -0700 Comment on attachment 345376 v2 patch to fix style errors. rs=me 1443588 7 lforschler 2018-07-19 16:38:22 -0700 Committed revision 234016. 1443590 8 345376 aakash_jain 2018-07-19 16:42:25 -0700 Comment on attachment 345376 v2 patch to fix style errors. looks good to me. 345375 2018-07-19 13:19:06 -0700 2018-07-19 13:28:35 -0700 patch for review 187817.patch text/plain 3574 lforschler SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMzk5OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE4LTA3LTE5ICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxl LmNvbT4KKworICAgICAgICBUZWFjaCB0aGUgQVdTIExhbWJkYSB0byB1c2UgdGhlIFttaW5pZmll ZF0tcGxhdGZvcm1zIGRhdGFiYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODc4MTcKKyAgICAgICAgCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0QXJjaGl2ZVN1cHBvcnQvbGFtYmRhL3JlZ2lz dGVyLWFyY2hpdmUtaW4tZHluYW1vZGIucHk6CisgICAgICAgIChsYW1iZGFfaGFuZGxlcik6IEFk ZCBzdXBwb3J0IGZvciB0aGUgcGxhdGZvcm1zLndlYmtpdC5vcmcgZGF0YWJhc2UKKyAgICAgICAg KiBXZWJLaXRBcmNoaXZlU3VwcG9ydC9sYW1iZGEvcmVnaXN0ZXItbWluaWZpZWQtczMtYXJjaGl2 ZS1pbi1keW5hbW9kYi5weToKKyAgICAgICAgKGxhbWJkYV9oYW5kbGVyKTogQWRkIHN1cHBvcnQg Zm9yIHRoZSBtaW5pZmllZC1wbGF0Zm9ybXMud2Via2l0Lm9yZyBkYXRhYmFzZQorCiAyMDE4LTA3 LTE5ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBQcm92aWRlIGFu IGxsZGIgdHlwZSBzdW1tYXJ5IGZvciBXZWJDb3JlOjpDb2xvcgpJbmRleDogVG9vbHMvV2ViS2l0 QXJjaGl2ZVN1cHBvcnQvbGFtYmRhL3JlZ2lzdGVyLWFyY2hpdmUtaW4tZHluYW1vZGIucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvV2ViS2l0QXJjaGl2ZVN1cHBvcnQvbGFtYmRhL3JlZ2lzdGVyLWFy Y2hpdmUtaW4tZHluYW1vZGIucHkJKHJldmlzaW9uIDIzMzk5OSkKKysrIFRvb2xzL1dlYktpdEFy Y2hpdmVTdXBwb3J0L2xhbWJkYS9yZWdpc3Rlci1hcmNoaXZlLWluLWR5bmFtb2RiLnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC01LDcgKzUsOCBAQCBpbXBvcnQgdXJsbGliLnBhcnNlICAjIHB5bGludDog ZGlzYWJsZT1FCiAKIERBWVNfVE9fS0VFUCA9IDE0CiBFUE9DSF9EQVkgPSA4NjQwMAotVEFCTEVf TkFNRSA9ICdhcmNoaXZlcy53ZWJraXQub3JnJworQVJDSElWRV9UQUJMRV9OQU1FID0gJ2FyY2hp dmVzLndlYmtpdC5vcmcnCitQTEFURk9STV9UQUJMRV9OQU1FID0gJ3BsYXRmb3Jtcy53ZWJraXQu b3JnJwogVVJMX1BSRUZJWCA9ICdodHRwczovL3MzLXVzLXdlc3QtMi5hbWF6b25hd3MuY29tJwog CiBkeW5hbW9kYl9jbGllbnQgPSBib3RvMy5jbGllbnQoJ2R5bmFtb2RiJykKQEAgLTQwLDcgKzQx LDE2IEBAIGRlZiBsYW1iZGFfaGFuZGxlcihldmVudCwgY29udGV4dCk6CiAgICAgICAgICAgICAn ZXhwaXJhdGlvblRpbWUnOiB7J04nOiBleHBpcmF0aW9uX3RpbWV9LAogICAgICAgICB9CiAgICAg ICAgIHByaW50KCdJdGVtOiB7fScuZm9ybWF0KGl0ZW0pKQotICAgICAgICBkeW5hbW9kYl9jbGll bnQucHV0X2l0ZW0oVGFibGVOYW1lPVRBQkxFX05BTUUsIEl0ZW09aXRlbSkKKyAgICAgICAgZHlu YW1vZGJfY2xpZW50LnB1dF9pdGVtKFRhYmxlTmFtZT1BUkNISVZFX1RBQkxFX05BTUUsIEl0ZW09 aXRlbSkKKyAgICAgICAgCisgICAgICAgIHBsYXRmb3JtID0geworICAgICAgICAgICAgJ2lkZW50 aWZpZXInOiB7J1MnOiBpZGVudGlmaWVyfSwKKyAgICAgICAgICAgICdjcmVhdGlvblRpbWUnOiB7 J04nOiBjcmVhdGlvbl90aW1lfSwKKyAgICAgICAgICAgICdleHBpcmF0aW9uVGltZSc6IHsnTic6 IGV4cGlyYXRpb25fdGltZX0sCisgICAgICAgIH0KKyAgICAgICAgcHJpbnQoJ1BsYXRmb3JtOiB7 fScuZm9ybWF0KHBsYXRmb3JtKSkKKyAgICAgICAgZHluYW1vZGJfY2xpZW50LnB1dF9pdGVtKFRh YmxlTmFtZT1QTEFURk9STV9UQUJMRV9OQU1FLCBJdGVtPXBsYXRmb3JtKQorICAgICAgICAKICAg ICAgICAgcmV0dXJuIHMzX3VybAogICAgIGV4Y2VwdCBFeGNlcHRpb24gYXMgZToKICAgICAgICAg cHJpbnQoZSkKSW5kZXg6IFRvb2xzL1dlYktpdEFyY2hpdmVTdXBwb3J0L2xhbWJkYS9yZWdpc3Rl ci1taW5pZmllZC1zMy1hcmNoaXZlLWluLWR5bmFtb2RiLnB5Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz L1dlYktpdEFyY2hpdmVTdXBwb3J0L2xhbWJkYS9yZWdpc3Rlci1taW5pZmllZC1zMy1hcmNoaXZl LWluLWR5bmFtb2RiLnB5CShyZXZpc2lvbiAyMzM5OTkpCisrKyBUb29scy9XZWJLaXRBcmNoaXZl U3VwcG9ydC9sYW1iZGEvcmVnaXN0ZXItbWluaWZpZWQtczMtYXJjaGl2ZS1pbi1keW5hbW9kYi5w eQkod29ya2luZyBjb3B5KQpAQCAtNSw3ICs1LDggQEAgaW1wb3J0IHVybGxpYi5wYXJzZSAgIyBw eWxpbnQ6IGRpc2FibGU9RQogCiBEQVlTX1RPX0tFRVAgPSA5MTAKIEVQT0NIX0RBWSA9IDg2NDAw Ci1UQUJMRV9OQU1FID0gJ21pbmlmaWVkLWFyY2hpdmVzLndlYmtpdC5vcmcnCitBUkNISVZFX1RB QkxFX05BTUUgPSAnbWluaWZpZWQtYXJjaGl2ZXMud2Via2l0Lm9yZycKK1BMQVRGT1JNX1RBQkxF X05BTUUgPSAnbWluaWZpZWQtcGxhdGZvcm1zLndlYmtpdC5vcmcnCiBVUkxfUFJFRklYID0gJ2h0 dHBzOi8vczMtdXMtd2VzdC0yLmFtYXpvbmF3cy5jb20nCiAKIGR5bmFtb2RiX2NsaWVudCA9IGJv dG8zLmNsaWVudCgnZHluYW1vZGInKQpAQCAtNDAsNyArNDEsMTYgQEAgZGVmIGxhbWJkYV9oYW5k bGVyKGV2ZW50LCBjb250ZXh0KToKICAgICAgICAgICAgICdleHBpcmF0aW9uVGltZSc6IHsnTic6 IGV4cGlyYXRpb25fdGltZX0sCiAgICAgICAgIH0KICAgICAgICAgcHJpbnQoJ0l0ZW06IHt9Jy5m b3JtYXQoaXRlbSkpCi0gICAgICAgIGR5bmFtb2RiX2NsaWVudC5wdXRfaXRlbShUYWJsZU5hbWU9 VEFCTEVfTkFNRSwgSXRlbT1pdGVtKQorICAgICAgICBkeW5hbW9kYl9jbGllbnQucHV0X2l0ZW0o VGFibGVOYW1lPUFSQ0hJVkVfVEFCTEVfTkFNRSwgSXRlbT1pdGVtKQorICAgICAgICAKKyAgICAg ICAgcGxhdGZvcm0gPSB7CisgICAgICAgICAgICAnaWRlbnRpZmllcic6IHsnUyc6IGlkZW50aWZp ZXJ9LAorICAgICAgICAgICAgJ2NyZWF0aW9uVGltZSc6IHsnTic6IGNyZWF0aW9uX3RpbWV9LAor ICAgICAgICAgICAgJ2V4cGlyYXRpb25UaW1lJzogeydOJzogZXhwaXJhdGlvbl90aW1lfSwKKyAg ICAgICAgfQorICAgICAgICBwcmludCgnSXRlbToge30nLmZvcm1hdChwbGF0Zm9ybSkpCisgICAg ICAgIGR5bmFtb2RiX2NsaWVudC5wdXRfaXRlbShUYWJsZU5hbWU9UExBVEZPUk1fVEFCTEVfTkFN RSwgSXRlbT1wbGF0Zm9ybSkKKyAgICAgICAgCiAgICAgICAgIHJldHVybiBzM191cmwKICAgICBl eGNlcHQgRXhjZXB0aW9uIGFzIGU6CiAgICAgICAgIHByaW50KGUpCg== 345376 2018-07-19 13:28:35 -0700 2018-07-19 16:32:26 -0700 v2 patch to fix style errors. 187817v2.patch text/plain 3542 lforschler SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIzMzk5OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE4LTA3LTE5ICBMdWNhcyBGb3JzY2hsZXIgIDxsZm9yc2NobGVyQGFwcGxl LmNvbT4KKworICAgICAgICBUZWFjaCB0aGUgQVdTIExhbWJkYSB0byB1c2UgdGhlIFttaW5pZmll ZF0tcGxhdGZvcm1zIGRhdGFiYXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xODc4MTcKKyAgICAgICAgCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogV2ViS2l0QXJjaGl2ZVN1cHBvcnQvbGFtYmRhL3JlZ2lz dGVyLWFyY2hpdmUtaW4tZHluYW1vZGIucHk6CisgICAgICAgIChsYW1iZGFfaGFuZGxlcik6IEFk ZCBzdXBwb3J0IGZvciB0aGUgcGxhdGZvcm1zLndlYmtpdC5vcmcgZGF0YWJhc2UKKyAgICAgICAg KiBXZWJLaXRBcmNoaXZlU3VwcG9ydC9sYW1iZGEvcmVnaXN0ZXItbWluaWZpZWQtczMtYXJjaGl2 ZS1pbi1keW5hbW9kYi5weToKKyAgICAgICAgKGxhbWJkYV9oYW5kbGVyKTogQWRkIHN1cHBvcnQg Zm9yIHRoZSBtaW5pZmllZC1wbGF0Zm9ybXMud2Via2l0Lm9yZyBkYXRhYmFzZQorCiAyMDE4LTA3 LTE5ICBEZWFuIEphY2tzb24gIDxkaW5vQGFwcGxlLmNvbT4KIAogICAgICAgICBQcm92aWRlIGFu IGxsZGIgdHlwZSBzdW1tYXJ5IGZvciBXZWJDb3JlOjpDb2xvcgpJbmRleDogVG9vbHMvV2ViS2l0 QXJjaGl2ZVN1cHBvcnQvbGFtYmRhL3JlZ2lzdGVyLWFyY2hpdmUtaW4tZHluYW1vZGIucHkKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gVG9vbHMvV2ViS2l0QXJjaGl2ZVN1cHBvcnQvbGFtYmRhL3JlZ2lzdGVyLWFy Y2hpdmUtaW4tZHluYW1vZGIucHkJKHJldmlzaW9uIDIzMzk5OSkKKysrIFRvb2xzL1dlYktpdEFy Y2hpdmVTdXBwb3J0L2xhbWJkYS9yZWdpc3Rlci1hcmNoaXZlLWluLWR5bmFtb2RiLnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC01LDcgKzUsOCBAQCBpbXBvcnQgdXJsbGliLnBhcnNlICAjIHB5bGludDog ZGlzYWJsZT1FCiAKIERBWVNfVE9fS0VFUCA9IDE0CiBFUE9DSF9EQVkgPSA4NjQwMAotVEFCTEVf TkFNRSA9ICdhcmNoaXZlcy53ZWJraXQub3JnJworQVJDSElWRV9UQUJMRV9OQU1FID0gJ2FyY2hp dmVzLndlYmtpdC5vcmcnCitQTEFURk9STV9UQUJMRV9OQU1FID0gJ3BsYXRmb3Jtcy53ZWJraXQu b3JnJwogVVJMX1BSRUZJWCA9ICdodHRwczovL3MzLXVzLXdlc3QtMi5hbWF6b25hd3MuY29tJwog CiBkeW5hbW9kYl9jbGllbnQgPSBib3RvMy5jbGllbnQoJ2R5bmFtb2RiJykKQEAgLTQwLDcgKzQx LDE2IEBAIGRlZiBsYW1iZGFfaGFuZGxlcihldmVudCwgY29udGV4dCk6CiAgICAgICAgICAgICAn ZXhwaXJhdGlvblRpbWUnOiB7J04nOiBleHBpcmF0aW9uX3RpbWV9LAogICAgICAgICB9CiAgICAg ICAgIHByaW50KCdJdGVtOiB7fScuZm9ybWF0KGl0ZW0pKQotICAgICAgICBkeW5hbW9kYl9jbGll bnQucHV0X2l0ZW0oVGFibGVOYW1lPVRBQkxFX05BTUUsIEl0ZW09aXRlbSkKKyAgICAgICAgZHlu YW1vZGJfY2xpZW50LnB1dF9pdGVtKFRhYmxlTmFtZT1BUkNISVZFX1RBQkxFX05BTUUsIEl0ZW09 aXRlbSkKKworICAgICAgICBwbGF0Zm9ybSA9IHsKKyAgICAgICAgICAgICdpZGVudGlmaWVyJzog eydTJzogaWRlbnRpZmllcn0sCisgICAgICAgICAgICAnY3JlYXRpb25UaW1lJzogeydOJzogY3Jl YXRpb25fdGltZX0sCisgICAgICAgICAgICAnZXhwaXJhdGlvblRpbWUnOiB7J04nOiBleHBpcmF0 aW9uX3RpbWV9LAorICAgICAgICB9CisgICAgICAgIHByaW50KCdQbGF0Zm9ybToge30nLmZvcm1h dChwbGF0Zm9ybSkpCisgICAgICAgIGR5bmFtb2RiX2NsaWVudC5wdXRfaXRlbShUYWJsZU5hbWU9 UExBVEZPUk1fVEFCTEVfTkFNRSwgSXRlbT1wbGF0Zm9ybSkKKwogICAgICAgICByZXR1cm4gczNf dXJsCiAgICAgZXhjZXB0IEV4Y2VwdGlvbiBhcyBlOgogICAgICAgICBwcmludChlKQpJbmRleDog VG9vbHMvV2ViS2l0QXJjaGl2ZVN1cHBvcnQvbGFtYmRhL3JlZ2lzdGVyLW1pbmlmaWVkLXMzLWFy Y2hpdmUtaW4tZHluYW1vZGIucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvV2ViS2l0QXJjaGl2ZVN1 cHBvcnQvbGFtYmRhL3JlZ2lzdGVyLW1pbmlmaWVkLXMzLWFyY2hpdmUtaW4tZHluYW1vZGIucHkJ KHJldmlzaW9uIDIzMzk5OSkKKysrIFRvb2xzL1dlYktpdEFyY2hpdmVTdXBwb3J0L2xhbWJkYS9y ZWdpc3Rlci1taW5pZmllZC1zMy1hcmNoaXZlLWluLWR5bmFtb2RiLnB5CSh3b3JraW5nIGNvcHkp CkBAIC01LDcgKzUsOCBAQCBpbXBvcnQgdXJsbGliLnBhcnNlICAjIHB5bGludDogZGlzYWJsZT1F CiAKIERBWVNfVE9fS0VFUCA9IDkxMAogRVBPQ0hfREFZID0gODY0MDAKLVRBQkxFX05BTUUgPSAn bWluaWZpZWQtYXJjaGl2ZXMud2Via2l0Lm9yZycKK0FSQ0hJVkVfVEFCTEVfTkFNRSA9ICdtaW5p ZmllZC1hcmNoaXZlcy53ZWJraXQub3JnJworUExBVEZPUk1fVEFCTEVfTkFNRSA9ICdtaW5pZmll ZC1wbGF0Zm9ybXMud2Via2l0Lm9yZycKIFVSTF9QUkVGSVggPSAnaHR0cHM6Ly9zMy11cy13ZXN0 LTIuYW1hem9uYXdzLmNvbScKIAogZHluYW1vZGJfY2xpZW50ID0gYm90bzMuY2xpZW50KCdkeW5h bW9kYicpCkBAIC00MCw3ICs0MSwxNiBAQCBkZWYgbGFtYmRhX2hhbmRsZXIoZXZlbnQsIGNvbnRl eHQpOgogICAgICAgICAgICAgJ2V4cGlyYXRpb25UaW1lJzogeydOJzogZXhwaXJhdGlvbl90aW1l fSwKICAgICAgICAgfQogICAgICAgICBwcmludCgnSXRlbToge30nLmZvcm1hdChpdGVtKSkKLSAg ICAgICAgZHluYW1vZGJfY2xpZW50LnB1dF9pdGVtKFRhYmxlTmFtZT1UQUJMRV9OQU1FLCBJdGVt PWl0ZW0pCisgICAgICAgIGR5bmFtb2RiX2NsaWVudC5wdXRfaXRlbShUYWJsZU5hbWU9QVJDSElW RV9UQUJMRV9OQU1FLCBJdGVtPWl0ZW0pCisKKyAgICAgICAgcGxhdGZvcm0gPSB7CisgICAgICAg ICAgICAnaWRlbnRpZmllcic6IHsnUyc6IGlkZW50aWZpZXJ9LAorICAgICAgICAgICAgJ2NyZWF0 aW9uVGltZSc6IHsnTic6IGNyZWF0aW9uX3RpbWV9LAorICAgICAgICAgICAgJ2V4cGlyYXRpb25U aW1lJzogeydOJzogZXhwaXJhdGlvbl90aW1lfSwKKyAgICAgICAgfQorICAgICAgICBwcmludCgn SXRlbToge30nLmZvcm1hdChwbGF0Zm9ybSkpCisgICAgICAgIGR5bmFtb2RiX2NsaWVudC5wdXRf aXRlbShUYWJsZU5hbWU9UExBVEZPUk1fVEFCTEVfTkFNRSwgSXRlbT1wbGF0Zm9ybSkKKwogICAg ICAgICByZXR1cm4gczNfdXJsCiAgICAgZXhjZXB0IEV4Y2VwdGlvbiBhcyBlOgogICAgICAgICBw cmludChlKQo=