187812 2018-07-19 11:14:10 -0700 Temporarily mitigate a bug where a source provider is null when it shouldn't be. 2018-07-19 12:44:34 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 187359 InRadar P2 Normal --- 187815 1 mark.lam mark.lam commit-queue fpizlo keith_miller msaboff rmorisset saam tzagallo webkit-bug-importer oldest_to_newest 1443425 0 mark.lam 2018-07-19 11:14:10 -0700 Adding a null check to temporarily mitigate https://bugs.webkit.org/show_bug.cgi?id=187811. <rdar://problem/41192691> 1443426 1 webkit-bug-importer 2018-07-19 11:15:23 -0700 <rdar://problem/42391474> 1443429 2 mark.lam 2018-07-19 11:15:46 -0700 <rdar://problem/41192691> 1443430 3 345362 mark.lam 2018-07-19 11:22:17 -0700 Created attachment 345362 proposed patch. 1443431 4 345363 mark.lam 2018-07-19 11:23:32 -0700 Created attachment 345363 proposed patch. 1443435 5 345363 msaboff 2018-07-19 11:33:51 -0700 Comment on attachment 345363 proposed patch. r=me 1443451 6 345363 saam 2018-07-19 12:27:19 -0700 Comment on attachment 345363 proposed patch. I thought I already fixed this bug? I’m pretty sure the issue here is the underlying codeblock was being collected. Maybe the bug here is we’re forgetting to copy the SourceCode instead of passing it by reference. Do you know if my previous fix fixed this issue? Or do we not have data to say. 1443453 7 mark.lam 2018-07-19 12:29:30 -0700 Thanks for the review. Landed in r233998: <http://trac.webkit.org/r233998>. 1443454 8 mark.lam 2018-07-19 12:30:01 -0700 (In reply to Saam Barati from comment #6) > Comment on attachment 345363 [details] > proposed patch. > > I thought I already fixed this bug? I’m pretty sure the issue here is the > underlying codeblock was being collected. > > Maybe the bug here is we’re forgetting to copy the SourceCode instead of > passing it by reference. Do you know if my previous fix fixed this issue? Or > do we not have data to say. I don't have data on that. Which bug are you referring to? I can take a look. 1443457 9 mark.lam 2018-07-19 12:36:40 -0700 (In reply to Mark Lam from comment #8) > (In reply to Saam Barati from comment #6) > > Comment on attachment 345363 [details] > > proposed patch. > > > > I thought I already fixed this bug? I’m pretty sure the issue here is the > > underlying codeblock was being collected. > > > > Maybe the bug here is we’re forgetting to copy the SourceCode instead of > > passing it by reference. Do you know if my previous fix fixed this issue? Or > > do we not have data to say. > > I don't have data on that. Which bug are you referring to? I can take a > look. Found the bug. Investigating now. 1443458 10 saam 2018-07-19 12:37:15 -0700 Seems very likely it’s the same. This is the same symptom I saw 1443459 11 mark.lam 2018-07-19 12:39:14 -0700 (In reply to Saam Barati from comment #10) > Seems very likely it’s the same. This is the same symptom I saw Yep. Total duplicate. Will roll out my mitigation. No wonder I don't see what's wrong in the source: it's already fixed. 1443461 12 commit-queue 2018-07-19 12:39:58 -0700 Re-opened since this is blocked by bug 187815 1443465 13 mark.lam 2018-07-19 12:44:14 -0700 The unneeded mitigation was rolled out in r233999: <https://trac.webkit.org/changeset/233999>. 1443467 14 mark.lam 2018-07-19 12:44:34 -0700 *** This bug has been marked as a duplicate of bug 187359 *** 345362 2018-07-19 11:22:17 -0700 2018-07-19 11:23:32 -0700 proposed patch. bug-187812.patch text/plain 2190 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMzOTkzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE4LTA3LTE5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBU ZW1wb3JhcmlseSBtaXRpZ2F0ZSBhIGJ1ZyB3aGVyZSBhIHNvdXJjZSBwcm92aWRlciBpcyBudWxs IHdoZW4gaXQgc2hvdWxkbid0IGJlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg3ODEyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MTE5MjY5MT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcg YSBudWxsIGNoZWNrIHRvIHRlbXBvcmFyaWx5IG1pdGlnYXRlIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODc4MTEuCisKKyAgICAgICAgKiBydW50aW1lL0Vycm9yLmNw cDoKKyAgICAgICAgKEpTQzo6YWRkRXJyb3JJbmZvKToKKwogMjAxOC0wNy0xOSAgS2VpdGggUm9s bGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRqdXN0IFdFQkNPUkVfRVhQT1JU IGFubm90YXRpb25zIGZvciBMVE8KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0Vycm9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9F cnJvci5jcHAJKHJldmlzaW9uIDIzMzk5MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0Vycm9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjM5LDcgKzIzOSw2IEBAIHZvaWQgYWRk RXJyb3JJbmZvKEV4ZWNTdGF0ZSogZXhlYywgSlNPYmoKIEpTT2JqZWN0KiBhZGRFcnJvckluZm8o Q2FsbEZyYW1lKiBjYWxsRnJhbWUsIEpTT2JqZWN0KiBlcnJvciwgaW50IGxpbmUsIGNvbnN0IFNv dXJjZUNvZGUmIHNvdXJjZSkKIHsKICAgICBWTSYgdm0gPSBjYWxsRnJhbWUtPnZtKCk7Ci0gICAg Y29uc3QgU3RyaW5nJiBzb3VyY2VVUkwgPSBzb3VyY2UucHJvdmlkZXIoKS0+dXJsKCk7CiAgICAg CiAgICAgLy8gVGhlIHB1dERpcmVjdCgpIGNhbGxzIGJlbG93IHNob3VsZCByZWFsbHkgYmUgcHV0 KCkgc28gdGhhdCB0aGV5IHRyaWdnZXIgbWF0ZXJpYWxpemF0aW9uIG9mCiAgICAgLy8gdGhlIGxp bmUvc291cmNlVVJMIHByb3BlcnRpZXMuIE90aGVyd2lzZSwgd2hhdCB3ZSBzZXQgaGVyZSB3aWxs IGp1c3QgYmUgb3ZlcndyaXR0ZW4gbGF0ZXIuCkBAIC0yNTYsOCArMjU1LDE1IEBAIEpTT2JqZWN0 KiBhZGRFcnJvckluZm8oQ2FsbEZyYW1lKiBjYWxsRnIKICAgICAvLyBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NjczCiAgICAgaWYgKGxpbmUgIT0gLTEpCiAgICAg ICAgIGVycm9yLT5wdXREaXJlY3Qodm0sIHZtLnByb3BlcnR5TmFtZXMtPmxpbmUsIGpzTnVtYmVy KGxpbmUpKTsKLSAgICBpZiAoIXNvdXJjZVVSTC5pc051bGwoKSkKLSAgICAgICAgZXJyb3ItPnB1 dERpcmVjdCh2bSwgdm0ucHJvcGVydHlOYW1lcy0+c291cmNlVVJMLCBqc1N0cmluZygmdm0sIHNv dXJjZVVSTCkpOworCisgICAgU291cmNlUHJvdmlkZXIqIHByb3ZpZGVyID0gc291cmNlLnByb3Zp ZGVyKCk7CisgICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIEFTU0VSVCBhbmQgbnVsbCBjaGVjayB3 aGVuIGh0dHBzOi8vaHR0cHM6Ly93ZWJraXQub3JnL2IvMTg3ODExIGlzIGZpeGVkLgorICAgIEFT U0VSVChwcm92aWRlcik7CisgICAgaWYgKExJS0VMWShwcm92aWRlcikpIHsKKyAgICAgICAgY29u c3QgU3RyaW5nJiBzb3VyY2VVUkwgPSBwcm92aWRlci0+dXJsKCk7CisgICAgICAgIGlmICghc291 cmNlVVJMLmlzTnVsbCgpKQorICAgICAgICAgICAgZXJyb3ItPnB1dERpcmVjdCh2bSwgdm0ucHJv cGVydHlOYW1lcy0+c291cmNlVVJMLCBqc1N0cmluZygmdm0sIHNvdXJjZVVSTCkpOworICAgIH0K ICAgICByZXR1cm4gZXJyb3I7CiB9CiAK 345363 2018-07-19 11:23:32 -0700 2018-07-19 11:33:51 -0700 proposed patch. bug-187812.patch text/plain 2182 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjMzOTkzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBA CisyMDE4LTA3LTE5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBU ZW1wb3JhcmlseSBtaXRpZ2F0ZSBhIGJ1ZyB3aGVyZSBhIHNvdXJjZSBwcm92aWRlciBpcyBudWxs IHdoZW4gaXQgc2hvdWxkbid0IGJlLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTg3ODEyCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS80MTE5MjY5MT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRpbmcg YSBudWxsIGNoZWNrIHRvIHRlbXBvcmFyaWx5IG1pdGlnYXRlIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xODc4MTEuCisKKyAgICAgICAgKiBydW50aW1lL0Vycm9yLmNw cDoKKyAgICAgICAgKEpTQzo6YWRkRXJyb3JJbmZvKToKKwogMjAxOC0wNy0xOSAgS2VpdGggUm9s bGluICA8a3JvbGxpbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRqdXN0IFdFQkNPUkVfRVhQT1JU IGFubm90YXRpb25zIGZvciBMVE8KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50aW1l L0Vycm9yLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9F cnJvci5jcHAJKHJldmlzaW9uIDIzMzk5MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9ydW50 aW1lL0Vycm9yLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjM5LDcgKzIzOSw2IEBAIHZvaWQgYWRk RXJyb3JJbmZvKEV4ZWNTdGF0ZSogZXhlYywgSlNPYmoKIEpTT2JqZWN0KiBhZGRFcnJvckluZm8o Q2FsbEZyYW1lKiBjYWxsRnJhbWUsIEpTT2JqZWN0KiBlcnJvciwgaW50IGxpbmUsIGNvbnN0IFNv dXJjZUNvZGUmIHNvdXJjZSkKIHsKICAgICBWTSYgdm0gPSBjYWxsRnJhbWUtPnZtKCk7Ci0gICAg Y29uc3QgU3RyaW5nJiBzb3VyY2VVUkwgPSBzb3VyY2UucHJvdmlkZXIoKS0+dXJsKCk7CiAgICAg CiAgICAgLy8gVGhlIHB1dERpcmVjdCgpIGNhbGxzIGJlbG93IHNob3VsZCByZWFsbHkgYmUgcHV0 KCkgc28gdGhhdCB0aGV5IHRyaWdnZXIgbWF0ZXJpYWxpemF0aW9uIG9mCiAgICAgLy8gdGhlIGxp bmUvc291cmNlVVJMIHByb3BlcnRpZXMuIE90aGVyd2lzZSwgd2hhdCB3ZSBzZXQgaGVyZSB3aWxs IGp1c3QgYmUgb3ZlcndyaXR0ZW4gbGF0ZXIuCkBAIC0yNTYsOCArMjU1LDE1IEBAIEpTT2JqZWN0 KiBhZGRFcnJvckluZm8oQ2FsbEZyYW1lKiBjYWxsRnIKICAgICAvLyBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTc2NjczCiAgICAgaWYgKGxpbmUgIT0gLTEpCiAgICAg ICAgIGVycm9yLT5wdXREaXJlY3Qodm0sIHZtLnByb3BlcnR5TmFtZXMtPmxpbmUsIGpzTnVtYmVy KGxpbmUpKTsKLSAgICBpZiAoIXNvdXJjZVVSTC5pc051bGwoKSkKLSAgICAgICAgZXJyb3ItPnB1 dERpcmVjdCh2bSwgdm0ucHJvcGVydHlOYW1lcy0+c291cmNlVVJMLCBqc1N0cmluZygmdm0sIHNv dXJjZVVSTCkpOworCisgICAgU291cmNlUHJvdmlkZXIqIHByb3ZpZGVyID0gc291cmNlLnByb3Zp ZGVyKCk7CisgICAgLy8gRklYTUU6IFJlbW92ZSB0aGlzIEFTU0VSVCBhbmQgbnVsbCBjaGVjayB3 aGVuIGh0dHBzOi8vd2Via2l0Lm9yZy9iLzE4NzgxMSBpcyBmaXhlZC4KKyAgICBBU1NFUlQocHJv dmlkZXIpOworICAgIGlmIChMSUtFTFkocHJvdmlkZXIpKSB7CisgICAgICAgIGNvbnN0IFN0cmlu ZyYgc291cmNlVVJMID0gcHJvdmlkZXItPnVybCgpOworICAgICAgICBpZiAoIXNvdXJjZVVSTC5p c051bGwoKSkKKyAgICAgICAgICAgIGVycm9yLT5wdXREaXJlY3Qodm0sIHZtLnByb3BlcnR5TmFt ZXMtPnNvdXJjZVVSTCwganNTdHJpbmcoJnZtLCBzb3VyY2VVUkwpKTsKKyAgICB9CiAgICAgcmV0 dXJuIGVycm9yOwogfQogCg==