187793 2018-07-18 17:27:53 -0700 Hitting RELEASE_ASSERT(!m_activeDOMObjectAdditionForbidden) under HTMLMediaElement::resume() 2018-07-19 06:38:24 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 graouts graouts cdumez commit-queue eric.carlson jer.noble rniwa webkit-bug-importer oldest_to_newest 1443247 0 graouts 2018-07-18 17:27:53 -0700 HTMLMediaElement::resume() may end up calling prepareForLoad() which will end up calling configureMediaControls() which will in turn instantiate the media controls and run JS code, which will trigger RELEASE_ASSERT(!m_activeDOMObjectAdditionForbidden) in ScriptExecutionContext::didCreateActiveDOMObject(). We need to delay the call to prepareForLoad() in resume(). 1443248 1 graouts 2018-07-18 17:28:03 -0700 <rdar://problem/42308469> 1443250 2 345312 graouts 2018-07-18 17:32:12 -0700 Created attachment 345312 Patch 1443260 3 345312 cdumez 2018-07-18 18:18:06 -0700 Comment on attachment 345312 Patch r=me 1443342 4 345312 commit-queue 2018-07-19 06:38:22 -0700 Comment on attachment 345312 Patch Clearing flags on attachment: 345312 Committed r233982: <https://trac.webkit.org/changeset/233982> 1443343 5 commit-queue 2018-07-19 06:38:24 -0700 All reviewed patches have been landed. Closing bug. 345312 2018-07-18 17:32:12 -0700 2018-07-19 06:38:22 -0700 Patch bug-187793-20180718173212.patch text/plain 4333 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzOTM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNGFiYTk4OGE2M2JlZjU0 YzI0MGM1MjM0ZTU1YjMyMTQwOWJhZWQzNS4uZWQwZWI5YWFkNjEwMzg5MjFjODk5ZTI3N2Q5NDAz MmE5ODgwODhjZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE4LTA3LTE4ICBBbnRv aW5lIFF1aW50ICA8Z3Jhb3V0c0BhcHBsZS5jb20+CisKKyAgICAgICAgSGl0dGluZyBSRUxFQVNF X0FTU0VSVCghbV9hY3RpdmVET01PYmplY3RBZGRpdGlvbkZvcmJpZGRlbikgdW5kZXIgSFRNTE1l ZGlhRWxlbWVudDo6cmVzdW1lKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTE4Nzc5MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vNDIzMDg0Njk+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRW5zdXJlIHdl IGRvIG5vdCBjYWxsIEpTIHVuZGVyIHJlc3VtZSgpLCB3aGljaCB3b3VsZCBoYXBwZW4gYXMgYSBy ZXN1bHQgb2YgY2FsbGluZyBjb25maWd1cmVNZWRpYUNvbnRyb2xzKCkgaW4gcHJlcGFyZUZvckxv YWQoKS4KKworICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojp+SFRNTE1lZGlhRWxlbWVudCk6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50Ojpjb250ZXh0RGVzdHJveWVkKToKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnN0b3ApOgorICAgICAgICAoV2ViQ29yZTo6SFRNTE1l ZGlhRWxlbWVudDo6c3VzcGVuZCk6CisgICAgICAgIChXZWJDb3JlOjpIVE1MTWVkaWFFbGVtZW50 OjpyZXN1bWUpOgorICAgICAgICAqIGh0bWwvSFRNTE1lZGlhRWxlbWVudC5oOgorCiAyMDE4LTA3 LTE4ICBKZXIgTm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3 ZWQgQVBJIFRlc3QgZml4OyByZXN0b3JlZCBhIGxpbmUgaW5hZHZlbnRhbnRseSByZW1vdmVkIGlu IHIyMzM5MjYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1l bnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCAy ODBkMTY2ZWNlNDZlMGY4ZDcwZGU3ODJlZTg3MDkzOWM5NmZmZTlhLi40MDkwNTJlZTk3NWE1MWRk ODZiYmQ4OWFjZWFiYjFiMjkxYTBiNGY0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxNZWRpYUVsZW1lbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlh RWxlbWVudC5jcHAKQEAgLTY3OCw2ICs2NzgsNyBAQCBIVE1MTWVkaWFFbGVtZW50Ojp+SFRNTE1l ZGlhRWxlbWVudCgpCiAjZW5kaWYKIAogICAgIG1fc2Vla1Rhc2tRdWV1ZS5jbG9zZSgpOworICAg IG1fcmVzdW1lVGFza1F1ZXVlLmNsb3NlKCk7CiAgICAgbV9wcm9taXNlVGFza1F1ZXVlLmNsb3Nl KCk7CiAgICAgbV9wYXVzZUFmdGVyRGV0YWNoZWRUYXNrUXVldWUuY2xvc2UoKTsKICAgICBtX3Bs YXliYWNrQ29udHJvbHNNYW5hZ2VyQmVoYXZpb3JSZXN0cmljdGlvbnNRdWV1ZS5jbG9zZSgpOwpA QCAtNTU4Myw2ICs1NTg0LDcgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50OjpzdG9wV2l0aG91dERl c3Ryb3lpbmdNZWRpYVBsYXllcigpCiB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OmNvbnRleHREZXN0 cm95ZWQoKQogewogICAgIG1fc2Vla1Rhc2tRdWV1ZS5jbG9zZSgpOworICAgIG1fcmVzdW1lVGFz a1F1ZXVlLmNsb3NlKCk7CiAgICAgbV9zaGFkb3dET01UYXNrUXVldWUuY2xvc2UoKTsKICAgICBt X3Byb21pc2VUYXNrUXVldWUuY2xvc2UoKTsKICAgICBtX3BhdXNlQWZ0ZXJEZXRhY2hlZFRhc2tR dWV1ZS5jbG9zZSgpOwpAQCAtNTYwNSw2ICs1NjA3LDcgQEAgdm9pZCBIVE1MTWVkaWFFbGVtZW50 OjpzdG9wKCkKICAgICBtX2FzeW5jRXZlbnRRdWV1ZS5jbG9zZSgpOwogICAgIG1fcHJvbWlzZVRh c2tRdWV1ZS5jbG9zZSgpOwogICAgIG1fcmVzb3VyY2VTZWxlY3Rpb25UYXNrUXVldWUuY2xvc2Uo KTsKKyAgICBtX3Jlc3VtZVRhc2tRdWV1ZS5jYW5jZWxBbGxUYXNrcygpOwogCiAgICAgLy8gT25j ZSBhbiBhY3RpdmUgRE9NIG9iamVjdCBoYXMgYmVlbiBzdG9wcGVkIGl0IGNhbiBub3QgYmUgcmVz dGFydGVkLCBzbyB3ZSBjYW4gZGVhbGxvY2F0ZQogICAgIC8vIHRoZSBtZWRpYSBwbGF5ZXIgbm93 LiBOb3RlIHRoYXQgdXNlckNhbmNlbGxlZExvYWQgd2lsbCBhbHJlYWR5IGNhbGxlZCBjbGVhck1l ZGlhUGxheWVyCkBAIC01NjIwLDYgKzU2MjMsOCBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnN1 c3BlbmQoUmVhc29uRm9yU3VzcGVuc2lvbiByZWFzb24pCiAgICAgSU5GT19MT0coTE9HSURFTlRJ RklFUik7CiAgICAgUmVmPEhUTUxNZWRpYUVsZW1lbnQ+IHByb3RlY3RlZFRoaXMoKnRoaXMpOwog CisgICAgbV9yZXN1bWVUYXNrUXVldWUuY2FuY2VsQWxsVGFza3MoKTsKKwogICAgIHN3aXRjaCAo cmVhc29uKSB7CiAgICAgY2FzZSBSZWFzb25Gb3JTdXNwZW5zaW9uOjpQYWdlQ2FjaGU6CiAgICAg ICAgIHN0b3BXaXRob3V0RGVzdHJveWluZ01lZGlhUGxheWVyKCk7CkBAIC01NjYyLDEzICs1NjY3 LDEzIEBAIHZvaWQgSFRNTE1lZGlhRWxlbWVudDo6cmVzdW1lKCkKIAogICAgIG1fbWVkaWFTZXNz aW9uLT5yZW1vdmVCZWhhdmlvclJlc3RyaWN0aW9uKE1lZGlhRWxlbWVudFNlc3Npb246OlJlcXVp cmVQYWdlQ29uc2VudFRvUmVzdW1lTWVkaWEpOwogCi0gICAgaWYgKG1fZXJyb3IgJiYgbV9lcnJv ci0+Y29kZSgpID09IE1lZGlhRXJyb3I6Ok1FRElBX0VSUl9BQk9SVEVEKSB7CisgICAgaWYgKG1f ZXJyb3IgJiYgbV9lcnJvci0+Y29kZSgpID09IE1lZGlhRXJyb3I6Ok1FRElBX0VSUl9BQk9SVEVE ICYmICFtX3Jlc3VtZVRhc2tRdWV1ZS5oYXNQZW5kaW5nVGFza3MoKSkgewogICAgICAgICAvLyBS ZXN0YXJ0IHRoZSBsb2FkIGlmIGl0IHdhcyBhYm9ydGVkIGluIHRoZSBtaWRkbGUgYnkgbW92aW5n IHRoZSBkb2N1bWVudCB0byB0aGUgcGFnZSBjYWNoZS4KICAgICAgICAgLy8gbV9lcnJvciBpcyBv bmx5IGxlZnQgYXQgTUVESUFfRVJSX0FCT1JURUQgd2hlbiB0aGUgZG9jdW1lbnQgYmVjb21lcyBp bmFjdGl2ZSAoaXQgaXMgc2V0IHRvCiAgICAgICAgIC8vICBNRURJQV9FUlJfQUJPUlRFRCB3aGls ZSB0aGUgYWJvcnRFdmVudCBpcyBiZWluZyBzZW50LCBidXQgY2xlYXJlZCBpbW1lZGlhdGVseSBh ZnRlcndhcmRzKS4KICAgICAgICAgLy8gVGhpcyBiZWhhdmlvciBpcyBub3Qgc3BlY2lmaWVkIGJ1 dCBpdCBzZWVtcyBsaWtlIGEgc2Vuc2libGUgdGhpbmcgdG8gZG8uCiAgICAgICAgIC8vIEFzIGl0 IGlzIG5vdCBzYWZlIHRvIGltbWVkYXRlbHkgc3RhcnQgbG9hZGluZyBub3csIGxldCdzIHNjaGVk dWxlIGEgbG9hZC4KLSAgICAgICAgcHJlcGFyZUZvckxvYWQoKTsKKyAgICAgICAgbV9yZXN1bWVU YXNrUXVldWUuZW5xdWV1ZVRhc2soc3RkOjpiaW5kKCZIVE1MTWVkaWFFbGVtZW50OjpwcmVwYXJl Rm9yTG9hZCwgdGhpcykpOwogICAgIH0KIAogICAgIHVwZGF0ZVJlbmRlcmVyKCk7CmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuaCBiL1NvdXJjZS9XZWJD b3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCmluZGV4IDE3MGJmOTg2MDBjYjdjMjc3ZWE0MzBh MGMxNWI5NmU3ZTYxYjI1ODkuLmQ1M2E4YjYwZmE5NWMxYzJhYjdiNDI0MTliY2QzNDE3ZjA5NGRm ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCisr KyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5oCkBAIC05MjksNiArOTI5 LDcgQEAgcHJpdmF0ZToKICAgICBUaW1lciBtX3NjYW5UaW1lcjsKICAgICBUaW1lciBtX3BsYXli YWNrQ29udHJvbHNNYW5hZ2VyQmVoYXZpb3JSZXN0cmljdGlvbnNUaW1lcjsKICAgICBUaW1lciBt X3NlZWtUb1BsYXliYWNrUG9zaXRpb25FbmRlZFRpbWVyOworICAgIEdlbmVyaWNUYXNrUXVldWU8 VGltZXI+IG1fcmVzdW1lVGFza1F1ZXVlOwogICAgIEdlbmVyaWNUYXNrUXVldWU8VGltZXI+IG1f c2Vla1Rhc2tRdWV1ZTsKICAgICBHZW5lcmljVGFza1F1ZXVlPFRpbWVyPiBtX3NoYWRvd0RPTVRh c2tRdWV1ZTsKICAgICBHZW5lcmljVGFza1F1ZXVlPFRpbWVyPiBtX3Byb21pc2VUYXNrUXVldWU7 Cg==