187788 2018-07-18 15:31:04 -0700 Let clients override _WKThumbnailView's background color 2018-07-19 13:29:53 -0700 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rmondello rmondello anshu commit-queue rmondello sam thorton webkit-bug-importer oldest_to_newest 1443199 0 rmondello 2018-07-18 15:31:04 -0700 Let clients override _WKThumbnailView's background color 1443231 1 345305 rmondello 2018-07-18 16:57:11 -0700 Created attachment 345305 Attempt. 1443234 2 345305 anshu 2018-07-18 17:05:57 -0700 Comment on attachment 345305 Attempt. View in context: https://bugs.webkit.org/attachment.cgi?id=345305&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm:159 > +- (void)setOverrideBackgroundColor:(NSColor *)overrideBackgroundColor > +{ > + if ([_overrideBackgroundColor isEqual:overrideBackgroundColor]) > + return; > + > + _overrideBackgroundColor = overrideBackgroundColor; > + [self updateLayer]; It seems strange to call -updateLayer directly. Could we instead -setNeedsDisplay on the layer so that -updateLayer gets called during the next display pass? 1443236 3 345305 thorton 2018-07-18 17:07:39 -0700 Comment on attachment 345305 Attempt. View in context: https://bugs.webkit.org/attachment.cgi?id=345305&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm:159 > + [self updateLayer]; Don't you usually setNeedsDisplay, not updateLayer directly? 1443237 4 thorton 2018-07-18 17:08:07 -0700 lol, yes, that 1443238 5 345308 rmondello 2018-07-18 17:10:24 -0700 Created attachment 345308 Attempt 2, using setNeedsDisplay 1443239 6 345308 thorton 2018-07-18 17:14:25 -0700 Comment on attachment 345308 Attempt 2, using setNeedsDisplay View in context: https://bugs.webkit.org/attachment.cgi?id=345308&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.mm:159 > + [self.layer setNeedsDisplay]; setNeedsDisplay on the view, no? Isn't that how you get to updateLayer? This might work too, I'm not sure. 1443244 7 345310 rmondello 2018-07-18 17:24:24 -0700 Created attachment 345310 Attempt 3, calling -setNeedsDisplay: on the view itself 1443262 8 345310 commit-queue 2018-07-18 18:19:47 -0700 Comment on attachment 345310 Attempt 3, calling -setNeedsDisplay: on the view itself Clearing flags on attachment: 345310 Committed r233945: <https://trac.webkit.org/changeset/233945> 1443263 9 commit-queue 2018-07-18 18:19:48 -0700 All reviewed patches have been landed. Closing bug. 1443264 10 webkit-bug-importer 2018-07-18 18:20:25 -0700 <rdar://problem/42361917> 1443482 11 345310 sam 2018-07-19 13:29:53 -0700 Comment on attachment 345310 Attempt 3, calling -setNeedsDisplay: on the view itself View in context: https://bugs.webkit.org/attachment.cgi?id=345310&action=review > Source/WebKit/UIProcess/API/Cocoa/_WKThumbnailView.h:51 > +@property (strong, nonatomic) NSColor *overrideBackgroundColor; I believe this should probably be nullable. 345305 2018-07-18 16:57:11 -0700 2018-07-18 17:09:33 -0700 Attempt. 0001-Let-clients-override-_WKThumbnailView-s-background-c.patch text/plain 3798 rmondello RnJvbSBhOGE4NzhkZjRlODIwNjRiZTMwZTM0N2I4OWIzNjY3YmFhNWVkMTNmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNreSBNb25kZWxsbyA8cm1vbmRlbGxvQGFwcGxlLmNvbT4K RGF0ZTogV2VkLCAxOCBKdWwgMjAxOCAxNjo1NDowOSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIExl dCBjbGllbnRzIG92ZXJyaWRlIF9XS1RodW1ibmFpbFZpZXcncyBiYWNrZ3JvdW5kIGNvbG9yCgpo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3Nzg4CgpSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KCiogVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tUaHVtYm5haWxWaWV3 Lmg6IERlY2xhcmUgYSBwcm9wZXJ0eS4KKiBVSVByb2Nlc3MvQVBJL0NvY29hL19XS1RodW1ibmFp bFZpZXcubW06IERlZmluZSBhbiBpdmFyLgooLVtfV0tUaHVtYm5haWxWaWV3IHVwZGF0ZUxheWVy XSk6IENvbnN1bHQgdGhlIGJhY2tncm91bmQgY29sb3IuCigtW19XS1RodW1ibmFpbFZpZXcgc2V0 T3ZlcnJpZGVCYWNrZ3JvdW5kQ29sb3I6XSk6IE5vdGFibHksIGNhbGwgLXVwZGF0ZUxheWVyLgoo LVtfV0tUaHVtYm5haWxWaWV3IG92ZXJyaWRlQmFja2dyb3VuZENvbG9yXSk6IEFkZGVkLgotLS0K IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICB8IDE0ICsrKysr KysrKysrKysrCiAuLi4vVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tUaHVtYm5haWxWaWV3LmggICAg fCAgMiArKwogLi4uL1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWlsVmlldy5tbSAgIHwg MTkgKysrKysrKysrKysrKysrKysrLQogMyBmaWxlcyBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCAwZDkyOGFiMGI5OC4uZjBjNmYzMmQ0ZDEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDctMTggIFJpY2t5IE1vbmRlbGxvICA8cm1v bmRlbGxvQGFwcGxlLmNvbT4KKworICAgICAgICBMZXQgY2xpZW50cyBvdmVycmlkZSBfV0tUaHVt Ym5haWxWaWV3J3MgYmFja2dyb3VuZCBjb2xvcgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODc3ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWls Vmlldy5oOiBEZWNsYXJlIGEgcHJvcGVydHkuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2Nv YS9fV0tUaHVtYm5haWxWaWV3Lm1tOiBEZWZpbmUgYW4gaXZhci4KKyAgICAgICAgKC1bX1dLVGh1 bWJuYWlsVmlldyB1cGRhdGVMYXllcl0pOiBDb25zdWx0IHRoZSBiYWNrZ3JvdW5kIGNvbG9yLgor ICAgICAgICAoLVtfV0tUaHVtYm5haWxWaWV3IHNldE92ZXJyaWRlQmFja2dyb3VuZENvbG9yOl0p OiBOb3RhYmx5LCBjYWxsIC11cGRhdGVMYXllci4KKyAgICAgICAgKC1bX1dLVGh1bWJuYWlsVmll dyBvdmVycmlkZUJhY2tncm91bmRDb2xvcl0pOiBBZGRlZC4KKwogMjAxOC0wNy0xNyAgVGltIEhv cnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChp T1MgMTIpOiBDYW4ndCBzY3JvbGwgdG8gdGhlIGJvdHRvbSBvZiB0aGUgcGFnZSBpbiBXS1dlYlZp ZXcgd2hpbGUga2V5Ym9hcmQgaXMgdXAgb24gcGFnZXMgd2l0aCB2aWV3cG9ydC1maXQ9Y292ZXIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tUaHVtYm5h aWxWaWV3LmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWls Vmlldy5oCmluZGV4IGIzMWEwNWZhMzAzLi5kNTM1ZWRiYTdlOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1RodW1ibmFpbFZpZXcuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWlsVmlldy5oCkBAIC00OCw2 ICs0OCw4IEBAIFdLX0NMQVNTX0FWQUlMQUJMRShtYWNvc3goMTAuMTApLCBpb3MoOC4wKSkKIC8v IERlZmF1bHRzIHRvIE5PLgogQHByb3BlcnR5IChub25hdG9taWMpIEJPT0wgc2hvdWxkS2VlcFNu YXBzaG90V2hlblJlbW92ZWRGcm9tU3VwZXJ2aWV3OwogCitAcHJvcGVydHkgKHN0cm9uZywgbm9u YXRvbWljKSBOU0NvbG9yICpvdmVycmlkZUJhY2tncm91bmRDb2xvcjsKKwogLy8gVGhpcyBzaG91 bGQgYmUgcmVtb3ZlZCB3aGVuIGFsbCBjbGllbnRzIGdvIGF3YXk7IGl0IGlzIGFsd2F5cyBZRVMg bm93LgogQHByb3BlcnR5IChub25hdG9taWMpIEJPT0wgdXNlc1NuYXBzaG90OwogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWlsVmlldy5t bSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tUaHVtYm5haWxWaWV3Lm1t CmluZGV4IGY4OTIxOGFhMWM1Li4zZDc4YzI2ZWI5NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1RodW1ibmFpbFZpZXcubW0KKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1RodW1ibmFpbFZpZXcubW0KQEAgLTU3LDYgKzU3 LDggQEAgdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKICAgICBCT09MIF9zbmFwc2hvdFdhc0RlZmVy cmVkOwogICAgIENHRmxvYXQgX2xhc3RTbmFwc2hvdFNjYWxlOwogICAgIENHU2l6ZSBfbGFzdFNu YXBzaG90TWF4aW11bVNpemU7CisKKyAgICBSZXRhaW5QdHI8TlNDb2xvciAqPiBfb3ZlcnJpZGVC YWNrZ3JvdW5kQ29sb3I7CiB9CiAKIEBzeW50aGVzaXplIHNuYXBzaG90U2l6ZT1fc25hcHNob3RT aXplOwpAQCAtMTExLDcgKzExMyw4IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiB7CiAgICAg W3N1cGVyIHVwZGF0ZUxheWVyXTsKIAotICAgIHNlbGYubGF5ZXIuYmFja2dyb3VuZENvbG9yID0g W05TQ29sb3IgcXVhdGVybmFyeUxhYmVsQ29sb3JdLkNHQ29sb3I7CisgICAgTlNDb2xvciAqYmFj a2dyb3VuZENvbG9yID0gc2VsZi5vdmVycmlkZUJhY2tncm91bmRDb2xvciA/OiBbTlNDb2xvciBx dWF0ZXJuYXJ5TGFiZWxDb2xvcl07CisgICAgc2VsZi5sYXllci5iYWNrZ3JvdW5kQ29sb3IgPSBi YWNrZ3JvdW5kQ29sb3IuQ0dDb2xvcjsKIH0KIAogLSAodm9pZClyZXF1ZXN0U25hcHNob3QKQEAg LTE0Nyw2ICsxNTAsMjAgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKICAgICB9KTsKIH0KIAor LSAodm9pZClzZXRPdmVycmlkZUJhY2tncm91bmRDb2xvcjooTlNDb2xvciAqKW92ZXJyaWRlQmFj a2dyb3VuZENvbG9yCit7CisgICAgaWYgKFtfb3ZlcnJpZGVCYWNrZ3JvdW5kQ29sb3IgaXNFcXVh bDpvdmVycmlkZUJhY2tncm91bmRDb2xvcl0pCisgICAgICAgIHJldHVybjsKKworICAgIF9vdmVy cmlkZUJhY2tncm91bmRDb2xvciA9IG92ZXJyaWRlQmFja2dyb3VuZENvbG9yOworICAgIFtzZWxm IHVwZGF0ZUxheWVyXTsKK30KKworLSAoTlNDb2xvciAqKW92ZXJyaWRlQmFja2dyb3VuZENvbG9y Cit7CisgICAgcmV0dXJuIF9vdmVycmlkZUJhY2tncm91bmRDb2xvci5nZXQoKTsKK30KKwogLSAo dm9pZClfdmlld1dhc1VucGFyZW50ZWQKIHsKICAgICBpZiAoIV9leGNsdXNpdmVseVVzZXNTbmFw c2hvdCkgewotLSAKMi4xNy4xIChBcHBsZSBHaXQtMTEwKQoK 345308 2018-07-18 17:10:24 -0700 2018-07-18 17:24:34 -0700 Attempt 2, using setNeedsDisplay 0001-Let-clients-override-_WKThumbnailView-s-background-c.patch text/plain 3808 rmondello RnJvbSBhYTNiMmEyZTcwZWNkOTRkNDU0YWIzMDZhMzJiNTQzNmFmNGU0NmIzIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNreSBNb25kZWxsbyA8cm1vbmRlbGxvQGFwcGxlLmNvbT4K RGF0ZTogV2VkLCAxOCBKdWwgMjAxOCAxNjo1NDowOSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIExl dCBjbGllbnRzIG92ZXJyaWRlIF9XS1RodW1ibmFpbFZpZXcncyBiYWNrZ3JvdW5kIGNvbG9yCgpo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3Nzg4CgpSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KCiogVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tUaHVtYm5haWxWaWV3 Lmg6IERlY2xhcmUgYSBwcm9wZXJ0eS4KKiBVSVByb2Nlc3MvQVBJL0NvY29hL19XS1RodW1ibmFp bFZpZXcubW06IERlZmluZSBhbiBpdmFyLgooLVtfV0tUaHVtYm5haWxWaWV3IHVwZGF0ZUxheWVy XSk6IENvbnN1bHQgdGhlIGJhY2tncm91bmQgY29sb3IuCigtW19XS1RodW1ibmFpbFZpZXcgc2V0 T3ZlcnJpZGVCYWNrZ3JvdW5kQ29sb3I6XSk6IE5vdGFibHksIGNhbGwgLXVwZGF0ZUxheWVyLgoo LVtfV0tUaHVtYm5haWxWaWV3IG92ZXJyaWRlQmFja2dyb3VuZENvbG9yXSk6IEFkZGVkLgotLS0K IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICB8IDE0ICsrKysr KysrKysrKysrCiAuLi4vVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tUaHVtYm5haWxWaWV3LmggICAg fCAgMiArKwogLi4uL1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWlsVmlldy5tbSAgIHwg MTkgKysrKysrKysrKysrKysrKysrLQogMyBmaWxlcyBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCAwZDkyOGFiMGI5OC4uZjBjNmYzMmQ0ZDEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDctMTggIFJpY2t5IE1vbmRlbGxvICA8cm1v bmRlbGxvQGFwcGxlLmNvbT4KKworICAgICAgICBMZXQgY2xpZW50cyBvdmVycmlkZSBfV0tUaHVt Ym5haWxWaWV3J3MgYmFja2dyb3VuZCBjb2xvcgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODc3ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWls Vmlldy5oOiBEZWNsYXJlIGEgcHJvcGVydHkuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2Nv YS9fV0tUaHVtYm5haWxWaWV3Lm1tOiBEZWZpbmUgYW4gaXZhci4KKyAgICAgICAgKC1bX1dLVGh1 bWJuYWlsVmlldyB1cGRhdGVMYXllcl0pOiBDb25zdWx0IHRoZSBiYWNrZ3JvdW5kIGNvbG9yLgor ICAgICAgICAoLVtfV0tUaHVtYm5haWxWaWV3IHNldE92ZXJyaWRlQmFja2dyb3VuZENvbG9yOl0p OiBOb3RhYmx5LCBjYWxsIC11cGRhdGVMYXllci4KKyAgICAgICAgKC1bX1dLVGh1bWJuYWlsVmll dyBvdmVycmlkZUJhY2tncm91bmRDb2xvcl0pOiBBZGRlZC4KKwogMjAxOC0wNy0xNyAgVGltIEhv cnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChp T1MgMTIpOiBDYW4ndCBzY3JvbGwgdG8gdGhlIGJvdHRvbSBvZiB0aGUgcGFnZSBpbiBXS1dlYlZp ZXcgd2hpbGUga2V5Ym9hcmQgaXMgdXAgb24gcGFnZXMgd2l0aCB2aWV3cG9ydC1maXQ9Y292ZXIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tUaHVtYm5h aWxWaWV3LmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWls Vmlldy5oCmluZGV4IGIzMWEwNWZhMzAzLi5kNTM1ZWRiYTdlOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1RodW1ibmFpbFZpZXcuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWlsVmlldy5oCkBAIC00OCw2 ICs0OCw4IEBAIFdLX0NMQVNTX0FWQUlMQUJMRShtYWNvc3goMTAuMTApLCBpb3MoOC4wKSkKIC8v IERlZmF1bHRzIHRvIE5PLgogQHByb3BlcnR5IChub25hdG9taWMpIEJPT0wgc2hvdWxkS2VlcFNu YXBzaG90V2hlblJlbW92ZWRGcm9tU3VwZXJ2aWV3OwogCitAcHJvcGVydHkgKHN0cm9uZywgbm9u YXRvbWljKSBOU0NvbG9yICpvdmVycmlkZUJhY2tncm91bmRDb2xvcjsKKwogLy8gVGhpcyBzaG91 bGQgYmUgcmVtb3ZlZCB3aGVuIGFsbCBjbGllbnRzIGdvIGF3YXk7IGl0IGlzIGFsd2F5cyBZRVMg bm93LgogQHByb3BlcnR5IChub25hdG9taWMpIEJPT0wgdXNlc1NuYXBzaG90OwogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWlsVmlldy5t bSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tUaHVtYm5haWxWaWV3Lm1t CmluZGV4IGY4OTIxOGFhMWM1Li4wN2Y2NzlmZDNlMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1RodW1ibmFpbFZpZXcubW0KKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1RodW1ibmFpbFZpZXcubW0KQEAgLTU3LDYgKzU3 LDggQEAgdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKICAgICBCT09MIF9zbmFwc2hvdFdhc0RlZmVy cmVkOwogICAgIENHRmxvYXQgX2xhc3RTbmFwc2hvdFNjYWxlOwogICAgIENHU2l6ZSBfbGFzdFNu YXBzaG90TWF4aW11bVNpemU7CisKKyAgICBSZXRhaW5QdHI8TlNDb2xvciAqPiBfb3ZlcnJpZGVC YWNrZ3JvdW5kQ29sb3I7CiB9CiAKIEBzeW50aGVzaXplIHNuYXBzaG90U2l6ZT1fc25hcHNob3RT aXplOwpAQCAtMTExLDcgKzExMyw4IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiB7CiAgICAg W3N1cGVyIHVwZGF0ZUxheWVyXTsKIAotICAgIHNlbGYubGF5ZXIuYmFja2dyb3VuZENvbG9yID0g W05TQ29sb3IgcXVhdGVybmFyeUxhYmVsQ29sb3JdLkNHQ29sb3I7CisgICAgTlNDb2xvciAqYmFj a2dyb3VuZENvbG9yID0gc2VsZi5vdmVycmlkZUJhY2tncm91bmRDb2xvciA/OiBbTlNDb2xvciBx dWF0ZXJuYXJ5TGFiZWxDb2xvcl07CisgICAgc2VsZi5sYXllci5iYWNrZ3JvdW5kQ29sb3IgPSBi YWNrZ3JvdW5kQ29sb3IuQ0dDb2xvcjsKIH0KIAogLSAodm9pZClyZXF1ZXN0U25hcHNob3QKQEAg LTE0Nyw2ICsxNTAsMjAgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKICAgICB9KTsKIH0KIAor LSAodm9pZClzZXRPdmVycmlkZUJhY2tncm91bmRDb2xvcjooTlNDb2xvciAqKW92ZXJyaWRlQmFj a2dyb3VuZENvbG9yCit7CisgICAgaWYgKFtfb3ZlcnJpZGVCYWNrZ3JvdW5kQ29sb3IgaXNFcXVh bDpvdmVycmlkZUJhY2tncm91bmRDb2xvcl0pCisgICAgICAgIHJldHVybjsKKworICAgIF9vdmVy cmlkZUJhY2tncm91bmRDb2xvciA9IG92ZXJyaWRlQmFja2dyb3VuZENvbG9yOworICAgIFtzZWxm LmxheWVyIHNldE5lZWRzRGlzcGxheV07Cit9CisKKy0gKE5TQ29sb3IgKilvdmVycmlkZUJhY2tn cm91bmRDb2xvcgoreworICAgIHJldHVybiBfb3ZlcnJpZGVCYWNrZ3JvdW5kQ29sb3IuZ2V0KCk7 Cit9CisKIC0gKHZvaWQpX3ZpZXdXYXNVbnBhcmVudGVkCiB7CiAgICAgaWYgKCFfZXhjbHVzaXZl bHlVc2VzU25hcHNob3QpIHsKLS0gCjIuMTcuMSAoQXBwbGUgR2l0LTExMCkKCg== 345310 2018-07-18 17:24:24 -0700 2018-07-18 18:19:47 -0700 Attempt 3, calling -setNeedsDisplay: on the view itself 0001-Let-clients-override-_WKThumbnailView-s-background-c.patch text/plain 3806 rmondello RnJvbSBhMDg2NTE4NDMzNDcxNzA1NmVhOGYyZTMxNzllNDE2ZDExMTY1ZDE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNreSBNb25kZWxsbyA8cm1vbmRlbGxvQGFwcGxlLmNvbT4K RGF0ZTogV2VkLCAxOCBKdWwgMjAxOCAxNjo1NDowOSAtMDcwMApTdWJqZWN0OiBbUEFUQ0hdIExl dCBjbGllbnRzIG92ZXJyaWRlIF9XS1RodW1ibmFpbFZpZXcncyBiYWNrZ3JvdW5kIGNvbG9yCgpo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3Nzg4CgpSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KCiogVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tUaHVtYm5haWxWaWV3 Lmg6IERlY2xhcmUgYSBwcm9wZXJ0eS4KKiBVSVByb2Nlc3MvQVBJL0NvY29hL19XS1RodW1ibmFp bFZpZXcubW06IERlZmluZSBhbiBpdmFyLgooLVtfV0tUaHVtYm5haWxWaWV3IHVwZGF0ZUxheWVy XSk6IENvbnN1bHQgdGhlIGJhY2tncm91bmQgY29sb3IuCigtW19XS1RodW1ibmFpbFZpZXcgc2V0 T3ZlcnJpZGVCYWNrZ3JvdW5kQ29sb3I6XSk6IE5vdGFibHksIGNhbGwgLXVwZGF0ZUxheWVyLgoo LVtfV0tUaHVtYm5haWxWaWV3IG92ZXJyaWRlQmFja2dyb3VuZENvbG9yXSk6IEFkZGVkLgotLS0K IFNvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAgICB8IDE0ICsrKysr KysrKysrKysrCiAuLi4vVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tUaHVtYm5haWxWaWV3LmggICAg fCAgMiArKwogLi4uL1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWlsVmlldy5tbSAgIHwg MTkgKysrKysrKysrKysrKysrKysrLQogMyBmaWxlcyBjaGFuZ2VkLCAzNCBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZwppbmRleCAwZDkyOGFiMGI5OC4uZjBjNmYzMmQ0ZDEgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTgtMDctMTggIFJpY2t5IE1vbmRlbGxvICA8cm1v bmRlbGxvQGFwcGxlLmNvbT4KKworICAgICAgICBMZXQgY2xpZW50cyBvdmVycmlkZSBfV0tUaHVt Ym5haWxWaWV3J3MgYmFja2dyb3VuZCBjb2xvcgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xODc3ODgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWls Vmlldy5oOiBEZWNsYXJlIGEgcHJvcGVydHkuCisgICAgICAgICogVUlQcm9jZXNzL0FQSS9Db2Nv YS9fV0tUaHVtYm5haWxWaWV3Lm1tOiBEZWZpbmUgYW4gaXZhci4KKyAgICAgICAgKC1bX1dLVGh1 bWJuYWlsVmlldyB1cGRhdGVMYXllcl0pOiBDb25zdWx0IHRoZSBiYWNrZ3JvdW5kIGNvbG9yLgor ICAgICAgICAoLVtfV0tUaHVtYm5haWxWaWV3IHNldE92ZXJyaWRlQmFja2dyb3VuZENvbG9yOl0p OiBOb3RhYmx5LCBjYWxsIC11cGRhdGVMYXllci4KKyAgICAgICAgKC1bX1dLVGh1bWJuYWlsVmll dyBvdmVycmlkZUJhY2tncm91bmRDb2xvcl0pOiBBZGRlZC4KKwogMjAxOC0wNy0xNyAgVGltIEhv cnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNTSU9OIChp T1MgMTIpOiBDYW4ndCBzY3JvbGwgdG8gdGhlIGJvdHRvbSBvZiB0aGUgcGFnZSBpbiBXS1dlYlZp ZXcgd2hpbGUga2V5Ym9hcmQgaXMgdXAgb24gcGFnZXMgd2l0aCB2aWV3cG9ydC1maXQ9Y292ZXIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tUaHVtYm5h aWxWaWV3LmggYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWls Vmlldy5oCmluZGV4IGIzMWEwNWZhMzAzLi5kNTM1ZWRiYTdlOSAxMDA2NDQKLS0tIGEvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1RodW1ibmFpbFZpZXcuaAorKysgYi9Tb3Vy Y2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWlsVmlldy5oCkBAIC00OCw2 ICs0OCw4IEBAIFdLX0NMQVNTX0FWQUlMQUJMRShtYWNvc3goMTAuMTApLCBpb3MoOC4wKSkKIC8v IERlZmF1bHRzIHRvIE5PLgogQHByb3BlcnR5IChub25hdG9taWMpIEJPT0wgc2hvdWxkS2VlcFNu YXBzaG90V2hlblJlbW92ZWRGcm9tU3VwZXJ2aWV3OwogCitAcHJvcGVydHkgKHN0cm9uZywgbm9u YXRvbWljKSBOU0NvbG9yICpvdmVycmlkZUJhY2tncm91bmRDb2xvcjsKKwogLy8gVGhpcyBzaG91 bGQgYmUgcmVtb3ZlZCB3aGVuIGFsbCBjbGllbnRzIGdvIGF3YXk7IGl0IGlzIGFsd2F5cyBZRVMg bm93LgogQHByb3BlcnR5IChub25hdG9taWMpIEJPT0wgdXNlc1NuYXBzaG90OwogCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvQ29jb2EvX1dLVGh1bWJuYWlsVmlldy5t bSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9Db2NvYS9fV0tUaHVtYm5haWxWaWV3Lm1t CmluZGV4IGY4OTIxOGFhMWM1Li41ZDc2NzIzMjQzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1RodW1ibmFpbFZpZXcubW0KKysrIGIvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvQVBJL0NvY29hL19XS1RodW1ibmFpbFZpZXcubW0KQEAgLTU3LDYgKzU3 LDggQEAgdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKICAgICBCT09MIF9zbmFwc2hvdFdhc0RlZmVy cmVkOwogICAgIENHRmxvYXQgX2xhc3RTbmFwc2hvdFNjYWxlOwogICAgIENHU2l6ZSBfbGFzdFNu YXBzaG90TWF4aW11bVNpemU7CisKKyAgICBSZXRhaW5QdHI8TlNDb2xvciAqPiBfb3ZlcnJpZGVC YWNrZ3JvdW5kQ29sb3I7CiB9CiAKIEBzeW50aGVzaXplIHNuYXBzaG90U2l6ZT1fc25hcHNob3RT aXplOwpAQCAtMTExLDcgKzExMyw4IEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJLaXQ7CiB7CiAgICAg W3N1cGVyIHVwZGF0ZUxheWVyXTsKIAotICAgIHNlbGYubGF5ZXIuYmFja2dyb3VuZENvbG9yID0g W05TQ29sb3IgcXVhdGVybmFyeUxhYmVsQ29sb3JdLkNHQ29sb3I7CisgICAgTlNDb2xvciAqYmFj a2dyb3VuZENvbG9yID0gc2VsZi5vdmVycmlkZUJhY2tncm91bmRDb2xvciA/OiBbTlNDb2xvciBx dWF0ZXJuYXJ5TGFiZWxDb2xvcl07CisgICAgc2VsZi5sYXllci5iYWNrZ3JvdW5kQ29sb3IgPSBi YWNrZ3JvdW5kQ29sb3IuQ0dDb2xvcjsKIH0KIAogLSAodm9pZClyZXF1ZXN0U25hcHNob3QKQEAg LTE0Nyw2ICsxNTAsMjAgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKICAgICB9KTsKIH0KIAor LSAodm9pZClzZXRPdmVycmlkZUJhY2tncm91bmRDb2xvcjooTlNDb2xvciAqKW92ZXJyaWRlQmFj a2dyb3VuZENvbG9yCit7CisgICAgaWYgKFtfb3ZlcnJpZGVCYWNrZ3JvdW5kQ29sb3IgaXNFcXVh bDpvdmVycmlkZUJhY2tncm91bmRDb2xvcl0pCisgICAgICAgIHJldHVybjsKKworICAgIF9vdmVy cmlkZUJhY2tncm91bmRDb2xvciA9IG92ZXJyaWRlQmFja2dyb3VuZENvbG9yOworICAgIFtzZWxm IHNldE5lZWRzRGlzcGxheTpZRVNdOworfQorCistIChOU0NvbG9yICopb3ZlcnJpZGVCYWNrZ3Jv dW5kQ29sb3IKK3sKKyAgICByZXR1cm4gX292ZXJyaWRlQmFja2dyb3VuZENvbG9yLmdldCgpOwor fQorCiAtICh2b2lkKV92aWV3V2FzVW5wYXJlbnRlZAogewogICAgIGlmICghX2V4Y2x1c2l2ZWx5 VXNlc1NuYXBzaG90KSB7Ci0tIAoyLjE3LjEgKEFwcGxlIEdpdC0xMTApCgo=