187786 2018-07-18 15:15:26 -0700 [WinCairo] Support DEVELOPER_MODE for allowing inspection of web inspector 2018-07-19 16:14:01 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo webkit-unassigned clopez commit-queue dbates don.olmstead fujii mark.lam mcatanzaro thorton webkit-bug-importer oldest_to_newest 1443186 0 stephan.szabo 2018-07-18 15:15:26 -0700 [WinCairo] Add missing piece for inspecting web inspector 1443187 1 345292 stephan.szabo 2018-07-18 15:19:04 -0700 Created attachment 345292 Patch 1443191 2 stephan.szabo 2018-07-18 15:22:32 -0700 We had added the support for setting the flags behind ENABLE(DEVELOPER_MODE) ala GTK to make the inspector page have DeveloperExtrasEnabled, but not the bits in cmake/scripts to get the flag set from the build. 1443273 3 fujii 2018-07-18 19:27:28 -0700 https://github.com/WebKit/webkit/blob/2f9002c4c64ab5eb4670dd7043f23a0b3e96fec0/Source/WebKit/UIProcess/win/WebInspectorProxyWin.cpp#L194 1443274 4 345292 fujii 2018-07-18 19:35:49 -0700 Comment on attachment 345292 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345292&action=review > Source/cmake/OptionsWin.cmake:96 > +SET_AND_EXPOSE_TO_BUILD(ENABLE_DEVELOPER_MODE ${DEVELOPER_MODE}) I think you should define it in OptionsWinCairo.cmake to keep AppleWin port untouched. > Tools/ChangeLog:3 > + [WinCairo] Add missing piece for inspecting web inspector What is the missing piece? I like more informative summary. > ChangeLog:8 > + * Source/cmake/OptionsWin.cmake: This change needs a more informative change log entry. 1443444 5 345370 stephan.szabo 2018-07-19 11:51:32 -0700 Created attachment 345370 Support DEVELOPER_MODE for allowing inspection of web inspector 1443573 6 345370 commit-queue 2018-07-19 16:11:34 -0700 Comment on attachment 345370 Support DEVELOPER_MODE for allowing inspection of web inspector Clearing flags on attachment: 345370 Committed r234010: <https://trac.webkit.org/changeset/234010> 1443574 7 commit-queue 2018-07-19 16:11:36 -0700 All reviewed patches have been landed. Closing bug. 1443576 8 webkit-bug-importer 2018-07-19 16:14:01 -0700 <rdar://problem/42405082> 345292 2018-07-18 15:19:04 -0700 2018-07-19 11:51:32 -0700 Patch bug-187786-20180718151903.patch text/plain 2380 stephan.szabo U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzOTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc1dpbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlCmluZGV4IGE2MDRk OTgyMWI1YjNmZjYxN2IwODdjM2QzOTI1YmY2ODY4MTdlZGIuLmFlOThhMTkyYWI3ZWU4NDk0N2Q3 ZjkwYmI2ODZiN2Q4Y2E4YThlMjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV2lu LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlCkBAIC05Myw2ICs5Myw4 IEBAIGVsc2UgKCkKICAgICBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVf V0VCR0wgUFVCTElDIE9GRikKIGVuZGlmICgpCiAKK1NFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKEVO QUJMRV9ERVZFTE9QRVJfTU9ERSAke0RFVkVMT1BFUl9NT0RFfSkKKwogV0VCS0lUX09QVElPTl9F TkQoKQogCiBpZiAoREVGSU5FRCBFTlZ7V0VCS0lUX0lHTk9SRV9QQVRIfSkKZGlmZiAtLWdpdCBh L1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkODc2NjA5ZGJiYzJmM2Iz MWIwZTQwNmM3ZWY3ZTYxY2EwYjcxZTczLi5jMDBmODVmYTQ3ZWFiMDNiMGU3ZjY2Njg5MzM1ZTcw YTIxMTBhM2JjIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTgtMDctMTggIFN0ZXBoYW4gU3phYm8gIDxzdGVwaGFu LnN6YWJvQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQWRkIG1pc3NpbmcgcGllY2Ug Zm9yIGluc3BlY3Rpbmcgd2ViIGluc3BlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3Nzg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChn ZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdCk6CisKIDIwMTgtMDctMTggIFdlbnNv biBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIFNQSSB0byBk ZWZlciBydW5uaW5nIGFzeW5jIHNjcmlwdCB1bnRpbCBhZnRlciBkb2N1bWVudCBsb2FkCmRpZmYg LS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtp dGRpcnMucG0KaW5kZXggODhiZjZkMDg0OWU0ZjI4NTNhOWFmMjUyNTE0MDYwZGZiMDc2MDMwNC4u OWNhNzlkYzUxMzQ4ZjQwOWE5NTM2MDBhMmE1MWI5MGYwNzg2NWI4OCAxMDA3NTUKLS0tIGEvVG9v bHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5w bQpAQCAtMjI2OSw3ICsyMjY5LDcgQEAgc3ViIGdlbmVyYXRlQnVpbGRTeXN0ZW1Gcm9tQ01ha2VQ cm9qZWN0CiAgICAgcHVzaCBAYXJncywgJy1EU0hPV19CSU5ESU5HU19HRU5FUkFUSU9OX1BST0dS RVNTPTEnIHVubGVzcyAoJHdpbGxVc2VOaW5qYSAmJiAtdCBTVERPVVQpOwogCiAgICAgIyBTb21l IHBvcnRzIGhhdmUgcHJvZHVjdGlvbiBtb2RlLCBidXQgYnVpbGQtd2Via2l0IHNob3VsZCBhbHdh eXMgdXNlIGRldmVsb3BlciBtb2RlLgotICAgIHB1c2ggQGFyZ3MsICItRERFVkVMT1BFUl9NT0RF PU9OIiBpZiBpc0d0aygpIHx8IGlzSlNDT25seSgpIHx8IGlzV1BFKCk7CisgICAgcHVzaCBAYXJn cywgIi1EREVWRUxPUEVSX01PREU9T04iIGlmIGlzR3RrKCkgfHwgaXNKU0NPbmx5KCkgfHwgaXNX UEUoKSB8fCBpc1dpbkNhaXJvKCk7CiAKICAgICBwdXNoIEBhcmdzLCBAY21ha2VBcmdzIGlmIEBj bWFrZUFyZ3M7CiAKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5ZGU1 YzJhNjI0NWQxZWJkY2ZmMDAzZDUyZDU5NDlkZTI4OWViYzlhLi4zNTBhNjE4MTQ4MTMxN2NiNGJl MmI2NmE4NTQ0NTNhODRhNzBjNTYxIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdl TG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTgtMDctMTggIFN0ZXBoYW4gU3phYm8gIDxzdGVwaGFu LnN6YWJvQHNvbnkuY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQWRkIG1pc3NpbmcgcGllY2Ug Zm9yIGluc3BlY3Rpbmcgd2ViIGluc3BlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3Nzg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc1dpbi5jbWFrZToKKwog MjAxOC0wNy0xOCAgTWljaGFlbCBDYXRhbnphcm8gIDxtY2F0YW56YXJvQGlnYWxpYS5jb20+CiAK ICAgICAgICAgU3dpdGNoIENNYWtlIHBvcnRzIGJhY2sgdG8gQysrIDE0Cg== 345370 2018-07-19 11:51:32 -0700 2018-07-19 16:11:34 -0700 Support DEVELOPER_MODE for allowing inspection of web inspector 187786-2.diff text/plain 2287 stephan.szabo ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5ZGU1YzJhNjI0NS4uMDcy YWQ1M2Q1NzMgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMyBAQAorMjAxOC0wNy0xOSAgU3RlcGhhbiBTemFibyAgPHN0ZXBoYW4uc3phYm9Ac29ueS5j b20+CisKKyAgICAgICAgW1dpbkNhaXJvXSBTdXBwb3J0IERFVkVMT1BFUl9NT0RFIGZvciBhbGxv d2luZyBpbnNwZWN0aW9uIG9mIHdlYiBpbnNwZWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE4Nzc4NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNXaW5DYWlyby5j bWFrZTogQWRkIEVOQUJMRV9ERVZFTE9QRVJfTU9ERQorICAgICAgICB0byBidWlsZCB3aGVuIERF VkVMT1BFUl9NT0RFIGlzIHR1cm5lZCBvbiBhdCBjbWFrZSB0aW1lLgorCiAyMDE4LTA3LTE4ICBN aWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNvbT4KIAogICAgICAgICBTd2l0 Y2ggQ01ha2UgcG9ydHMgYmFjayB0byBDKysgMTQKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9P cHRpb25zV2luQ2Fpcm8uY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dpbkNhaXJvLmNtYWtl CmluZGV4IDAwOGQxZjMyYTI5Li5mYTYxOGY3NjQ2MSAxMDA2NDQKLS0tIGEvU291cmNlL2NtYWtl L09wdGlvbnNXaW5DYWlyby5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc1dpbkNhaXJv LmNtYWtlCkBAIC0zMyw0ICszMyw2IEBAIHNldChFTkFCTEVfV0VCS0lUIE9OKQogCiBzZXQoQ09S RUZPVU5EQVRJT05fTElCUkFSWSBDRmxpdGUpCiAKK1NFVF9BTkRfRVhQT1NFX1RPX0JVSUxEKEVO QUJMRV9ERVZFTE9QRVJfTU9ERSAke0RFVkVMT1BFUl9NT0RFfSkKKwogYWRkX2RlZmluaXRpb25z KC1EV1RGX1BMQVRGT1JNX1dJTl9DQUlSTz0xKQpkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdlTG9n IGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGQ4NzY2MDlkYmJjLi44YWJmNjZiNmQzNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDE4LTA3LTE5ICBTdGVwaGFuIFN6YWJvICA8c3RlcGhhbi5zemFib0Bzb255LmNvbT4K KworICAgICAgICBbV2luQ2Fpcm9dIFN1cHBvcnQgREVWRUxPUEVSX01PREUgZm9yIGFsbG93aW5n IGluc3BlY3Rpb24gb2Ygd2ViIGluc3BlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3Nzg2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAgIChn ZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVjdCk6IFR1cm4gb24gREVWRUxPUEVSX01P REUKKyAgICAgICAgZm9yIFdpbkNhaXJvIGJ1aWxkcy4KKwogMjAxOC0wNy0xOCAgV2Vuc29uIEhz aWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgU1BJIHRvIGRlZmVy IHJ1bm5pbmcgYXN5bmMgc2NyaXB0IHVudGlsIGFmdGVyIGRvY3VtZW50IGxvYWQKZGlmZiAtLWdp dCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbQppbmRleCA4OGJmNmQwODQ5ZS4uOWNhNzlkYzUxMzQgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAg LTIyNjksNyArMjI2OSw3IEBAIHN1YiBnZW5lcmF0ZUJ1aWxkU3lzdGVtRnJvbUNNYWtlUHJvamVj dAogICAgIHB1c2ggQGFyZ3MsICctRFNIT1dfQklORElOR1NfR0VORVJBVElPTl9QUk9HUkVTUz0x JyB1bmxlc3MgKCR3aWxsVXNlTmluamEgJiYgLXQgU1RET1VUKTsKIAogICAgICMgU29tZSBwb3J0 cyBoYXZlIHByb2R1Y3Rpb24gbW9kZSwgYnV0IGJ1aWxkLXdlYmtpdCBzaG91bGQgYWx3YXlzIHVz ZSBkZXZlbG9wZXIgbW9kZS4KLSAgICBwdXNoIEBhcmdzLCAiLURERVZFTE9QRVJfTU9ERT1PTiIg aWYgaXNHdGsoKSB8fCBpc0pTQ09ubHkoKSB8fCBpc1dQRSgpOworICAgIHB1c2ggQGFyZ3MsICIt RERFVkVMT1BFUl9NT0RFPU9OIiBpZiBpc0d0aygpIHx8IGlzSlNDT25seSgpIHx8IGlzV1BFKCkg fHwgaXNXaW5DYWlybygpOwogCiAgICAgcHVzaCBAYXJncywgQGNtYWtlQXJncyBpZiBAY21ha2VB cmdzOwogCg==