187784 2018-07-18 14:53:08 -0700 REGRESSION (r233897): CrashTracer: com.apple.WebKit.WebContent.Development at com.apple.WebKit: WKBooleanGetValue + 9 2018-07-18 16:39:35 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez beidson ggaren rniwa webkit-bug-importer oldest_to_newest 1443173 0 cdumez 2018-07-18 14:53:08 -0700 REGRESSION (r233897): CrashTracer: com.apple.WebKit.WebContent.Development at com.apple.WebKit: WKBooleanGetValue + 9: 50 WebKit: WKBooleanGetValue <== 50 WebKitTestRunnerInjectedBundle: WTR::InjectedBundle::shouldProcessWorkQueue() const 50 WebKitTestRunnerInjectedBundle: WTR::InjectedBundlePage::frameDidChangeLocation(OpaqueWKBundleFrame const*) 50 WebKit: WebKit::InjectedBundlePageLoaderClient::didFinishLoadForFrame(WebKit::WebPage&, WebKit::WebFrame&, WTF::RefPtr<API::Object, WTF::DumbPtrTraits<API::Object> >&) 50 WebKit: WebKit::WebFrameLoaderClient::dispatchDidFinishLoad() 50 WebCore: WebCore::FrameLoader::checkLoadCompleteForThisFrame() 50 WebCore: WebCore::FrameLoader::checkLoadComplete() 50 WebCore: WebCore::DocumentLoader::finishedLoading() 50 WebCore: WebCore::DocumentLoader::maybeLoadEmpty() 50 WebCore: WebCore::DocumentLoader::startLoadingMainResource(WebCore::ShouldContinue) 50 WebCore: WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, WebCore::ShouldContinue, WebCore::AllowNavigationToInvalidURL)::$_14::operator()() const 50 WebCore: WebCore::FrameLoader::continueLoadAfterNavigationPolicy(WebCore::ResourceRequest const&, WebCore::FormState*, WebCore::ShouldContinue, WebCore::AllowNavigationToInvalidURL) 50 WebCore: WTF::Function<void (WebCore::ResourceRequest&&, WTF::WeakPtr<WebCore::FormState>&&, WebCore::ShouldContinue)>::CallableWrapper<WebCore::FrameLoader::loadWithDocumentLoader(WebCore::DocumentLoader*, WebCore::FrameLoadType, WTF::RefPtr<WebCore::FormState, WTF::DumbPtrTraits<WebCore::FormState> >&&, WebCore::AllowNavigationToInvalidURL, WebCore::ShouldTreatAsContinuingLoad, WTF::CompletionHandler<void ()>&&)::$_9>::call(WebCore::ResourceRequest&&, WTF::WeakPtr<WebCore::FormState>&&, WebCore::ShouldContinue) 50 WebCore: WTF::Function<void (WebCore::PolicyAction)>::CallableWrapper<WebCore::PolicyChecker::checkNavigationPolicy(WebCore::ResourceRequest&&, WebCore::ResourceResponse const&, WebCore::DocumentLoader*, WTF::RefPtr<WebCore::FormState, WTF::DumbPtrTraits<WebCore::FormState> >&&, WTF::CompletionHandler<void (WebCore::ResourceRequest&&, WTF::WeakPtr<WebCore::FormState>&&, WebCore::ShouldContinue)>&&, WebCore::PolicyDecisionMode)::$_2>::call(WebCore::PolicyAction) 50 WebKit: WebKit::WebFrame::didReceivePolicyDecision(unsigned long long, WebCore::PolicyAction, unsigned long long, WebKit::DownloadID, std::optional<WebKit::WebsitePoliciesData>&&) 50 WebKit: WebKit::WebPage::didReceiveWebPageMessage(IPC::Connection&, IPC::Decoder&) 50 WebKit: IPC::MessageReceiverMap::dispatchMessage(IPC::Connection&, IPC::Decoder&) 50 WebKit: WebKit::WebProcess::didReceiveMessage(IPC::Connection&, IPC::Decoder&) 50 WebKit: IPC::Connection::dispatchMessage(std::__1::unique_ptr<IPC::Decoder, std::__1::default_delete<IPC::Decoder> >) 50 WebKit: IPC::Connection::dispatchOneIncomingMessage() 50 JavaScriptCore: WTF::RunLoop::performWork() 50 JavaScriptCore: WTF::RunLoop::performWork(void*) 50 CoreFoundation: __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__ 50 CoreFoundation: __CFRunLoopDoSource0 50 CoreFoundation: __CFRunLoopDoSources0 50 CoreFoundation: __CFRunLoopRun 50 CoreFoundation: CFRunLoopRunSpecific 50 Foundation: -[NSRunLoop(NSRunLoop) runMode:beforeDate:] 50 Foundation: -[NSRunLoop(NSRunLoop) run] 50 libxpc.dylib: _xpc_objc_main 50 libxpc.dylib: xpc_main 50 com.apple.WebKit.WebContent.Development: 50 libdyld.dylib: start 1443174 1 cdumez 2018-07-18 14:53:20 -0700 <rdar://problem/42329230> 1443180 2 345290 cdumez 2018-07-18 15:04:15 -0700 Created attachment 345290 Patch 1443220 3 345290 rniwa 2018-07-18 16:14:05 -0700 Comment on attachment 345290 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345290&action=review > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:857 > + // The IPC failed. This happens when process swapping on navigation because the WebPageProxy unregisters itself When process *swaps* on navigation? 1443221 4 cdumez 2018-07-18 16:15:54 -0700 (In reply to Ryosuke Niwa from comment #3) > Comment on attachment 345290 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=345290&action=review > > > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:857 > > + // The IPC failed. This happens when process swapping on navigation because the WebPageProxy unregisters itself > > When process *swaps* on navigation? "when process swapping on navigation" reads well to me, let's ask an American :) Brady? 1443222 5 beidson 2018-07-18 16:18:02 -0700 (In reply to Chris Dumez from comment #4) > (In reply to Ryosuke Niwa from comment #3) > > Comment on attachment 345290 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=345290&action=review > > > > > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:857 > > > + // The IPC failed. This happens when process swapping on navigation because the WebPageProxy unregisters itself > > > > When process *swaps* on navigation? > > "when process swapping on navigation" reads well to me, let's ask an > American :) Brady? "process swapping" being a noun we've invented makes it read okay. I'd rewrite: "This happens when swapping processes on navigation..." 1443223 6 beidson 2018-07-18 16:20:26 -0700 (In reply to Brady Eidson from comment #5) > (In reply to Chris Dumez from comment #4) > > (In reply to Ryosuke Niwa from comment #3) > > > Comment on attachment 345290 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=345290&action=review > > > > > > > Tools/WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:857 > > > > + // The IPC failed. This happens when process swapping on navigation because the WebPageProxy unregisters itself > > > > > > When process *swaps* on navigation? > > > > "when process swapping on navigation" reads well to me, let's ask an > > American :) Brady? > > "process swapping" being a noun we've invented makes it read okay. Both a noun and a verb, but regardless it requires you to be familiar with it. My proposed rewrite doesn't: > > I'd rewrite: "This happens when swapping processes on navigation..." 1443226 7 cdumez 2018-07-18 16:33:27 -0700 Committed r233941: <https://trac.webkit.org/changeset/233941> 345290 2018-07-18 15:04:15 -0700 2018-07-18 16:39:35 -0700 Patch bug-187784-20180718150415.patch text/plain 2569 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzOTI0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDVhOGMwYjQzMmNhMjhkZGJhNWRjNWU1YmMxY2I4ODUy NTc2ZGIyMy4uOGYzZmQxMTc2ZWE0NmMxYTJjODc4MTEwM2VjYjAwZmM1NjA1ZmNkNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0 IEBACisyMDE4LTA3LTE4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAg ICAgUkVHUkVTU0lPTiAocjIzMzg5Nyk6IENyYXNoVHJhY2VyOiBjb20uYXBwbGUuV2ViS2l0Lldl YkNvbnRlbnQuRGV2ZWxvcG1lbnQgYXQgY29tLmFwcGxlLldlYktpdDogV0tCb29sZWFuR2V0VmFs dWUgKyA5CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0x ODc3ODQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzQyMzI5MjMwPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gcHJvY2VzcyBzd2FwcGluZyBv biBuYXZpZ2F0aW9uLCBXZWJQYWdlUHJveHk6OnJlYXR0YWNoVG9XZWJQcm9jZXNzKCkgdW5yZWdp c3RlcnMgdGhlIHBhZ2UgYXMgYSBNZXNzYWdlUmVjZWl2ZXIKKyAgICAgICAgZnJvbSB0aGUgb2xk IFdlYlByb2Nlc3NQcm94eSBhbmQgcmVnaXN0ZXJzIGl0c2VsZiBhcyBhIE1lc3NhZ2VSZWNlaXZl ciBmb3IgdGhlIG5ldyBXZWJQcm9jZXNzUHJveHkgaW5zdGVhZC4gVGhpcworICAgICAgICBtZWFu cyB0aGF0IGFmdGVyIHRoaXMgcG9pbnQsIElQQyBzZW50IGJ5IHRoZSBwcmV2aW91cyBXZWJQcm9j ZXNzIHRvIGl0cyBXZWJQYWdlUHJveHkgd2lsbCBmYWlsLgorCisgICAgICAgIFdoZW4gd2UgcHJv Y2VzcyBzd2FwLCB3ZSBhbHNvIG5hdmlnYXRlIHRoZSBwYWdlIGluIHRoZSBvbGQgV2ViUHJvY2Vz cyB0byBhYm91dDpibGFuaywgd2hlbiB0aGUgbmF2aWdhdGlvbiB0bworICAgICAgICBhYm91dDpi bGFuayB3b3VsZCBjb21wbGV0ZSwgdGhlIFdlYktpdFRlc3RSdW5uZXIncyBpbmplY3RlZCBidW5k bGUgd291bGQgdHJ5IGFuZCBzZW5kIElQQyB0byB0aGUgV2ViUGFnZVByb3h5CisgICAgICAgIHdo aWNoIHdvdWxkIGZhaWwgYW5kIHdvdWxkIGNhdXNlIFdLQnVuZGxlUGFnZVBvc3RTeW5jaHJvbm91 c01lc3NhZ2VGb3JUZXN0aW5nKCkgdG8gcmV0dXJuIGEgbnVsbCByZXN1bHQuIFdLVFIKKyAgICAg ICAgd291bGQgY3Jhc2ggd2hlbiBkZXJlZmVyZW5jaW5nIHRoaXMgbnVsbCByZXN1bHQuIFRoaXMg cGF0Y2ggYWRkcmVzc2VzIHRoaXMgYnkgZGVhbGluZyB3aXRoIHRoZSBwb3RlbnRpYWwgbnVsbAor ICAgICAgICByZXN1bHQuCisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVu ZGxlL0luamVjdGVkQnVuZGxlLmNwcDoKKyAgICAgICAgKFdUUjo6SW5qZWN0ZWRCdW5kbGU6OnNo b3VsZFByb2Nlc3NXb3JrUXVldWUgY29uc3QpOgorCiAyMDE4LTA3LTE4ICBBYWthc2ggSmFpbiAg PGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBbZXdzLWJ1aWxkXSBBZGQgYnVpbGQg c3RlcCB0byBydW4gbGF5b3V0LXRlc3QKZGlmZiAtLWdpdCBhL1Rvb2xzL1dlYktpdFRlc3RSdW5u ZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwIGIvVG9vbHMvV2ViS2l0VGVzdFJ1 bm5lci9JbmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAKaW5kZXggNTlmMWE2YjRmOGFj OGNjNjk0YWY3NDE2YzAwYTkyZGNkM2I3Y2Y2MS4uNjBiMTA3YWRjMjIxOGJhMWMxZmI5NjcyNjQ2 MzBkYjZhNDgyN2U1NiAxMDA2NDQKLS0tIGEvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3Rl ZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAKKysrIGIvVG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9J bmplY3RlZEJ1bmRsZS9JbmplY3RlZEJ1bmRsZS5jcHAKQEAgLTg1NCw2ICs4NTQsMTEgQEAgYm9v bCBJbmplY3RlZEJ1bmRsZTo6c2hvdWxkUHJvY2Vzc1dvcmtRdWV1ZSgpIGNvbnN0CiAgICAgV0tC dW5kbGVQYWdlUG9zdFN5bmNocm9ub3VzTWVzc2FnZUZvclRlc3RpbmcocGFnZSgpLT5wYWdlKCks IG1lc3NhZ2VOYW1lLmdldCgpLCAwLCAmcmVzdWx0VG9QYXNzKTsKICAgICBXS1JldGFpblB0cjxX S0Jvb2xlYW5SZWY+IGlzRW1wdHkoQWRvcHRXSywgc3RhdGljX2Nhc3Q8V0tCb29sZWFuUmVmPihy ZXN1bHRUb1Bhc3MpKTsKIAorICAgIC8vIFRoZSBJUEMgZmFpbGVkLiBUaGlzIGhhcHBlbnMgd2hl biBwcm9jZXNzIHN3YXBwaW5nIG9uIG5hdmlnYXRpb24gYmVjYXVzZSB0aGUgV2ViUGFnZVByb3h5 IHVucmVnaXN0ZXJzIGl0c2VsZgorICAgIC8vIGFzIGEgTWVzc2FnZVJlY2VpdmVyIGZyb20gdGhl IG9sZCBXZWJQcm9jZXNzUHJveHkgYW5kIHJlZ2lzdGVyIGl0c2VsZiB3aXRoIHRoZSBuZXcgV2Vi UHJvY2Vzc1Byb3h5IGluc3RlYWQuCisgICAgaWYgKCFpc0VtcHR5KQorICAgICAgICByZXR1cm4g ZmFsc2U7CisKICAgICByZXR1cm4gIVdLQm9vbGVhbkdldFZhbHVlKGlzRW1wdHkuZ2V0KCkpOwog fQogCg==