187772 2018-07-18 10:59:25 -0700 Web Inspector: REGRESSION(r232591): CodeMirrorEditor should not use a RegExp lineSeparator option 2018-07-18 11:40:23 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue inspector-bugzilla-changes joepeck oldest_to_newest 1443053 0 mattbaker 2018-07-18 10:59:25 -0700 Summary: CodeMirrorEditor should not use a RegExp lineSeparator option. Instead we should leave this option undefined. When no lineSeparator is specified, CodeMirror will effectively split lines on /\r\n?|\n/, but joins on \n when recreating the source text. Regressed in https://trac.webkit.org/changeset/232591. 1443054 1 mattbaker 2018-07-18 11:00:01 -0700 <rdar://problem/42331640> 1443060 2 345261 mattbaker 2018-07-18 11:06:27 -0700 Created attachment 345261 Patch 1443065 3 345261 joepeck 2018-07-18 11:12:52 -0700 Comment on attachment 345261 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345261&action=review r=me > Source/WebInspectorUI/ChangeLog:15 > + it detects \n, \r\n, and \r. By specifying a regular expression we > + merely cause problems when CodeMirror uses the supplied lineSeparator > + when joining its array of lines together. Well that stinks. 1443067 4 345261 mattbaker 2018-07-18 11:14:12 -0700 Comment on attachment 345261 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=345261&action=review >> Source/WebInspectorUI/ChangeLog:15 >> + when joining its array of lines together. > > Well that stinks. Indeed. 1443091 5 345261 commit-queue 2018-07-18 11:40:21 -0700 Comment on attachment 345261 Patch Clearing flags on attachment: 345261 Committed r233920: <https://trac.webkit.org/changeset/233920> 1443092 6 commit-queue 2018-07-18 11:40:23 -0700 All reviewed patches have been landed. Closing bug. 345261 2018-07-18 11:06:27 -0700 2018-07-18 11:40:21 -0700 Patch bug-187772-20180718110625.patch text/plain 3452 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjMzOTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAy M2VlZWJhZmRlODFhMGI1MjdhOTlhODFkMzM0MDRkMDdkYWE2NDQzLi5mYWVmNzZlZjJiZGVhNzA3 N2MyOGQyOGRjZjRjMzc1YjY4NWFjYzlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyNSBAQAorMjAxOC0wNy0xOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUkVHUkVTU0lPTihyMjMyNTkxKTogQ29kZU1pcnJv ckVkaXRvciBzaG91bGQgbm90IHVzZSBhIFJlZ0V4cCBsaW5lU2VwYXJhdG9yIG9wdGlvbgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTg3NzcyCisgICAg ICAgIDxyZGFyOi8vcHJvYmxlbS80MjMzMTY0MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvQ29kZU1pcnJvckVk aXRvci5qczoKKyAgICAgICAgKFdJLkNvZGVNaXJyb3JFZGl0b3IuY3JlYXRlKToKKyAgICAgICAg KFdJLkNvZGVNaXJyb3JFZGl0b3IpOgorICAgICAgICBDb2RlTWlycm9yIHNob3VsZCBiZSBsZWZ0 IHRvIGF1dG8tZGV0ZWN0IGxpbmUgc2VwYXJhdG9ycy4gQnkgZGVmYXVsdAorICAgICAgICBpdCBk ZXRlY3RzIFxuLCBcclxuLCBhbmQgXHIuIEJ5IHNwZWNpZnlpbmcgYSByZWd1bGFyIGV4cHJlc3Np b24gd2UKKyAgICAgICAgbWVyZWx5IGNhdXNlIHByb2JsZW1zIHdoZW4gQ29kZU1pcnJvciB1c2Vz IHRoZSBzdXBwbGllZCBsaW5lU2VwYXJhdG9yCisgICAgICAgIHdoZW4gam9pbmluZyBpdHMgYXJy YXkgb2YgbGluZXMgdG9nZXRoZXIuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1Rl eHRFZGl0b3IuanM6CisgICAgICAgIChXSS5UZXh0RWRpdG9yLnNldCBzdHJpbmcudXBkYXRlKToK KyAgICAgICAgKFdJLlRleHRFZGl0b3IucHJvdG90eXBlLnNldCBzdHJpbmcpOgorICAgICAgICBU aGlzIGFzc2VydGlvbiB3YXMgb25seSB0cnVlIHdoZW4gd2UgZm9yY2VkICJcbiIgbGluZSBlbmRp bmdzIGV2ZXJ5d2hlcmUuCisgICAgICAgIEl0IG5vIGxvbmdlciBob2xkcyBmb3Igc291cmNlIHRl eHQgd2l0aCAiXHJcbiIgKFdpbmRvd3Mtc3R5bGUpIGxpbmUgZW5kaW5ncy4KKwogMjAxOC0wNy0x NiAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogRml4IGV4ZWN1dGlvbiBoaWdobGlnaHRpbmcgYWZ0ZXIgcjIzMzgyMApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29kZU1pcnJvckVk aXRvci5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0NvZGVN aXJyb3JFZGl0b3IuanMKaW5kZXggZDA2MzZmMzk3ODFlNWRiNmUyOTZiMWY3ZjA5MGRkYzhlMTE2 YmRlMy4uNjZlNDdlZWIwMWQ1NjJjNDkzYzUzZDBhMzY3OWM0OTU0NGE3MWRhYiAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ29kZU1pcnJvckVk aXRvci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9D b2RlTWlycm9yRWRpdG9yLmpzCkBAIC0yNywxMCArMjcsNiBAQCBXSS5Db2RlTWlycm9yRWRpdG9y ID0gY2xhc3MgQ29kZU1pcnJvckVkaXRvcgogewogICAgIHN0YXRpYyBjcmVhdGUoZWxlbWVudCwg b3B0aW9ucykKICAgICB7Ci0gICAgICAgIC8vIERlZmF1bHQgbGluZSBlbmRpbmdzIG1hdGNoIHR5 cGljYWwgZXhwZWN0ZWQgbGluZSBlbmRpbmdzIGZvciBKYXZhU2NyaXB0IChhdCBsZWFzdCB0aG9z ZSBzdXBwb3J0ZWQgYnkgSmF2YVNjcmlwdENvcmUpLgotICAgICAgICBpZiAob3B0aW9ucy5saW5l U2VwYXJhdG9yID09PSB1bmRlZmluZWQpCi0gICAgICAgICAgICBvcHRpb25zLmxpbmVTZXBhcmF0 b3IgPSAvXHJcbj98XG4vOwotCiAgICAgICAgIC8vIENvZGVNaXJyb3IncyBtYW51YWwgc2Nyb2xs YmFyIHBvc2l0aW9uaW5nIHJlc3VsdHMgaW4gZG91YmxlIHNjcm9sbGJhcnMsCiAgICAgICAgIC8v IG5vciBkb2VzIGl0IGhhbmRsZSBicmFjZXMgYW5kIGJyYWNrZXRzIHdlbGwsIHNvIGRlZmF1bHQg dG8gdXNpbmcgTFRSLgogICAgICAgICAvLyBDbGllbnRzIGNhbiBvdmVycmlkZSB0aGlzIGlmIGN1 c3RvbSBsYXlvdXQgZm9yIFJUTCBpcyBhdmFpbGFibGUuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGV4dEVkaXRvci5qcwppbmRleCBjOTY2 MGM3NTgyZjI4ZjM4MTI4YjU3ZTJmODE4ZTNjOTEyNTc0N2I5Li4wNjUyNWViMDkzNmMxZTI2YjM2 ZDZlY2Y3NDJhZDA0NDg0NmNiNmVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9UZXh0RWRpdG9yLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1RleHRFZGl0b3IuanMKQEAgLTExOCwxMCArMTE4LDkg QEAgV0kuVGV4dEVkaXRvciA9IGNsYXNzIFRleHRFZGl0b3IgZXh0ZW5kcyBXSS5WaWV3CiAgICAg ICAgICAgICBpZiAodGhpcy5faW5pdGlhbFN0cmluZ05vdFNldCkKICAgICAgICAgICAgICAgICB0 aGlzLl9jb2RlTWlycm9yLnJlbW92ZUxpbmVDbGFzcygwLCAid3JhcCIpOwogCi0gICAgICAgICAg ICBpZiAodGhpcy5fY29kZU1pcnJvci5nZXRWYWx1ZSgpICE9PSBuZXdTdHJpbmcpIHsKKyAgICAg ICAgICAgIGlmICh0aGlzLl9jb2RlTWlycm9yLmdldFZhbHVlKCkgIT09IG5ld1N0cmluZykKICAg ICAgICAgICAgICAgICB0aGlzLl9jb2RlTWlycm9yLnNldFZhbHVlKG5ld1N0cmluZyk7Ci0gICAg ICAgICAgICAgICAgY29uc29sZS5hc3NlcnQodGhpcy5zdHJpbmcubGVuZ3RoID09PSBuZXdTdHJp bmcubGVuZ3RoLCAiQSBsb3Qgb2Ygb3VyIGNvZGUgZGVwZW5kcyBvbiBwcmVjaXNlIHRleHQgb2Zm c2V0cywgc28gdGhlIHN0cmluZyBzaG91bGQgcmVtYWluIHRoZSBzYW1lLiIpOwotICAgICAgICAg ICAgfSBlbHNlIHsKKyAgICAgICAgICAgIGVsc2UgewogICAgICAgICAgICAgICAgIC8vIEVuc3Vy ZSB3ZSBhdCBkaXNwbGF5IGNvbnRlbnQgZXZlbiBpZiB0aGUgdmFsdWUgZGlkIG5vdCBjaGFuZ2Uu IFRoaXMgb2Z0ZW4gaGFwcGVucyB3aGVuIGF1dG8gZm9ybWF0dGluZy4KICAgICAgICAgICAgICAg ICB0aGlzLmxheW91dCgpOwogICAgICAgICAgICAgfQo=